574 Commits (df913f596b796d32cfec217faef048e7d3c52875)

Author	SHA1	Message	Date
Sylvia Moss	baa203bb53	Adds acpi_shutdown to virtualbox builder (#8587)	6 years ago
Adrien Delorme	7b5a868de2	virtualbox/vm.Builder: use config as a non pointer to avoid a panic ... this is a continuation to #8513	6 years ago
Lars Lehtonen	8098ba9cdf	builder/virtualbox/common: remove unused url variable (#8559)	6 years ago
Megan Marsh	348e00422e	Merge pull request #8509 from hashicorp/fix_step_import_panic ... Remove config dependency from inside StepImport	6 years ago
Moss	7912e496aa	Remove config dependency inside StepImport	6 years ago
Megan Marsh	127905e855	remove time flaky time limited tests (#8522) ... * remove flaky test. It isn't very useful anyway given that we're slowly adding retries to the checks for lockfiles * remove time-component from retry test; in underpowered CI builds, this can flake fairly often.	6 years ago
Megan Marsh	f47d9f1b1f	Merge pull request #8514 from hashicorp/fix_5821 ... Configure NAT interface before forwarded port mapping	6 years ago
Adrien Delorme	f1e6f8eac1	removed unused config puts	6 years ago
Adrien Delorme	a67948f155	fix config pointers	6 years ago
Moss	9216f43463	Configure NAT interface before forwarded port mapping	6 years ago
Moss	42cf9ef064	Remove pointer fixing panic on interface conversion	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Sylvia Moss	c57f093efe	Remove unnecessary source_path validation for virtualbox-ovf (#8489)	6 years ago
Sylvia Moss	0a8b172bf9	Remove duplicated retry mechanism when deleting VM ffrom virtual box (#8485) ... This retry was also added to fix a locked by session error reported in #5501 and fixed in #5512.	6 years ago
Megan Marsh	84063d2132	implement ID and Type values in the provisioner template info sharing	6 years ago
Sylvia Moss	2ee3311082	Retry command execution when VM session is locked (#8483)	6 years ago
Sylvia Moss	c6b9efb522	Fix virtualbox-iso TestBuilderAcc_basic (#8481) ... make sure the test works for later usage	6 years ago
Sylvia Moss	2f63c581a0	Remove unnecessary 1 sec sleep (#8453)	6 years ago
Sylvia Moss	5ff5623433	Add disable_shutdown option to VirtualBox builder (#8449)	6 years ago
Adrien Delorme	a36b94320a	virtualbox: simplify ParseSnapshotData	7 years ago
Adrien Delorme	116a038de9	Update snapshot.go ... avoid a panic on a too short slice.	7 years ago
Adrien Delorme	14243ce56a	Merge pull request #8305 from hashicorp/fix_8301 ... allow nvme, since virtualbox 6.0 allows it	7 years ago
Adrien Delorme	a23801d4a9	builder.virtualbox.iso: document that EFI mode needs to be enabled for pcie/nvme to work too	7 years ago
Megan Marsh	974eba443a	update docs to include warning about extension pack	7 years ago
Adrien Delorme	b790776096	vbox iso: use NVMe Controller when the hard drive interface if pcie	7 years ago
Megan Marsh	6f54468dd5	fix mocks	7 years ago
Megan Marsh	65ad3105b3	udpdate generated code	7 years ago
Megan Marsh	9343a23021	add driver calls to enable nvme controller	7 years ago
Megan Marsh	d2867c47f0	allow nvme, since virtualbox 6.0 allows it	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Lars Lehtonen	4a3a011310	builder/virtualbox/vm: fix dropped error	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
allinwait	171c2a9a07	add the floppy label option	7 years ago
Brian Fox	5b6dcb0c94	fix(virtualbox) LoadSnapshots should succeed even if VM has no snapshots	7 years ago
Adrien Delorme	597a3e323b	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	350aa54274	Update step_shutdown_test.go ... bump test duration	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Thomas Meckel	01edafb49f	Cleaned up golint warnings	7 years ago
Thomas Meckel	92501cd344	target_snapshot is not optional as described in the documentation	7 years ago
Megan Marsh	06bef2844b	Merge pull request #7996 from hashicorp/fix_7925 ... dont bother with a targetpath for the vbox additions; use a hash like…	7 years ago
Brian Fox	47c027e5c8	Remove check/requirement for target_snapshot	7 years ago
Megan Marsh	02399f32f6	dont bother with a targetpath for the vbox additions; use a hash like everything else	7 years ago
Thomas Meckel	822b72bd14	Added force_delete_snapshot configuration item and the corresponding checks	7 years ago
Thomas Meckel	e7583de847	StepCreateSnapshot.Run() will stop and create an error if the virtual machine is still running ... Removed left over code from StepCreateSnapshot.Cleanup()	7 years ago
Thomas Meckel	d9b8623f64	StepShutdown now always waits for the shutdown of the virtual machine to complete, not only if a shutdown command is specified	7 years ago
Thomas Meckel	b873876670	Added test TestSnapshot_EnsureParents ... No using asserts NotNil and Nil	7 years ago
Thomas Meckel	6fd0b3e83e	Fixed a bug in ParseSnapshotData ... Added fuction GetSnapshots	7 years ago
Thomas Meckel	225a140055	Applied correct source format (got fmt) to builder\virtualbox\common\driver_mock.go	7 years ago
Thomas Meckel	51e5ae69db	Corrected method signatures in builder\virtualbox\common\driver_mock.go	7 years ago
Thomas Meckel	ab6a163ff2	Added missing newline at end of builder\virtualbox\common\driver_mock.go	7 years ago
Thomas Meckel	e9b5332e99	Added missing functions to builder\virtualbox\common\driver_mock.go	7 years ago
Thomas Meckel	fd5a2db58f	Removed commented (obsolete) code from builder\virtualbox\common\driver_4_2.go	7 years ago
Thomas Meckel	7d3c84e5f9	Changed VirtualBox VM builder according to current builder interface	7 years ago
Thomas Meckel	2ef911f6f0	Fixed bugs in snapshot and builder code	7 years ago
Thomas Meckel	ebd2780e5d	implemented first unit tests for snapshot.go	7 years ago
Thomas Meckel	f1f7c4e10c	* added function ParseSnapshotData to parse a string representation of a VBox snapshot tree ... * fixed bugs	7 years ago
Thomas Meckel	45e2095ae3	Moved parsing of tree string representation to new function in snapshot.go	7 years ago
Thomas Meckel	092e32fe9e	First version of reworked snapshot implementation	7 years ago
Thomas Meckel	a6074894f1	Defined struct and first function for enhanced snapshot handling	7 years ago
Thomas Meckel	d3202497ae	First working version of virtualbox/vm builder	7 years ago
Thomas Meckel	2a531f8ad6	Merged changes from local branch	7 years ago
Adrien Delorme	74f0d56cfc	virtualbox merge vbpx manage configs	7 years ago
Adrien Delorme	01eff9472a	virtualbox: merge ExportOpts and ExportConfig structs	7 years ago
Adrien Delorme	9b75c0af3d	WIP VB	7 years ago
Adrien Delorme	c11ef90cb6	use interpolate.NewContext() instead of testConfigTemplate(t) ... because it's what's happenning there	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Megan Marsh	9f1a4e0fed	Merge pull request #7423 from hashicorp/lock_ports ... Lock packer ports using a lock file	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	f67b5ff59d	virtualbox StepConfigureVRDP: use common/net pkg to find open port	7 years ago
Adrien Delorme	59370986fb	virtualbox StepForwardSSH: use common/net pkg to find open port	7 years ago
Vadym Haidamaka	414d0750f0	Add tests to validate 'none' communicator in the virtualbox builder	7 years ago
Vadym Haidamaka	0263503c45	Validate virtualbox_version_file and guest_additions_mode when communicator is none	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	3dc1dafe58	Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225 ... virtualbox: create ephemeral SSH key pair for build process	7 years ago
Stephen Fox	7e1cbc6d89	Rename references to key pair name to comment. ... Per the OpenSSH manual, the field is for a comment.	7 years ago
Stephen Fox	61a8968b22	Use 'os.OpenFile' to atomically create debug key file. ... Per code review feedback.	7 years ago
Stephen Fox	094c87e395	Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead. ... Per code review feedback, the Go template library supports encoding variables in URL query format. Instead of exposing two different public key formats (unmodified string and a URL encoded string), just have the user apply the 'urlquery' modifier to their template.	7 years ago
Stephen Fox	2ef6b9247d	Initial take on code review feedback from @azr. ... Do not use builder pattern or interfaces; stick to structs and some basic functions.	7 years ago
Megan Marsh	3fd589fa72	typos	7 years ago
Megan Marsh	e2d8c0bfd7	docs	7 years ago
Megan Marsh	07c0c599e0	attach guest additions via SATA when necessasry	7 years ago
chris marget	53c0376dfd	don't print keypair to the user's screen	7 years ago
chris marget	13cc73d600	keypair parsing and testing	7 years ago
Stephen Fox	f9d24ccda0	Allow user to get public key straight up, or URL encoded.	7 years ago
Stephen Fox	f2c11b55be	Renamed authorized_keys public key function.	7 years ago
Stephen Fox	01c98f3d82	Tweaked debug SSH private key file name for vbox.	7 years ago
Stephen Fox	c6ae8654d9	Moved SSH key pair code into 'helper/ssh'.	7 years ago
Stephen Fox	25775886a8	Properly set SSH key pair name.	7 years ago