856 Commits (df913f596b796d32cfec217faef048e7d3c52875)

Author	SHA1	Message	Date
Megan Marsh	4c0ac6917e	switch to using aws base config, which means we're using code tested and maitnained by the terraform crowd.	6 years ago
Sylvia Moss	96e3def294	Add pause_before_ssm config to pause before establishing the Session Manager session (#9988)	6 years ago
Megan Marsh	d66b358100	Merge pull request #9991 from hashicorp/b-amazon-ssm-infinite-loop ... amazon/ssm_driver: Update log polling logic	6 years ago
Wilken Rivera	2f2b5683a2	amazon/ssm_driver: Update log polling logic ... This change checks for closed iochans related to the log polling function and will break out of the loop when both channels are closed. Which is an indicator that the SSM session has been terminated by some external process. This fixes an issue where Packer hangs, due to the infinite loop, when an SSM session is killed outside of Packer. Related to #9442	6 years ago
Megan Marsh	429d431365	Implement assume_role for Packer. This functionality is copied shamelessly ... from the Terraform AWS provider	6 years ago
Sylvia Moss	d347bbec4c	Retry fleet creating only on invalid IAM instance profile (#9946)	6 years ago
Adrien Delorme	0d0bd9ce75	name fields of PolicyDocument correctly in HCL (#9812) ... withouth this fix we would have had to do ```hcl temporary_iam_instance_profile_policy_document { statement { action = ["*"] effect = "Allow" resource = ["*"] } version = "2012-10-17" } ``` instead of the same document but with capitalised fields	6 years ago
Adrien Delorme	a0c09e85df	retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up (#9810) ... PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134) which was causing the `CreateFleet` to fail (100% for me). So for now we retry a bit later. Waiting 5 seconds after the previously linked code also fixed this. Test file: ```json { "builders": [ { "type": "amazon-ebs", "region": "eu-west-1", "ami_name": "ubuntu-16.04 test {{timestamp}}", "ami_description": "Ubuntu 16.04 LTS - expand root partition", "source_ami_filter": { "filters": { "virtualization-type": "hvm", "name": "ubuntu/images/*/ubuntu-xenial-16.04-amd64-server-*", "root-device-type": "ebs" }, "owners": [ "099720109477" ], "most_recent": true }, "spot_price": "0.03", "spot_instance_types": [ "t2.small" ], "encrypt_boot": true, "ssh_username": "ubuntu", "ssh_interface": "session_manager", "temporary_iam_instance_profile_policy_document": { "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Action": [ "*" ], "Resource": "*" } ] }, "communicator": "ssh" } ]} ```	6 years ago
sylviamoss	1a0d5a93ee	fix max_attempts typo	6 years ago
sylviamoss	788dc32598	add aws_polling config option to override env variables	6 years ago
Megan Marsh	8b4993e44c	fix docs for kms key ids (#9766)	6 years ago
Megan Marsh	54469c4728	Add all of the custom AWS template engines to GeneratedData for use b… (#9751)	6 years ago
Megan Marsh	f9df185ef1	Merge pull request #9579 from hashicorp/fix_9562 ... wrap CreateImage call in a retry to account for eventual consistencey…	6 years ago
Megan Marsh	a56942d3c7	change isAwsErr to an exported func so I can use it in other aws modules.	6 years ago
Adrien Delorme	810f161d22	builder/amazon/common/block_device.go: replace tabs with words	6 years ago
Adrien Delorme	966b17d2b5	builder/amazon/common/access_config.go: replace tabs with words	6 years ago
Adrien Delorme	5c4901c2c2	builder/amazon/common/run_config.go: replace tabs with words	6 years ago
Adrien Delorme	1455a29f2b	remove tabs for security_group_filter too	6 years ago
Adrien Delorme	191094edcc	better `disable_stop_instance` docs	6 years ago
Megan Marsh	530f5e3f63	more additions to partials	6 years ago
Megan Marsh	a1651977b3	add tabs to generated docs from access_config and run_config structs	6 years ago
Megan Marsh	4d3b2cea96	Merge pull request #9480 from adongy/master ... aws: retry fetching blockdevicemapping if empty	6 years ago
Megan Marsh	a885e620ee	don't error for no mappings if no mappings were set.	6 years ago
Megan Marsh	122e80f591	generated code	6 years ago
Megan Marsh	0122530a07	make statement an array of strings	6 years ago
Anthony Dong	2322d3ae6b	aws: retry fetching blockdevicemapping if empty	6 years ago
Wilken Rivera	a8dfb66d6c	docs/builder/amazon: Add WinRM unsupported note to Session Manager docs ... Closes #9451 Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
nitrocode	6d29ec956b	Added SourceAMICreationDate	6 years ago
Wilken Rivera	b5639d4697	tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps (#9213) ... * test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base * Update mod files	6 years ago
Wilken Rivera	6f5f6bf999	builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds ... Tests before change ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2] goroutine 299 [running]: github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800) /home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2 github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800) /home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6 github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...) /home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2 github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0) /home/wilken/Development/packer/packer/build.go:287 +0x7ef github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...) /home/wilken/Development/packer/command/build.go:290 +0x189 created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext /home/wilken/Development/packer/command/build.go:284 +0xd5a FAIL github.com/hashicorp/packer/provisioner/shell 188.335s FAIL ``` Test After change ``` --- PASS: TestShellProvisioner (212.39s) --- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s) PASS ```	6 years ago
Wilken Rivera	89fb7bb080	Apply suggestions from code review ... Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Wilken Rivera	056f1f6e76	docs/amazon/builder: Add not about using a temporary_iam_instance_profile_policy_document	6 years ago
Wilken Rivera	bf1da57a05	Update address to localhost to be consistent with other proxies	6 years ago
Wilken Rivera	7cea7466ba	buider/amazon: Add `session_manager_port` option for setting a custom local port	6 years ago
Wilken Rivera	0d13c634b7	Update logging constructs for Session Manger driver	6 years ago
Wilken Rivera	81c40b8d08	Add section to docs about the session-manager-plugin tunnel	6 years ago
Wilken Rivera	5f68303504	Remove no longer needed port check ... The communicator code base will default to the correct port settings for valid communicators and fail the build for non valid communicators.	6 years ago
Wilken Rivera	3ae7ab994b	step_create_ssm_tunnel: Add port availability check for LocalPortNumber	6 years ago
Wilken Rivera	08dc2cb847	Remove call to unstubbed session start	6 years ago
Wilken Rivera	f498866c3a	Update validation for session_manager connectivity ... Validation will now check that either a IamInstanceProfile or a TemporaryIamInstanceProfilePolicyDocument is set	6 years ago
Wilken Rivera	2f09b74587	amazon/builder: Move port validation for security group into RunConfig.Prepare	6 years ago
Wilken Rivera	743df19af2	Add tests for driver and ssm tunnel step	6 years ago
Wilken Rivera	e53d6aea66	amazon/ssm_driver: Update to support command context ... * Defer the release of the found port to prevent possible Packer build collisions.	6 years ago
Wilken Rivera	5e14089851	tests/builder/amazon: Add basic testing for session_manager ... * Add a test to ensure the proper host is returned when using session_manager * Add a basic driver test for the validating that the SSMDriver will fail if the plugin is not in the path.	6 years ago
Wilken Rivera	60e0ba7e68	Update iam instance profile name	6 years ago
Wilken Rivera	e515aefee3	Add validation checks for session_manager ... * Session manager connectivity only supported via SSH * Session manager requires the use of an iam instance profile with system manager permissions	6 years ago
Wilken Rivera	c1d2477d18	builder/amzon: Update port configuration for WinRM ... Connectivity for WinRM works for the initial connection, but fails to upload any provisioning scripts - need to dive in deeper. For now connectivity over SSH works as expected.	6 years ago
Wilken Rivera	fbffbd1899	docs/builder/amazon: Add short blurb for connecting via the AWS session_manager interface	6 years ago
Wilken Rivera	520061dee6	builder/amazon: Update Session Manger connectivity ... * Update security group creation step skip ingress rules if using session manager * Update create ssm tunnel step to dynamically set a session port * Add SSHPort function to common to return session-manager tunnel port * Update SSHHost to return proper host for session-manager	6 years ago