267 Commits (daaeccd8b006362c64bfbd3376a545fe648830df)

Author	SHA1	Message	Date
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Wilken Rivera	89fb7bb080	Apply suggestions from code review ... Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Wilken Rivera	7cea7466ba	buider/amazon: Add `session_manager_port` option for setting a custom local port	6 years ago
Wilken Rivera	3f6b28b70c	Add SSMTunnel step to other amazon builders, minus chroot	6 years ago
Wilken Rivera	d5a0262d6c	builder/amazon/instance: Add session manager support	6 years ago
Megan Marsh	f0d2680426	remove spot_price_auto_product from docs (#9173)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Adrien Delorme	73242e8de4	make sure keyvalue and namevalue filters are using the same naming as the service being used	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Jeff Escalante	2999934326	fix generation script, bugfixes in source comments, update website paths in primary codebase	6 years ago
Jeff Escalante	bcc848a83d	were rendering yay	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	b5e8750f5f	Change key/value to name/value to remain consistent with Terraform	6 years ago
Adrien Delorme	d532bb376c	wip	6 years ago
Adrien Delorme	87d6b2433f	make generate	6 years ago
Adrien Delorme	b4efd13a4d	aws: use the empty func when possible	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Adrien Delorme	7d5f0c11af	add max_retries option to aws builders	6 years ago
Megan Marsh	d252a24b82	allow user to set winrm_host override like we do ssh_host override	6 years ago
Wilken Rivera	111bab86d9	Merge pull request #8622 from datalot/pre-validate-with-filters ... Allow aws builder pre validation to pass when subnet filters are present	6 years ago
Sylvia Moss	0b7251a4bb	Share .Device and .MountPath between builders, provisioners and post-processors (#8621)	6 years ago
Rich Cavanaugh	4fb0de5256	allow validation to pass when subnet filters are present	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Adrien Delorme	731904d3d2	mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Oded Priva	5e81c6f44e	added the option to skip IAM instance profile validation (#8457)	6 years ago
nywilken	f9f4726eff	builder/amazon/step_pre_validate: Add check for non-default VPCs ... Subnet information is only really needed when the specified `vpc_id` is not the default VPC for the region where the builder is being executed. This change uses the AWS API to determine if the VPC provided is a non-default VPC and only validates the existence of a `subnet_id` if a user has provided a non-default `vpc_id`. Tests after change ``` > make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc' ... === RUN TestStepPreValidate_checkVpc === RUN TestStepPreValidate_checkVpc/DefaultVpc === RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet === RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet === RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc === RUN TestStepPreValidate_checkVpc/NoVpcInformation --- PASS: TestStepPreValidate_checkVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s) PASS ... ```	6 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	6 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	6 years ago
Bernard Baltrusaitis	6e2146324f	Merge branch 'master' of github.com:b-b3rn4rd/packer	6 years ago
Bernard Baltrusaitis	8b83cca064	adding temporary instance profile document policy	6 years ago
Megan Marsh	4bc381183d	make aws instsance builder work with recent changes for volume copy	6 years ago
Megan Marsh	0cbd3ff0f3	make sure amazon builders respect ssh_host option	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	1a6adadb89	convert EnableAMIENASupport to trilean in code	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	6ad975f296	Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" ... This reverts commit b0c09087a2.	7 years ago
Megan Marsh	c722afe707	stop calculating spot bids; amazon changed the way spot instances are priced to be stable rather than bid-based, so when user sets auto, we can just default to the ondemand price and know that they'll get the same price as everyone else bidding at that time.	7 years ago
Adrien Delorme	aeb898d598	document amazon-instance builder with partials	7 years ago
Adrien Delorme	c696878d2e	aws block devices mapping: BlockDevices.Build -> BuildEC2BlockDeviceMappings()	7 years ago
Adrien Delorme	ff2e0298ba	simplify block devices utilisation by removing intermediary types	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
Megan Marsh	708165eaa8	refactoring step_run_spot_instance and swapping out the calls to create a spot instance with a call to create a spot fleet of one, so that we can be more flexible with the instance type when desired	7 years ago
Megan Marsh	2c352cc681	add tests for step_ami_region_copy	7 years ago
Megan Marsh	201c8c1332	make sure that you encrypt using the provided kms key id and not the default	7 years ago