801 Commits (ced2e945e3cc5ea9ef48a0896ce396f79ffb65c5)

Author	SHA1	Message	Date
Paschalis Tsilias	beca6de71b	Add packer.ExpandUser() function to support tilde in usage of config.ValidationKeyPath (#8657)	6 years ago
nywilken	b80882f3b8	provisioner/shell: Fix envVarFile clean up issue ... This change ensures the deletion of the external envVarFile (use_env_var_file = true) occurs after all script files have been executed and deleted. Build results before change ``` > packer build build.pkr.hcl [~0] docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp476880774:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh ==> docker: /bin/sh: 1: .: Can't open /tmp/varfile_2555.sh ==> docker: Provisioning step had errors: Running the cleanup provisioner, if present... ==> docker: Killing the container: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b Build 'docker' errored: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Some builds didn't complete successfully and had errors: --> docker: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Builds finished but no artifacts were created. ``` Build results after change ``` > packer build build.pkr.hcl docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp819845000:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh docker: FooBar Script docker: wilken is NotForSale! ==> docker: Committing the container docker: Image ID: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ==> docker: Killing the container: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 Build 'docker' finished. ==> Builds finished. The artifacts of successful builds are: --> docker: Imported Docker image: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ```	6 years ago
Megan Marsh	4b9568e409	fix winrmpass sanitization to account for empty string value.	6 years ago
Megan Marsh	9eda2031d2	Remove redundant placeholder (#8503)	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	3389d843f0	update all provisioners that used the winrmpassword tooling to use the new generateddata option	6 years ago
Megan Marsh	b2012c7ff3	fix tests	6 years ago
Megan Marsh	39fd462b56	change all provision func signatures to use map[string]interface{}	6 years ago
Megan Marsh	0ca7c9f397	fix tests	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	f4c3501af5	pass struct of generated data into provision() call	6 years ago
Megan Marsh	822aa02500	Merge pull request #8468 from pfuender/master ... Add version selection for chef-client provisioner	6 years ago
pfuender	ffb9272fb2	adding version-override for chef-client provisioner	6 years ago
Wilken Rivera	b79986c3c5	Merge pull request #8411 from kevingunn-wk/fix_8410 ... rename galaxy_command to galaxycommand	6 years ago
Kevin Gunn	70aa0516de	reset ansible-local documentation to include galaxy_command ... fix spacing in fixer.go	6 years ago
Kevin Gunn	28d1037864	change galaxycommand to galaxy_command and add fixer	6 years ago
Megan Marsh	7d4353864f	use shell struct in shell-local provisioner and post-processor.	7 years ago
Megan Marsh	ad34a4551b	provisioner/windows-restart: revert sleep hack now that we've fixed the underlying bug in #8369 (#8377)	7 years ago
nywilken	3522e13b1e	provisioner/shell: Add `env_var_format` support to shell provisioner ... * Move setting of default EnvVarFormat to the Prepare function * Add generated hcl2 structure for the updated Shell provisioner config * Move `EnvVarFormat` field to shared common shell type * Add description for the `env_var_format` parameter * Update `env_var_format` when used with `use_env_var_file`	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Adrien Delorme	193d3e6bbd	provisioner.windows-shell: demove duplicate ExecuteCommand field	7 years ago
Lars Lehtonen	9c19cfdc6f	provisioner/shell: fix dropped error	7 years ago
Lars Lehtonen	bd01d0d3c3	provisioner/inspec: Fix dropped error	7 years ago
Lars Lehtonen	b207752883	provisioner/ansible: Fix dropped error	7 years ago
Ruben Tsirunyan	1b35c586ce	Changes to roles_path option	7 years ago
Ruben Tsirunyan	d247329599	Adding support for installing roles with ansible-galaxy for ansible provisioner	7 years ago
Megan Marsh	0f704fb5b2	These cancel functions have been obsolete since merge of c7ce4d598e	7 years ago
Stefan Scherer	35dae5791c	Use --input-file instead of --attrs. ... Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>	7 years ago
David Hao	c6a471d149	[Salt] Replace scp with scp + mv to handle non-root case	7 years ago
David Z Hao	1d4750a2d9	DisableSudo, not PreventSudo	7 years ago
David Z Hao	ea238b66c0	Make salt-masterless provisioner respect disable_sudo directive for all commands	7 years ago
Megan Marsh	6982ec796f	remove redundant error check	7 years ago
Megan Marsh	6dcff18d36	prevent nil pointer dereference by defining IsUserAuthority. This occurred as a regression when we updated the crypto library in v1.4.0	7 years ago
Megan Marsh	de7106c36b	Merge pull request #7696 from hashicorp/go_generate_from_makefile ... run `go generate ./...` from makefile & CI test that it generates no diff	7 years ago
Megan Marsh	4bf75ac0f3	fix null file descriptor error	7 years ago
Adrien Delorme	abd6eda6c9	generate execution policy from makefile ... * make generate now generates on `./...` instead of `.`	7 years ago
Megan Marsh	1204213516	Merge pull request #7678 from hashicorp/docker_windows_defaults ... builder/docker: better windows defaults	7 years ago
Megan Marsh	6f560bef0a	Merge pull request #7653 from aaronwalker/chef_license_acceptance ... adds support for accepting the chef license	7 years ago
Adrien Delorme	478f80af83	remove unused func	7 years ago
Adrien Delorme	7005958155	execution policy: make everything more idiomatic ... * make possible execution policy values lowercase * prefix execution policies possibilities	7 years ago
Adrien Delorme	e62aba3788	allow to set ExecutionPolicy to none for powershell provisioner ... this has the effect to not wrap the command, which will allow to know the exit status of a command in docker	7 years ago
Adrien Delorme	e96409954a	add execution policy type and use it to default the powershell cmd	7 years ago
Aaron Walker	85b8a654b0	only sets default value for chef license when installing chef and the install command is not set	7 years ago
Paul Meyer	814665fddd	Check error returned from retry.Config.Run()	7 years ago
Paul Meyer	ec14ab4875	Add unit test to find issue #7655	7 years ago