451 Commits (b4e70cc0ec0b24b040fe0dfbf68c560dc6c0f736)

Author	SHA1	Message	Date
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Megan Marsh	9f1a4e0fed	Merge pull request #7423 from hashicorp/lock_ports ... Lock packer ports using a lock file	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	f67b5ff59d	virtualbox StepConfigureVRDP: use common/net pkg to find open port	7 years ago
Adrien Delorme	59370986fb	virtualbox StepForwardSSH: use common/net pkg to find open port	7 years ago
Vadym Haidamaka	414d0750f0	Add tests to validate 'none' communicator in the virtualbox builder	7 years ago
Vadym Haidamaka	0263503c45	Validate virtualbox_version_file and guest_additions_mode when communicator is none	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	3dc1dafe58	Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225 ... virtualbox: create ephemeral SSH key pair for build process	7 years ago
Stephen Fox	7e1cbc6d89	Rename references to key pair name to comment. ... Per the OpenSSH manual, the field is for a comment.	7 years ago
Stephen Fox	61a8968b22	Use 'os.OpenFile' to atomically create debug key file. ... Per code review feedback.	7 years ago
Stephen Fox	094c87e395	Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead. ... Per code review feedback, the Go template library supports encoding variables in URL query format. Instead of exposing two different public key formats (unmodified string and a URL encoded string), just have the user apply the 'urlquery' modifier to their template.	7 years ago
Stephen Fox	2ef6b9247d	Initial take on code review feedback from @azr. ... Do not use builder pattern or interfaces; stick to structs and some basic functions.	7 years ago
Megan Marsh	3fd589fa72	typos	7 years ago
Megan Marsh	e2d8c0bfd7	docs	7 years ago
Megan Marsh	07c0c599e0	attach guest additions via SATA when necessasry	7 years ago
chris marget	53c0376dfd	don't print keypair to the user's screen	7 years ago
chris marget	13cc73d600	keypair parsing and testing	7 years ago
Stephen Fox	f9d24ccda0	Allow user to get public key straight up, or URL encoded.	7 years ago
Stephen Fox	f2c11b55be	Renamed authorized_keys public key function.	7 years ago
Stephen Fox	01c98f3d82	Tweaked debug SSH private key file name for vbox.	7 years ago
Stephen Fox	c6ae8654d9	Moved SSH key pair code into 'helper/ssh'.	7 years ago
Stephen Fox	25775886a8	Properly set SSH key pair name.	7 years ago
Stephen Fox	be081944b1	Moved new key pair funcs closer to builder funcs.	7 years ago
Stephen Fox	b1b67ecffa	Added support for setting a name in SSH key pair. ... Also refactored how new SSH key pairs are created, and how the tests are structured.	7 years ago
Stephen Fox	5893134c61	Updated comment for 'PrivateKeyPemBlock()'.	7 years ago
Stephen Fox	cd4ae03324	Create / use SSH key pairs in vbox builders. ... This follows the business logic for creating / using SSH key pairs in the cloud-type builders (e.g., Amazon EC2).	7 years ago
Stephen Fox	72d1501551	Made SSH public key available in vbox boot command. ... The SSH public key (in authorized_keys format) can be retreived in the build template by specifying '{{ .SSHPublicKey }}'. The key is URL encoded to escape spaces.	7 years ago
Stephen Fox	459bd1ea7a	Added vbox step for SSH key pair business logic.	7 years ago
Stephen Fox	6824806e6f	Allow caller to specify new line for SSH public key. ... The default behavior of the various builders that create SSH key pairs appears to be to add a trailing new line. This will be the default behavior, but at least it can be customized if desired.	7 years ago
Stephen Fox	ad075ffac3	Added 'Description()' to 'sshKeyPair'. ... Also cleaned up tests.	7 years ago
Stephen Fox	f233e54992	Initial SSH key pair helper implementation.	7 years ago
Megan Marsh	97a791389a	deduplicate step_output_dir and move to common folder	7 years ago
Adrien Delorme	c8a39e939a	Merge pull request #7178 from edwardmlyte/simplify-version-check ... Simplify version check for port count argument	7 years ago
Ed Maxwell-Lyte	e8e92fe6c6	rename clashing import	7 years ago
Ed Maxwell-Lyte	4437f8d8ba	Use go-version for comparison	7 years ago
Ed Maxwell-Lyte	346f5d9bba	Simplify version check for port count argument ... Might be personal preference, but I think this reads more clearly	7 years ago
Adrien Delorme	9f7b4ffc17	Merge branch 'master' into pr/6950	7 years ago
Ed Maxwell-Lyte	4fc02ea406	Assign to existing var	7 years ago
Adrien Delorme	f91b668617	Create portCountArg in the if statement ... You can't assign to something that doesn't exist Co-Authored-By: edwardmlyte <edwardmlyte@gmail.com>	7 years ago
Ed Maxwell-Lyte	a9eed311a6	Run gofmt on driver_4_2.go	7 years ago
Ed Maxwell-Lyte	e5b1e0f4d9	Add version 0.x to the rule	7 years ago
Ed Maxwell-Lyte	e40c90423f	Reverse default port count virtualbox argument ... As we know the exact versions that used the old `sataportcount` option, it's safe to assume we want to use the newer `portcount` option for everything else. Reversed the option check and use the `portcount` option by default. Prevents needing to update this for future major versions of VirtualBox.	7 years ago
Adrien Delorme	b7222d1f56	Add tmp package that offers Dir & File funcs ... this regroups the calls of tmp func calls into one package. the tmp pkg allows to store tmp files under a common directory for easier managment Squashed commit of the following: commit 74b674c015 Merge: fc94b5714 66001525d Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 02:02:38 2018 -0400 Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs commit fc94b57142 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit 5a562359f4 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 9d5a4a0935 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit fbae4c2e05 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 3590fae8bd Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit d5c5306a97 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 0a72297da8 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 20f68228b6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit c73ebe3d83 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit 63549b8bd7 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit 9761010749 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit 95159afbc0 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 66001525d7 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit e9b6adefea Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 852113ed07 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit 54add38d1d Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 6b5b8f6d4e Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit c22092c601 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 7a73045091 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 0f2933adb6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit d74839ede0 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit eb65416619 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit acaa2b31ed Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit e573fde668 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 39a9874afc Merge: 8a413cfe8 3315812c2 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 18:19:26 2018 -0400 Merge branch 'master' of https://github.com/hashicorp/packer into prestine commit 8a413cfe83 Merge: e07491de5 4e14710a6 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Oct 1 20:18:10 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit e07491de59 Merge: 42610a35d a1fa35dff Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Aug 21 13:26:19 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 42610a35d5 Merge: 5298142da 0d63cf7bc Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue Jun 19 22:45:05 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 5298142da6 Merge: 7bb110bc7 9d9736552 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Jun 11 15:10:09 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 7bb110bc74 Merge: a61c869ca 6189d66e7 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Wed May 9 23:41:22 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit a61c869ca7 Merge: 098101dd9 4be5f072c Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri May 4 10:13:04 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 098101dd99 Merge: fefaf0fa6 554b2b4a5 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue May 1 20:52:30 2018 -0400 Merge branch 'EOL-handling' into prestine Co-Authored-By: Matthew Patton <pattonme@yahoo.com>	7 years ago
Megan Marsh	a819217c93	fix virtualbox 6.0 beta command options	7 years ago
Megan Marsh	6728244480	simplify for loop logic	7 years ago