72 Commits (af009c2aa0957526004ce2ba38c19cebc965ce8d)

Author	SHA1	Message	Date
Sylvia Moss	ce45a1990a	Refactor communicator config for Qemu and add SkipNatMapping option (#9307)	6 years ago
Megan Marsh	9ee75bc41c	add disk_size, disk_thin_provisioned, and disk_eagerly_scrub to the DeprecatedOptions field.	6 years ago
Megan Marsh	9842e02aab	Update fix/fixer_amazon_temporary_security_group_cidrs.go ... Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Megan Marsh	21e9bef202	update fixer interface to return a list of deprecated options, if any	6 years ago
Megan Marsh	ddf223b56b	fix fixer	6 years ago
Megan Marsh	1edc931e7f	actually run the fixer	6 years ago
Megan Marsh	3ad2f86cc2	fix network card fixer (#9311)	6 years ago
Adrien Delorme	0fa60c68fb	Drop the iso_checksum_type & iso_checksum_url fields (#8437) ... * Drop the iso_checksum_type & iso_checksum_url fields In favor of simply using iso_checksum that will know what to do. * fix after master merge * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * remove checksum lowercasing tests * Update builder_test.go * Update builder_test.go * better docs * Update builder_test.go * even better docs * Update config.go * Update builder_test.go * Update step_create_vmx_test.go * make generate * better docs * fix imports * up tests * Update _ISOConfig-required.html.md * Update builder_test.go * don't use sha1.Sum("none") as a caching path * Update builder_test.go * better docs * Update iso_config_test.go remove ISOChecksumType/ISOChecksumURL references * Update step_download_test.go * add iso_checksum_url and iso_checksum_type fixers + tests * add concrete examples of checksum values * add examples of checksumming from local file * update go-getter dep * up deps * use new go-getter version * up ESX5Driver.VerifyChecksum: use go-getter's checksumming * ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum * Update iso_config.go * get go-getter from v2 branch * Update driver_esx5.go add more comments * Update driver_esx5.go * show better error message when the checksum is invalid * Update builder_test.go put in a valid checksum to fix tests, checksum is md5("packer") * Update builder_test.go test invalid and valid checksum * more test updating * fix default md5 string to be a valid md5 * TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming * Update iso_config_test.go * Update iso_config_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update CHANGELOG.md * Update CHANGELOG.md * Update go.mod * Update go.mod * Update CHANGELOG.md	6 years ago
jhawk28	820f353573	(vsphere-iso) remove deprecated network and disk fields (#9149) ... * remove deprecated network and disk fields	6 years ago
Adrien Delorme	4ebcbad332	update consul and vault dependencies (#9205) ... * update consul and vault dependencies * update triton sign call accorting to https://github.com/joyent/triton-go/pull/135 * Delete readme.md * put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why * fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order	6 years ago
Megan Marsh	16233371e6	fix unrelated broken flaky test	6 years ago
Megan Marsh	7c13cc5744	swap out tag for tags since it's a list ... add fixer for docker tag to tags change	6 years ago
Wilken Rivera	b9f1b3c8d4	Fix gosimple S1005 linting issue (#8870) ... Results before change ``` ⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1005 fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple) fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple) fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple) packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple) packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple) ``` Results after change ``` ```	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
nywilken	d2a9e6b32e	Format code with `gofmt -s -w`	6 years ago
Sylvia Moss	d6a351b173	Rename communicator config variables and remove deprecated code (#8584)	6 years ago
Ricard Clau	b2578ee0f9	Fix typo in Synopsis for galaxycommand fixer (#8573)	6 years ago
Kevin Gunn	a7d32afe4e	removed escape character check, updated synopsis string, change type to 'ansbile-local' only	6 years ago
Kevin Gunn	70aa0516de	reset ansible-local documentation to include galaxy_command ... fix spacing in fixer.go	6 years ago
Kevin Gunn	28d1037864	change galaxycommand to galaxy_command and add fixer	6 years ago
Victor Yap	9a961bb079	Implement fixer to convert qemu disk size type to string	6 years ago
Brendan Devenney	2b16b5cae4	Move fixer test to fix package ... Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Brendan Devenney	75d8d7fce5	Update and futureproof fix command usage ... * Dynamically generate the fixer documentation (in order) from FixerOrder * Update fixers which used linebreaks in their Synopsis Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Brendan Devenney	556492fb0d	Add fixers erroneously removed by e8f04c3 ... Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Megan Marsh	c979cad579	add a fixer and update docs for spot_price_auto_product	7 years ago
Megan Marsh	3e72e65a6c	Merge pull request #7456 from hashicorp/do_5770 ... introduce the clean_resource_name to clean image/var names	7 years ago
Adrien Delorme	a08d9dec9b	add a Fixer that replaces the "clean_(image|ami)_name" template calls with "clean_resource_name"	7 years ago
Megan Marsh	17c14770a7	Merge pull request #7450 from AkshatM/rename_security_group_cidr_to_security_group_cidrs ... Rename and change `temporary_security_group_source_cidr` to accept a list of strings (for Amazon builders).	7 years ago
Akshat Mahajan	22504200cc	Fix typographical errors in the fixers	7 years ago
Akshat Mahajan	f07e4214cc	Addresses issues #5384, #5494: Rename and change `temporary_security_group_source_cidr` ... to accept a list of strings (for Amazon builders). Per this change, `temporary_security_group_source_cidr` in the configuration: 1. Will be renamed to `temporary_security_group_source_cidrs`. 2. Will accept a list of CIDRs. 3. Will have its documentation updated to reflect this change. 4. Will have a fixer attached for newer templates to avail of.	7 years ago
Megan Marsh	2b57b10284	write fixer	7 years ago
Megan Marsh	424a6a3a7e	Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming ... DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""	7 years ago
Don Kuntz	279fb7a632	gofix	7 years ago
Don Kuntz	b0589c9643	Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip	7 years ago
Don Kuntz	04de86d211	Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP	7 years ago
Don Kuntz	e4faa98b6f	cleanup: remove continue statement after a return statement, because it's unreachable	7 years ago
Don Kuntz	e251adb37e	Make the amazon-private-ip fixer errors more visible ... At present, when using the packer fix command on a template that has "ssh_private_ip" set to anything but a boolean value, the fixer will fail, and appear to fail silently, simply returning a non-zero status code without any message. To determine what happened, users have to know to set PACKER_LOG=1 to make the log message visible. So far as I can tell, this is the only instance of log.Fatalf being called, and based on the surrounding code the better solution would be to return an error, which will then be visible to users of packer fix without having to look in the logs.	7 years ago
Megan Marsh	be0959004a	Revert "Revert "Rename attribute api_access_key to organization_id""	7 years ago
Megan Marsh	c1c929164f	Revert "Rename attribute api_access_key to organization_id"	7 years ago
Rémy Léone	e54d2e3591	Rename attribute api_access_key to organization	7 years ago
Matthew Hooker	8a7d43dd44	bug fix and add test	8 years ago
Matthew Hooker	42910a5f8c	fix docker email fixer ... Fixing post-processors requires some smart parsing of the template. Let's turn that logic into a helper and use it everywhere.	8 years ago
Jeffrey Martin	e8f04c34a3	add vmware-compaction fixer help	8 years ago
Jeffrey Martin	1833b4edaf	validate compaction is skipped when not 'thin'	8 years ago
Matthew Hooker	7519037562	Merge pull request #6629 from hashicorp/travisbuild ... travis builds go 1.11. remove 1.9	8 years ago
Matthew Hooker	e41e99954d	go 1.11 format rules	8 years ago
DanHam	c8f54d5291	Fixer and tests to convert 'clone_from_vmxc_path' -> 'clone_from_vmcx_path'	8 years ago
DanHam	28087cb9f7	Fixer and tests to remove deprecated 'vhd_temp_path' Hyper-V ISO setting	8 years ago
Brendan Devenney	73c532e772	Ensure amazon-private-ip fixes string values ... The "ssh_private_ip" key works with either boolean values or string representations of booleans. The fixer errors when the value is defined as, for example, "true" (with quotation marks). This commit will attempt to convert the string into a bool when necessary to ensure this case is handled. Signed-off-by: Brendan Devenney <brendan.devenney@cloudreach.com>	8 years ago
Matthew Hooker	c6299972b9	s/boot_command/bootcommand/	8 years ago