873 Commits (aa91ef7edfb9d2c17758e2e7ef7e6bec9073bf1a)

Author	SHA1	Message	Date
Megan Marsh	b5b8f2e308	add template option for templating the inventory file lines (#9438)	6 years ago
Megan Marsh	3d7c9cb9c2	make ansible provisioner docs generated from code (#9439)	6 years ago
Wilken Rivera	d72173ac1a	Revert "Merge pull request #9040 from hashicorp/powershell-exit-code-fix-4916" ... This reverts commit 334f399ee3, reversing changes made to 45a5d28bad. When testing against Windows SSH the Powershell script fails to parse the newly added if statement.	6 years ago
Megan Marsh	9699af4dee	Merge pull request #9350 from gamethis/fix_ansiblepassword ... Fix for ansible_password	6 years ago
Lane, Larry	5976929595	Fix for #9283	6 years ago
Søren Hansen	19e4afa728	provisioner/windows-restart: Get full hostname, instead of just the NetBIOS name. (#9335) ... `env:COMPUTERNAME` give you the first 15 characters of the machine name (the NetBIOS name). But normally its pretty nice to get the full DNS name. We can solve this in this way.	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	077d34f12c	Merge pull request #9279 from gamethis/fix_arg_order ... [WIP] Anisble-Remote fix arg order	6 years ago
Adrien Delorme	a2e9439ee6	provisioner/salt-masterless: ignore the CmdArgs field in hcl2 (#9290) ... fix #9233	6 years ago
Wilken Rivera	1e90165a56	Add source URL to test fixture script (#9296)	6 years ago
Megan Marsh	fecb040bf4	fix bug where build vars couldn't be properly interpolated into this execute command (#9275)	6 years ago
Lane, Larry	f4254e9cbf	updated test	6 years ago
Lane, Larry	c689eb9694	added test	6 years ago
Lane, Larry	de12432e6b	add test	6 years ago
Lane, Larry	e6670fc4a0	fix arg order	6 years ago
Wilken Rivera	2e326ef334	Switch back to call operator as opposed to dot sourcing ... * Ensure child scope doesn't conflict with parent scope * Add elevated user options to tests case.	6 years ago
Wilken Rivera	38f799df3e	Add conditional to check if LastExitCode is defined ... * Add broken requires statement test case * Add test case to reproduce invalid LastExitCode	6 years ago
Wilken Rivera	35df3914d2	provisioner/powershell: Update default execute command to handle script errors ... This change sets the ErrorActionPreference and wraps the script execution in a Try/Catch statement so that the provisioner can capture any errors encountered when running the script. In addition to the try/catch the `&` operator is replaced by the `.` sourcing operator to ensure the script is executed in the same scope as the parent command (so that errors bubble up properly). Tests after change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test ./provisioner/powershell/... -timeout=1h ok github.com/hashicorp/packer/provisioner/powershell 915.865s ```	6 years ago
Wilken Rivera	13e0c1a097	tests/provisioner/powershell: Add acceptance test to reproduce issue 4916	6 years ago
Sylvia Moss	be9dbaacd7	Interpolate generatedData in the Inspec provisioner (#9262) ... * Interpolate generatedData in the Inspec provisioner * Add inspec license section to inspec docs * add user arg if user config it not empty * increase resource size for check-lint pipeline * update changelog * Update provisioner/inspec/provisioner.go * Update provisioner/inspec/provisioner.go Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Wilken Rivera	c330d2f04c	provisioner/powershell: Update cleanup logic ... This change reduces the retry timeout from 5m to 1m, and sets the RetryDelay to 10s for a total of 6 retries. In additional to the retry time reduction the cleanup script will now check to see if the provisioner script created by Packer exists before trying to delete to prevent any file not found issues. Closes #9181 Closes #9189	6 years ago
Lars Lehtonen	7440c2e6ba	provisioner/windows-shell: remove unused testObjects() (#9116)	6 years ago
DamianBis	b679f61536	Update to make NoExitOnFailure work correctly. (#9119) ... if NoExitOnFailure is true then ignore the error returned from salt.	6 years ago
Matt Kotsenas	fe55494207	Add `debug_mode` to PowerShell provisioner (#8996)	6 years ago
Sylvia Moss	553b1fb9f8	Add RetriedProvisioner to allow retry provisioners (#9061)	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Megan Marsh	73c349d09c	Merge pull request #8908 from hashicorp/fix_4795 ... provisioner/powershell: Add cleanup step to remove any temporarily created scripts	6 years ago
Lars Lehtonen	49f28c9439	provisioner/powershell: fix dropped error ... provisioner/powershell: improve error message	6 years ago
Wilken Rivera	4a46d6ff7b	docs/provisioner/powershell: Add documentation for `skip_clean` option	6 years ago
Wilken Rivera	fe721d8e11	test/provisioner/powershell: Add acceptance test for powershell provisioner cleanup ... Passing Tests ``` --- PASS: TestAccPowershellProvisioner_basic (282.02s) --- PASS: TestAccPowershellProvisioner_basic/testing_amazon-ebs_builder_against_powershell_provisioner (282.01s) PASS ok github.com/hashicorp/packer/provisioner/powershell 282.046s ``` Failing tests on master ``` 2020/04/08 09:59:34 Uploading file to 'c:/Windows/Temp/script.bat' 2020/04/08 09:59:36 [INFO] starting remote command: set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat" 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: C:\Users\Administrator>dir C:\Windows\Temp\packer-*.ps1 2020/04/08 09:59:36 ui: amazon-ebs: Volume in drive C has no label. 2020/04/08 09:59:36 [INFO] command 'set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat"' exited with code: 0 2020/04/08 09:59:36 ui: amazon-ebs: Volume Serial Number is 46CA-4083 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: Directory of C:\Windows\Temp 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 102 packer-acc-test-script-test.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 76 packer-acc-test-vars.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 2 File(s) 178 bytes 2020/04/08 09:59:36 ui: amazon-ebs: 0 Dir(s) 9,735,806,976 bytes free 2020/04/08 09:59:36 ui: ==> amazon-ebs: Provisioning step had errors: Running the cleanup provisioner, if present... 2020/04/08 09:59:36 ui: ==> amazon-ebs: Terminating the source AWS instance... 2020/04/08 10:00:09 ui: ==> amazon-ebs: Cleaning up any extra volumes... 2020/04/08 10:00:09 ui: ==> amazon-ebs: No volumes to clean up, skipping 2020/04/08 10:00:09 ui: ==> amazon-ebs: Deleting temporary security group... 2020/04/08 10:00:10 ui: ==> amazon-ebs: Deleting temporary keypair... 2020/04/08 10:00:11 ui error: Build 'amazon-ebs' errored: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] 2020/04/08 10:00:11 machine readable: error-count []string{"1"} 2020/04/08 10:00:11 ui error: ==> Some builds didn't complete successfully and had errors: 2020/04/08 10:00:11 machine readable: amazon-ebs,error []string{"Script exited with non-zero exit status: 0.Allowed exit codes are: [1]"} 2020/04/08 10:00:11 ui error: --> amazon-ebs: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] ``` test: Fix windows-shell command	6 years ago
Wilken Rivera	91c8afda8e	provisioner/elevated: Add cleanup logic to remove elevated user scheduled task artifacts	6 years ago
Wilken Rivera	11db6014fa	provisioner/powershell: Update remote clean up logic ... * Add retry logic so that the provisioner will retry if it fails to upload/execute because of some restart provisioner step * Add a testConfigWithSkipClean for testing that the provisioner executes the correct commands * Add a test case for toggling the "skip_clean" config option	6 years ago
Wilken Rivera	f6a61e2511	provisioner/powershell: Add post clean up step to remove temp script files	6 years ago
Wilken Rivera	1eee0bca5f	Merge pull request #9011 from hashicorp/powershell-acceptance-test ... provisioner/powershell: Add basic Powershell provisioner acceptance tests	6 years ago
Megan Marsh	bdcc95f989	fix execution policy parser to not interfere with legit integers, and add tests (#8997)	6 years ago
Lars Lehtonen	78bb742aa5	provisioner/shell: fix dropped test error	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Moss	185deeeb38	Fix provisioner acc-test builder and provisioner store	6 years ago
Wilken Rivera	b183c5498f	provisioner/powershell: Add basic Powershell provisioner acceptance tests ... * Modifies the amazon-ebs builder with a windows build configuration ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/powershell/... -run=TestPowershellProvisioner_Inline --- PASS: TestPowershellProvisioner_Inline (256.50s) --- PASS: TestPowershellProvisioner_Inline/testing_amazon-ebs_builder_against_powershell_provisioner (256.50s) PASS ok github.com/hashicorp/packer/provisioner/powershell 256.525s ```	6 years ago
Megan Marsh	b804e5a8f5	Merge pull request #8987 from VaijanathB/azure-devtestlabs-take2 ... Building Azure devtestlabs Images using Packer - update	6 years ago
Megan Marsh	8840b4a830	Merge pull request #8625 from hashicorp/remove_ansible_proxy ... Remove ansible proxy	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Vaijanath Angadihiremath	b7d85b8a23	Added acceptance tests for DTL. Fixed couple of issues with DTL root resource group not set to new directory	6 years ago
Vaijanath Angadihiremath	69015b1870	Fixing the linting errors	6 years ago
Vaijanath Angadihiremath	e726902116	Fixing the latest changes from the merge	6 years ago
Vaijanath Angadihiremath	645cdf1a59	Updating the modules to include update to autorest 12.4	6 years ago
Megan Marsh	b66e49223d	extract the building of command args into a testable helper function	6 years ago
Megan Marsh	91906b688c	regenerate code	6 years ago
Megan Marsh	73c87044fd	fix tests	6 years ago