236 Commits (9ee75bc41c312a7cb6107bc03dbba6eafefebe10)

Author	SHA1	Message	Date
Megan Marsh	a94e147865	fix go fmt	6 years ago
Megan Marsh	b28059c0a5	add generator to create a list of all the deprecated options that the fixers fix ... fix location of deprecated_options code	6 years ago
Megan Marsh	15b14d4879	add deprecation check to config helper	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Megan Marsh	217dcbb97f	golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago
Jeff Escalante	2999934326	fix generation script, bugfixes in source comments, update website paths in primary codebase	6 years ago
Jeff Escalante	4afd107eeb	patch source files for extensions changes	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	834f44190f	go generate	6 years ago
Adrien Delorme	87d6b2433f	make generate	6 years ago
Megan Marsh	fc35f02004	Merge pull request #8890 from hashicorp/fix_8880 ... fix googlecompute password interpolation	6 years ago
Megan Marsh	e94ff70199	Merge pull request #8883 from hashicorp/fix_8835 ... Interpolate shell inline config	6 years ago
Megan Marsh	6477d8a0c8	Merge pull request #8882 from hashicorp/fix-var-file-hcl ... allow to use hcl files as var files in HCL mode	6 years ago
Megan Marsh	6008f911fd	Merge pull request #8847 from takaishi/support-keyboard-interactive ... communicator/ssh: support keyboard-interactive auth to connect bastion	6 years ago
Megan Marsh	bcb7b8751c	fix googlecompute password interpolation	6 years ago
Moss	5a8c628880	Add acc test validation to avoid running with unit tests	6 years ago
Moss	3f49b7c66e	Fix linter	6 years ago
Moss	2ca6804827	Move shell prov acc test to the same folder	6 years ago
Adrien Delorme	60a3105a45	make ssh docs less AWS specific	6 years ago
r_takaishi	70e3f60539	write unit test	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Adrien Delorme	7ec39ebb4e	TestStringSlice_Set: check error even if none is returned	6 years ago
Adrien Delorme	6b48feb817	kvflag: add TestStringSlice_Set	6 years ago
Adrien Delorme	c8300b620a	allow to use hcl files as var files in HCL mode ... fix #8781	6 years ago
Wilken Rivera	7b705545d9	docs: Various doc clean-ups to fix code block formatting and syntax highlighting (#8868)	6 years ago
r_takaishi	34bb0429d0	keyboard-interactive used when ssh_bastion_host is true.	6 years ago
Sylvia Moss	76f13deaf4	Make template variables SSHPublicKey and SSHPrivateKey as strings (#8829)	6 years ago
Lars Lehtonen	74a94d8547	helper/builder/testing: prune unused functions (#8852)	6 years ago
r_takaishi	e2df4a80f8	support keyboard interactive auth	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Megan Marsh	d252a24b82	allow user to set winrm_host override like we do ssh_host override	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Megan Marsh	82f03fca7c	fix to work with hcl2; update tests	6 years ago
Megan Marsh	4059ed75f5	update docs to mention ssh auth sock env var (#8523) ... Closes #8358 Add some docs to alleviate confusion.	6 years ago
Megan Marsh	cd7abf1f9e	clean up a few final issues with info sharing	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
nywilken	a61fe833ef	helper/communicator/step_connect_ssh: Update proxy connection settings to use `SSHProxyUsername` and `SSHProxyPassword`	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Chris Roberts	8bb7d8dc16	Prevent busy loop while waiting for WinRM connection ... Set first run variable outside conditional so it will properly be updated during the first run and pause on subsequent runs.	7 years ago