304 Commits (992cbe6dee7dccdfd56e88c5b2112ec4dd6247f5)

Author	SHA1	Message	Date
Adrien Delorme	d532bb376c	wip	6 years ago
Adrien Delorme	87d6b2433f	make generate	6 years ago
Adrien Delorme	b4efd13a4d	aws: use the empty func when possible	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Adrien Delorme	7d5f0c11af	add max_retries option to aws builders	6 years ago
Megan Marsh	d252a24b82	allow user to set winrm_host override like we do ssh_host override	6 years ago
Wilken Rivera	111bab86d9	Merge pull request #8622 from datalot/pre-validate-with-filters ... Allow aws builder pre validation to pass when subnet filters are present	6 years ago
Sylvia Moss	0b7251a4bb	Share .Device and .MountPath between builders, provisioners and post-processors (#8621)	6 years ago
Rich Cavanaugh	4fb0de5256	allow validation to pass when subnet filters are present	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Adrien Delorme	731904d3d2	mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Oded Priva	5e81c6f44e	added the option to skip IAM instance profile validation (#8457)	6 years ago
nywilken	f9f4726eff	builder/amazon/step_pre_validate: Add check for non-default VPCs ... Subnet information is only really needed when the specified `vpc_id` is not the default VPC for the region where the builder is being executed. This change uses the AWS API to determine if the VPC provided is a non-default VPC and only validates the existence of a `subnet_id` if a user has provided a non-default `vpc_id`. Tests after change ``` > make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc' ... === RUN TestStepPreValidate_checkVpc === RUN TestStepPreValidate_checkVpc/DefaultVpc === RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet === RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet === RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc === RUN TestStepPreValidate_checkVpc/NoVpcInformation --- PASS: TestStepPreValidate_checkVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s) PASS ... ```	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Bernard Baltrusaitis	6e2146324f	Merge branch 'master' of github.com:b-b3rn4rd/packer	7 years ago
Bernard Baltrusaitis	8b83cca064	adding temporary instance profile document policy	7 years ago
Megan Marsh	4bc381183d	make aws instsance builder work with recent changes for volume copy	7 years ago
Megan Marsh	0cbd3ff0f3	make sure amazon builders respect ssh_host option	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	1a6adadb89	convert EnableAMIENASupport to trilean in code	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	6ad975f296	Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" ... This reverts commit b0c09087a2.	7 years ago
Megan Marsh	c722afe707	stop calculating spot bids; amazon changed the way spot instances are priced to be stable rather than bid-based, so when user sets auto, we can just default to the ondemand price and know that they'll get the same price as everyone else bidding at that time.	7 years ago
Adrien Delorme	aeb898d598	document amazon-instance builder with partials	7 years ago
Adrien Delorme	c696878d2e	aws block devices mapping: BlockDevices.Build -> BuildEC2BlockDeviceMappings()	7 years ago
Adrien Delorme	ff2e0298ba	simplify block devices utilisation by removing intermediary types	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
Megan Marsh	708165eaa8	refactoring step_run_spot_instance and swapping out the calls to create a spot instance with a call to create a spot fleet of one, so that we can be more flexible with the instance type when desired	7 years ago
Megan Marsh	2c352cc681	add tests for step_ami_region_copy	7 years ago
Megan Marsh	201c8c1332	make sure that you encrypt using the provided kms key id and not the default	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Akshat Mahajan	f07e4214cc	Addresses issues #5384, #5494: Rename and change `temporary_security_group_source_cidr` ... to accept a list of strings (for Amazon builders). Per this change, `temporary_security_group_source_cidr` in the configuration: 1. Will be renamed to `temporary_security_group_source_cidrs`. 2. Will accept a list of CIDRs. 3. Will have its documentation updated to reflect this change. 4. Will have a fixer attached for newer templates to avail of.	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	3ed9fe6dee	remove unused imports ... remove HttpClientWithEnvironmentProxy from amazon builders; let access config handle it	7 years ago
Megan Marsh	3704a053d0	move region validation and credential wait into step pre validate	7 years ago
Megan Marsh	035c3506ba	manually set proxyfromenvironment in default http client for ec2 sessions	7 years ago
Megan Marsh	9573013d3a	Merge pull request #6872 from aspectcapital/disable-ena-support ... Add support to explicitly disable ENA support	8 years ago
Matt Dainty	feb8067c7d	Convert `ena_support` to a pointer ... This means it now has three states, `true`, `false`, & `nil`. The default state is now `nil` which does nothing instead of `false` which now will explicitly disable ENA support instead of just not enabling it.	8 years ago
Megan Marsh	57f87f58b9	Merge pull request #6374 from rickard-von-essen/aws-filters ... builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter	8 years ago
Matthew Hooker	9181570bc3	remove stray struct dumps in logs	8 years ago
Megan Marsh	79093da6ad	skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock	8 years ago
Megan Marsh	38cc525ec7	new option allowing user to clean up the ephemeral ssh key from the authorized_keys file	8 years ago
Adrien Delorme	2e73ed8d46	pass Comm instance to fix Spot instance creation	8 years ago
Adrien Delorme	e02d0dacc4	Merge branch 'master' into aws-filters	8 years ago
Megan Marsh	b94e6e913e	Merge pull request #6670 from sargun/fix-ena-on-pv ... Allow users to build hvm images from pv images to have ena_support	8 years ago
Sargun Dhillon	902497d6ce	Allow users to build hvm images from pv images to have ena_support	8 years ago
RenaudS	26aab49aaf	aws spot instances: add block_duration_minutes option (#6638) ... * Add block_duration_minutes option * int64 cannot be nil * Update doc * Fix formating	8 years ago
Adrien Delorme	df9e756865	pass the Comm instance to the amazon ebs builders steps	8 years ago
Adrien Delorme	b0c09087a2	move SSHInterface/SSHIPVersion fields to communitator.Config struct	8 years ago
Adrien Delorme	ef4ca9c48e	builder.amazon: use c.Comm for ssh	8 years ago
Adrien Delorme	293c485372	builder.aws: use SSHAgentAuth from Comm	8 years ago
Adrien Delorme	ef08c441c9	builder.aws: use Comm field for StepKeyPair & StepGetPassword	8 years ago
Adrien Delorme	51d2aac9f6	SSHPrivateKey => SSHPrivateKeyFile	8 years ago
Matthew Hooker	e41e99954d	go 1.11 format rules	8 years ago
Rickard von Essen	533967cb66	builder/amazon: Add suppport for security_group_filter ... Allow selecting SG's using a filter. Also some cleanup of vpc_filter and subnet_filter.	8 years ago
Megan Marsh	340363a649	Merge pull request #6613 from hashicorp/merge_ssh_config_funcs ... Merge ssh config funcs from builders	8 years ago
Adrien Delorme	41f6e0334d	refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc ... * still need to append the auth methods into an array for gracefullness	8 years ago
Megan Marsh	ff6a039d5b	replace scrubconfig with packer.LogSecretFilter.Set ... filter winrm password from logs Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.	8 years ago
James Nugent	9fffe4056e	Merge pull request #5452 from smaato/tag-spot-requests ... Enable tagging of spot requests	8 years ago
Megan Marsh	f49a2d8aed	move UI call to before the wait; add context to these steps	8 years ago
Megan Marsh	cf63dd10bf	replace AMIStateRefreshFunc, InstanceStateRefreshFunc, our spot instance waiter, our chroot volume waiter, and our snapshot waiters with waiters form AWS's SDK.	8 years ago
Mark Meyer	3dbf1cb371	Enable tagging of spot requests ... This adds a new parameter to the EBS builders named `spot_tags'. This parameter accepts a map of tags, much like `tags'. These tags will be applied to a spot request that is created. Improve visibility.	8 years ago
DanHam	d5304a25e9	Pass T2 Unlimited settings to run instance step for appropriate EC2 builders	8 years ago
DanHam	9b6fc5a58d	Remove tmp files created by builder/amazon/instance tests	8 years ago
Megan Marsh	3afb243f11	use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.	8 years ago
Matthew Hooker	21812fa17f	Add volume and run tags if in us-gov/china ... We can't tag on instance creation when we're in "restricted" regions, so let's add the tags after the resources have been created. Adds methods to AccessConfig to detect if we're in China or US Gov regions (i.e. "restricted"). Also turns tag:tag maps into a type, and moves methods around validating and converting them to ec2Tags to methods of the type.	8 years ago
Matthew Hooker	7a189a83a1	fix imports ... `find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`	8 years ago
Matthew Hooker	a831d522be	change run signatures ... Run now takes a context as well as a statebag. We'll assign the context to the blank identifier to prevent namespace collisions. We'll let the step authors opt-in to using the context. `find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`	8 years ago
Matthew Hooker	366dc3da0a	move multistep imports to helper. ... gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"	8 years ago
Matthew Hooker	ebe995c0ff	run goimports	8 years ago
Matthew Hooker	f3dea272d9	Set session in state bag ... We can construct connections to arbitrary regions from it	8 years ago
Matthew Hooker	f6c401a143	don't pass in accessconfig	8 years ago
Rong Chen	3e92b1374e	issue5606: follow the convention to use AccessConfig to create new aws session for step_create_tags etc.	8 years ago
Rickard von Essen	63f791570a	Merge pull request #5665 from kwilczynski/remove-sts-token-from-logging ... amazon: Remove Session Token (STS) from being shown in the log.	8 years ago
Matthew Hooker	f216330ba3	spot instance ena/sriov checking for all other builders	8 years ago
Krzysztof Wilczynski	05327b7524	amazon: Remove Session Token (STS) from being shown in the log. ... This commit adds a change which ensures that the Session Token config struct item is removed from log output. Signed-off-by: Krzysztof Wilczynski <kw@linux.com>	8 years ago
John Davies-Colley	707ec675b2	ssh interface for amazon builders 🔨	9 years ago
Matthew Hooker	8ab390a048	Merge pull request #5495 from smaato/master ... Fix regressions relating to spot instances and EBS volumes	9 years ago
Matthew Hooker	c65fa8490d	fix various bugs deregistering AMIs ... always deregister ami in session region validate that session region does not appear in ami_regions	9 years ago
Mark Meyer	4c5df79222	Fix regressions introduced in the instance builder ... Related to #5504	9 years ago
Matthew Hooker	f7e269945e	add cidr validation and rename option	9 years ago
Matthew Hooker	c74be87187	Merge pull request #5384 from dave2/sg-source-cidr ... [WIP] Allow temporary security group to have source CIDR block explicit	9 years ago
SwampDragons	512ac214b4	Merge pull request #5417 from smaato/master ... Add ability to tag volumes on creation	9 years ago
Mark Meyer	dbb3c76032	Remove redundant step and its usage ... StepTagEBSVolumes is no longer needed, since this functionality is now taken over by StepRunSourceInstance and StepRunSpotInstance. So remove this functionality from the codebase.	9 years ago
Matthew Hooker	ae455bff99	add debugging help if ec2-upload-bundle fails	9 years ago
Mark Meyer	2661fd7869	Move building of spot instances into its own step	9 years ago
Zanetti, David	8a8b51be97	Allow temporary security group to have source CIDR block explicitly provided	9 years ago
Matthew Hooker	02cd6bc7f0	Merge pull request #5288 from hashicorp/fix3114 ... add token variable to upload bundle command template	9 years ago
Matthew Hooker	4bc8e7de3d	add token variable to upload bundle command template	9 years ago
Megan Marsh	2d4bc70d7b	use ami prefix to make it clear that these variables are amazon specific ... add fixer, fixer tests	9 years ago
Megan Marsh	9e2e467b31	Allow granular modification of sriov and ena enhanced networking options in amazon amis. Maintain old functionality.	9 years ago