packer

Commit Graph

Author	SHA1	Message	Date
Lucas Bajolet	962ccdfc80	packer: address gosimple lint errors	2 years ago
Lucas Bajolet	4a7f5f38a6	Makefile: replace enumer upstream with dmarkham's (#13107 ) Since the enumer implementation we used hadn't been updated for 5+ years, this didn't work with recent linux/go versions, and enumer crashed while attempting to parse/analyse the source files. There's another alternative on Github, forked from the one we used, which seems more maintained now, and does produce the expected files in Packer.	2 years ago
Lucas Bajolet	b4a843c4e2	commands: reject constraints with pre-releases (#12999 ) When remotely installing a plugin, constraints are used by Packer to determine which version of a plugin to install. These constraints can be arbitrarily complex, including operators and ranges in which to look for valid versions. However, the versions specified in those constraints should always be final releases, and not a pre-release since we don't explicitly support remotely installing pre-releases. This commit therefore addds checks to make sure these are reported ASAP, even before the source is contacted to list releases and picking one to install.	2 years ago
Lucas Bajolet	a852434410	packer: fix listing on windows with .exe ext Listing installed plugins on Windows requires the extension to be set in the ListOptions, otherwise they are not discovered. While working on the discovery code, and consolidating it in a single location, we've forgotten to pass the argument to ListInstallations, so that makes it impossible to automatically discover installed components on Windows. This commit fixes this issue for the plugins required, and the general discovery process during build/validate.	2 years ago
Lucas Bajolet	c7f2508373	addrs: return error on ParsePluginSource The ParsePluginSource function can be invoked from either a HCL2 context (when parsing a required_plugins block), or from the command-line itself. While in the first context a hcl.Diagnostics is coherent, in case the source to parse is a command-line argument, for example when installing or removing a plugin, the error message cannot have an HCL context, leading to errors that are incorrectly prefixed by a <nil> string dure to the lack of a reference to attach the diagnostic to. Therefore, in order to fix this behaviour, the logic that parses plugin sources now returns an error, and attaching the error to an HCL subject is done independently, if needed.	2 years ago
Wilken Rivera	9f2d6ce1fc	docs/plugins/remove: Update command usage text * Add an example of piping the results of `plugins installed` to `plugins remove`	2 years ago
Lucas Bajolet	b24ab44a55	command: list releases only for remote installs When installing a plugin from a remote source, we list the installed plugins that match the constraints specified, and if the constraint is already satisfied, we don't do anything. However, since remote installation is only relevant for releases of a plugin, we should only look at the installed releases of a plugin, and not consider pre-releases for that step. This wasn't the case before this commit, as if a prerelease version of a commit (ex: 10.8.1-dev), and we try to invoke `packer init` with a constraint on this version specifically, Packer would locate that pre-release and assume it was already installed, so would silently succeed the command and do nothing. This isn't the expected behaviour as we should install the final release of that plugin, regardless of any prerelease installation of the plugin. So this commit fixes that by only listing releases, so we don't report the plugin being already installed if a prerelease is what's installed.	2 years ago
Lucas Bajolet	2d8aa69779	init: fix --force and pre-releases installed case When packer init is invoked with a --force argument, but no --update, we clamp the version to install based on the last one locally installed. Doing this may however cause the constraint to always be false if the latest available version of a plugin is a pre-release, as none of the upstream constraints will match that. Therefore this commit changes how the constraint is derived from the local list of installations, so that only the last installation that matches the original constraint will be used, and not a pre-release.	2 years ago
Lucas Bajolet	6fc1d154bd	packer: relax constraints on sources The source parsing logic was heavily directed towards Github compatible source URIs, however if we want to support more cases, we need to make sure we are able to specify those URIs, and to load plugins installed from those sources. Right now, since the getters available are only github.com, we will not support remotely instlling plugins from sources other than github.com, with the same set of constraints as before. However, we do support now installing from a local plugin binary to any kind of source, and we support loading them, including if a template wants this plugin installed locally with version constraints.	2 years ago
Lucas Bajolet	d7f299886d	command: scrub metadata from version at install When installing plugins with the `packer plugins install --path' command, the metadata is now scrubbed from the file installed locally. This is as a protection against collisions in the versions, as metadata is meaningless for version comparison, so if two versions of the same plugin are installed, the precedence order between them is undefined. Therefore to avoid such collisions, we remove the metadata from the file name, that way if two successive versions of a plugin include metadata in the version, they won't coexist, and the last installed will be the only installed version locally.	2 years ago
Lucas Bajolet	3f721ff03e	cmd/plugin_install: use semver to render version When installing a plugin from a local binary, Packer builds the name of the plugin from the results of the `describe' command. Depending on how the plugin is built, the version reported may or may not contain a leading `v', which was not taken into account beforehand and the leading `v' was always injected in the path. This caused plugins that report a leading `v' in their version to be installed with two v's in their path, making them impossible to load. Therefore to fix this issue, we count on the version library to print out a version without the leading v, and we inject that in the resulting path.	2 years ago
Lucas Bajolet	930b6c3e2b	command: support local paths for plugins remove The packer plugins remove command allows users to delete plugins installed locally. Previous versions of the command only allowed for the plugins to be removed using the source for a plugin, and the versions to remove, optionally. This commit adds the capability for the plugins to be removed using their local path, in addition to the regular source+version method, that way we are able to pipe the results of `packer plugins installed' into the plugins remove command for quick plugin removal.	2 years ago
Wilken Rivera	bd0423d793	Add ignore-prerelease-flag to command help text	2 years ago
Lucas Bajolet	7f056211d9	commands: rename plugin to execute The plugin and plugins command had a name that was close, and while plugin is not supposed to be directly called by Packer users, this could happen by accident while trying to execute packer plugins subcommands, and when it does, the error messages are far from explicit, so unless they understand what Packer is doing here, they'll likely be lost. To reduce the risk of confusion, we rename the command to run packer embedded components as execute.	2 years ago
Lucas Bajolet	ea1e798c47	fmt: print parse errors on error The fmt command reformats HCL2 templates, provided it can parse the file and reformat its contents according to the standards set by the HCL library's formatters. However, if the file is malformed for some reason, the command will fail with a parse error, but while the parse error message is shown, the actual errors in the template(s) are not forwarded, making it hard for users to understand what went wrong with the contents of the file they're trying to format. In order to be more helpful with those errors, we now forward those parsing errors to the UI.	2 years ago
Lucas Bajolet	2e2038bc30	command: migrate tests using the comment plugin In order to test the Packer subcommands, some tests rely on a plugin: github.com/sylviamoss/comment. This plugin is outdated compared to our SDK, and some of the binaries releases don't match what is expected by Packer, i.e. v1.0.0 vs. v0.2.8. To fix that, we migrate to use the hashicups plugin, which is our demo plugin for Packer, and is actually maintained, and up-to-date, which will make those tests more reliable moving forward.	2 years ago
Lucas Bajolet	503768c683	command: trim trailing spaces from help message	2 years ago
Lucas Bajolet	9a6e74a66b	command: add dev support for plugins install Since we now support loading pre-releases with Packer subcommands, we relax the contraints we had placed on the `--path' option, so it will accept any `-dev' binary, in addition to final releases.	2 years ago
Lucas Bajolet	b5848b9913	command: add --release-only flag to validate/build Since we added the capability for the plugin discovery to ignore installed pre-releases of plugins, we give that capacity to the validate and build commands, through a new command-line flag: release-only.	2 years ago
Lucas Bajolet	ee01cf8ba9	command: move plugins remove tests outside of repo Since the plugins remove subcommand now only loads valid plugins, it cannot run on mock data anymore, and the logic for creating a valid plugin hierarchy is not present in this repository, but does in another, so we move those tests from here to that repository in order to continue testing them.	2 years ago
Lucas Bajolet	4b00a81bf3	packer: remove directory slices from structs Since we'll only look in the plugin directory, and not from multiple sources now, for installing/listing plugins, we can simplify the structures which used to accept multiple directories so they only accept one.	2 years ago
Lucas Bajolet	94aaff44a1	packer: only support one directory for plugins Since we're removing the alternative plugin installation directories in favour of only supporting installing them in the PACKER_PLUGIN_PATH directory, we only return one directory when getting the known plugin directories.	2 years ago
Lucas Bajolet	548893bbee	build: don't suggest lack of HCP support on fail When running a build with HCP Packer enabled, Packer attempts to push the build status to HCP. If the build fails, we update the status to BUILD_FAILED, and that's the end of it. If however the build succeeds, Packer attempts to get the HCP artifact from the builder, which will only succeed if the builder supports it. Otherwise, we'll get either nil, or an artifact type that is not compatible with what is expected for HCP support. When either of those happens, we warn that the builder may not support HCP Packer at all, so users are aware of the problem. However, when the error was introduced, it only looked at the fact that an error was produced, independently of the type of error. This caused legitimate errors while building to be reported as potential incompatibility between the builder and HCP, which was confusing to users. This commit changes this by introducing a new error type, only produced when the artifact either is nil, or failed to be deserialised into a HCP artifact, which lets us produce the incompatibility warning with more accuracy.	2 years ago
Wilken Rivera	12b8c885a3	Update error messaging for HCP incompatible plugin builds (#12800 ) * Update error messaging for HCP incompatible plugin builds * Update command/build.go Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com> --------- Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>	2 years ago
Devashish	3fa637c608	Migrate HCP Packer to API V2 and new nomenclature changes (#12794 ) * add hcp packer new nomenclature updates * Update docs with nomenclature changes * Update navigation bar links * Bump github.com/hashicorp/hcp-sdk-go from 0.81.0 to 0.82.0 * fix acceptance test template --------- Co-authored-by: sylviamoss <moss@hashicorp.com> Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	2 years ago
Lucas Bajolet	6c99f387a0	packer: remove single-component plugins Single-component plugins are a relic from the past that has been deprecated from version 1.7.0 and onwards. Since we're revisiting how plugins are installed/loaded, and the changes will be incompatible with those, we remove them in preparation of this work.	2 years ago
Wilken Rivera	2241b1fba7	Update spacing for flags within Help text Before Change ``` Options: - path <path>: install the plugin from a locally-sourced plugin binary. This installs the plugin where a normal invocation would, but will not try to download it from a remote location, and instead install the binary in the Packer plugins path. This option cannot be specified with a version constraint. - force: forces reinstallation of plugins, even if already installed. ``` After Change ``` Options: -path <path> Install the plugin from a locally-sourced plugin binary. This installs the plugin where a normal invocation would, but will not try to download it from a remote location, and instead install the binary in the Packer plugins path. This option cannot be specified with a version constraint. -force Forces reinstallation of plugins, even if already installed. ```	2 years ago
Lucas Bajolet	97e2e9e637	docs: add exerpt on packer plugins install --path	2 years ago
Lucas Bajolet	8e2a22e583	command: simplify local binary installation Read original binary into memory to fix case when installation destination and source were the same, resulting in an empty binary.	2 years ago
Lucas Bajolet	e293f2d890	command: plugins install reject non-releases When installing a plugin with packer plugins install --path, we only accept release versions of a plugin, as otherwise the loading can be inconsistent if for example a user specifies a required_plugins block in their template, in which case the plugins will be ignored. Until we have a simpler loading scheme then, we will reject non-release versions of plugins to avoid confusion.	2 years ago
Lucas Bajolet	ae5b91864c	command: reject version with --path for install To avoid plugins being installed with a specific version when a path is used for installing a plugin from a locally sourced plugin binary, we explicitly reject the combination of both a path and a version for plugins install.	2 years ago
Lucas Bajolet	a2d9c9dce4	command: add --force option to init/install The --force option for packer init and packer plugins install enforces installation of a plugin, even if it is already locally installed. This will become useful if for some reason a pre-existing plugin binary/version is already installed, and we want to overwrite it.	2 years ago
Lucas Bajolet	6f43a82e02	command: add packer plugins install path flag This new flag allows the `packer plugins install' command to install a plugin from a local binary rather than from Github. This command will only call `describe' on the plugin, and won't do any further checks for functionality. The SHA256SUM will be directly computed from the binary, so as with anything manual and potentially sourced by the community, extra care should be applied when invoking this.	2 years ago
Wilken Rivera	ebaf831562	cmd/hcl2upgrade: Add VirtualBox as known plugin	2 years ago
Lucas Bajolet	f221a799d8	command: error on invalid plugins remove If a user attempts to remove a plugin through the `packer plugins remove' subcommand, and the specified plugin is not installed, the command succeeds, but does nothing, and exits silently. This is not clear what is happening, and arguably, calling a command that does nothing, not even explain what went wrong, is not intuitive. Because of that, this commit changes how the command behaves in this case, stating what went wrong, and exiting with a non-zero status.	2 years ago
Lucas Bajolet	d47cbe7f48	command: remove SHA256SUM file on plugin removal When a user invokes `packer plugins remove', the plugin binary gets removed, but not the corresponding SHA256SUM file. This patch changes this so that when a binary is removed, so is its SHA256SUM file.	2 years ago
Wilken Rivera	da061169bc	cmd/hcl2_upgrade: Don't error when using a HashiCorp plugin that is not installed This change updates hcl2_upgrade to not flag known plugin components, those used for generating the required plugins block, when upgrading a legacy JSON template to HCL2. Any unknown plugins will be installed after running packer init on the generated template so we don't error. We may want to suggest running packer init to install any missing plugins. * Move knownPluginPrefixes into the hcl2_upgrade command	2 years ago
Wilken Rivera	e8d5436228	Remove functions for detecting plugin usage With the removal of vendored_plugins we are no longer interested in tacking bundled plugins usage. For plugins such as file, null, or anything bultin into Packer we don't track because there is no way to install them outside of Packer, for now.	2 years ago
Wilken Rivera	c65bb2fdca	Remove amazon plugin from acceptance test	2 years ago
Wilken Rivera	ac71611cf5	Remove all HashiCorp vendored plugins	2 years ago
Lucas Bajolet	020f18e37f	command: remove unused FlagSetFlags enum The enumeration for FlagSetFlags, which presumably was added when the Meta structure was introduced, aims to pre-populate the flagset for a subcommand with a series of arguments. However, despite it being documented, it is actually not used, and therefore can safely be removed from the codebase.	2 years ago
Lucas Bajolet	c0e594738b	init: warn if no requirements specified When users call `packer init' on a template that does not specify a `required_plugin' block, the command succeeds but does nothing, which is not helpful for users that may expect their plugins to install. To remedy that problem, we now output a message like what `packer plugins required' does on templates without such a block, so that users have an idea of what to change in order to get the command to work.	2 years ago
guoguangwu	7eb6a45cd4	chore: remove refs to deprecated io/ioutil Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>	2 years ago
guoguangwu	324e628b86	chore: unnecessary use of fmt.Sprintf Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>	2 years ago
Lucas Bajolet	eb9e1a4795	packer: remove implicit required plugins Since this feature is no longer something we plan to activate later, as it contradicts with our efforts to remove bundled plugins, and encouraging users to move to either manually installing plugins, or managing them through `packer init', we clean-up the code for this feature.	3 years ago
hashicorp-copywrite[bot]	19055df3ec	[COMPLIANCE] License changes (#12568 ) * Updating the license from MPL to Business Source License Going forward, this project will be licensed under the Business Source License v1.1. Please see our blog post for more details at https://hashi.co/bsl-blog, FAQ at https://hashi.co/license-faq, and details of the license at www.hashicorp.com/bsl. * Update copyright file headers to BUSL-1.1 --------- Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
Wilken Rivera	99c79ecbd6	Add build tags to skip amd64 tests on darwin/arm64 (#12549 )	3 years ago
Lucas Bajolet	3512a175a6	command: change wording for init's postitional arg `packer init' is meant to be invoked on a template file or a directory. This was described in the command-line help message as `[template.pkr.hcl\|folder]'. Because this is encapsulated between square brackets, this could be taken as an option instead of a positional, mandatory argument. This commit changes the wording to adopt a similar convention as `packer build', so the two are consistent in how they are invoked, and to avoid mistaking this argument as optional.	3 years ago
Lucas Bajolet	d0198c8a17	packer: track bundled plugins usage on telemetry	3 years ago
Lucas Bajolet	b522edca36	hcl2_upgrade: add required_plugins in out template When a legacy JSON template references built-in plugins, we add them to the resulting template as a `required_plugins' block in HCL2.	3 years ago

1 2 3 4 5 ...

799 Commits (962ccdfc80a52dc5d7d60f21b70fadbaf41ea098)