1146 Commits (9216f43463a7517f17a00a1f64895cd6ed98c771)

Author	SHA1	Message	Date
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	84063d2132	implement ID and Type values in the provisioner template info sharing	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	601007e3e2	pas data into provisioners well	6 years ago
Oded Priva	5e81c6f44e	added the option to skip IAM instance profile validation (#8457)	6 years ago
deisenzimmer	2b3935778e	amazon-ebssurrogate plugin: StepSnapshotVolumes: Added mutex to synchronise map access across threads. (#8432)	6 years ago
Megan Marsh	de9f391a1c	Merge pull request #8430 from hashicorp/fix_8359 ... Fix request retry mechanism to launch aws instance	6 years ago
Megan Marsh	fcda07ee6a	clarify docs by removing unclear string (#8439) ... the docs generator from code PR #7724 mis scrapped it	6 years ago
Moss	28c720bd3a	Organize imports	6 years ago
Moss	250643d54b	Remove 5 sec sleep after adding iam instance profile	6 years ago
Moss	4516978555	Fix request retry mechanism to run aws instance	6 years ago
Jon Allie	c31bbcf4cf	builder/amazon: AmiFilterOptions.GetOwners: avoid taking the address of a loop iterator var (#8417) ... GetOwners() always returned a slice of pointers to the last value. Because slice ranging reuses the same local variable.	6 years ago
Mike Dziedziela	7c3e032fb7	amazon docs: update block-device-configuration docs (#8395) ... So that it works for all builders as some use it with the following field names: launch_block_device_mappings, ami_block_device_mappings or ebs_volumes. the refactored docs weird being to specific.	6 years ago
Megan Marsh	59e6e1d4d5	Merge pull request #8393 from hashicorp/fix_8362 ... Add no_ephemeral template option to nuke ephemeral drives from launch mappings	7 years ago
Megan Marsh	818d9bb087	send to step run spot instance	7 years ago
Megan Marsh	67c3373107	enable no_ephemeral for spot devices, clean up ranging behavior, update docs	7 years ago
Anthony Dong	2e989088e5	amazon-ebssurrogate: allow enabling ena/sr-iov on spot instances	7 years ago
Megan Marsh	08e97ba4d8	generate code for no_ephemeral option	7 years ago
Megan Marsh	0e2bdc8be6	forcibly prevent ephemeral drives from being created in the amazon-ebs builder, when no_ephemeral is set	7 years ago
DanHam	b40e5d90b6	builder/amazon/common/step_pre_validate: Return DescribeVpcs errors	7 years ago
nywilken	afb880c134	test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock ... * Update condition to check for a empty VpcId	7 years ago
DanHam	074be9942d	Only validate the user has provided a subnet_id when vpc_id has been set	7 years ago
nywilken	f9f4726eff	builder/amazon/step_pre_validate: Add check for non-default VPCs ... Subnet information is only really needed when the specified `vpc_id` is not the default VPC for the region where the builder is being executed. This change uses the AWS API to determine if the VPC provided is a non-default VPC and only validates the existence of a `subnet_id` if a user has provided a non-default `vpc_id`. Tests after change ``` > make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc' ... === RUN TestStepPreValidate_checkVpc === RUN TestStepPreValidate_checkVpc/DefaultVpc === RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet === RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet === RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc === RUN TestStepPreValidate_checkVpc/NoVpcInformation --- PASS: TestStepPreValidate_checkVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s) PASS ... ```	7 years ago
Megan Marsh	dfa134cd98	ditch else statement for improved clarity	7 years ago
Megan Marsh	ce8bca349f	Update builder/amazon/ebs/step_create_ami.go ... Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>	7 years ago
Megan Marsh	a35ac0127e	fix bug in step_region_copy	7 years ago
nywilken	488e539f63	builder/amazon: Add helper function for checking against AWSError ... Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function	7 years ago
Megan Marsh	6e2456d028	make error messaging around ResourceNotReady better, update docs with other possible issues (#8349)	7 years ago
cove	2898d66812	retry runinstances aws api that wasn't retried and could fail	7 years ago
Megan Marsh	6c704f7046	Revert "fix template imports" ... This reverts commit 0e70e0e5a4.	7 years ago
Megan Marsh	517834d528	Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"" ... This reverts commit 44f91c9afc.	7 years ago
Megan Marsh	fcb65ee422	Merge pull request #8307 from hashicorp/fix_8116 ... delete amazon import post-processor intermediary snapshots	7 years ago
Megan Marsh	e9e4c102e5	delete amazon import post-processor intermediary snapshots	7 years ago
Adrien Delorme	1b7ef252d2	Merge pull request #8303 from alrs/amazon-builder-cleanup ... Cleanup builder/amazon/common	7 years ago
Lars Lehtonen	d072079899	builder/amazon/common: remove dead test type and function mockEC2Conn_Modify_EBS.ModifyInstanceAttribute()	7 years ago
Lars Lehtonen	953be1603b	builder/amazon/common: remove dead test type and function mockEC2ConnSpot.DescribeSpotPriceHistory()	7 years ago
Lars Lehtonen	7a09f9c678	builder/amazon/common: remove dead test function fakeModifyEBSBackedInstanceState()	7 years ago
Lars Lehtonen	0a13b620d6	builder/amazon/common: remove dead test function StepModifyEBSBackedInstance_EnableAMIENASupport()	7 years ago
Lars Lehtonen	c74df8b652	builder/amazon/common: remove dead test function getMockConnSpot()	7 years ago
Lars Lehtonen	e5e2bfa83f	builder/amazon/common: remove nil check on slice, len() on nil slices is zero	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Megan Marsh	6191b9c8c6	Merge pull request #8288 from hashicorp/fix_8271 ... add some extra layers of validation to make sure that people don't tr…	7 years ago
Megan Marsh	d084cd1895	Update builder/amazon/common/ami_config.go	7 years ago
Megan Marsh	e9f02e44cb	add test to catch this case	7 years ago
Megan Marsh	7cf47fc463	add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build	7 years ago
Megan Marsh	e2283445f2	need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly.	7 years ago
Megan Marsh	a783a09ea3	Merge pull request #8269 from paulmey/paulmey/generalize-chroot ... [amazon/chroot] Move common/generic chroot builder steps to common directory	7 years ago