172 Commits (91ce35f439d2bd5c65b7d2e31165e481deccb8a9)

Author	SHA1	Message	Date
Lucas Bajolet	55854f5537	Makefile: only build dev version of binary/docker ... The Docker images release-light and release-full are not to be built locally from a dev build, but from a release, and the commands to build those images are only referenced in CI, so we don't need to ship them as part of the makefile. In addition, those images are not straightforward to build from the Makefile, as they require quite a few things from the environment, as well as the binary installed in a specific location, which is never setup by the rest of the Makefile. Therefore, we opted to simplify the Makefile so that it only builds docker-dev for local use.	3 years ago
Lucas Bajolet	6e764658b7	Makefile: remove mode-check target (#12505) ... The Makefile would check for executable files inside the Packer repository, and produce errors if one was detected and not explicitely whitelisted through the `EXECUTABLE_FILES' Makefile variable. This check was introduced a while back to avoid having executable files in the repository, but this check can be problematic sometimes because of how it is written, namely when building the website, which causes a lot of JS executable files to appear in the hierarchy, and in turn this causes the shell expansion to fail because of the large number of arguments. Since this test is not necessary for Packer to build or test, and since it implies that we have to maintain the whitelist regex, we remove it from the Makefile.	3 years ago
Wilken Rivera	502d77cbae	Bump version of golanci-lint	3 years ago
claire labry	0d94e7d753	Introduce action-set-product-version for Packer (#12135) ... This change introduces the new actions-set-product-version, a tiny, but mighty, GitHub action that acts as a bridge between the product repo and our new CRT feature: automated version bumping. tl;dr automated version bumping has a new command (bob update version) in the bob CLI that automatically bumps the version to a new patch. This automation has been introduced to crt-workflows-common as a new workflow (with the new bob command) and handles version bumping at the end of the release pipeline (after being released to production); for example, 1.0.0→1.0.1 and 1.0.0-dev→1.0.0. Bumping the minor version (ie 1.0.x→1.1.0) is only supported manually via bob update version -bump minor, but not supported in CRT (this work is upcoming). This is made possible by adding the new event “bump-version” in the ci.hcl file in this PR. What this small action does: Allows for the static version string from the version/VERSION file to be read by the new CRT workflow and automagically be bumped to the next version (whether it be a minor, or patch, or major version bump). Outputs an error if there’s no VERSION file in the version dir Outputs an error if there’s no version string in the VERSION file Is able to parse product_version if it is 1.3.0-alpha1 as 1.3.0 (example: when product_version = 1.3.0-alpha1, base_version = 1.3.0) Is able to parse prerelease product versions such as alpha1 (example prerelease_product_version = alpha1) in the statement above.	3 years ago
Lucas Bajolet	7091726ca6	Makefile: bump golangci-lint to 1.46.0 (#11977) ... Since we moved to go 1.18, we should bump golangci-lint to a version that supports it. This change is motivated by the fact that some valid go code was being rejected by the `typecheck` with aliased modules beign unrecognised, namely the `hcl' module, imported from `hcl/v2'. This should not cause any issues as the typechecker should be aware that the package exported by `hcl/v2' is indeed called `hcl', but for some reason, with version 0.42.0, it does not work.	3 years ago
Lucas Bajolet	7d4b9548ac	Makefile: use go install for install-gen-deps ... The `go get' command for installing a module without modifying the go.mod/go.sum was deprecated for several versions, and is now removed in go 1.18. Since the project supports go 1.17 at minimum, the behaviour is supported too, and we can change this in the Makefile so the build works on Go 1.18 too.	4 years ago
Adrien Delorme	7661e41412	reference main branch instead of master branch (#11652) ... using search-n-replace	4 years ago
Michele Degges	b63a9c9803	Onboard to CRT (#11564) ... Onboard Packer to CRT Co-authored-by: Wilken Rivera <wilken@hashicorp.com> Co-authored-by: Claire Labry <claire@hashicorp.com>	4 years ago
Matthieu MOREL	079a680492	Update golangci to v1.42.0 (#11252) ... * Update Makefile * Update .golangci.yml Remove comment as version pinning is no longer needed. Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	5 years ago
Adrien Delorme	0f6a081724	Remove the vendor dir (#10916) ... * update ci scripts	5 years ago
Adrien Delorme	87ba7258b3	Use packer-sdc in packer + remove mapstructure-to-hcl2 & struct-markdown (#10913) ... * start using `go:generate packer-sdc struct-markdown` * Update Makefile remove @go install ./cmd/struct-markdown * run go generate for struct-markdown * use //go:generate packer-sdc mapstructure-to-hcl2 * run go generate for mapstructure-to-hcl2 * remove struct-markdown and mapstructure-to-hcl2 * vendor vendors	5 years ago
Wilken Rivera	076596cd3b	Makefile: Update install steps for gox	5 years ago
Megan Marsh	c90e3d8466	fix makefile	5 years ago
Megan Marsh	395920f917	didnt mean to delete this	5 years ago
Megan Marsh	f179f01314	Modify struct-markdown generator code to work from different projct roots ... Modify makefile to call generate code properly, setting project root. 'make generate' now avoids deleting website code generated in the packer plugin sdk. For now it will be maintainers' responsibility to regenerate this docs code from the packer plugin sdk every release, and commit it to these folders manually. remove boot command generator code	5 years ago
Megan Marsh	6ecdd3ca16	small tweaks	5 years ago
Megan Marsh	76177b50ce	Refactor provisioner acceptance tests to shell directly out to Packer rather than import the core. Modify test case formatting to more closely reflect the builder test cases.	5 years ago
Megan Marsh	afc798c30a	Modify vmware_vmx acceptance tests to use builderT framework ... Modify builderT framework to enable use of shell and file provisioners	5 years ago
Megan Marsh	f8f1ebf0c7	move version and useragent definitions into sdk	5 years ago
Megan Marsh	7d658149ea	update tests and website and generated partials to reflect new package format	5 years ago
Wilken Rivera	26161b7599	makefile: Disable test caching explicitly for go test ... * Bump the default time for acceptance tests to 120m	5 years ago
Megan Marsh	9f2cb0d560	make the default target generate dev builds. (#9811)	6 years ago
Megan Marsh	f295b6d2e5	change default target to just make the dev binaries (#9706)	6 years ago
Ivo van Geel	f27d9ab35e	make generate: don't error when find does not find any file (#9413) ... Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	6 years ago
Megan Marsh	b28059c0a5	add generator to create a list of all the deprecated options that the fixers fix ... fix location of deprecated_options code	6 years ago
Wilken Rivera	7ec55860e5	Revert golangci-lint to use new-from-rev pinned at 1.23.8 (#9072) ... Turns out linting each file individually causes issues with the linter not being able to find the import types.	6 years ago
Megan Marsh	f12269f124	fix builds on linux (#9031) ... * fix builds on linux * Build: Move to CGO_ENABLED=0 (#9057) After further investigation on cross-compiling Go bins on Linux. I found that statically linking against GCC (for libc) failed to build for ARM and introduced a possible licensing issue as our bins would essentially be bundling libc into the bin. Diving further into cross compiling on Linux I found that the defacto solution is to compile with CGO disabled - this was also found to be the case for other HashiCorp products. Disabling CGO has the limitation of not allowing the use of any pkg that calls out to C (net, os), but in looking into the Packer code base and the relevant Go code base it appears that the latest versions of Go have pure Go implementations of the said packages so I believe we are good to go. I should also point out that CGO is disabled by default when cross compiling via `go build`. However, the GOX tool will enable it if it is not explicitly disabled. Below are three test cases executed to validate the compile bins work as expected. Build results after change ``` ⇶ make bin WARN: 'make bin' is for debug / test builds only. Use 'make release' for release builds. ==> Checking for necessary tools... ==> Entering Packer source dir... ==> Ensuring output directories are present... ==> Removing old builds... ==> Building... Number of parallel builds: 7 --> windows/amd64: github.com/hashicorp/packer --> linux/arm64: github.com/hashicorp/packer --> linux/386: github.com/hashicorp/packer --> linux/arm: github.com/hashicorp/packer --> darwin/amd64: github.com/hashicorp/packer --> windows/386: github.com/hashicorp/packer --> linux/amd64: github.com/hashicorp/packer --> darwin/386: github.com/hashicorp/packer ==> Copying binaries for this platform... './pkg/linux_amd64/packer' -> 'bin/packer' './pkg/linux_amd64/packer' -> '/home/wilken/Development/go/bin/packer' ==> Results: total 111M -rwxr-xr-x 1 wilken wilken 111M Apr 13 12:29 packer ``` Packer executed on ARM based machine ``` ubuntu@ip-172-31-10-18:~$ ./packer version Packer v1.5.6-dev (314ac5b65+CHANGES ubuntu@ip-172-31-10-18:~$ uname -a Linux ip-172-31-10-18 4.15.0-1054-aws #56-Ubuntu SMP Thu Nov 7 16:18:50 UTC 2019 aarch64 aarch64 aarch64 GNU/Linux ubuntu@ip-172-31-10-18:~$ ./packer build build.json null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell170248556 null: UUID from Packer: 79cc8532-6114-925d-2a79-33ef6ce281cd Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ``` Custom Docker image with updated bin ``` ⇶ docker run packertest:latest version Packer v1.5.6-dev (314ac5b65+CHANGES) ⇶ docker run packertest:latest build build.json null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell065599452 null: UUID from Packer: 852f0604-2be4-9e16-99af-6d7df972ac2e Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ``` Windows AMI ``` [...] ==> amazon-ebs: Launching a source AWS instance... ==> amazon-ebs: Adding tags to source instance amazon-ebs: Adding tag: "Name": "Packer Builder" amazon-ebs: Instance ID: i-04387545cf3e2acd3 ==> amazon-ebs: Waiting for instance (i-04387545cf3e2acd3) to become ready... ==> amazon-ebs: Skipping waiting for password since WinRM password set... ==> amazon-ebs: Using winrm communicator to connect: 18.206.100.104 ==> amazon-ebs: Waiting for WinRM to become available... amazon-ebs: WinRM connected. ==> amazon-ebs: Connected to WinRM! ==> amazon-ebs: Uploading packertest => c:/Windows/Temp ==> amazon-ebs: Provisioning with Powershell... ==> amazon-ebs: Provisioning with powershell script: /tmp/powershell-provisioner173180945 amazon-ebs: Packer v1.5.6-dev (314ac5b65+CHANGES) amazon-ebs: null: output will be in this color. amazon-ebs: ``` Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Wilken Rivera	c9c0ee65d3	circle-ci: update ci-lint steps (#9043) ... * new-from-rev option is showing inconsistent results on circle and locally. This change moves to a custom command `script/lint.sh` that gets a list of added go files and pipes them to golangci-lint for testing. * Add a git fetch as a step before retrieving merge-base changes to fix the issue described at https://discuss.circleci.com/t/checkout-script-adds-commits-to-master-from-circle-branch/14194/2 * Moved source code out of GOPATH to ensure go mod support and reduce the risk of having golangci-lint trying to scan all of the files within GOPATH. This was an issue in the past, in changing it I found less OOM issues on circle.	6 years ago
Jeff Escalante	2999934326	fix generation script, bugfixes in source comments, update website paths in primary codebase	6 years ago
Jeff Escalante	9165be87da	packer.io prefix removal, html extension remove for in-code errors	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Wilken Rivera	3a9d356c9d	golangci-lint: Update --new-from-rev option to check only newly added commits (#8923) ... * golangci-lint: Update --new-from-rev option to check only code added in the latest commit Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	6 years ago
Adrien Delorme	b15c92bc1e	scripts/generate-plugins.go: programatically gofmt the file before outputing it to avoid having to do that later on	6 years ago
Sylvia Moss	fa4b9ae958	Add Codecov configuration (#8862)	6 years ago
Wilken Rivera	5a87760702	makefile: Update code path for golangci-lint (#8751) ... While `golangci-lint run` is the same as `golangci-lint run ./...` running it without a path seems to throw warning messages related to its cache, which is confusing. This change sets an explicit path for golangci-lint when calling `make lint` or `make ci-lint`.	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Adrien Delorme	75a639775e	Update Makefile ... there's no find dir	6 years ago
Adrien Delorme	1158eeb46d	Update Makefile ... to @go install ./cmd/mapstructure-to-hcl2 so that we can `make generate` and tests that generated code is what it should be	6 years ago
Adrien Delorme	597a3e323b	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	1091066c57	go get use enumer@master	7 years ago
Adrien Delorme	c77a0bd196	remove goimports dependency as the generated code is now correct and won't need fixing ... this should save us from running this command every now an then	7 years ago
Adrien Delorme	22a89ccf8a	fix comment typo	7 years ago
Adrien Delorme	a2e934e7fb	Makefile: document why	7 years ago
Adrien Delorme	e4563655fd	Makefile: go to temporary directory to avoid go get of binaries from changing go deps	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	b82ab2cc6a	change installation of pigeon if off gopath	7 years ago
Adrien Delorme	4c1abf828c	Merge branch 'master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	0a2f4d884a	make bin currently won't work outside of GOPATH	7 years ago
Adrien Delorme	6fcf581e3e	remove all generated doc files before generating it again ... in order to remove files that should be	7 years ago
Adrien Delorme	4ab5471490	Makefile: install-gen-deps now installs ./cmd/struct-markdown	7 years ago