976 Commits (8ce3aae2f7f16c85a5465f922dcafe54090ed3e2)

Author	SHA1	Message	Date
Sylvia Moss	3dc7a53125	Correct check if PackerHttpAddr is implemented or not (#9498)	6 years ago
Simon Jones	45f81893b9	RunWithUI already calls Wait on the command ... - Remove redundant Wait	6 years ago
Simon Jones	aaa913a484	RunWithUi sets appropriate default for stderr buffer ... - The WinRM communicator requires that stderr is not nil - RunWithUi will set a default stderr buffer if none is specified in the command	6 years ago
Megan Marsh	b5b8f2e308	add template option for templating the inventory file lines (#9438)	6 years ago
Megan Marsh	3d7c9cb9c2	make ansible provisioner docs generated from code (#9439)	6 years ago
Wilken Rivera	d72173ac1a	Revert "Merge pull request #9040 from hashicorp/powershell-exit-code-fix-4916" ... This reverts commit 334f399ee3, reversing changes made to 45a5d28bad. When testing against Windows SSH the Powershell script fails to parse the newly added if statement.	6 years ago
Megan Marsh	9699af4dee	Merge pull request #9350 from gamethis/fix_ansiblepassword ... Fix for ansible_password	6 years ago
Lane, Larry	5976929595	Fix for #9283	6 years ago
Søren Hansen	19e4afa728	provisioner/windows-restart: Get full hostname, instead of just the NetBIOS name. (#9335) ... `env:COMPUTERNAME` give you the first 15 characters of the machine name (the NetBIOS name). But normally its pretty nice to get the full DNS name. We can solve this in this way.	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	077d34f12c	Merge pull request #9279 from gamethis/fix_arg_order ... [WIP] Anisble-Remote fix arg order	6 years ago
Adrien Delorme	a2e9439ee6	provisioner/salt-masterless: ignore the CmdArgs field in hcl2 (#9290) ... fix #9233	6 years ago
Wilken Rivera	1e90165a56	Add source URL to test fixture script (#9296)	6 years ago
Megan Marsh	fecb040bf4	fix bug where build vars couldn't be properly interpolated into this execute command (#9275)	6 years ago
Lane, Larry	f4254e9cbf	updated test	6 years ago
Lane, Larry	c689eb9694	added test	6 years ago
Lane, Larry	de12432e6b	add test	6 years ago
Lane, Larry	e6670fc4a0	fix arg order	6 years ago
Wilken Rivera	2e326ef334	Switch back to call operator as opposed to dot sourcing ... * Ensure child scope doesn't conflict with parent scope * Add elevated user options to tests case.	6 years ago
Wilken Rivera	38f799df3e	Add conditional to check if LastExitCode is defined ... * Add broken requires statement test case * Add test case to reproduce invalid LastExitCode	6 years ago
Wilken Rivera	35df3914d2	provisioner/powershell: Update default execute command to handle script errors ... This change sets the ErrorActionPreference and wraps the script execution in a Try/Catch statement so that the provisioner can capture any errors encountered when running the script. In addition to the try/catch the `&` operator is replaced by the `.` sourcing operator to ensure the script is executed in the same scope as the parent command (so that errors bubble up properly). Tests after change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test ./provisioner/powershell/... -timeout=1h ok github.com/hashicorp/packer/provisioner/powershell 915.865s ```	6 years ago
Wilken Rivera	13e0c1a097	tests/provisioner/powershell: Add acceptance test to reproduce issue 4916	6 years ago
Sylvia Moss	be9dbaacd7	Interpolate generatedData in the Inspec provisioner (#9262) ... * Interpolate generatedData in the Inspec provisioner * Add inspec license section to inspec docs * add user arg if user config it not empty * increase resource size for check-lint pipeline * update changelog * Update provisioner/inspec/provisioner.go * Update provisioner/inspec/provisioner.go Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Wilken Rivera	c330d2f04c	provisioner/powershell: Update cleanup logic ... This change reduces the retry timeout from 5m to 1m, and sets the RetryDelay to 10s for a total of 6 retries. In additional to the retry time reduction the cleanup script will now check to see if the provisioner script created by Packer exists before trying to delete to prevent any file not found issues. Closes #9181 Closes #9189	6 years ago
Lars Lehtonen	7440c2e6ba	provisioner/windows-shell: remove unused testObjects() (#9116)	6 years ago
DamianBis	b679f61536	Update to make NoExitOnFailure work correctly. (#9119) ... if NoExitOnFailure is true then ignore the error returned from salt.	6 years ago
Matt Kotsenas	fe55494207	Add `debug_mode` to PowerShell provisioner (#8996)	6 years ago
Sylvia Moss	553b1fb9f8	Add RetriedProvisioner to allow retry provisioners (#9061)	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Megan Marsh	73c349d09c	Merge pull request #8908 from hashicorp/fix_4795 ... provisioner/powershell: Add cleanup step to remove any temporarily created scripts	6 years ago
Lars Lehtonen	49f28c9439	provisioner/powershell: fix dropped error ... provisioner/powershell: improve error message	6 years ago
Wilken Rivera	4a46d6ff7b	docs/provisioner/powershell: Add documentation for `skip_clean` option	6 years ago
Wilken Rivera	fe721d8e11	test/provisioner/powershell: Add acceptance test for powershell provisioner cleanup ... Passing Tests ``` --- PASS: TestAccPowershellProvisioner_basic (282.02s) --- PASS: TestAccPowershellProvisioner_basic/testing_amazon-ebs_builder_against_powershell_provisioner (282.01s) PASS ok github.com/hashicorp/packer/provisioner/powershell 282.046s ``` Failing tests on master ``` 2020/04/08 09:59:34 Uploading file to 'c:/Windows/Temp/script.bat' 2020/04/08 09:59:36 [INFO] starting remote command: set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat" 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: C:\Users\Administrator>dir C:\Windows\Temp\packer-*.ps1 2020/04/08 09:59:36 ui: amazon-ebs: Volume in drive C has no label. 2020/04/08 09:59:36 [INFO] command 'set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat"' exited with code: 0 2020/04/08 09:59:36 ui: amazon-ebs: Volume Serial Number is 46CA-4083 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: Directory of C:\Windows\Temp 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 102 packer-acc-test-script-test.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 76 packer-acc-test-vars.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 2 File(s) 178 bytes 2020/04/08 09:59:36 ui: amazon-ebs: 0 Dir(s) 9,735,806,976 bytes free 2020/04/08 09:59:36 ui: ==> amazon-ebs: Provisioning step had errors: Running the cleanup provisioner, if present... 2020/04/08 09:59:36 ui: ==> amazon-ebs: Terminating the source AWS instance... 2020/04/08 10:00:09 ui: ==> amazon-ebs: Cleaning up any extra volumes... 2020/04/08 10:00:09 ui: ==> amazon-ebs: No volumes to clean up, skipping 2020/04/08 10:00:09 ui: ==> amazon-ebs: Deleting temporary security group... 2020/04/08 10:00:10 ui: ==> amazon-ebs: Deleting temporary keypair... 2020/04/08 10:00:11 ui error: Build 'amazon-ebs' errored: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] 2020/04/08 10:00:11 machine readable: error-count []string{"1"} 2020/04/08 10:00:11 ui error: ==> Some builds didn't complete successfully and had errors: 2020/04/08 10:00:11 machine readable: amazon-ebs,error []string{"Script exited with non-zero exit status: 0.Allowed exit codes are: [1]"} 2020/04/08 10:00:11 ui error: --> amazon-ebs: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] ``` test: Fix windows-shell command	6 years ago
Wilken Rivera	91c8afda8e	provisioner/elevated: Add cleanup logic to remove elevated user scheduled task artifacts	6 years ago
Wilken Rivera	11db6014fa	provisioner/powershell: Update remote clean up logic ... * Add retry logic so that the provisioner will retry if it fails to upload/execute because of some restart provisioner step * Add a testConfigWithSkipClean for testing that the provisioner executes the correct commands * Add a test case for toggling the "skip_clean" config option	6 years ago
Wilken Rivera	f6a61e2511	provisioner/powershell: Add post clean up step to remove temp script files	6 years ago
Wilken Rivera	1eee0bca5f	Merge pull request #9011 from hashicorp/powershell-acceptance-test ... provisioner/powershell: Add basic Powershell provisioner acceptance tests	6 years ago
Megan Marsh	bdcc95f989	fix execution policy parser to not interfere with legit integers, and add tests (#8997)	6 years ago
Lars Lehtonen	78bb742aa5	provisioner/shell: fix dropped test error	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Moss	185deeeb38	Fix provisioner acc-test builder and provisioner store	6 years ago
Wilken Rivera	b183c5498f	provisioner/powershell: Add basic Powershell provisioner acceptance tests ... * Modifies the amazon-ebs builder with a windows build configuration ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/powershell/... -run=TestPowershellProvisioner_Inline --- PASS: TestPowershellProvisioner_Inline (256.50s) --- PASS: TestPowershellProvisioner_Inline/testing_amazon-ebs_builder_against_powershell_provisioner (256.50s) PASS ok github.com/hashicorp/packer/provisioner/powershell 256.525s ```	6 years ago
Megan Marsh	b804e5a8f5	Merge pull request #8987 from VaijanathB/azure-devtestlabs-take2 ... Building Azure devtestlabs Images using Packer - update	6 years ago
Megan Marsh	8840b4a830	Merge pull request #8625 from hashicorp/remove_ansible_proxy ... Remove ansible proxy	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Vaijanath Angadihiremath	b7d85b8a23	Added acceptance tests for DTL. Fixed couple of issues with DTL root resource group not set to new directory	6 years ago
Vaijanath Angadihiremath	69015b1870	Fixing the linting errors	6 years ago
Vaijanath Angadihiremath	e726902116	Fixing the latest changes from the merge	6 years ago
Vaijanath Angadihiremath	645cdf1a59	Updating the modules to include update to autorest 12.4	6 years ago
Megan Marsh	b66e49223d	extract the building of command args into a testable helper function	6 years ago
Megan Marsh	91906b688c	regenerate code	6 years ago
Megan Marsh	73c87044fd	fix tests	6 years ago
Megan Marsh	64b706983e	docs and cleanup	6 years ago
Megan Marsh	d45ffe73d0	fix default ssh-extra-args flag	6 years ago
Megan Marsh	d57809bcda	pass ansible_password on command line instead of inside inventory file	6 years ago
Megan Marsh	eda9ce70e7	update tests	6 years ago
Megan Marsh	9a40403433	clean up tests	6 years ago
Megan Marsh	e155d2a1c8	add mock so we can test full provision flow	6 years ago
Megan Marsh	6c756a7b31	fix tests	6 years ago
Megan Marsh	19d49f8b78	templatize inventory files; implement inventory for winrm	6 years ago
Megan Marsh	ca5814ab74	move proxy behind feature flag	6 years ago
Adrien Delorme	b94937c05c	Update provisioner_test.go (#8900)	6 years ago
Adrien Delorme	569c802630	Update provisioner_test.go ... fix TestProvisioner_RemoteFileDefaultsToScriptnnnn	6 years ago
Adrien Delorme	f1c0a9cdbd	see what's wrong with that weird test	6 years ago
Moss	112d4daa3d	Fix linter	6 years ago
Moss	5a8c628880	Add acc test validation to avoid running with unit tests	6 years ago
Moss	3f49b7c66e	Fix linter	6 years ago
Moss	0cc1092222	Fix format	6 years ago
Moss	2ca6804827	Move shell prov acc test to the same folder	6 years ago
Moss	7fbbbffd5c	Interpolate file provisioner and add integration tests	6 years ago
Moss	6c06a2a048	Fix format	6 years ago
Moss	a3740bb9be	Interpolate shell inline config	6 years ago
Wilken Rivera	e1a46ec293	Fix gosimple S1025 linting errors (#8838) ... Remove unneeded use of fmt.Sprintf for variables that are already strings.	6 years ago
Sylvia Moss	ce674ff272	Add exclude mapstructure tag to exclude from hcl2spec struct (#8785)	6 years ago
Paschalis Tsilias	beca6de71b	Add packer.ExpandUser() function to support tilde in usage of config.ValidationKeyPath (#8657)	6 years ago
nywilken	b80882f3b8	provisioner/shell: Fix envVarFile clean up issue ... This change ensures the deletion of the external envVarFile (use_env_var_file = true) occurs after all script files have been executed and deleted. Build results before change ``` > packer build build.pkr.hcl [~0] docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp476880774:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh ==> docker: /bin/sh: 1: .: Can't open /tmp/varfile_2555.sh ==> docker: Provisioning step had errors: Running the cleanup provisioner, if present... ==> docker: Killing the container: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b Build 'docker' errored: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Some builds didn't complete successfully and had errors: --> docker: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Builds finished but no artifacts were created. ``` Build results after change ``` > packer build build.pkr.hcl docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp819845000:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh docker: FooBar Script docker: wilken is NotForSale! ==> docker: Committing the container docker: Image ID: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ==> docker: Killing the container: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 Build 'docker' finished. ==> Builds finished. The artifacts of successful builds are: --> docker: Imported Docker image: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ```	6 years ago
Megan Marsh	4b9568e409	fix winrmpass sanitization to account for empty string value.	6 years ago
Megan Marsh	9eda2031d2	Remove redundant placeholder (#8503)	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	3389d843f0	update all provisioners that used the winrmpassword tooling to use the new generateddata option	6 years ago
Megan Marsh	b2012c7ff3	fix tests	6 years ago
Megan Marsh	39fd462b56	change all provision func signatures to use map[string]interface{}	6 years ago
Megan Marsh	0ca7c9f397	fix tests	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	f4c3501af5	pass struct of generated data into provision() call	6 years ago
Megan Marsh	822aa02500	Merge pull request #8468 from pfuender/master ... Add version selection for chef-client provisioner	6 years ago
pfuender	ffb9272fb2	adding version-override for chef-client provisioner	6 years ago
Wilken Rivera	b79986c3c5	Merge pull request #8411 from kevingunn-wk/fix_8410 ... rename galaxy_command to galaxycommand	6 years ago
Kevin Gunn	70aa0516de	reset ansible-local documentation to include galaxy_command ... fix spacing in fixer.go	6 years ago
Kevin Gunn	28d1037864	change galaxycommand to galaxy_command and add fixer	6 years ago
Megan Marsh	7d4353864f	use shell struct in shell-local provisioner and post-processor.	7 years ago
Megan Marsh	ad34a4551b	provisioner/windows-restart: revert sleep hack now that we've fixed the underlying bug in #8369 (#8377)	7 years ago
nywilken	3522e13b1e	provisioner/shell: Add `env_var_format` support to shell provisioner ... * Move setting of default EnvVarFormat to the Prepare function * Add generated hcl2 structure for the updated Shell provisioner config * Move `EnvVarFormat` field to shared common shell type * Add description for the `env_var_format` parameter * Update `env_var_format` when used with `use_env_var_file`	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Adrien Delorme	193d3e6bbd	provisioner.windows-shell: demove duplicate ExecuteCommand field	7 years ago
Lars Lehtonen	9c19cfdc6f	provisioner/shell: fix dropped error	7 years ago
Lars Lehtonen	bd01d0d3c3	provisioner/inspec: Fix dropped error	7 years ago
Lars Lehtonen	b207752883	provisioner/ansible: Fix dropped error	7 years ago
Ruben Tsirunyan	1b35c586ce	Changes to roles_path option	7 years ago
Ruben Tsirunyan	d247329599	Adding support for installing roles with ansible-galaxy for ansible provisioner	7 years ago
Megan Marsh	0f704fb5b2	These cancel functions have been obsolete since merge of c7ce4d598e	7 years ago
Stefan Scherer	35dae5791c	Use --input-file instead of --attrs. ... Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>	7 years ago
David Hao	c6a471d149	[Salt] Replace scp with scp + mv to handle non-root case	7 years ago
David Z Hao	1d4750a2d9	DisableSudo, not PreventSudo	7 years ago
David Z Hao	ea238b66c0	Make salt-masterless provisioner respect disable_sudo directive for all commands	7 years ago
Megan Marsh	6982ec796f	remove redundant error check	7 years ago
Megan Marsh	6dcff18d36	prevent nil pointer dereference by defining IsUserAuthority. This occurred as a regression when we updated the crypto library in v1.4.0	7 years ago
Megan Marsh	de7106c36b	Merge pull request #7696 from hashicorp/go_generate_from_makefile ... run `go generate ./...` from makefile & CI test that it generates no diff	7 years ago
Megan Marsh	4bf75ac0f3	fix null file descriptor error	7 years ago
Adrien Delorme	abd6eda6c9	generate execution policy from makefile ... * make generate now generates on `./...` instead of `.`	7 years ago
Megan Marsh	1204213516	Merge pull request #7678 from hashicorp/docker_windows_defaults ... builder/docker: better windows defaults	7 years ago
Megan Marsh	6f560bef0a	Merge pull request #7653 from aaronwalker/chef_license_acceptance ... adds support for accepting the chef license	7 years ago
Adrien Delorme	478f80af83	remove unused func	7 years ago
Adrien Delorme	7005958155	execution policy: make everything more idiomatic ... * make possible execution policy values lowercase * prefix execution policies possibilities	7 years ago
Adrien Delorme	e62aba3788	allow to set ExecutionPolicy to none for powershell provisioner ... this has the effect to not wrap the command, which will allow to know the exit status of a command in docker	7 years ago
Adrien Delorme	e96409954a	add execution policy type and use it to default the powershell cmd	7 years ago
Aaron Walker	85b8a654b0	only sets default value for chef license when installing chef and the install command is not set	7 years ago
Paul Meyer	814665fddd	Check error returned from retry.Config.Run()	7 years ago
Paul Meyer	ec14ab4875	Add unit test to find issue #7655	7 years ago
Aaron Walker	dfc5e5cf94	adds support for accepting the chef license	7 years ago
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	2b06d74019	add a sleep provisioner ... mainly for testing purposes	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	a81abd297b	Merge remote-tracking branch 'origin/master' into context_provisioner	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	82c4b76639	[Builder|Build|PostProcessor|Provisioner|Hook]Server: context cancel using a RPC cancel method	7 years ago
Adrien Delorme	c7ce4d598e	change Provisioner to be passed a context for cancellation	7 years ago
Megan Marsh	0e6c779a88	allow user to access env_var_format in windows_shell call	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	a77ce59e36	Update provisioner_test.go ... remove unecessary test	7 years ago
Adrien Delorme	72e5ae9ddc	use ValidExitCode in provisioners windows-shell, powershell and shell	7 years ago
Adrien Delorme	30a65c858a	regroup shell provisioner params into a common struct	7 years ago
Adrien Delorme	8fea9439f8	windows-shell provisioner: allow to pass ValidExitCodes	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
xinau	b449af84ee	moved concurrency-safe ui code to packer/ui.go	7 years ago
xinau	ae59b81f44	added check for docker backend	7 years ago
xinau	36c1e8d838	moved adapter to common package	7 years ago
xinau	8526244285	changed local_port to uint representation	7 years ago
xinau	c207451f7e	Merge branch 'master' of https://github.com/hashicorp/packer into packer-provisioner-inspec	7 years ago
pauloj95	b1fffee614	Update guest_commands_test.go	7 years ago
pauloj95	b4d1c77cc0	Update guest_commands_test.go	7 years ago
pauloj95	d7b93aa343	add force to guestcommands test too	7 years ago
pauloj95	8d8b880ac4	add force to powershell move command ... this will allow powershell move in provisioners and replace file if existing found... issue example: https://github.com/hashicorp/packer/issues/7280	7 years ago
Rickard von Essen	52b55fb899	ansible: change local_port to uint instead of string	7 years ago