packer

Commit Graph

Author	SHA1	Message	Date
Lucas Bajolet	68ddb2f89d	hcl2_upgrade: add share_image_gallery workaround (#12087 ) In azure templates, the shared_image_gallery was mistakenly considered an attribute while this is supposed to be a block. This is due to a heuristic we use for deciding whether a JSON object is to be translated to an attribute or a block that fell short as the shared_image_gallery does not contain complex types. This cannot be fixed trivially for the general case, so we add this entity to the list of workarounds until we can implement something more robust.	3 years ago
Lucas Bajolet	3c249c0d42	hcl2_upgrade: replace passthroughs by pre-visit In previous versions of hcl2_upgrade, we referenced a list of passthrough statements from the original JSON template to be replaced by their equivalent Go-template in HCL2. This works but requires us to explicitely accept every possible templated variable in order to not ever encounter <no value> in our generated HCL2 templates. This is suboptimal, hence this commit changes approach by pre-visting the AST from the original Go Template, escaping every sequence that is not covered by the list of functions we can migrate. Pipes are also excluded from this function.	4 years ago
Zach Shilton	879fd9035c	fix: update redirected and broken links (#12060 ) * website: fix broken links on /docs/templates * fix: redirected install-plugins link * fix: debugging link * fix: secrets manager link in docs * fix: secrets manager link in source * fix: amazon ami plugin link in docs * fix: amazon ami plugin link in source * fix: extending plugins link * fix: plugins/builders/amazon links * fix: various builders links * fix: various amazon builder links * fix: redirected terminology link * fix: custom-provisioners link * fix: docker-push redirected plugin link * fix: googlecompute plugin links * fix: hyperv iso plugin links * website: update link to hcl upgrade guide Co-authored-by: Wilken Rivera <wilken@hashicorp.com> Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
Lucas Bajolet	c0e7e7bd3c	hcl2: report error on build without sources When a template describes a build block without a source reference, the build should be considered invalid as we won't have a CoreBuild produced as a result of the need to have both. In current versions of Packer, this will produce an error message hinting that nothing will happen because of the lack of either build or source block. This commit takes the defined block, and points out to it as missing a source block as being the reason why nothing is happening, making it clearer what is required for an HCL2 build to be processed.	4 years ago
Lucas Bajolet	61c56e161c	hcl2: add example for undefined variable set warn When a variable is set in a pkrvars file, but isn't defined, an error message is output, but does not deliver an example of what is expected by Packer in order to complete a build. To remedy that, we improve the error message by giving an example of variable block to include in the build template.	4 years ago
Lucas Bajolet	e94b8766cb	build: exit immediately if no builds and diags When a template with some builds to run ends its GetBuilds with an error, and no builds produced, we can exit immediately without printing more errors.	4 years ago
Lucas Bajolet	a298617ecb	command/build: warn and exit when nothing to build When a `packer build' is run on a config that does not define anything to be built, the process would run normally, and only state that no artifacts were produced after builds were run successfully. This is misleading as we reach the end of the command without having a proper warning that nothing was even attempted to be built. This commit adds a warning when that happens, and leaves immediately after.	4 years ago
Lucas Bajolet	7cd095062a	parser: extract HCP logic out of the HCL parser Before this commit, some HCP-related logic was embedded in the parser, making all of it common to all commands. This complexifies the logic as some parts rely on the template being in a HCP-valid environment, and the datasources need to be evaluated in order for some operations to be executed. To simplify this and avoid those pitfalls, we move this logic to its own set of functions that will be performed after the parsing is done, on any valid HCL2 or JSON template.	4 years ago
Adrien Delorme	0362a3ec10	all shells: Pass env vars through a key value store (#11569 ) * allowing to set shell env vars from a key/value map. * tests This new map will work alongside the `environment_vars` but it allows using a datasource value seamlessly. At validation, and because `environment_vars` was an array of strings containing `KEY=value`, using datsources would not work, because these values are not known yet and would evaluate to `<unknown>`. With this, the value and the key can be unknown and will validate correctly for datasources.	4 years ago
Adrien Delorme	e03ad29ca0	Sanitize var code (#11566 ) * evaluateLocalVariables: modify code for readability and some (not benchmarked) perfs * Make default input variable type the DynamicPseudoType This should be the default, and avoids a panic. This type can represent situations where a type is not yet known. Its meaning is undefined in cty. * do not take Empty types from default value * Update types.variables.go Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
teddylear	1d01ad3651	feat: print all locals errors when there is a circular error (#11527 )	4 years ago
Wilken Rivera	4a0fbd911a	Add support for variable interpolation to hcp_packer_registry and build blocks. (#11421 ) * Add variable interpolation support to hcp_packer_registry block * Add tests for variable interpolation in hcp_packer_registry block * Add variable interpolation support to the build block (#11425) * Add simple test to build command	4 years ago
Adrien Delorme	710d109c55	HCL2: fix a crash when an HCL2 component is nil after a misconfiguration (#11382 ) * add test for crash * fix * show more precise error message when parse of a provisioner fails * Revert "fix" This reverts commit `fc88e89fbb`. * add better severity	4 years ago
Adrien Delorme	254e020b08	Allow to use build variables in a post processor (#11323 ) * hcl: add test to verify that build.name can be used in a pp * allow to use build vars in post processors	5 years ago
Adrien Delorme	eb8e302941	hcl2_upgrade: special case: vsphere fix (#11216 ) * fix typo * hcl2_upgrade: special case linux_options and network_interface to block instead of maps * Update hcl2_upgrade_test.go * Update hcl2_upgrade_test.go remove unused code * hcl2_upgrade: support strftime too (#11220) * hcl2_upgrade strftime function * create legacy_strftime.mdx	5 years ago
Adrien Delorme	9d0193ac14	add possibility to use variables everywhere in post-processor blocks (#11094 ) feature + tests. Including in: * name * only * except * keep_input_artifact Example file: ```hcl source "null" "example1" { communicator = "none" } source "null" "example2" { communicator = "none" } locals { except = "null.example1" } variable "only" { default = "null.example1" } build { sources = ["source.null.example1", "source.null.example2"] post-processor "shell-local" { except = [local.except] inline = ["echo first post-processor"] } post-processor "shell-local" { only = [var.only] inline = ["echo second post-processor"] } } ``` Ouput: ```shell-session $ packer build foo.pkr.hcl null.example1: output will be in this color. null.example2: output will be in this color. ==> null.example1: Running post-processor: (type shell-local) ==> null.example2: Running post-processor: (type shell-local) ==> null.example2 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell201696062 ==> null.example1 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell494781572 null.example1 (shell-local): second post-processor Build 'null.example1' finished after 61 milliseconds 432 microseconds. null.example2 (shell-local): first post-processor Build 'null.example2' finished after 111 milliseconds 678 microseconds. ==> Wait completed after 111 milliseconds 714 microseconds ``` close #4895	5 years ago
Sylvia Moss	927093e5c0	improve regex to fix escaping on split function (#11083 )	5 years ago
Adrien Delorme	98990fc34e	hcl2_upgrade: allow to hcl2_upgrade with unknown builders, just log errors (#11049 )	5 years ago
Adrien Delorme	e60a7e60b9	add test to repro #10975	5 years ago
Adrien Delorme	77a29fc2f8	Allow to have `dynamic` blocks in a `build` block + tests (#10825 ) This : * allows to have a `build.dynamic` block * add tests * makes sure to show a correct message when a source was not found * display only name of source (instead of a weird map printout) * use a "Did you mean %q" feature where possible Because dynamic blocks need all variables to be evaluated and available, I moved parsing of everything that is not a variable to "after" variables are extrapolated. Meaning that dynamic block get expanded in the `init` phase and then only we start interpreting HCL2 content. After #10819 fix #10657	5 years ago
Adrien Delorme	a9bec7945e	remove .mdx extensions in links (#10823 ) Some of them were added in #10800 some where already there	5 years ago
Sylvia Moss	505cbd2591	Vendor amazon plugin (#10800 ) * remove amazon from core * vendor amazon plugin * remove website content * Add amazon to docs-remote-plugins * update amazon reference links in the documentation * update amazon docs version to latest Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	5 years ago
Megan Marsh	0993c976fa	hcl2_upgrade escaped quotes fix (#10794 ) * clean up extra quoting that can cause text template failures. when everyone else abandons you, regex will always be there. * LINTING	5 years ago
Megan Marsh	4242cf3151	fix tests	5 years ago
Sylvia Moss	610dde7f02	check for nil config map (#10730 )	5 years ago
sylviamoss	5ccbd27b72	Improve upgrade error and transform all variables with template eng to locals	5 years ago
sylviamoss	a1a5cf0113	upgrade variables with other variables	5 years ago
sylviamoss	2016d6baec	Fix panic on upgrading variables json file	5 years ago
Sylvia Moss	37d05c85ff	upgrade pause_before (#10654 )	5 years ago
Sylvia Moss	e0557f84e9	Add access config to generated amazon ami data source (#10634 )	5 years ago
sylviamoss	76e3d57cae	add with-annotation flag to hcl2_upgrade	5 years ago
Sylvia Moss	774c5903f6	Add error-cleanup-provisioner to HCL2 (#10604 )	5 years ago
Sylvia Moss	d28e6fe009	write timestamp local only when necessary (#10602 )	5 years ago
Sylvia Moss	f5006d0842	fix empty locals and source name with blank space (#10593 )	5 years ago
Sylvia Moss	d53488db68	Add aws_secretsmanager transformation to hcl2_upgrade (#10553 )	5 years ago
Sylvia Moss	ef4afafde9	Fix force flag for hcl2 provisioners and post-processors (#10571 )	5 years ago
Sylvia Moss	291121dd55	(2) Implement datasources (#10440 )	5 years ago
Sylvia Moss	e44cb9d7e5	Add Amazon AMI data source to hcl_upgrade command (#10491 )	5 years ago
Megan Marsh	4cb6e07900	Hcl beta tag (#10493 ) * change beta tag * remove beta tag from hcl2_upgrade comment * add a partial to describe the legacy json limitations * exclude legacy category from templates until it is deployed to the website	5 years ago
Megan Marsh	54a75421ea	regenerate	5 years ago
Megan Marsh	1cb9aea752	change markdown references to new pathing	5 years ago
Wilken Rivera	4e58987026	command/fmt: Ensure all variable files ending in `.pkrvars.hcl` get formatted (#10377 ) Before change ``` ⇶ packer fmt -check /tmp/unformatted.pkrvars.hcl Error: Cannot tell whether /tmp/unformatted.pkrvars.hcl contains HCL2 configuration data ⇶ echo $? 1 ``` After fix ``` ⇶ packer fmt -check /tmp/unformatted.pkrvars.hcl /tmp/unformatted.pkrvars.hcl ⇶ echo $? 3 ⇶ packer fmt -check command/test-fixtures/fmt command/test-fixtures/fmt/unformatted.pkr.hcl command/test-fixtures/fmt/unformatted.auto.pkrvars.hcl command/test-fixtures/fmt/unformatted.pkrvars.hcl ```	5 years ago
Megan Marsh	39ab646236	move plugin and rpc code into sdk; other minor tweaks (#10359 )	5 years ago
Adrien Delorme	73b7499811	HCL2: version block: test validation & document version/availability (#10298 ) * HCL2: Test that the packer block passes in packer validate * HCL2: Test invalid packer blocks are invalid * docs: state from which version the packer block is available	5 years ago
Adrien Delorme	f44e912072	Update hcl2upgrade command to update env calls + tests (#10244 )	5 years ago
Adrien Delorme	deba1484ff	HCL2: allow calling env as input var default value (#10240 ) * HCL2: allow to use env in default value of input variables	5 years ago
Adrien Delorme	17ec88246f	hcl2_upgrade update (#10221 ) * handle template_dir, pwd funcs, handle min_packer_version * gotpl packer_version becomes hcl2 packer.version * uuid becomes hcl2 uuidv4 * test code with emojis * handle all cases were we cannot guess what the argument was * handle clean_resource_name cases * up docs	5 years ago
Adrien Delorme	6dd06fad14	add command/ tests	6 years ago
Adrien Delorme	4bc16455b4	HCL2: add a packer block with a required_version input setting (#10149 ) * add the possibility to set the packer.required_version field; to make sure the template file works with that version of Packer * add tests * add documentation on packer.required_version Example: packer { required_version = ">= 1.2.0, < 2.0.0" }	6 years ago
Megan Marsh	66b81d9bee	add build.name to hcl code (#10114 )	6 years ago

1 2 3

107 Commits (8ce3aae2f7f16c85a5465f922dcafe54090ed3e2)