1358 Commits (8b59e703dad3fb2fa69ba904e18c1cebc1996721)

Author	SHA1	Message	Date
nywilken	d2a9e6b32e	Format code with `gofmt -s -w`	6 years ago
Wilken Rivera	111bab86d9	Merge pull request #8622 from datalot/pre-validate-with-filters ... Allow aws builder pre validation to pass when subnet filters are present	6 years ago
Sylvia Moss	0b7251a4bb	Share .Device and .MountPath between builders, provisioners and post-processors (#8621)	6 years ago
Rich Cavanaugh	4fb0de5256	allow validation to pass when subnet filters are present	6 years ago
Sylvia Moss	39c25b2c66	Add retry mechanism to amazon DeleteSnapshot (#8614)	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Sylvia Moss	0e177915f8	Add retry mechanism to DeregisterImage from awsec2 (#8598)	6 years ago
Adrien Delorme	731904d3d2	mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests	6 years ago
Megan Marsh	b7ee807cf1	Merge pull request #8571 from hashicorp/fix_8565 ... fix ssh interface docs for amazon builders	6 years ago
Megan Marsh	6655f93b59	fix typo and regenerate code	6 years ago
Megan Marsh	76251e5fd2	fix ssh interface docs for amazon builders	6 years ago
Trevor Pounds	47e48ebc24	Add source AMI owner ID/name to build template.	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	84063d2132	implement ID and Type values in the provisioner template info sharing	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	601007e3e2	pas data into provisioners well	6 years ago
Oded Priva	5e81c6f44e	added the option to skip IAM instance profile validation (#8457)	6 years ago
deisenzimmer	2b3935778e	amazon-ebssurrogate plugin: StepSnapshotVolumes: Added mutex to synchronise map access across threads. (#8432)	6 years ago
Megan Marsh	de9f391a1c	Merge pull request #8430 from hashicorp/fix_8359 ... Fix request retry mechanism to launch aws instance	6 years ago
Megan Marsh	fcda07ee6a	clarify docs by removing unclear string (#8439) ... the docs generator from code PR #7724 mis scrapped it	6 years ago
Moss	28c720bd3a	Organize imports	6 years ago
Moss	250643d54b	Remove 5 sec sleep after adding iam instance profile	6 years ago
Moss	4516978555	Fix request retry mechanism to run aws instance	6 years ago
Jon Allie	c31bbcf4cf	builder/amazon: AmiFilterOptions.GetOwners: avoid taking the address of a loop iterator var (#8417) ... GetOwners() always returned a slice of pointers to the last value. Because slice ranging reuses the same local variable.	6 years ago
Mike Dziedziela	7c3e032fb7	amazon docs: update block-device-configuration docs (#8395) ... So that it works for all builders as some use it with the following field names: launch_block_device_mappings, ami_block_device_mappings or ebs_volumes. the refactored docs weird being to specific.	7 years ago
Megan Marsh	59e6e1d4d5	Merge pull request #8393 from hashicorp/fix_8362 ... Add no_ephemeral template option to nuke ephemeral drives from launch mappings	7 years ago
Megan Marsh	818d9bb087	send to step run spot instance	7 years ago
Megan Marsh	67c3373107	enable no_ephemeral for spot devices, clean up ranging behavior, update docs	7 years ago
Anthony Dong	2e989088e5	amazon-ebssurrogate: allow enabling ena/sr-iov on spot instances	7 years ago
Megan Marsh	08e97ba4d8	generate code for no_ephemeral option	7 years ago
Megan Marsh	0e2bdc8be6	forcibly prevent ephemeral drives from being created in the amazon-ebs builder, when no_ephemeral is set	7 years ago
DanHam	b40e5d90b6	builder/amazon/common/step_pre_validate: Return DescribeVpcs errors	7 years ago
nywilken	afb880c134	test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock ... * Update condition to check for a empty VpcId	7 years ago
DanHam	074be9942d	Only validate the user has provided a subnet_id when vpc_id has been set	7 years ago
nywilken	f9f4726eff	builder/amazon/step_pre_validate: Add check for non-default VPCs ... Subnet information is only really needed when the specified `vpc_id` is not the default VPC for the region where the builder is being executed. This change uses the AWS API to determine if the VPC provided is a non-default VPC and only validates the existence of a `subnet_id` if a user has provided a non-default `vpc_id`. Tests after change ``` > make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc' ... === RUN TestStepPreValidate_checkVpc === RUN TestStepPreValidate_checkVpc/DefaultVpc === RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet === RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet === RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc === RUN TestStepPreValidate_checkVpc/NoVpcInformation --- PASS: TestStepPreValidate_checkVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s) PASS ... ```	7 years ago
Megan Marsh	dfa134cd98	ditch else statement for improved clarity	7 years ago
Megan Marsh	ce8bca349f	Update builder/amazon/ebs/step_create_ami.go ... Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>	7 years ago
Megan Marsh	a35ac0127e	fix bug in step_region_copy	7 years ago
nywilken	488e539f63	builder/amazon: Add helper function for checking against AWSError ... Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function	7 years ago
Megan Marsh	6e2456d028	make error messaging around ResourceNotReady better, update docs with other possible issues (#8349)	7 years ago
cove	2898d66812	retry runinstances aws api that wasn't retried and could fail	7 years ago
Megan Marsh	6c704f7046	Revert "fix template imports" ... This reverts commit 0e70e0e5a4.	7 years ago
Megan Marsh	517834d528	Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"" ... This reverts commit 44f91c9afc.	7 years ago
Megan Marsh	fcb65ee422	Merge pull request #8307 from hashicorp/fix_8116 ... delete amazon import post-processor intermediary snapshots	7 years ago
Megan Marsh	e9e4c102e5	delete amazon import post-processor intermediary snapshots	7 years ago
Adrien Delorme	1b7ef252d2	Merge pull request #8303 from alrs/amazon-builder-cleanup ... Cleanup builder/amazon/common	7 years ago
Lars Lehtonen	d072079899	builder/amazon/common: remove dead test type and function mockEC2Conn_Modify_EBS.ModifyInstanceAttribute()	7 years ago
Lars Lehtonen	953be1603b	builder/amazon/common: remove dead test type and function mockEC2ConnSpot.DescribeSpotPriceHistory()	7 years ago
Lars Lehtonen	7a09f9c678	builder/amazon/common: remove dead test function fakeModifyEBSBackedInstanceState()	7 years ago
Lars Lehtonen	0a13b620d6	builder/amazon/common: remove dead test function StepModifyEBSBackedInstance_EnableAMIENASupport()	7 years ago
Lars Lehtonen	c74df8b652	builder/amazon/common: remove dead test function getMockConnSpot()	7 years ago
Lars Lehtonen	e5e2bfa83f	builder/amazon/common: remove nil check on slice, len() on nil slices is zero	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Megan Marsh	6191b9c8c6	Merge pull request #8288 from hashicorp/fix_8271 ... add some extra layers of validation to make sure that people don't tr…	7 years ago
Megan Marsh	d084cd1895	Update builder/amazon/common/ami_config.go	7 years ago
Megan Marsh	e9f02e44cb	add test to catch this case	7 years ago
Megan Marsh	7cf47fc463	add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build	7 years ago
Megan Marsh	e2283445f2	need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly.	7 years ago
Megan Marsh	a783a09ea3	Merge pull request #8269 from paulmey/paulmey/generalize-chroot ... [amazon/chroot] Move common/generic chroot builder steps to common directory	7 years ago
Megan Marsh	7928b5b045	fix transcription error from when we moved to generated docs	7 years ago
Paul Meyer	3be7d81ce2	Move common steps together	7 years ago
Paul Meyer	e6dfe301ac	Move CommandWrapper & ShellCommand to common	7 years ago
Megan Marsh	b9245a402d	add structure to its own struct to make generated code stop complaining	7 years ago
Megan Marsh	5614f307fb	regerate code ... generate flat FlatPolicyDocument add PolicyDocument to generate command	7 years ago
Megan Marsh	d15f43e4eb	Merge pull request #8232 from hashicorp/artifact-tree ... HCL2 configs - part one	7 years ago
Bernard Baltrusaitis	ec1d70dc44	adding required changes	7 years ago
Bernard Baltrusaitis	65d1447b64	adding formatting	7 years ago
Bernard Baltrusaitis	6e2146324f	Merge branch 'master' of github.com:b-b3rn4rd/packer	7 years ago
Bernard Baltrusaitis	8b83cca064	adding temporary instance profile document policy	7 years ago
Adrien Delorme	cf1555bf17	Merge remote-tracking branch 'origin/master' into artifact-tree	7 years ago
Paul Meyer	977ca5be1c	Add StepCopyFiles and StepChrootProvision	7 years ago
Paul Meyer	9a3e6661b1	Add StepMountExtra	7 years ago
Paul Meyer	addbdedea9	Add StepPostMountCommands	7 years ago
Paul Meyer	4d750ddefa	Reuse amazon/chroot/step_pre_mount_commands.go	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Adrien Delorme	221e72e9c3	builder.amazon.common: remove pointer (*) from []*string and map[*string]*string types ... because they make hcl2/cty decoding panic	7 years ago
Adrien Delorme	8b8c2fc138	builder.amazon.chroot: remove specific BlockDevice definition ... because the common one already has a KmsKeyId field	7 years ago
Megan Marsh	f05fd3969f	Merge pull request #8212 from hashicorp/fix_8204 ... Fix 8204	7 years ago
Megan Marsh	2e20facc8b	fix tests	7 years ago
Megan Marsh	0e70e0e5a4	fix template imports	7 years ago
Megan Marsh	44f91c9afc	Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name" ... This reverts commit 0026792d2f.	7 years ago
Megan Marsh	4bc381183d	make aws instsance builder work with recent changes for volume copy	7 years ago
Megan Marsh	e283023d9b	make sure step_register_ami in chroot builder respects encryption and ami skip build retion values once the copy happens	7 years ago
Megan Marsh	469af8e592	ebssurrogate builds didn't keep up with recent optimizations to region encryption in the ebs builder, and that was causing bugs with the common ami region copy step	7 years ago
Adrien Delorme	d4600a7716	fix go imports	7 years ago
Megan Marsh	0026792d2f	remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name	7 years ago
Megan Marsh	e16fb19bfc	don't abort on a single error if another availability zone was able to create the instance	7 years ago
Megan Marsh	eccf0fb51d	update docs	7 years ago
Megan Marsh	e047b97bf7	Merge pull request #8162 from hashicorp/fix_8154 ... make sure amazon builders respect ssh_host option	7 years ago
Megan Marsh	ac6e7a4800	updates tests to validate that ssh_host value supplied in the template overrides all else	7 years ago
Adrien Delorme	941dc394f0	Update step_run_spot_instance.go	7 years ago
Adrien Delorme	d049284120	Update builder/amazon/common/step_run_spot_instance.go ... remove unused code that might induce errors	7 years ago
Adrien Delorme	07e97e26de	step_run_source_instance.go: make sure we use the right ShouldRetry error	7 years ago
Megan Marsh	c722009159	we only need one describeInstances call, not 3, and it should be wrapped in a retry	7 years ago
Megan Marsh	e47059aaca	put retry around describeinstances call in amazon	7 years ago
Megan Marsh	31bb1e818f	fix tests	7 years ago
Megan Marsh	0cbd3ff0f3	make sure amazon builders respect ssh_host option	7 years ago
Megan Marsh	72d393c95a	update docs to show a use case for block device mappings	7 years ago
Adrien Delorme	4fb05e5bc4	fix test	7 years ago
Adrien Delorme	792f61a4ad	fmt	7 years ago
Adrien Delorme	849de792da	re-apply doc changes of master	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	4d4bd38afa	Merge pull request #8087 from hashicorp/fix_8048 ... add retry wrapper to query so it handles rate limiting	7 years ago
Megan Marsh	9503802814	adding ctx makes the cancel channel redundant	7 years ago
Megan Marsh	4b497006b3	add retry wrapper to query so it handles rate limiting	7 years ago
Adrien Delorme	146b88ba1e	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	de9bb26f62	Merge branch 'master' into fix_7959	7 years ago
DanHam	bbeb1a3528	Delete any `run_volume_tags` applied to EBS volumes at instance creation ... * Allows `run_volume_tags` to be set without requiring a major rewrite of the (common) amazon builder code used to start an instance. The common start up code tags the instance and *all attached volumes at creation*. If `run_volume_tags` are set this means that any volumes specified in `ebs_volumes` will *initially* be tagged with the `run_volume_tags` rather than the tags set in the `ebs_volumes` section * Once the instance is reported to be 'ready' the step to tag the EBS volumes is run. Once complete all volumes should have the tags requested by the user: * Volumes associated with the source instance should be tagged with the tags set in `run_volume_tags` (if any) * Each EBS volumes specified in the `ebs_volumes` section of the template should only be tagged with its associated tags (if any)	7 years ago
DanHam	61b1605a85	More accurate error description; Add comments; Add output	7 years ago
DanHam	430d41fbf9	Add option to enable tagging of the running instances volumes ... * Currently this results in *all* volumes attached to the instance being tagged with the `run_volume_tags`. This includes any `ebs_volumes` for which the user may have configured other tags. * This issue will be addressed in a later commit	7 years ago
DanHam	30070ffb30	Sort fields and options alphabetically	7 years ago
Adrien Delorme	9f8e9893b3	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	86cee5cbef	Merge pull request #8034 from cove/retry-describe-instances ... add AWS API call reties on AMI prevalidation	7 years ago
cove	87e0a3b5e7	add prevalidating AMI name retries so the build doesn't fail when throttled	7 years ago
Adrien Delorme	9d0bc476d9	add ommited struct interpolation ... after dcc22df609	7 years ago
Adrien Delorme	239f97471c	fix ebs volume tags doc field ... Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>	7 years ago
Adrien Delorme	5517d41468	make sure all documentation fields are there ... * add missing `temporary_key_pair_name` field for alicloud * add missing description to `vpc_filter` for aws * add missing ssh communicator fields for aws * add links for aws * update vmware-vmx docs * manually describe AMI Configuration section for ebsvolume * display missing required ami_name field for aws * add missing fields for docker * add missing fields for openstack	7 years ago
Adrien Delorme	2efc94521b	use trilean initializers in test where missing	7 years ago
Megan Marsh	6a895db9be	converte block device encryption to trilean	7 years ago
Megan Marsh	1d9bba6fe3	change AMIEncryptBootVolume to trilean	7 years ago
Megan Marsh	1a6adadb89	convert EnableAMIENASupport to trilean in code	7 years ago
Megan Marsh	3c3f7f26ce	implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool.	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	4aa33306cb	make sure that fleetId exists before trying to stick it into error message	7 years ago
Megan Marsh	316a30b31d	fix spot_tags	7 years ago
Megan Marsh	9f6d14c75a	work around spot_tags related regression and bad fleet cleanup in spot instances	7 years ago
Megan Marsh	b42701380c	add test for nil case	7 years ago
DanHam	088151e51d	Type assertion safety - fix panic when key cannot be retrieved from statebag	7 years ago
Christian Muehlhaeuser	216afbaa8b	Fixed various typos ... Just a bunch of nit-picky typo fixes.	7 years ago
Megan Marsh	54d2ad5028	refactored step_ami_region_copy to fix bugs and clarify assumptions; added more tests for that step. ... fix race condition caused by variable declaration outside of loop	7 years ago
Megan Marsh	39a4da4d07	add code to deduplicate the region list, and to make sure that the original region's kms key id is in the map.	7 years ago
Megan Marsh	6ad975f296	Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" ... This reverts commit b0c09087a2.	7 years ago
Megan Marsh	62120c5c0b	Merge pull request #7813 from hashicorp/stop_calculating_spot_bids ... stop calculating spot bids	7 years ago
Megan Marsh	d4b6a61445	don't store names of volumes we will be deleting when the instance terminates	7 years ago
Megan Marsh	42611e6004	fix build	7 years ago
Megan Marsh	a60f7e395e	add a test to make sure we don't error becaue of spot price auto product, yet	7 years ago
Megan Marsh	c722afe707	stop calculating spot bids; amazon changed the way spot instances are priced to be stable rather than bid-based, so when user sets auto, we can just default to the ondemand price and know that they'll get the same price as everyone else bidding at that time.	7 years ago
Daniel Rodgers-Pryor	8a9753032c	Allow EC2 fleet packer instances to run in parallel ... Without conflicting over the name of the launch template that they create/delete. Previously, the launch template name was just hard coded to `packer-fleet-launch-template`, but since AWS enforces unique template names within an account, this caused simultaneously running packer instances to hit template-already-exists errors when creating their templates and race-conditions around deleting the template. Now, the template name is randomly generated on each run, so there should be no conflicts.	7 years ago
Adrien Delorme	02421bad33	simplify BlockDevice prepares	7 years ago
Adrien Delorme	433c40d72d	make block device example less specific	7 years ago
Adrien Delorme	8cea5d409a	doc ebsvolume builder using partials	7 years ago
Adrien Delorme	aeb898d598	document amazon-instance builder with partials	7 years ago
Adrien Delorme	c54879717b	document ebssurrogate with partials	7 years ago
Adrien Delorme	9f4c8fb321	document ebs builder using partials	7 years ago
Adrien Delorme	a476ab79d7	document chroot builder using partials	7 years ago
Adrien Delorme	dcc22df609	aws: move the OmitFromArtifact field in ebssurrogat where it's being used ... also, simplified a bit the usage of block device	7 years ago
Adrien Delorme	a86aae1c7e	mode KmsKeyId to chroot block device, as it's only used there	7 years ago
Adrien Delorme	9989845ada	add BuildEC2BlockDeviceMapping func to the BlockDevice type	7 years ago
Adrien Delorme	c696878d2e	aws block devices mapping: BlockDevices.Build -> BuildEC2BlockDeviceMappings()	7 years ago
Adrien Delorme	ff2e0298ba	simplify block devices utilisation by removing intermediary types	7 years ago
Adrien Delorme	78b29d1a74	up AMIBlockDevices docs	7 years ago
Megan Marsh	305592d8ed	fix copy logic and tests	7 years ago
Megan Marsh	8cc82ca8d2	add broken test	7 years ago
Megan Marsh	0d55bc46ee	add skip_save_build_region flag to fix naming conflicts when building for multiple regions	7 years ago
Adrien Delorme	daa9f9d34e	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Megan Marsh	1c3b234b55	Merge pull request #7737 from hashicorp/document_retry ... retry.Backoff: document	7 years ago
Adrien Delorme	6e3dc1aa9a	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	98206d59d7	aws: step_create_tags make the max waiting time 30s and not 30ns	7 years ago
Pratyush Singhal	d92e82c43f	refactor: replace the maxBackoff from 30 nanosecond to 30 seconds ... Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>	7 years ago
Pratyush singhal	d4b0cb68e3	feat: add retry for temp key-pair generation in amazon-ebs ... Signed-off-by: Pratyush singhal <psinghal20@gmail.com>	7 years ago
Adrien Delorme	8e857d64f1	aws: rewrap struct comments for documentation generation	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e09f3fbd02	amazon: update docs & links	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
Megan Marsh	3f036b33c5	test for length of ami tags before tagging	7 years ago
Megan Marsh	078d888dba	Merge pull request #7707 from CARFAX/master ... Enable encrypted AMI sharing across accounts	7 years ago
Jason McIntosh	abef9820c7	Fixed spacing on comment	7 years ago
Jason McIntosh	24a4e2f23e	Updated comments	7 years ago
Jason McIntosh	24bc50ce1b	Enable encrypted AMIs with custom KMS Keys	7 years ago
Megan Marsh	6786c0d641	update tests to reflect new behavior	7 years ago
Megan Marsh	bda09bf7d5	the build ami is made with an intermediary name, which means that we can't skip copying even from the original build region when unencrypted	7 years ago
Megan Marsh	708165eaa8	refactoring step_run_spot_instance and swapping out the calls to create a spot instance with a call to create a spot fleet of one, so that we can be more flexible with the instance type when desired	7 years ago
Megan Marsh	1062295ecd	add omit_from_artifact option for ebssurragote launch_block_devices	7 years ago
Megan Marsh	2cfba56265	fix typos	7 years ago
Megan Marsh	02c9f24531	allow user to set architecture	7 years ago
Megan Marsh	2c352cc681	add tests for step_ami_region_copy	7 years ago
Megan Marsh	ae3cf48f71	in ebs, don't clean up temporary amis from encryption step. that's handled in step_copy_ami now	7 years ago
Megan Marsh	8c1d0f9686	clean up temporary unencrypted AMI and associated snapshots	7 years ago
Megan Marsh	c0e69a9da0	if encrypt_boot is explicitly set to false, don't copy. Also, make sure we don't cause a wait group block when we aren't performing a copy.	7 years ago
Megan Marsh	105d3f8853	delete unencrypted temporary snapshot when encrypt_boot is true. Also, fix nil map error in region copy	7 years ago
Megan Marsh	201c8c1332	make sure that you encrypt using the provided kms key id and not the default	7 years ago
Adrien Delorme	aee73d745d	update code after go mod update	7 years ago
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	a81abd297b	Merge remote-tracking branch 'origin/master' into context_provisioner	7 years ago
Megan Marsh	3e72e65a6c	Merge pull request #7456 from hashicorp/do_5770 ... introduce the clean_resource_name to clean image/var names	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Adrien Delorme	9836dad0c9	introduce the clean_resource_name to clean image names and deprecate the old ones	7 years ago
Akshat Mahajan	f07e4214cc	Addresses issues #5384, #5494: Rename and change `temporary_security_group_source_cidr` ... to accept a list of strings (for Amazon builders). Per this change, `temporary_security_group_source_cidr` in the configuration: 1. Will be renamed to `temporary_security_group_source_cidrs`. 2. Will accept a list of CIDRs. 3. Will have its documentation updated to reflect this change. 4. Will have a fixer attached for newer templates to avail of.	7 years ago
programmer04	596a9cc7ff	Improve error message for AWS and Alibaba	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	0196d7f835	Merge pull request #7370 from sargun/allow-users-to-specify-custom-block-device-mapping ... amazon-chroot: Allow users to specify custom block device mapping	7 years ago
Megan Marsh	3ed9fe6dee	remove unused imports ... remove HttpClientWithEnvironmentProxy from amazon builders; let access config handle it	7 years ago
Megan Marsh	0ed57a37a3	dont overwrite session config in ebs builder	7 years ago
Megan Marsh	ca9a5daf29	fix proxy and tls	7 years ago
Sargun Dhillon	601e754438	amazon/chroot: Allow creating new block device mappings !not fromScratch ... Previously, when you built from an existing image, you were unable to reconfigure block device mappings, as it just took them and copied them over. This allows users to specify new, custom block device mappings, even when building from an existing image.	7 years ago
Megan Marsh	ec3b0a5138	fix conflict from mergeing too many things to master at once	7 years ago
Megan Marsh	9d2b06bd61	Merge pull request #7342 from hashicorp/fix_7316 ... swap region copy and encryption steps	7 years ago
Megan Marsh	0abd16527e	Merge pull request #7337 from sargun/fix-chroot-builder ... Amazon-chroot: Fix building PV images and where mount_partition is set	7 years ago
Adrien Delorme	f535464097	up a test	7 years ago
Adrien Delorme	f03cbd8a10	aws: allow to pass nil bool as encryption parameter ... to retain current encryption settings this changes the fields : * ami_config.encrypt_boot * block_device.encrypted This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy	7 years ago
Adrien Delorme	ce8532e94b	aws: document ValidateRegion better	7 years ago
Adrien Delorme	6af621c37a	aws: StepAMIRegionCopy call waitgroup.add only once	7 years ago
Michael F	01a0b0c766	kmsArnStartPattern - fix support for aws-us-gov ... While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration. For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.	7 years ago
Megan Marsh	026e543b24	move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation	7 years ago
Megan Marsh	3b726e66c1	swap region copy and encryption steps	7 years ago
Sargun Dhillon	142a84ef43	amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour ... There is some logic around how EBS mappings are handled / generated depending on whether an image if from scratch or not. There was no testing around this behaviour before. This strips that logic out into a separate function, to enable testing it independentlhy.	7 years ago
Sargun Dhillon	d3c65ee77d	builder/amazon/chroot: Fix building PV images with mount_partition ... Right now, if we have a source image that's PV, and try to build an image with mount_partition set to not 0, it does not get picked up. This is because under PV we only had a filesystem, not partitions, but you can convert a PV image to an HVM image during build time.	7 years ago
Megan Marsh	2a613dd6e9	fix up the github suggestion	7 years ago
Adrien Delorme	3ae5a912d4	Update builder/amazon/common/step_pre_validate.go ... Co-Authored-By: SwampDragons <megan@hashicorp.com>	7 years ago
Megan Marsh	3704a053d0	move region validation and credential wait into step pre validate	7 years ago
Megan Marsh	8add176ab7	finish first pass at vault code; needs testing and cleanup of error messages	7 years ago
Megan Marsh	7a78b47e83	make vault engine stuff into a little struct for easier management	7 years ago
Megan Marsh	035c3506ba	manually set proxyfromenvironment in default http client for ec2 sessions	7 years ago
Adrien Delorme	4a2773f8fa	remove default max retries config of 8, it will now be used from env ... removing the code that wants to guess region from metadata allows us to change that setting, which can now be taken from environment.	7 years ago
Adrien Delorme	964b149df2	aws: remove now unused AccessConfig.metadataRegion	7 years ago
Adrien Delorme	335f442b51	aws: unwrap AccessConfig.region func ... * it was used only in the Session() call. * default region guessing from metadata should happen in the SDK, not 'manually'	7 years ago
Adrien Delorme	54af9951a8	make guard clauses to clearly see success pass	7 years ago
Adrien Delorme	0864b4d07b	name unclear import	7 years ago
Megan Marsh	e0543246fa	remove commented code	7 years ago
Megan Marsh	783ed32e7e	fix region stuff	7 years ago
Adrien Delorme	9f7b4ffc17	Merge branch 'master' into pr/6950	7 years ago
Megan Marsh	ee2e5cc874	Merge pull request #7080 from hashicorp/do_6508 ... Move logging about aws waiters to the access config prepare() so that…	7 years ago
Adrien Delorme	b7222d1f56	Add tmp package that offers Dir & File funcs ... this regroups the calls of tmp func calls into one package. the tmp pkg allows to store tmp files under a common directory for easier managment Squashed commit of the following: commit 74b674c015 Merge: fc94b5714 66001525d Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 02:02:38 2018 -0400 Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs commit fc94b57142 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit 5a562359f4 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 9d5a4a0935 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit fbae4c2e05 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 3590fae8bd Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit d5c5306a97 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 0a72297da8 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 20f68228b6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit c73ebe3d83 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit 63549b8bd7 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit 9761010749 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit 95159afbc0 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 66001525d7 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit e9b6adefea Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 852113ed07 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit 54add38d1d Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 6b5b8f6d4e Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit c22092c601 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 7a73045091 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 0f2933adb6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit d74839ede0 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit eb65416619 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit acaa2b31ed Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit e573fde668 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 39a9874afc Merge: 8a413cfe8 3315812c2 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 18:19:26 2018 -0400 Merge branch 'master' of https://github.com/hashicorp/packer into prestine commit 8a413cfe83 Merge: e07491de5 4e14710a6 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Oct 1 20:18:10 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit e07491de59 Merge: 42610a35d a1fa35dff Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Aug 21 13:26:19 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 42610a35d5 Merge: 5298142da 0d63cf7bc Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue Jun 19 22:45:05 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 5298142da6 Merge: 7bb110bc7 9d9736552 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Jun 11 15:10:09 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 7bb110bc74 Merge: a61c869ca 6189d66e7 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Wed May 9 23:41:22 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit a61c869ca7 Merge: 098101dd9 4be5f072c Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri May 4 10:13:04 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 098101dd99 Merge: fefaf0fa6 554b2b4a5 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue May 1 20:52:30 2018 -0400 Merge branch 'EOL-handling' into prestine Co-Authored-By: Matthew Patton <pattonme@yahoo.com>	7 years ago
Tom Elliff	12bf7fc4d6	Check that the KMS key ID is valid ... KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias. Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.	7 years ago
Megan Marsh	042e9ad14b	Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.	7 years ago
Megan Marsh	c03894c05d	fix bad interpolation exemption for volume_size	8 years ago
Megan Marsh	da6e350949	fix tests	8 years ago
Megan Marsh	fbb3d526e3	move region validation to run so that we don't break validation when we don't have aws creds set	8 years ago
Mikhail Ushanov	536252683e	builders: reuse private key file reading function ... Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>	8 years ago
Megan Marsh	79862f1bbb	Merge pull request #6931 from hashicorp/fix_6919 ... aws: better error handling of region/credential guessing from metadata	8 years ago
Adrien Delorme	3f288fc6ca	aws client: config.WithMaxRetries(8)	8 years ago
Mikhail Ushanov	4608b5d39d	amazon: add option for skipping TLS verification ... Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>	8 years ago
Adrien Delorme	f4fbf45349	remove duplicate region check error	8 years ago
Adrien Delorme	16aa21dffe	aws: better error handling of region guessing from metadata ... * this will fix #6919	8 years ago
Adrien Delorme	ed793a8fb8	make ValidateRegion a member of *AccessConfig and make it variadic	8 years ago
Megan Marsh	fe044d8ff7	fix tests	8 years ago
Megan Marsh	340009009d	Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890"" ... This reverts commit 0cd3f36d50.	8 years ago
Megan Marsh	0cd3f36d50	Revert "Merge pull request #6892 from hashicorp/fix_6890" ... This reverts commit 1c4062c316, reversing changes made to 9bc41a23b9.	8 years ago
Megan Marsh	0924a316b7	fix template-set credentials ... update tests with mocked session	8 years ago
Megan Marsh	9573013d3a	Merge pull request #6872 from aspectcapital/disable-ena-support ... Add support to explicitly disable ENA support	8 years ago
Matt Dainty	feb8067c7d	Convert `ena_support` to a pointer ... This means it now has three states, `true`, `false`, & `nil`. The default state is now `nil` which does nothing instead of `false` which now will explicitly disable ENA support instead of just not enabling it.	8 years ago
Megan Marsh	57f87f58b9	Merge pull request #6374 from rickard-von-essen/aws-filters ... builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter	8 years ago
Megan Marsh	2266514408	Merge pull request #6843 from gmmephisto/pr-master-aws-security-group ... aws: wait for temporary security group before authorize rules	8 years ago