345 Commits (80ed988ffe4e5eb8df98b4e7cf1c8f51599bb7af)

Author	SHA1	Message	Date
Megan Marsh	c3266cc3b0	remove indexing from cdrom command and let qemu handle it (#10519)	5 years ago
Darwin Liu	8ef4cfa070	Add in a sanity check for valid vnc ports ... Check to make sure that the max and min VNC ports be below 65535 in config.	5 years ago
Darwin Liu	2b698478a6	Adjusted QEMU step_run_tests.go to reflect previous changes	5 years ago
Darwin Liu	4f2e9117c3	QEMU: Minor fix to VNC mapping parameters and output ... * Set the QEMU builder vnc_port_min to have a minimum value of 5900, with updated documentation to explain why. * Changed output messages so that the correct port is listed in packer's messaging to the user. LONGER DESCRIPTION If vnc_min_port is set to anything above 5900, then packer will fail to connect via VNC to the QEMU instance. This is due to how QEMU parses the port for listening to VNC: host:d TCP connections will only be allowed from host on display d. By convention the TCP port is 5900+d. Previously the calculation for the port was vncPort - VNCPortMin, however this will result in an incorrect port being displayed in packer's messages and potentially packer being unable to connect via VNC to the host. For example if vnc_port_min=5990 nad vnc_port_max=5999: ``` Looking for available port between 5990 and 5999 on 0.0.0.0 Found available port: 5996 on IP: 0.0.0.0 Found available VNC port: 5996 on IP: 0.0.0.0 [....] ==> Starting VM, booting disk image view the screen of the VM, connect via VNC without a password to vnc://0.0.0.0:6 ``` This will cause QEMU to set the listening port to 5906 while packer's VNC client is attempting to connect to 5996. I am a touch concerned as this commit undoes pull request #9905 (specfically commit 7335695c), but I am also confused as to how he was able to get QEMU to get a VNC listening port below 5900, as examining QEMU's git history has shown that this behavior has been in since at least 2017, probably older. Hopefully the more explicit error messaging and documentation can make it clear why this is being undone.	5 years ago
Megan Marsh	ce99640fe2	fix test fixture path	5 years ago
Megan Marsh	88b7b0e14a	remove sdk	5 years ago
Megan Marsh	5f34bbd56e	add extra line before package declaration so this line does not become the synopsis of a package for godoc	5 years ago
Megan Marsh	1d2ee0bf81	Merge pull request #10337 from serverwentdown/serverwentdown/duplicate-output-file ... Fix duplication of main disk in QEMU	5 years ago
Megan Marsh	5576bb5caa	move packer config constants next to the packer config	5 years ago
Megan Marsh	8558d1241f	move TestUi func to sdk	5 years ago
Ambrose Chua	436ac8ef26	Fix duplication of main disk in QEMU	5 years ago
Ambrose Chua	f5d5e28012	Update step_copy_disk.go (#10333)	5 years ago
Megan Marsh	39354f64e5	move helper/communicator dir into packer-plugin-sdk ... fix imports; fix website and generated partials	5 years ago
Megan Marsh	faa3832537	extract builder interface to sdk	5 years ago
Megan Marsh	d5971ca25e	fix tests by moving mock hooks and communicators, and BasicUi definition, into SDK	5 years ago
Megan Marsh	56a45b04ab	Move hook and communicator definitions to packer-plugin-sdk	5 years ago
Megan Marsh	14bdb9516c	move Artifact and artifact mock to the sdk	5 years ago
Megan Marsh	c70870cb83	move multierror and multierrorappend into sdk	5 years ago
Megan Marsh	001886670d	move Ui definition into the packer plugin sdk.	5 years ago
Wilken Rivera	d82b9d2072	builder/qemu: Add ok check for state values (#10249) ... This changes fixes two crashes in `step_run` that expects certain information to be in state from prior steps. This change requires testing to ensure the bugs have been fixed. I believe there may be more state values that need to be checked as they may not be put into state if a build configuration has attributes that would skip or otherwise not put data into the statebag.	5 years ago
Megan Marsh	f8f1ebf0c7	move version and useragent definitions into sdk	5 years ago
Megan Marsh	9e47696dff	move helper/config to bundle with the other template definitions	5 years ago
Megan Marsh	3f6deb8828	move multistep into the plugin sdk	6 years ago
Megan Marsh	7d658149ea	update tests and website and generated partials to reflect new package format	6 years ago
Megan Marsh	f52a2ad0fa	move retry function that is only used by osc builder into that builder's common dir instead of the global common dir. Fix bug in quemu where the wrong retry value is checked against.	6 years ago
Megan Marsh	c4d0c5505a	fix tests ... regenerate code regenerate code, revendor fix website	6 years ago
Megan Marsh	e04eaa89e6	move steps and step configs from packer/common to packer/common/commonsteps	6 years ago
Megan Marsh	6402362018	create packer-plugin-sdk directory and begin moving the relevant folders into it.	6 years ago
Megan Marsh	3db40194af	version files	6 years ago
Megan Marsh	8ecd16db81	regenerate code	6 years ago
Megan Marsh	45b5f0c2ee	move custom http client creation with env proxy args into same package as other network related helpers	6 years ago
Megan Marsh	69312458c4	Merge pull request #10111 from hashicorp/azr_selectable_temp_keygen_type_gcp ... GCP: Allow to select algo when generating temporary SSH keypair	6 years ago
Megan Marsh	fb3d357e84	fix step_shutdown when a null communicator is used (#10178)	6 years ago
Adrien Delorme	f5e037e8b4	Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp	6 years ago
Megan Marsh	00037d8e69	Merge pull request #10145 from hashicorp/fix_10135 ... commhostport isn't present if communicator is null; protect casting i…	6 years ago
Megan Marsh	70cb4097e1	review comments, add plugin type for a few missing builders	6 years ago
Megan Marsh	f1f834b8fe	commhostport isn't present if communicator is null; protect casting in a check	6 years ago
Adrien Delorme	522d122858	regen all code	6 years ago
Adrien Delorme	54032d6c11	gen code and docs	6 years ago
Megan Marsh	b05fd9303e	document that users must re-apply packer defualts for drive and device arguments	6 years ago
Megan Marsh	3e35630d8d	remove slashes to prevent windows test fails	6 years ago
Megan Marsh	8e632866b1	typo	6 years ago
Megan Marsh	b54b778572	major refactor of the step_run. Splits step into two major parts: ... - generating defaults - overriding defaults with user args The default generation has been shuffled around some, in order to make sure that any changes to a specific arg happen in one place to make it easier to reason about those args. Related args have been moved close to one another. The deviceArgs and driveArgs were overly complex after several layers of copy/paste modifications. Careful pruning reduced the layers of logic and repeated code, to help make it easier to reason about.	6 years ago
Lik	bdb1c47532	Pass QemuImgArgs to stepConvertDisk (#10001)	6 years ago
Megan Marsh	b7b43a41f3	review cleanup	6 years ago
Megan Marsh	1d218d9e65	add QemuImgArgs option to set specialized flags in qemu-img ... convert, resize, and create commands. Add tests. Refactor steps to not require config pulled from statebag.	6 years ago
Megan Marsh	1052733fca	Skip qemu-img convert if format of output file matches format of input file. ... This works around an osx bug in qemu-img convert in osx.	6 years ago
Megan Marsh	83ee4e7d13	miscellaneous qemu cleanup. Fix generator strings; generate code ... fix diskimage logic linting fix tests	6 years ago
Megan Marsh	3577c4a283	refactor multistep array construction in qemu builder to push majority of conditionals into their steps rather than the multistep constructor code.	6 years ago
Megan Marsh	9ac76be190	clean up step_run	6 years ago