packer

Commit Graph

Author	SHA1	Message	Date
hashicorp-copywrite[bot]	6af0b29558	[COMPLIANCE] Update Copyright and License Headers	5 months ago
Lucas Bajolet	b6141fd532	command: copy AWS plugin structures for upgrade The hcl2_upgrade command transforms a JSON template into an HCL2 template for use with Packer. The command is quite fragile already, but given that this is the last remaining fragment that causes Packer to depend on the AWS SDK directly, we can do away with it. This commit therefore imports the definitions for AWS access config, so we can extract this information from the JSON template, and include it in the definition of the output source for AWS, since we manage this one differently from other sources. This allows us to not depend on the AWS plugin directly, which in turn makes Packer not need to link with the AWS plugin when compiling the executable. We are still depending on the AWS SDK for now since the SDK exposes a aws_secretsmanager function that can be used for interpolation (legacy JSON interpolation to be clear), so this cannot be removed from now, but we should consider some form of remediation in the future.	1 year ago
Lucas Bajolet	cd74430e0c	command: add use-sequential options for commands For all the commands that call Initialise, we introduce a new flag: UseSequential. This disables DAG scheduling for evaluating datasources and locals as a fallback to the newly introduced DAG scheduling approach. `hcl2_upgrade` is a special case here, as the template is always JSON, there cannot be any datasource, so the DAG in this case becomes meaningless, and is not integrated in this code path.	1 year ago
Wilken Rivera	ebaf831562	cmd/hcl2upgrade: Add VirtualBox as known plugin	2 years ago
Wilken Rivera	da061169bc	cmd/hcl2_upgrade: Don't error when using a HashiCorp plugin that is not installed This change updates hcl2_upgrade to not flag known plugin components, those used for generating the required plugins block, when upgrading a legacy JSON template to HCL2. Any unknown plugins will be installed after running packer init on the generated template so we don't error. We may want to suggest running packer init to install any missing plugins. * Move knownPluginPrefixes into the hcl2_upgrade command	3 years ago
Lucas Bajolet	020f18e37f	command: remove unused FlagSetFlags enum The enumeration for FlagSetFlags, which presumably was added when the Meta structure was introduced, aims to pre-populate the flagset for a subcommand with a series of arguments. However, despite it being documented, it is actually not used, and therefore can safely be removed from the codebase.	3 years ago
hashicorp-copywrite[bot]	19055df3ec	[COMPLIANCE] License changes (#12568 ) * Updating the license from MPL to Business Source License Going forward, this project will be licensed under the Business Source License v1.1. Please see our blog post for more details at https://hashi.co/bsl-blog, FAQ at https://hashi.co/license-faq, and details of the license at www.hashicorp.com/bsl. * Update copyright file headers to BUSL-1.1 --------- Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
Lucas Bajolet	b522edca36	hcl2_upgrade: add required_plugins in out template When a legacy JSON template references built-in plugins, we add them to the resulting template as a `required_plugins' block in HCL2.	3 years ago
hashicorp-copywrite[bot]	b7df3ca36f	[COMPLIANCE] Add Copyright and License Headers (#12254 ) Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
Wilken Rivera	095959ed6d	Fix crash when variables block is undefined This change fixes a crash that occurs when trying to add undeclared variables into an empty variables map. The variables block when defined will always be non-nil but in the case where variables are declared and initialized from a legacy JSON variables file the map must be initialized first.	3 years ago
Wilken Rivera	dbeeab448a	cmd/hcl2_upgrade: Generate variable block for all referenced user input variables (#12136 ) Currently the HCL2 upgrade command generates a valid variable block for all variables within the JSON variables property. However JSON templates in Packer support variable interpolation for input variables defined within a variable definition file without it being declared within the variables property. When upgrading a JSON template to HCL2 the user variable reference gets converted to var.<var_name>. The upgraded template ultimately fails on validation or build execution with undefined variable errors, with this change the upgrade command will now create a variable block for all input variables referenced within the build template to ensure all required variables been defined.	3 years ago
Lucas Bajolet	1cee460d0d	hcp: extract all HCP-related code to hcp package As part of the work to displace everything related to HCP from scattered places around the Packer code, we move it all to an hcp package. This in turn reduces the amount of code that the commands have to integrate, and leaves the HCP details to its own enclave.	3 years ago
Lucas Bajolet	68ddb2f89d	hcl2_upgrade: add share_image_gallery workaround (#12087 ) In azure templates, the shared_image_gallery was mistakenly considered an attribute while this is supposed to be a block. This is due to a heuristic we use for deciding whether a JSON object is to be translated to an attribute or a block that fell short as the shared_image_gallery does not contain complex types. This cannot be fixed trivially for the general case, so we add this entity to the list of workarounds until we can implement something more robust.	4 years ago
Lucas Bajolet	296562614f	hcl2_upgrade: fix liniting issues with fmt.Sprintf Some literal strings without format-string directives nor arguments were littered around the hcl2_upgrade command's code, which is pointed out by the linters. Since they serve no purpose, we remove them.	4 years ago
Lucas Bajolet	3c249c0d42	hcl2_upgrade: replace passthroughs by pre-visit In previous versions of hcl2_upgrade, we referenced a list of passthrough statements from the original JSON template to be replaced by their equivalent Go-template in HCL2. This works but requires us to explicitely accept every possible templated variable in order to not ever encounter <no value> in our generated HCL2 templates. This is suboptimal, hence this commit changes approach by pre-visting the AST from the original Go Template, escaping every sequence that is not covered by the list of functions we can migrate. Pipes are also excluded from this function.	4 years ago
Zach Shilton	879fd9035c	fix: update redirected and broken links (#12060 ) * website: fix broken links on /docs/templates * fix: redirected install-plugins link * fix: debugging link * fix: secrets manager link in docs * fix: secrets manager link in source * fix: amazon ami plugin link in docs * fix: amazon ami plugin link in source * fix: extending plugins link * fix: plugins/builders/amazon links * fix: various builders links * fix: various amazon builder links * fix: redirected terminology link * fix: custom-provisioners link * fix: docker-push redirected plugin link * fix: googlecompute plugin links * fix: hyperv iso plugin links * website: update link to hcl upgrade guide Co-authored-by: Wilken Rivera <wilken@hashicorp.com> Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
teddylear	11f5da8b5a	fix: Removing test debris (#11300 ) * fix: fixing provisioner file test debris * fix: Setting hcl2_upgrade command create directory permissions to 0755	5 years ago
Adrien Delorme	eb8e302941	hcl2_upgrade: special case: vsphere fix (#11216 ) * fix typo * hcl2_upgrade: special case linux_options and network_interface to block instead of maps * Update hcl2_upgrade_test.go * Update hcl2_upgrade_test.go remove unused code * hcl2_upgrade: support strftime too (#11220) * hcl2_upgrade strftime function * create legacy_strftime.mdx	5 years ago
Adrien Delorme	57f37c99ea	avoid hcl2_upgrade panic when file does not exist (#11206 )	5 years ago
Sylvia Moss	927093e5c0	improve regex to fix escaping on split function (#11083 )	5 years ago
Adrien Delorme	98990fc34e	hcl2_upgrade: allow to hcl2_upgrade with unknown builders, just log errors (#11049 )	5 years ago
Adrien Delorme	a9bec7945e	remove .mdx extensions in links (#10823 ) Some of them were added in #10800 some where already there	5 years ago
Sylvia Moss	505cbd2591	Vendor amazon plugin (#10800 ) * remove amazon from core * vendor amazon plugin * remove website content * Add amazon to docs-remote-plugins * update amazon reference links in the documentation * update amazon docs version to latest Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	5 years ago
Adrien Delorme	7732f7998c	Add http_content func to serve variables from HTTP @ preseed (#10801 ) This imports hashicorp/packer-plugin-sdk#43 * code generate things * update docs * update guides * update examples We want to add a new guide.	5 years ago
Megan Marsh	0993c976fa	hcl2_upgrade escaped quotes fix (#10794 ) * clean up extra quoting that can cause text template failures. when everyone else abandons you, regex will always be there. * LINTING	5 years ago
Megan Marsh	502708b86a	Refactor hcl2_upgrade (#10787 )	5 years ago
Megan Marsh	0ecc4b5e52	add annotation warning to isotime func usage	5 years ago
Megan Marsh	6986fb0e81	make upgrade set isotime func properly	5 years ago
Sylvia Moss	610dde7f02	check for nil config map (#10730 )	5 years ago
sylviamoss	5ccbd27b72	Improve upgrade error and transform all variables with template eng to locals	5 years ago
sylviamoss	20e8f666d9	make locals out of variables with template engines	5 years ago
sylviamoss	a1a5cf0113	upgrade variables with other variables	5 years ago
sylviamoss	2016d6baec	Fix panic on upgrading variables json file	5 years ago
Sylvia Moss	37d05c85ff	upgrade pause_before (#10654 )	5 years ago
Sylvia Moss	e0557f84e9	Add access config to generated amazon ami data source (#10634 )	5 years ago
Megan Marsh	cac6b04546	update help text for hcl2_upgrade (#10624 )	5 years ago
Megan Marsh	80ed988ffe	Hcl2 upgrade fix (#10625 ) * fix random nil pointer dereference I found while debugging hcl2_upgrade issues * fix hcl2_upgrade command by creating passthroughs for all text template fields	5 years ago
sylviamoss	e69410b633	fix lint	5 years ago
sylviamoss	76e3d57cae	add with-annotation flag to hcl2_upgrade	5 years ago
Sylvia Moss	774c5903f6	Add error-cleanup-provisioner to HCL2 (#10604 )	5 years ago
Sylvia Moss	d28e6fe009	write timestamp local only when necessary (#10602 )	5 years ago
Sylvia Moss	f5006d0842	fix empty locals and source name with blank space (#10593 )	5 years ago
Sylvia Moss	d53488db68	Add aws_secretsmanager transformation to hcl2_upgrade (#10553 )	5 years ago
Adrien Delorme	ed091163be	HCL2 Parse packer.required_plugins block + packer init (#10304 ) This adds the new `required_plugins` block to be nested under the packer block. Example: ```hcl packer { required_plugins { aws = { version = ">= 2.7.0" source = "azr/aws" } azure = ">= 2.7.0" } } ``` For example on darwin_amd64 Packer will install those under : * "${PACKER_HOME_DIR}/plugin/github.com/azr/amazon/packer-plugin-amazon_2.7.0_x5.0_darwin_amd64" * "${PACKER_HOME_DIR}/plugin/github.com/hashicorp/azure/packer-plugin-azure_2.7.0_x5.0_darwin_amd64_x5" + docs + tests	5 years ago
Sylvia Moss	291121dd55	(2) Implement datasources (#10440 )	5 years ago
Sylvia Moss	e44cb9d7e5	Add Amazon AMI data source to hcl_upgrade command (#10491 )	5 years ago
Megan Marsh	4cb6e07900	Hcl beta tag (#10493 ) * change beta tag * remove beta tag from hcl2_upgrade comment * add a partial to describe the legacy json limitations * exclude legacy category from templates until it is deployed to the website	5 years ago
Megan Marsh	54a75421ea	regenerate	5 years ago
Megan Marsh	1cb9aea752	change markdown references to new pathing	5 years ago
Megan Marsh	88b7b0e14a	remove sdk	5 years ago

1 2

60 Commits (802199dde15c05478e79e23d15c4e226694b2dfd)