60 Commits (7ca0a80a86df0dfdd50f4e4b41f9e5a06b15c0fe)

Author	SHA1	Message	Date
Wilken Rivera	b9f1b3c8d4	Fix gosimple S1005 linting issue (#8870) ... Results before change ``` ⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1005 fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple) fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple) fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple) packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple) packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple) ``` Results after change ``` ```	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
nywilken	d2a9e6b32e	Format code with `gofmt -s -w`	6 years ago
Sylvia Moss	d6a351b173	Rename communicator config variables and remove deprecated code (#8584)	6 years ago
Ricard Clau	b2578ee0f9	Fix typo in Synopsis for galaxycommand fixer (#8573)	6 years ago
Kevin Gunn	a7d32afe4e	removed escape character check, updated synopsis string, change type to 'ansbile-local' only	6 years ago
Kevin Gunn	70aa0516de	reset ansible-local documentation to include galaxy_command ... fix spacing in fixer.go	6 years ago
Kevin Gunn	28d1037864	change galaxycommand to galaxy_command and add fixer	6 years ago
Victor Yap	9a961bb079	Implement fixer to convert qemu disk size type to string	6 years ago
Brendan Devenney	2b16b5cae4	Move fixer test to fix package ... Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Brendan Devenney	75d8d7fce5	Update and futureproof fix command usage ... * Dynamically generate the fixer documentation (in order) from FixerOrder * Update fixers which used linebreaks in their Synopsis Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Brendan Devenney	556492fb0d	Add fixers erroneously removed by e8f04c3 ... Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>	7 years ago
Megan Marsh	c979cad579	add a fixer and update docs for spot_price_auto_product	7 years ago
Megan Marsh	3e72e65a6c	Merge pull request #7456 from hashicorp/do_5770 ... introduce the clean_resource_name to clean image/var names	7 years ago
Adrien Delorme	a08d9dec9b	add a Fixer that replaces the "clean_(image|ami)_name" template calls with "clean_resource_name"	7 years ago
Megan Marsh	17c14770a7	Merge pull request #7450 from AkshatM/rename_security_group_cidr_to_security_group_cidrs ... Rename and change `temporary_security_group_source_cidr` to accept a list of strings (for Amazon builders).	7 years ago
Akshat Mahajan	22504200cc	Fix typographical errors in the fixers	7 years ago
Akshat Mahajan	f07e4214cc	Addresses issues #5384, #5494: Rename and change `temporary_security_group_source_cidr` ... to accept a list of strings (for Amazon builders). Per this change, `temporary_security_group_source_cidr` in the configuration: 1. Will be renamed to `temporary_security_group_source_cidrs`. 2. Will accept a list of CIDRs. 3. Will have its documentation updated to reflect this change. 4. Will have a fixer attached for newer templates to avail of.	7 years ago
Megan Marsh	2b57b10284	write fixer	7 years ago
Megan Marsh	424a6a3a7e	Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming ... DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""	7 years ago
Don Kuntz	279fb7a632	gofix	7 years ago
Don Kuntz	b0589c9643	Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip	7 years ago
Don Kuntz	04de86d211	Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP	7 years ago
Don Kuntz	e4faa98b6f	cleanup: remove continue statement after a return statement, because it's unreachable	7 years ago
Don Kuntz	e251adb37e	Make the amazon-private-ip fixer errors more visible ... At present, when using the packer fix command on a template that has "ssh_private_ip" set to anything but a boolean value, the fixer will fail, and appear to fail silently, simply returning a non-zero status code without any message. To determine what happened, users have to know to set PACKER_LOG=1 to make the log message visible. So far as I can tell, this is the only instance of log.Fatalf being called, and based on the surrounding code the better solution would be to return an error, which will then be visible to users of packer fix without having to look in the logs.	7 years ago
Megan Marsh	be0959004a	Revert "Revert "Rename attribute api_access_key to organization_id""	7 years ago
Megan Marsh	c1c929164f	Revert "Rename attribute api_access_key to organization_id"	7 years ago
Rémy Léone	e54d2e3591	Rename attribute api_access_key to organization	7 years ago
Matthew Hooker	8a7d43dd44	bug fix and add test	8 years ago
Matthew Hooker	42910a5f8c	fix docker email fixer ... Fixing post-processors requires some smart parsing of the template. Let's turn that logic into a helper and use it everywhere.	8 years ago
Jeffrey Martin	e8f04c34a3	add vmware-compaction fixer help	8 years ago
Jeffrey Martin	1833b4edaf	validate compaction is skipped when not 'thin'	8 years ago
Matthew Hooker	7519037562	Merge pull request #6629 from hashicorp/travisbuild ... travis builds go 1.11. remove 1.9	8 years ago
Matthew Hooker	e41e99954d	go 1.11 format rules	8 years ago
DanHam	c8f54d5291	Fixer and tests to convert 'clone_from_vmxc_path' -> 'clone_from_vmcx_path'	8 years ago
DanHam	28087cb9f7	Fixer and tests to remove deprecated 'vhd_temp_path' Hyper-V ISO setting	8 years ago
Brendan Devenney	73c532e772	Ensure amazon-private-ip fixes string values ... The "ssh_private_ip" key works with either boolean values or string representations of booleans. The fixer errors when the value is defined as, for example, "true" (with quotation marks). This commit will attempt to convert the string into a bool when necessary to ensure this case is handled. Signed-off-by: Brendan Devenney <brendan.devenney@cloudreach.com>	8 years ago
Matthew Hooker	c6299972b9	s/boot_command/bootcommand/	8 years ago
Josh Soref	0503e429c3	spelling: override	8 years ago
Matthew Hooker	83ee29d768	Merge pull request #5876 from hashicorp/fix5680 ... builder/amazon: remove ssh_private_ip	8 years ago
Matthew Hooker	19a89a101e	builder/amazon: remove ssh_private_ip ... ssh_private_ip should now be set through ssh_interface. Adds fixer to automatically fix existing json files	8 years ago
DanHam	4cc078256d	Fixer for templates affected by auto escape of special powershell chars	8 years ago
Megan Marsh	79fe900378	Revert "Merge pull request #5376 from DanHam/ps-escapes" ... Revert so that we can merge a different branch that's had more recent work instead This reverts commit ba518637d4, reversing changes made to e56849c605.	8 years ago
DanHam	6ad4917960	First attempt at fixer for powershell escapes	8 years ago
Matthew Hooker	ebe995c0ff	run goimports	8 years ago
Matthew Hooker	1901c0385f	remove login_email from docker ... adds fixer removes documentation removes from docker builder and docker-push pp	8 years ago
DanHam	4ef462816a	Fix typo in fixer file name	9 years ago
Matthew Hooker	1a4c309ad5	namespace the enhanced networking fixer appropriately.	9 years ago
Megan Marsh	1adcce6046	Merge pull request #5284 from hashicorp/fix_5093 ... Allow granular modification of sriov and ena enhanced networking opti…	9 years ago
Megan Marsh	2d4bc70d7b	use ami prefix to make it clear that these variables are amazon specific ... add fixer, fixer tests	9 years ago