736 Commits (78cf1405abff0519f9912ccbf1ae5e0056741786)

Author	SHA1	Message	Date
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Adrien Delorme	ac92916b01	StepConfigureVNC: close listener only once	7 years ago
Adrien Delorme	a3838ecfad	error on negative ports	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	f828b72c10	step configure vnc: allow to use ESX5Driver again	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	b5d78d47f5	vmware StepConfigureVNC: use common/net pkg to find open port	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	eb98840f18	Merge pull request #7357 from e-mow/issue-7140 ... Issue 7140	7 years ago
Eric Mowry	cef3d0eb24	Ran make fmt per Megan's request.	7 years ago
Eric Mowry	109ba2c54c	After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.	7 years ago
Megan Marsh	0371e2a1b4	Merge pull request #7074 from hashicorp/fix_3329 ... vmware-iso (esxi) Add check that "format" is not being set when remote_type is empty.	7 years ago
Eric Mowry	e74a81e27b	Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process.	7 years ago
Eric Mowry	1127096beb	Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted.	7 years ago
Megan Marsh	5cc442872e	Merge pull request #7314 from hashicorp/fix_7234 ... add noSSLVerify to ovftool args	7 years ago
Megan Marsh	bbc52f9a7d	add noSSLVerify to ovftool args	7 years ago
Megan Marsh	bd3339f1f9	also strip \r to work around windows file ending strangeness	7 years ago
Megan Marsh	6ea64bc378	Merge pull request #7191 from arizvisa/GH-7190 ... Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.	7 years ago
Megan Marsh	ce8f5c31df	escape query as suggested in issue #7200	7 years ago
Ali Rizvi-Santiago	9d2f98394e	Revert "Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`." ... This reverts commit 0c37a3c68f and avoids bikeshedding from other committers.	7 years ago
Ali Rizvi-Santiago	0c37a3c68f	Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`.	7 years ago
Ali Rizvi-Santiago	4894873971	Added logic to the vmware-iso builder that appends the number of cores per socket to the vmx in `stepCreateVmx`.	7 years ago
Ali Rizvi-Santiago	062c62eed8	Added support for specifying the number of cores as `cores` to vmware-common.	7 years ago
Adrien Delorme	9f7b4ffc17	Merge branch 'master' into pr/6950	7 years ago
DanHam	0821653256	Fix 'nil' dir in VMware artifact when building locally	7 years ago
Megan Marsh	7d5ea43f41	revert the hddorder being added to the vmx template, since it's breaking things for some of our users.	7 years ago
Adrien Delorme	b7222d1f56	Add tmp package that offers Dir & File funcs ... this regroups the calls of tmp func calls into one package. the tmp pkg allows to store tmp files under a common directory for easier managment Squashed commit of the following: commit 74b674c015 Merge: fc94b5714 66001525d Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 02:02:38 2018 -0400 Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs commit fc94b57142 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit 5a562359f4 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 9d5a4a0935 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit fbae4c2e05 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 3590fae8bd Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit d5c5306a97 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 0a72297da8 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 20f68228b6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit c73ebe3d83 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit 63549b8bd7 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit 9761010749 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit 95159afbc0 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 66001525d7 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit e9b6adefea Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 852113ed07 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit 54add38d1d Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 6b5b8f6d4e Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit c22092c601 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 7a73045091 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 0f2933adb6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit d74839ede0 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit eb65416619 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit acaa2b31ed Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit e573fde668 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 39a9874afc Merge: 8a413cfe8 3315812c2 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 18:19:26 2018 -0400 Merge branch 'master' of https://github.com/hashicorp/packer into prestine commit 8a413cfe83 Merge: e07491de5 4e14710a6 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Oct 1 20:18:10 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit e07491de59 Merge: 42610a35d a1fa35dff Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Aug 21 13:26:19 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 42610a35d5 Merge: 5298142da 0d63cf7bc Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue Jun 19 22:45:05 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 5298142da6 Merge: 7bb110bc7 9d9736552 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Jun 11 15:10:09 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 7bb110bc74 Merge: a61c869ca 6189d66e7 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Wed May 9 23:41:22 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit a61c869ca7 Merge: 098101dd9 4be5f072c Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri May 4 10:13:04 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 098101dd99 Merge: fefaf0fa6 554b2b4a5 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue May 1 20:52:30 2018 -0400 Merge branch 'EOL-handling' into prestine Co-Authored-By: Matthew Patton <pattonme@yahoo.com>	7 years ago
Ali Rizvi-Santiago	1a36458e9e	Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.	7 years ago
Megan Marsh	dbfc1b5aff	fix tests	7 years ago
Megan Marsh	0058422a5c	also for vmx	7 years ago
Megan Marsh	0fe4d79bbf	add validation to prevent users from being confused about format functionality	7 years ago
Ali Rizvi-Santiago	96bdf17d2e	Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.	7 years ago
Ali Rizvi-Santiago	fa4998e1ec	Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.	7 years ago
Ali Rizvi-Santiago	e0d3861e81	Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.	7 years ago
Ali Rizvi-Santiago	3512c3c5ea	Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.	7 years ago
Ali Rizvi-Santiago	27b16cee0a	Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.	7 years ago
Megan Marsh	11ef407b4d	Merge pull request #7016 from rickard-von-essen/vmware-tech-prev ... vmware: Correctly parse version for VMware Fusion Tech Preview	7 years ago
Megan Marsh	ec75913412	fix crash that occurs when dir is nil	7 years ago
Megan Marsh	89fb8f0d3e	fix defaulting/lack thereof for cpu count and memory in vmware template	7 years ago
Ali Rizvi-Santiago	f8c23c1808	Updated things related to the vmware-iso builder to include @azr's suggestions.	7 years ago
Ali Rizvi-Santiago	61ee3a44f5	Modified the cpus and memory options for the vmware builders to only apply them if they were specified.	7 years ago
Ali Rizvi-Santiago	fb7ce9f2b5	Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).	7 years ago
Ali Rizvi-Santiago	cd45248eaa	Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.	7 years ago
Rickard von Essen	4ea3d1567a	vmware: Correctly parse version for VMware Fusion Tech Preview ... Closes #5317	7 years ago
Ali Rizvi-Santiago	4e73c85e22	Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.	7 years ago
Megan Marsh	dca02c7b07	Merge pull request #6962 from hashicorp/fix_6940 ... escape vSphere username when putting it into the query	7 years ago
Megan Marsh	3b413d2e5e	fix rebase conflicts	7 years ago
Megan Marsh	89184ae384	rework if/else to simplify main code body.	7 years ago