18 Commits (71b815a5fd6d319647e238b32d9d3a2fd9dee3ee)

Author	SHA1	Message	Date
Thomas Dreibholz	c5df930437	Added firmware option for QEMU builder (#10683)	5 years ago
Darwin Liu	8ef4cfa070	Add in a sanity check for valid vnc ports ... Check to make sure that the max and min VNC ports be below 65535 in config.	5 years ago
Darwin Liu	4f2e9117c3	QEMU: Minor fix to VNC mapping parameters and output ... * Set the QEMU builder vnc_port_min to have a minimum value of 5900, with updated documentation to explain why. * Changed output messages so that the correct port is listed in packer's messaging to the user. LONGER DESCRIPTION If vnc_min_port is set to anything above 5900, then packer will fail to connect via VNC to the QEMU instance. This is due to how QEMU parses the port for listening to VNC: host:d TCP connections will only be allowed from host on display d. By convention the TCP port is 5900+d. Previously the calculation for the port was vncPort - VNCPortMin, however this will result in an incorrect port being displayed in packer's messages and potentially packer being unable to connect via VNC to the host. For example if vnc_port_min=5990 nad vnc_port_max=5999: ``` Looking for available port between 5990 and 5999 on 0.0.0.0 Found available port: 5996 on IP: 0.0.0.0 Found available VNC port: 5996 on IP: 0.0.0.0 [....] ==> Starting VM, booting disk image view the screen of the VM, connect via VNC without a password to vnc://0.0.0.0:6 ``` This will cause QEMU to set the listening port to 5906 while packer's VNC client is attempting to connect to 5996. I am a touch concerned as this commit undoes pull request #9905 (specfically commit 7335695c), but I am also confused as to how he was able to get QEMU to get a VNC listening port below 5900, as examining QEMU's git history has shown that this behavior has been in since at least 2017, probably older. Hopefully the more explicit error messaging and documentation can make it clear why this is being undone.	5 years ago
Megan Marsh	88b7b0e14a	remove sdk	5 years ago
Ambrose Chua	436ac8ef26	Fix duplication of main disk in QEMU	5 years ago
Megan Marsh	c70870cb83	move multierror and multierrorappend into sdk	5 years ago
Megan Marsh	9e47696dff	move helper/config to bundle with the other template definitions	6 years ago
Megan Marsh	3f6deb8828	move multistep into the plugin sdk	6 years ago
Megan Marsh	7d658149ea	update tests and website and generated partials to reflect new package format	6 years ago
Megan Marsh	e04eaa89e6	move steps and step configs from packer/common to packer/common/commonsteps	6 years ago
Megan Marsh	6402362018	create packer-plugin-sdk directory and begin moving the relevant folders into it.	6 years ago
Megan Marsh	70cb4097e1	review comments, add plugin type for a few missing builders	6 years ago
Megan Marsh	b05fd9303e	document that users must re-apply packer defualts for drive and device arguments	6 years ago
Megan Marsh	b7b43a41f3	review cleanup	6 years ago
Megan Marsh	1d218d9e65	add QemuImgArgs option to set specialized flags in qemu-img ... convert, resize, and create commands. Add tests. Refactor steps to not require config pulled from statebag.	6 years ago
Megan Marsh	1052733fca	Skip qemu-img convert if format of output file matches format of input file. ... This works around an osx bug in qemu-img convert in osx.	6 years ago
Megan Marsh	83ee4e7d13	miscellaneous qemu cleanup. Fix generator strings; generate code ... fix diskimage logic linting fix tests	6 years ago
Megan Marsh	5b714497e6	qemu: split config and config tests into their own files to match best practices from other builders	6 years ago