9 Commits (6f93eec99ba558eab37c2f2ef68b5aa6c4eeaf5a)

Author	SHA1	Message	Date
Lucas Bajolet	6f93eec99b	test: add test for loading plugins with wd plugin ... Add one more test to ensure we don't load plugins with the old naming convention in the workdir for a packer run.	2 years ago
Lucas Bajolet	7aa9bac256	test: make must succeed/fail gadgets functions ... For consistency with other gadgets like Grep, we make the MustSucceed and MustFail gadgets private with a function to return an instance of it.	2 years ago
Lucas Bajolet	0c2cfe3745	test: reimplement Grep with a pipe ... As we've introduced pipelines, we can use those to compose a version of grep that doesn't have specific logic. Besides, this refactor allows us to expose grep as a function with variadic options, so this makes it more concise and clear to assert an input with Grep.	2 years ago
Lucas Bajolet	96892fbca0	test: add loading tests with legacy/valid plugins	2 years ago
Lucas Bajolet	f8749afa16	test: add method for setting plugin path for cmd ... When running a PackerCommand for acceptance tests, we generally run the test on a temporary plugin directory, populated by test plugins. Setting that temporary directory means we need to set the environment variable, which while it could be easier with a constant for the name for example, isn't too straightforward. Therefore for those tests we add a new function for PackerCommand so that it automatically sets that envvar for the current command.	2 years ago
Lucas Bajolet	fbb8cac698	test: remove unnecessary testing.T arg ... Since the MakePluginDir function takes the TestSuite as receiver, we don't need to additionally pass in a reference to testing.T, since the test suite already contains one instance, and offers a function to get it from.	2 years ago
Lucas Bajolet	0e2695d3e2	test: return cleanup function for temp plugin dirs ... When creating a temporary plugin directory, we had to build a cleanup function, which could be as simple as `os.Mkdirall` without any kind of warning that a directory failed to be cleaned-up, or we could do some more work in order to report the possible issues around this. That code would quickly be redundant, as there's not a ton of variability in the code that can be written for this step, so we abstract it through a pre-defined cancellation function which can be safely defer invoked.	2 years ago
Lucas Bajolet	56c2b5ad8b	test: call different packer cmds for loading tests	2 years ago
Lucas Bajolet	ef50474a9f	test: add base suite for core acceptance testing ... Acceptance testing, i.e. running Packer core commands in a controlled environment and ensuring the behaviour is consistent to what we expect/document, is not something we have a robust and usable framework for at the moment. This commit is a proposal for a base testing framework of the sort, that is meant to be shipped with packer core, and which will eventually host most of the tests we currently do in command where we mock an environment.	2 years ago