1125 Commits (68da46cdc4b53a370c6bb9d2ae96f8078dccc026)

Author	SHA1	Message	Date
DanHam	b40e5d90b6	builder/amazon/common/step_pre_validate: Return DescribeVpcs errors	7 years ago
nywilken	afb880c134	test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock ... * Update condition to check for a empty VpcId	7 years ago
DanHam	074be9942d	Only validate the user has provided a subnet_id when vpc_id has been set	7 years ago
nywilken	f9f4726eff	builder/amazon/step_pre_validate: Add check for non-default VPCs ... Subnet information is only really needed when the specified `vpc_id` is not the default VPC for the region where the builder is being executed. This change uses the AWS API to determine if the VPC provided is a non-default VPC and only validates the existence of a `subnet_id` if a user has provided a non-default `vpc_id`. Tests after change ``` > make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc' ... === RUN TestStepPreValidate_checkVpc === RUN TestStepPreValidate_checkVpc/DefaultVpc === RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet === RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet === RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc === RUN TestStepPreValidate_checkVpc/NoVpcInformation --- PASS: TestStepPreValidate_checkVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s) --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s) --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s) PASS ... ```	7 years ago
Megan Marsh	dfa134cd98	ditch else statement for improved clarity	7 years ago
Megan Marsh	ce8bca349f	Update builder/amazon/ebs/step_create_ami.go ... Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>	7 years ago
Megan Marsh	a35ac0127e	fix bug in step_region_copy	7 years ago
nywilken	488e539f63	builder/amazon: Add helper function for checking against AWSError ... Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function	7 years ago
Megan Marsh	6e2456d028	make error messaging around ResourceNotReady better, update docs with other possible issues (#8349)	7 years ago
cove	2898d66812	retry runinstances aws api that wasn't retried and could fail	7 years ago
Megan Marsh	6c704f7046	Revert "fix template imports" ... This reverts commit 0e70e0e5a4.	7 years ago
Megan Marsh	517834d528	Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"" ... This reverts commit 44f91c9afc.	7 years ago
Megan Marsh	fcb65ee422	Merge pull request #8307 from hashicorp/fix_8116 ... delete amazon import post-processor intermediary snapshots	7 years ago
Megan Marsh	e9e4c102e5	delete amazon import post-processor intermediary snapshots	7 years ago
Adrien Delorme	1b7ef252d2	Merge pull request #8303 from alrs/amazon-builder-cleanup ... Cleanup builder/amazon/common	7 years ago
Lars Lehtonen	d072079899	builder/amazon/common: remove dead test type and function mockEC2Conn_Modify_EBS.ModifyInstanceAttribute()	7 years ago
Lars Lehtonen	953be1603b	builder/amazon/common: remove dead test type and function mockEC2ConnSpot.DescribeSpotPriceHistory()	7 years ago
Lars Lehtonen	7a09f9c678	builder/amazon/common: remove dead test function fakeModifyEBSBackedInstanceState()	7 years ago
Lars Lehtonen	0a13b620d6	builder/amazon/common: remove dead test function StepModifyEBSBackedInstance_EnableAMIENASupport()	7 years ago
Lars Lehtonen	c74df8b652	builder/amazon/common: remove dead test function getMockConnSpot()	7 years ago
Lars Lehtonen	e5e2bfa83f	builder/amazon/common: remove nil check on slice, len() on nil slices is zero	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Megan Marsh	6191b9c8c6	Merge pull request #8288 from hashicorp/fix_8271 ... add some extra layers of validation to make sure that people don't tr…	7 years ago
Megan Marsh	d084cd1895	Update builder/amazon/common/ami_config.go	7 years ago
Megan Marsh	e9f02e44cb	add test to catch this case	7 years ago
Megan Marsh	7cf47fc463	add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build	7 years ago
Megan Marsh	e2283445f2	need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly.	7 years ago
Megan Marsh	a783a09ea3	Merge pull request #8269 from paulmey/paulmey/generalize-chroot ... [amazon/chroot] Move common/generic chroot builder steps to common directory	7 years ago
Megan Marsh	7928b5b045	fix transcription error from when we moved to generated docs	7 years ago
Paul Meyer	3be7d81ce2	Move common steps together	7 years ago
Paul Meyer	e6dfe301ac	Move CommandWrapper & ShellCommand to common	7 years ago
Megan Marsh	b9245a402d	add structure to its own struct to make generated code stop complaining	7 years ago
Megan Marsh	5614f307fb	regerate code ... generate flat FlatPolicyDocument add PolicyDocument to generate command	7 years ago
Megan Marsh	d15f43e4eb	Merge pull request #8232 from hashicorp/artifact-tree ... HCL2 configs - part one	7 years ago
Bernard Baltrusaitis	ec1d70dc44	adding required changes	7 years ago
Bernard Baltrusaitis	65d1447b64	adding formatting	7 years ago
Bernard Baltrusaitis	6e2146324f	Merge branch 'master' of github.com:b-b3rn4rd/packer	7 years ago
Bernard Baltrusaitis	8b83cca064	adding temporary instance profile document policy	7 years ago
Adrien Delorme	cf1555bf17	Merge remote-tracking branch 'origin/master' into artifact-tree	7 years ago
Paul Meyer	977ca5be1c	Add StepCopyFiles and StepChrootProvision	7 years ago
Paul Meyer	9a3e6661b1	Add StepMountExtra	7 years ago
Paul Meyer	addbdedea9	Add StepPostMountCommands	7 years ago
Paul Meyer	4d750ddefa	Reuse amazon/chroot/step_pre_mount_commands.go	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Adrien Delorme	221e72e9c3	builder.amazon.common: remove pointer (*) from []*string and map[*string]*string types ... because they make hcl2/cty decoding panic	7 years ago
Adrien Delorme	8b8c2fc138	builder.amazon.chroot: remove specific BlockDevice definition ... because the common one already has a KmsKeyId field	7 years ago
Megan Marsh	f05fd3969f	Merge pull request #8212 from hashicorp/fix_8204 ... Fix 8204	7 years ago
Megan Marsh	2e20facc8b	fix tests	7 years ago
Megan Marsh	0e70e0e5a4	fix template imports	7 years ago