packer

Commit Graph

Author	SHA1	Message	Date
Lucas Bajolet	4d559e23b7	hcl2: don't warn on excluded post-processor (#12187 ) * hcl2template: use && for chaining conditions For deciding if we need to run an error provisioner block, we checked using a nested if that we didn't need to avoid running it. This is unnecessary, and adds a superfluous level of inbrication to the code, so we chain both conditions with &&. * hcl2: don't warn on excluded post-processor When a post-processor is excluded through the -except command-line argument for packer build, we used to print a warning on HCL2 templates if this except statement did not match a build. However, since we can use the except option to avoid running post-processors, we should account for this as well when printing out a warning that there were no matches. This commit adds this counter to the except checks for the post-processors as well.	3 years ago
Lucas Bajolet	ca197afe9b	hcp: remove superfluous return value on GetBuilds This commit irons out one of the pain points of the HCP rework by introducing a HCPPublisher interface, implemented both by the JSON Core, and the HCL2 PackerConfig, which keeps a map of the build names used by Packer to the build names pushed on HCP. This in turn lets us go back to the old implementation of the GetBuilds function, which returns a list of (filtered) builds, and eventually an error if something went wrong while processing.	3 years ago
Lucas Bajolet	2200cb14ce	hcp: set the status to CANCELLED when a build is Related to the previous behaviour problem, this changes how the status of a build is set on HCP Packer, as a cancelled build is different from a failed one, we can set it to the appropriate state on cancellation.	3 years ago
Lucas Bajolet	f8bc240b02	core: CoreBuild.Run error on cancelled builds When a build is cancelled by a user, the current implementation of CoreBuild.Run does not return an error signifying that there was a problem with the build. This in turn causes the HCP code to attempt to update the status of the build to DONE, but fails because there are no artifacts to push. This commit changes this behaviour by returning the error provoked by the cancellation to the caller, so it can be taken into account when setting the status of the build.	3 years ago
Wilken Rivera	ea1d32e456	Update CHANGELOG	3 years ago
Wilken Rivera	56f784ae95	Bump github.com/hashicorp/go-getter/v2 (#12161 ) The latest version of Go-Getter contains a SMBClient timeout option, along with an updated AWS SDK to improve S3 support. ``` go get github.com/hashicorp/go-getter/v2 go get github.com/hashicorp/go-getter/s3/v2 go get github.com/hashicorp/go-getter/gcs/v2 go mod tidy ```	3 years ago
Wilken Rivera	9002ac263f	Update BuildBlock with valid HCL2Ref (#12167 ) While looking into #11932 I found that Packer will throw an error when an unknown source is referenced from within the sources attribute for a build block. The hcl.Diagnostics error includes a Subject, which should highlight where in the HCL2 configuration file the unknown source resides. But when creating the BuildBlock no HCL2Ref data is copied over, thus the Subject is displayed with with zero value for an hcl.Range type. This change updates the build creation logic to copy the HCL2Ref data from the build block at decode time so that it can be properly referenced downstream. Closes #11932 Failure due to change in output ``` --- FAIL: TestValidateCommand_ShowLineNumForMissing (0.00s) --- FAIL: TestValidateCommand_ShowLineNumForMissing/test-fixtures/validate-invalid/missing_build_block.pkr.hcl (0.00s) validate_test.go:377: Unexpected output: ( """ Error: Unknown source file.cho - on line 0: + on test-fixtures/validate-invalid/missing_build_block.pkr.hcl line 6: (source code not available) ... // 4 identical lines """ ) validate_test.go:379: FAIL FAIL github.com/hashicorp/packer/command 1.002s ```	3 years ago
Wilken Rivera	50a356529a	Update Go checks to run on pull_requests (#12166 ) Currently go-test and go-validate only run for users who have push access to the Packer repo. We want to ensure tests and validation run for all opened pull requests including public forks.	3 years ago
dependabot[bot]	a6e7635d05	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.28.0 to 0.29.0 (#12163 ) Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.28.0 to 0.29.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 years ago
Wilken Rivera	82bcc9e671	Reset to dev mode	3 years ago
Wilken Rivera	020f9818c3	Update CHANGELOG.md Fix version for vSphere plugin	3 years ago
Wilken Rivera	e4f31384a3	Cut release 1.8.5	3 years ago
Wilken Rivera	ad25ebc836	Update CHANGELOG 1.8.5	3 years ago
Lucas Bajolet	027e920147	go.mod: bump golang.org/net to 0.4.0 As with the go version to 1.18.9, this fix concerns mitigations to the GO-2022-1144 vulnerability. Since we depend on golang.org/net too, we need to update it to a version that is not vulnerable anymore, and this is starting at version 0.4.0	3 years ago
Wilken Rivera	f35270700f	Update external plugins to latest available release	3 years ago
Fedor Korotkov	5997724745	website: Added Tart builder This PR add [`tart` builder](https://github.com/cirruslabs/packer-plugin-tart) to the list of all the builders. Tart is a open-source toolset for building, running and managing Linux and macOS virtual machines on Apple Silicon. Part of the toolset is this packer plugin.	3 years ago
Lucas Bajolet	0aa2df1027	go-version: bump to 1.18.9 The go 1.18.9 version fixes a vulnerability GO-2022-1144, which concerns the net/http and golang.org/x/net packages. These are used in the codebase, and therefore automated tools report the generated binaries as vulnerable to this. Note that while Packer is indeed vulnerable to this, this is a DoS attack. This is therefore unlikely to impact Packer severely, especially as it requires a deliberate attempt to provoke an OOM/excessive GC cycles. Nonetheless, since this vulnerability is fixed with go 1.18.9, we bump the version used to build/test the tools to this version.	3 years ago
Wilken Rivera	3b9274aa04	command/validate: Add `-evaluate-datasources` flag to command help text (#12152 ) ``` Usage: packer validate [options] TEMPLATE Checks the template is valid by parsing the template and also checking the configuration with the various builders, provisioners, etc. If it is not valid, the errors will be shown and the command will exit with a non-zero exit status. If it is valid, it will exit with a zero exit status. Options: -syntax-only Only check syntax. Do not verify config of the template. -except=foo,bar,baz Validate all builds other than these. -only=foo,bar,baz Validate only these builds. -machine-readable Produce machine-readable output. -var 'key=value' Variable for templates, can be used multiple times. -var-file=path JSON or HCL2 file containing user variables, can be used multiple times. -no-warn-undeclared-var Disable warnings for user variable files containing undeclared variables. -evaluate-datasources Evaluate data sources during validation (HCL2 only, may incur costs); Defaults to false. ```	3 years ago
dependabot[bot]	7c498d7217	build(deps): bump dessant/lock-threads from 3 to 4 (#12145 ) Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 3 to 4. - [Release notes](https://github.com/dessant/lock-threads/releases) - [Changelog](https://github.com/dessant/lock-threads/blob/master/CHANGELOG.md) - [Commits](https://github.com/dessant/lock-threads/compare/v3...v4) --- updated-dependencies: - dependency-name: dessant/lock-threads dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 years ago
Wilken Rivera	bd53a7e237	Add github.com/hashicorp/hcp-sdk-go to dependabot tracking (#12147 )	3 years ago
Lucas Bajolet	4846301ff4	hcp: reject template type changes between builds As a follow-up to tracking the template type for an iteration, we actively check that it remains consistent between two invocations of packer, and reject the update if it is not the case.	3 years ago
Lucas Bajolet	6d0045607c	hcp: record template type when creating iterations In order to ensure users keep the same templates between two packer invocations for a single iteration, we start tracking the type of template used when building images.	3 years ago
Lucas Bajolet	08f1e85fb1	hcp: fix payloads for new SDK version The grpc_gateway v2 changes had some repercussions in the payloads of the API calls, making the current code non-functional against the latest SDK.	3 years ago
Christophe Jauffret	abb2f79155	Add Nutanix docs (#12131 )	3 years ago
HashiBot	97bdeadbe6	chore: Update Digital Team Files (#12139 ) * Update generated website Makefile * Update generated scripts (should-build.sh) * Update generated scripts (website-start.sh) * Update generated scripts (website-build.sh)	3 years ago
Wilken Rivera	dbeeab448a	cmd/hcl2_upgrade: Generate variable block for all referenced user input variables (#12136 ) Currently the HCL2 upgrade command generates a valid variable block for all variables within the JSON variables property. However JSON templates in Packer support variable interpolation for input variables defined within a variable definition file without it being declared within the variables property. When upgrading a JSON template to HCL2 the user variable reference gets converted to var.<var_name>. The upgraded template ultimately fails on validation or build execution with undefined variable errors, with this change the upgrade command will now create a variable block for all input variables referenced within the build template to ensure all required variables been defined.	3 years ago
Wilken Rivera	f29b6da035	Merge pull request #12130 from hashicorp/dependabot/github_actions/atlassian/gajira-create-3.0.1 build(deps): bump atlassian/gajira-create from 2.0.1 to 3.0.1	3 years ago
Wilken Rivera	077c15e9a6	Merge pull request #12129 from hashicorp/dependabot/github_actions/atlassian/gajira-login-3.0.1 build(deps): bump atlassian/gajira-login from 2.0.0 to 3.0.1	3 years ago
dependabot[bot]	15a9463030	build(deps): bump atlassian/gajira-create from 2.0.1 to 3.0.1 Bumps [atlassian/gajira-create](https://github.com/atlassian/gajira-create) from 2.0.1 to 3.0.1. - [Release notes](https://github.com/atlassian/gajira-create/releases) - [Commits](https://github.com/atlassian/gajira-create/compare/v2.0.1...v3.0.1) --- updated-dependencies: - dependency-name: atlassian/gajira-create dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	3 years ago
dependabot[bot]	5dff58d776	build(deps): bump atlassian/gajira-login from 2.0.0 to 3.0.1 Bumps [atlassian/gajira-login](https://github.com/atlassian/gajira-login) from 2.0.0 to 3.0.1. - [Release notes](https://github.com/atlassian/gajira-login/releases) - [Commits](https://github.com/atlassian/gajira-login/compare/v2.0.0...v3.0.1) --- updated-dependencies: - dependency-name: atlassian/gajira-login dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	3 years ago
Lucas Bajolet	338c95b2eb	datasource: remove packer-image-iteration The `packer-image-iteration' datasource is an undocumented, and unexported datasource, so it cannot be used by clients. Since this is dead weight, we can remove it safely from the codebase.	3 years ago
Lucas Bajolet	ccb5a22bb4	hcp: remove duplicated build registration for JSON In JSON templates, we register the builds to process on HCP at the initialisation of the Registry. However, during the HCP breakout, this code was duplicated with a slight difference for the JSON templates, and the build names were registered once during initialisation, with the expected full name, and once at the start of PopulateIteration, with the truncated name. This caused a bug when processing a template that contains a builder with both a name and a type, as both would be registered, but only one would complete, leading to the iteration being unable to complete.	3 years ago
Lucas Bajolet	14cad650ca	website: add docs for variable warning bypass opts When the options for bypassing/enabling assigned and undeclared variables were added to Packer, the website documentation for those commands and options was not updated. This commit adds some documentation for those options.	3 years ago
Lucas Bajolet	bb2384c56a	command/validate: add option to eval datasources When packer validate is invoked, it does not try to evaluate the datasources before attempting to decide if the template is valid. In many cases, this works, but sometimes it will fail as the value is unknown by the validation code. Since the validation code for all the elements of a Packer template is left to be implemented by plugins, we cannot rely on checking for unknown values everywhere, especially since the unknown references are replaced automatically by a value of the right type for the configuration expected. So, in order for such configurations to be validable, we add an extra option to packer validate, that will let users evaluate the datasources from a template.	3 years ago
Wilken Rivera	4af0619721	Merge pull request #12112 from hashicorp/amb.fix-duplicate-line Removing duplicate line of text	3 years ago
Ashlee M Boyer	991331c1fc	Removing duplicate line of text	3 years ago
Wilken Rivera	57cbe4e203	core: Update validation options for undeclared variables (#12104 ) * Update validation options for undeclared variables In an effort to help users move from JSON to HCL2 templates the support for variable definitions files are being updated to ignore undeclared variable warnings on build execution. For legacy JSON templates builds no warnings are displayed when var-files contain undeclared variables. Since preferred mode HCL2 templates is to be explicit with variable declarations - they must be declared to be used - validation for undeclared variables still warns when running `packer validate`. A new flag has been added to the validate command that can be used to disable undeclared variable warnings. * Update validation test for unused variables Example Run ``` ~> go run . validate -no-warn-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl The configuration is valid. ~> go run . validate -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } The configuration is valid. ~> go run . build -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl file.chocolate: output will be in this color. Build 'file.chocolate' finished after 744 microseconds. ==> Wait completed after 798 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ``` * Rename Strict field to WarnOnUndeclaredVar The field name Strict is a bit vague since it is only used for checking against undeclared variables within a var-file definition. To mitigate against potential overloading of this field it is being renamed to be more explicit on its usage. * command/build: Add warn-on-undeclared-var flag Now that the default behaviour is to not display warnings for undeclared variables an optional flag has been added to toggle the old behaviour. ``` ~> go run . build -warn-on-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } file.chocolate: output will be in this color. Build 'file.chocolate' finished after 762 microseconds. ==> Wait completed after 799 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ```	3 years ago
Lucas Bajolet	719c8681cd	registry: don't use datasource output for ancestry The ancestry inferral code relied on HCP datasource outputs for deciding what would be the ancestry for an image built with HCP. This brings a dependency into the hcp package, which is not really necessary as we only need a few information from those entities, hence this commit removes the full dependency on the structures, in favour of more focused data structures where we only cherry pick what is necessary for this code.	3 years ago
Wilken Rivera	606e6c48f1	internal: reorganise registry/HCP code This commit reorganises the code for both the registry/API and the Orchestrator/Registry. The main difference with the previous version is how stuff is exposed. Now we only expose a Registry interface to the outside (previously named Orchestrator), which has several implementations: null is the default, and is returned if HCP is not enabled. The other implementations being HCL/JSON, both private to the hcp sub-package. The api (previously `registry') is the set of functionality that abstracts and calls the HCP API. It was meant to be merged with the `hcp' package, but because of a dependency loop with the datasources, both are separated for now.	3 years ago
Lucas Bajolet	1cee460d0d	hcp: extract all HCP-related code to hcp package As part of the work to displace everything related to HCP from scattered places around the Packer code, we move it all to an hcp package. This in turn reduces the amount of code that the commands have to integrate, and leaves the HCP details to its own enclave.	3 years ago
Lucas Bajolet	dad07c6097	hcp: keep map of build names for hcp tracking To be able to track HCP builds during a Packer build, we need to propagate the name used for registering the build to HCP. This works out-of-the-box for JSON templates, as the build's name is always the builder's, so there's no confusion on that. For HCP templates however, there's a possibility for a template to define a name for the build, which is returned by a CoreBuild's Name() function, in addition to the source's Type/Name. The builds are registered to HCP with the source.String() function however, which does not contain the build's name. This prevents any build containing a name to work, as their name/source.String does not match. The name we registered the build with is stored in a CoreBuild as the Type attribute, but cannot be safely accessed, as builds are types within the command as packersdk.Build, which only exposes Name() for this purpose. In order to circumvent this problem, and as a way to present a prototype of solution that will likely have to be discussed before we merge it, this commit hotfixes the issue.	3 years ago
Lucas Bajolet	f3e4c2c3bb	tmp: move HCP logic to unwrap builds/post	3 years ago
Lucas Bajolet	f0d0a0e6c5	internal/registry: reverse image check condition In order to determine whether or not a build is done or needs processing, we check 3 things: 1. that its status is not done 2. that its ID is not empty 3. that it has no images linked to it The was the image check was phrased indicated that we checked for the reverse, so we reverse the naming to make it less confusing.	3 years ago
Wilken Rivera	c1cd718e0e	Update github.com/stretchr/testify to address vulnerabilities in dependencies * Resolves CVE-2022-28948 in gopkg.in/yaml.v3 Many thanks to chncaption for bubbling this vulnerability in #12908	3 years ago
Lucas Bajolet	9d9f6d3a9a	packer: try previous ver. on unavailable checksum When Packer tries to get the latest version of a plugin, it will attempt to get the latest version from a list that is picked from the list of releases, fetched directly from Github. What may happen is that a release is triggered, the assets are not yet available, including the checksum file, which is uploaded last, at the end of the release process. This causes any client that tries to get the latest version of a plugin to fail during that window, as the code will fail immediately whenever a checksum file is unavailable. To circumvent this issue, and fallback to a previous version, we acknowledge that a checksum was unavailable then trying to get the latest version, and fallback to a previous one.	3 years ago
Lucas Bajolet	0224d6e0de	plugin_test: error on missing checksum file The mockPluginGetter would always succeed in returning a file from the list of suggested releases, which does not let us test what happens when a release is not yet complete, and a checksum file fails to be fetched from the source. This commit changes this behaviour so that we get an error when a checksum does not exist, mirrorring what happens in real conditions.	3 years ago
dependabot[bot]	113bc5eea4	Bump github.com/hashicorp/hcl/v2 from 2.13.0 to 2.14.1 (#12015 ) Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.13.0 to 2.14.1. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcl/compare/v2.13.0...v2.14.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcl/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Zachary Shilton	f3a0dbc491	chore: add empty page redirects	4 years ago
Zachary Shilton	1ec6b70028	chore: stub in empty page redirects	4 years ago
Paulo Dias	8ce3aae2f7	Add packages for iso builds	4 years ago

... 2 3 4 5 6 ...

18244 Commits (6312947e796ff1817cbbcb3ec520b29232d69c9e) All Branches Search

18244 Commits (6312947e796ff1817cbbcb3ec520b29232d69c9e)

All Branches