529 Commits (40df74e95afca30ba0aa8dbfa50cfd9fdad05d88)

Author	SHA1	Message	Date
Wilken Rivera	67cd123d1c	Merge pull request #9834 from hashicorp/azr-fix-hcl2_upgrade_random_generate ... hcl2_upgrade: fix a case where the generated type is wrong	6 years ago
Wilken Rivera	0e2a3e1058	command/hcl2_upgrade: Update description text for command ... Before change ``` Usage: packer [--version] [--help] <command> [<args>] Available commands are: build build image(s) from template console creates a console for testing variable interpolation fix fixes templates from old versions of packer hcl2_upgrade build image(s) from template inspect see components of a template validate check that a template is valid version Prints the Packer version ``` After change ``` Usage: packer [--version] [--help] <command> [<args>] Available commands are: build build image(s) from template console creates a console for testing variable interpolation fix fixes templates from old versions of packer hcl2_upgrade transform a JSON template into a HCL2 configuration inspect see components of a template validate check that a template is valid version Prints the Packer version ```	6 years ago
Adrien Delorme	0f00709fb6	hcl2_upgrade: fix a case where the generated type is wrong ... when it encounters map[string]interface{} or []interface{} types, hcl2_upgrade now takes the 'most complex' entry from those in order to tell wether this is going to be a body `body {}` or an attribute `attribute = {}`. Before that the hcl2_upgrade command could be a bit random there. A way better ( but may be somewhat hard ) way to do this would be to use the actual plugins structs in order to generate the HCL2.	6 years ago
Adrien Delorme	5ba134ac5b	JSON to HCL2 (minimal best-effort) transpiler (#9659) ... hcl2_upgrade transforms a JSON build-file in a HCL2 build-file. This starts a validated Packer core and from that core we generate an HCL 'block' per plugin/configuration. So for a builder, a provisioner, a post-processor or a variable. The contents of each block is just transformed as is and basically all fields are HCL2-ified. A generated field can be valid in JSON but invalid on HCL2; for example JSON templating (in mapstructure) allows to set arrays of strings - like `x = ["a", "b"]` - with single strings - like `x="a"` -, HCL does not allow this. Since JSON does not make the distinction between variables and locals, everything will be a variable. So variables that use other variables will not work. hcl2_upgrade tries to transform go templating interpolation calls to HCL2 calls when possible, leaving the go templating calls like they are in case it cannot. Work: * transpiler * tests * update hcl v2 library so that output looks great. * update docs	6 years ago
sylviamoss	39a8dee4ea	add tests and update override example	6 years ago
Chris Gilmer	6e918c4bd3	Update test for builder output	6 years ago
Chris Gilmer	04f952a2f4	Pretty print build durations	6 years ago
Adrien Delorme	c7b35dd6bc	HCL2: add post-processors block to run multiple post-processor after a build (#9638) ... added `post-processors` block to run chained post-processors after a build. Before this, defining multiple `post-processor` blocks after provisioning steps would run them sequentially, now doing this makes them start from the build's artifact. To queue post-processors you now have to define them in a `post-processors` block. This is a breaking change.	6 years ago
Adrien Delorme	44616d3bff	refactor initialization out from packer configs + tests (#9627) ... The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost. This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too. fix #9478	6 years ago
Adrien Delorme	125178d943	core: Decode: when in HCL2 decoding mode; reset the whole struct before preparing it. (#9622) ... * core: Decode when in HCL2 decoding mode; reset the whole struct before preparing it. * HCL2: add path variables + docs & tests Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Gennady Lipenkov	553d203e68	Add yandex-import post-processor	6 years ago
Adrien Delorme	b0238e6f4a	Update build_windows_test.go	6 years ago
Adrien Delorme	d84d956e36	add language coment !	6 years ago
Adrien Delorme	a15ad19411	test builds can be 'excepted'	6 years ago
Adrien Delorme	c1c8b8d22a	complete -> recipes	6 years ago
Adrien Delorme	10e5d952ac	unquote 'cooking...'	6 years ago
Adrien Delorme	0475b0529d	tests: fix line endings in windows	6 years ago
Adrien Delorme	0deaa5d2a5	add a complete tests for builder variables + only/except	6 years ago
Adrien Delorme	7969b690de	Revert "Share build info with Provisioner and Post-Processor via HCL2 variables (#9444)" ... This reverts commit 99046c9178.	6 years ago
Adrien Delorme	3d371a2d5d	Add complete HCL2 examples + allow to name a singular build.source blocks (#9490) ... * in the examples/hcl folder * add possibility to name singular build.source blocks to differentiate their output and to filter on them	6 years ago
Sylvia Moss	99046c9178	Share build info with Provisioner and Post-Processor via HCL2 variables (#9444)	6 years ago
Adrien Delorme	6f4d79799b	add thorough test	6 years ago
Adrien Delorme	dabcc866e5	add another inspect test	6 years ago
Adrien Delorme	f98576b19e	add a basic test for the inspect command	6 years ago
Adrien Delorme	51d02f8c2d	hcl2: inspect command	6 years ago
Adrien Delorme	fb337f8867	hcl work on only/except (#9454) ... * HCL2: allow to skip a named build block too * test that excepting a build block works * test only on a named build block * add/update docs	6 years ago
Megan Marsh	42e98f15ae	make sure the no-op progress bar gets used for machine readable uis	6 years ago
Moss	4f26534072	add on-error flag option to run cleanup provisioner	6 years ago
Moss	daaeccd8b0	Skip consecutives post-processors	6 years ago
Moss	bfb9df0039	fix except flag for JSON and HCL2	6 years ago
Wilken Rivera	f672f5bd9b	command/validate: Add support for HCL2 configuration files ... * Update validate command to use FixConfig for checking against known fixers * Update validation command flag docs * Add ConfigFixer method to PackerHandler Interface * Implement ConfigFixer interface in PackerConfig * Remove all stdout messaging (i.e calls to c.Ui.Say) in the validate command. The command will only display hcl.Diagnotic messaging when there is an error or warning. HCL2 Configs ``` ⇶ packer validate docker_centos_shell_provisioner.pkr.hcl ``` JSON Configs ``` ⇶ packer validate vmware-iso_ubuntu_minimal/vmware-iso_ubuntu_minimal.json Error: Failed to prepare build: "vmware-iso" 1 error occurred: * Deprecated configuration key: 'iso_checksum_type'. Please call `packer fix` against your template to update your template to be compatable with the current version of Packer. Visit https://www.packer.io/docs/commands/fix/ for more detail. Warning: Fixable configuration found. You may need to run `packer fix` to get your build to run correctly. See debug log for more information. map[string]interface{}{ "builders": []interface{}{ map[string]interface{}{ ... // 3 identical entries "guest_os_type": string("ubuntu-64"), "http_directory": string("http"), - "iso_checksum": string("946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), + "iso_checksum": string("sha256:946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), - "iso_checksum_type": string("sha256"), "iso_url": string("http://old-releases.ubuntu.com/releases/14.04.1/ubuntu-14.04.1-server-amd64.iso"), "shutdown_command": string("echo 'vagrant' | sudo -S shutdown -P now"), ... // 4 identical entries }, }, } ```	6 years ago
Adrien Delorme	bac9c74447	packer console for HCL2 (#9359)	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Megan Marsh	ee5635722b	enable force, debug, and on-error for hcl2 builds	6 years ago
Megan Marsh	533fbc1381	Merge pull request #9139 from hashicorp/hcl2_commands_refactor ... Hcl2 commands refactor	6 years ago
Adrien Delorme	2f26168adc	ConsoleCommand.ParseArgs: don't fail if no buildfile was passed	6 years ago
Adrien Delorme	52b2151b21	go generate ./packer	6 years ago
Adrien Delorme	466358a13e	Delete command.go	6 years ago
Adrien Delorme	7ca0a80a86	remove Ui from command.MetaArgs	6 years ago
Adrien Delorme	77297e49e9	Update cli.go	6 years ago
Adrien Delorme	49c2a8cb17	update fix command with new synthax	6 years ago
Adrien Delorme	14f18f4236	dont catch signals in console, as it seems unecessary for now	6 years ago
Adrien Delorme	22a36ef97a	Move vars from Meta to cla args; this forces us to use it in GetConfigFromJSON which in turn forces us into updating console and validate	6 years ago
Adrien Delorme	534e98c4ef	pass Meta command line arguments around	6 years ago
Adrien Delorme	b35ec44d06	Update build.go	6 years ago
Adrien Delorme	e6aac8cd6f	Update build_test.go	6 years ago
Adrien Delorme	efcc6af06c	fix tests	6 years ago
Adrien Delorme	a93a45e4d3	more fixes to refactor	6 years ago
Adrien Delorme	42a05e1e80	more refactoring	6 years ago
Adrien Delorme	2ef758763f	Update build_cancellation_test.go	6 years ago
Adrien Delorme	2f63e4e79d	refactor term interrupts & have RunContext take a conf struct now	6 years ago
Adrien Delorme	532a69c968	Update command.go	6 years ago
Adrien Delorme	5290beb23e	Update cli.go	6 years ago
Adrien Delorme	a5ab87ca44	add scaffolding for the new packer command layout	6 years ago
Megan Marsh	6a682aca2e	Merge pull request #9124 from GennadySpb/yandex-export-post-processor ... [WIP] Yandex export post processor	6 years ago
nqb	be08eddd8d	remove useless comment ... -var-file allow an HCL file	6 years ago
Adrien Delorme	4047113746	Update build.go	6 years ago
Adrien Delorme	2c556ed8c0	remove clarified comment	6 years ago
Adrien Delorme	c71a792186	simplify/refactor core for build & validate	6 years ago
Adrien Delorme	7aaee62970	command/build: don't reset error code in case an error hapened	6 years ago
Adrien Delorme	5c2b8da63b	get builds from PackerConfig instead of parser ... to allow just reading the config and to not start anything. This will allow to later on run `validate --syntax-only`. Note that none of the builder/provisioner/post-processor config will be read but simply ignored. HCL2 still needs the body to be properly formatted and it should detect most syntax errors.	6 years ago
Tom Dyas	c0a6623ea2	teach HCL mode builds to honor -only and -except options (#8947)	6 years ago
Gennady Lipenkov	d5a6781fb7	Add new 'yandex-export' post-processor	6 years ago
Megan Marsh	217dcbb97f	golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago
Adrien Delorme	2af40c762b	HCL2: pass on builder type and name (#8956) ... * sets `packer_build_name` and `packer_builder_type` variables for builder provisioners and post-processors in HCL2 * allows to use the new `${source.type}` and `${source.name}` variables in HCL2 * fixes #8932 Note that the common.PackerConfig is used everywhere and was not set for HCL2, this had some implications: For #8923 you can see the issue here: dde74232f2/builder/lxd/config.go (L61-L63) More random examples of where this could cause an issue : 0785c2f6fc/provisioner/ansible-local/provisioner.go (L380-L381) b4efd13a4d/builder/amazon/ebs/builder.go (L232-L236) * [All references to PackerConfig.PackerBuildName](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L7:2&tab=references) * [All references to PackerConfig.PackerBuilderType](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L8:2&tab=references)	6 years ago
Jeff Escalante	9165be87da	packer.io prefix removal, html extension remove for in-code errors	6 years ago
Vaijanath Angadihiremath	fd21b669db	Fixing the linting errors now required for merging	6 years ago
Vaijanath Angadihiremath	c815a5df67	Fixing the Make Ci errors	6 years ago
Vaijanath Angadihiremath	645cdf1a59	Updating the modules to include update to autorest 12.4	6 years ago
Megan Marsh	f5c98a7601	make sure cli vars supercede var files (#8964)	6 years ago
Adrien Delorme	d068430abf	make sure locals are evaluated only once variables are + test this (#8918) ... fix #8898	6 years ago
Adrien Delorme	ad8dafa3bd	HCL: add tests and fixes around var-file and var args (#8914)	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	94a1f0bcb6	go fmt	6 years ago
Adrien Delorme	0a46bb9525	more precise docs	6 years ago
Adrien Delorme	b5e8750f5f	Change key/value to name/value to remain consistent with Terraform	6 years ago
Adrien Delorme	c8300b620a	allow to use hcl files as var files in HCL mode ... fix #8781	6 years ago
Adrien Delorme	d2964d59e9	document that the `-var-file` option still expects JSON files for now	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Sylvia Moss	23fa3107a3	Render variables one time on prepare method (#8727)	6 years ago
Adrien Delorme	193dad46e6	Hcl2 input variables, local variables and functions (#8588) ... Mainly redefine or reused what Terraform did. * allow to used `variables`, `variable` and `local` blocks * import the following functions and their docs from Terraform: abs, abspath, basename, base64decode, base64encode, bcrypt, can, ceil, chomp, chunklist, cidrhost, cidrnetmask, cidrsubnet, cidrsubnets, coalesce, coalescelist, compact, concat, contains, convert, csvdecode, dirname, distinct, element, file, fileexists, fileset, flatten, floor, format, formatdate, formatlist, indent, index, join, jsondecode, jsonencode, keys, length, log, lookup, lower, max, md5, merge, min, parseint, pathexpand, pow, range, reverse, rsadecrypt, setintersection, setproduct, setunion, sha1, sha256, sha512, signum, slice, sort, split, strrev, substr, timestamp, timeadd, title, trim, trimprefix, trimspace, trimsuffix, try, upper, urlencode, uuidv4, uuidv5, values, yamldecode, yamlencode, zipmap.	6 years ago
Megan Marsh	073eda76aa	remove extraneous files from when vsphere builder was a plugin, and move README into packer website as separated docs for vsphere-clone and vsphere-iso. Move option descriptions into struct code, and generate documentation directly from those structs as we do inside of the other builders	6 years ago
Megan Marsh	5bacd37014	fix pps	6 years ago
Megan Marsh	dca2c03cdb	Merge pull request #7866 from hashicorp/sharing_info ... Add new struct to Provision() method signature, allowing us to share connection and credential info generated at build time with provisioners.	6 years ago
nywilken	3d56f8ac80	command/build: Fix URL to HCL2 syntax guide ... * small typo fixes	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Moss	a0329ef196	Simplify testing template	6 years ago
Moss	7466c4fdca	Return exit code 1 when builder type is not found	6 years ago
mingsheng.su	2c513fce64	update ucloud packer	7 years ago
mingsheng.su	61f9d3a9fe	add ucloud import	7 years ago
Paul Meyer	7297d74c98	Add azure-chroot builder plugin	7 years ago
Megan Marsh	59efa0faee	rename option to error-cleanup-privisoner, which I think is clearer	7 years ago
Megan Marsh	0683bc409b	add test for error-cleanup provisioner, and fix tests by fixing null builder to use an actual none communicator instead of skipping communicator generation altogether	7 years ago
Megan Marsh	6688f436dd	Merge pull request #7960 from guidodobboletta/master ... Fix console help text	7 years ago
xiaohan.liang	f4fc9dd09a	Rewrite all files, remove sensitive information	7 years ago
Guido Dobboletta	e79d62d006	Fix text	7 years ago
Thomas Meckel	d3202497ae	First working version of virtualbox/vm builder	7 years ago
Thomas Meckel	2a531f8ad6	Merged changes from local branch	7 years ago