242 Commits (2dbfef57504d06ac27909297f2e97656956213b0)

Author	SHA1	Message	Date
Adrien Delorme	f09fd790b7	Merge branch 'master' into master	6 years ago
Adrien Delorme	1147ef9a36	Merge pull request #9291 from hashicorp/f-singular-build-source-blocks ... Allow to set source fields from a new `build.source` block	6 years ago
Adrien Delorme	6a406ffb1d	Update hcl2template/types.source.go ... Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Adrien Delorme	225081c3a6	Update hcl2template/types.source.go ... Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Adrien Delorme	b4aa71aef2	Merge remote-tracking branch 'origin/master' into pr/AdrienneCohea/9245	6 years ago
Adrien Delorme	059a782b0e	remove debug log	6 years ago
Adrien Delorme	8a13dd3073	HCL2: Make the `build`.`sources` argument list optional	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Adrien Delorme	125ffe36c3	Allow to override some source fields from the build section ... Using `hcl.MergeBodies`	6 years ago
Megan Marsh	24dd7e9dbb	Merge pull request #9257 from hashicorp/azr-hcl2-use-source-type-and-name ... HCL2: use source type and name as Name of a CoreBuild	6 years ago
Adrien Delorme	1ddf2a7d05	Update types.packer_config_test.go	6 years ago
Adrien Delorme	d431db0a38	HCL2: use source type and name as Name of a CoreBuild	6 years ago
Adrienne Cohea	6c6039798c	Add test.	6 years ago
Adrienne Cohea	6aea8ead6a	Support named builds in HCL2 templates.	6 years ago
Megan Marsh	ee5635722b	enable force, debug, and on-error for hcl2 builds	6 years ago
Adrien Delorme	1f3e85185e	Update types.packer_config.go	6 years ago
Adrien Delorme	0062160581	Update common_test.go	6 years ago
Adrien Delorme	42a05e1e80	more refactoring	6 years ago
Adrien Delorme	526d040534	document Parser.Parse better	6 years ago
Adrien Delorme	5c2b8da63b	get builds from PackerConfig instead of parser ... to allow just reading the config and to not start anything. This will allow to later on run `validate --syntax-only`. Note that none of the builder/provisioner/post-processor config will be read but simply ignored. HCL2 still needs the body to be properly formatted and it should detect most syntax errors.	6 years ago
Adrien Delorme	2df21496b3	hcl2template: let PackerConfig actually start a builder/provisioner/post-processor	6 years ago
Adrien Delorme	a3343c1848	Delete zz_retrocompat.go ... it's dead/unused code I previously though I'd need it	6 years ago
Tom Dyas	c0a6623ea2	teach HCL mode builds to honor -only and -except options (#8947)	6 years ago
Adrien Delorme	73242e8de4	make sure keyvalue and namevalue filters are using the same naming as the service being used	6 years ago
Sylvia Moss	553b1fb9f8	Add RetriedProvisioner to allow retry provisioners (#9061)	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Adrien Delorme	2af40c762b	HCL2: pass on builder type and name (#8956) ... * sets `packer_build_name` and `packer_builder_type` variables for builder provisioners and post-processors in HCL2 * allows to use the new `${source.type}` and `${source.name}` variables in HCL2 * fixes #8932 Note that the common.PackerConfig is used everywhere and was not set for HCL2, this had some implications: For #8923 you can see the issue here: dde74232f2/builder/lxd/config.go (L61-L63) More random examples of where this could cause an issue : 0785c2f6fc/provisioner/ansible-local/provisioner.go (L380-L381) b4efd13a4d/builder/amazon/ebs/builder.go (L232-L236) * [All references to PackerConfig.PackerBuildName](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L7:2&tab=references) * [All references to PackerConfig.PackerBuilderType](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L8:2&tab=references)	6 years ago
Jeff Escalante	9165be87da	packer.io prefix removal, html extension remove for in-code errors	6 years ago
Adrien Delorme	d068430abf	make sure locals are evaluated only once variables are + test this (#8918) ... fix #8898	6 years ago
Adrien Delorme	ad8dafa3bd	HCL: add tests and fixes around var-file and var args (#8914)	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	3beea4fb94	NameValues.CopyOn: don't instanciate a receiving map if there is nothing to copy over	6 years ago
Adrien Delorme	b5e8750f5f	Change key/value to name/value to remain consistent with Terraform	6 years ago
Adrien Delorme	c845436e32	KeyValues.CopyOn: make sure a receiving nil map is set too	6 years ago
Adrien Delorme	87d6b2433f	make generate	6 years ago
Adrien Delorme	6e6490d688	WIP	6 years ago
Adrien Delorme	af38430eb8	add kvfilter type that regroups very frequently used filters	6 years ago
Adrien Delorme	9e6d5da277	hcl2: add general kv store that could be used anywhere	6 years ago
Adrien Delorme	c9ec967205	better testing	6 years ago
Adrien Delorme	710ebdcef5	add more test for var files	6 years ago
Adrien Delorme	c8300b620a	allow to use hcl files as var files in HCL mode ... fix #8781	6 years ago
zac	79f1fab836	hcl2template/types: add spaces in error messages. (#8881)	6 years ago
Megan Marsh	e518a0a8b7	Merge branch 'master' into update_go-cty_regex	6 years ago
Adrien Delorme	0c45bd8b4f	import new replace and regex replace funcs from go-cty + documentation	6 years ago
Adrien Delorme	631f402d1e	Merge branch 'master' into fix_8730	6 years ago
Adrien Delorme	0ccff0d5b9	all variables must have a value. ... A variable's default value can be set to null to force user to set it.	6 years ago
Adrien Delorme	6d8cce501e	tweak validation & add tests	6 years ago
Wilken Rivera	9403b48a52	hcl2template/types.variables: Update logic for parsing literal value variables (#8834) ... * hcl2template/types.variables: Update logic for parsing literal value variables In running tests via the CLI it was determined that when using the variable block with no explicit type assigned the type of the default value was not being set within the map. This change updates the `decodeConfig` method so that a type is always set for any defined variable if not specified. The second change is to properly handle the evaluation of basic variable types (e.g String, Number, Bool). Previously variables defined on the CLI or via PKR_VAR required some additional quoting to for proper evaluation. This change fixes that issue so that it works like it does in Terraform :) Build results before the change ``` ⇶ PKR_VAR_example='["one","two"]' ~/bin/packer build -var 'foo=home' . Error: Variables not allowed on <value for var.foo from arguments> line 1: (source code not available) Variables may not be used here. ==> Builds finished but no artifacts were created. ``` Build results after the change ``` ⇶ PKR_VAR_example='["one","two"]' ~/bin/packer build -var 'foo="home"' . null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell885249462 null: two null: home Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ⇶ ~/bin/packer build -var 'foo=home' -var 'example=["one","another variable"]' . null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell123467506 null: another variable null: home Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ``` * tests/hcl2template/types.variables: Update test to use Bool Turns out a string value won't actually complain if it's given a non string looking value. It will just covert the value to a string literal so using a type Bool which should fail if given anything that is not true or false. * tests/hcl2template/types.variables: Update unit tests During testing it was found that by default the variable stanza were defaulting to a cty.NilType, and not the Type of it's default value. This change sets the default type of the defined variable to ensure variable evaluation behaviors correctly. * Add a simple cty.Bool test case * tests/hcl2template/types.variables: Enable quoted_string test case * Update hcl2template/types.variables.go space Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	6 years ago
Adrien Delorme	e9d3826219	variables: use Range instead of Block ... because a variable can be defined in the Locals block	6 years ago
Adrien Delorme	9b649594c6	update tests	6 years ago
Adrien Delorme	8482c6c2e6	evaluateLocalVariable: also pass the variable name	6 years ago
Adrien Delorme	bd3112fa7c	parseLocalVariables: simplify loop	6 years ago
Adrien Delorme	23b940dbd5	fix this !	6 years ago
Adrien Delorme	e851050774	don't force to set unused variables too	6 years ago
Adrien Delorme	382f209b07	Update types.packer_config.go	6 years ago
Adrien Delorme	59cc246942	Merge remote-tracking branch 'origin/master' into fix_8730	6 years ago
Adrien Delorme	50896d4ddf	WIP	6 years ago
Sylvia Moss	591b684f08	Fix HCL2 local variables decoding to allow local usage within another local in the same locals block (#8755)	6 years ago
Adrien Delorme	a8fcb2d91a	HCL2: add support for dynamic blocks, document for loops and splat expressions (#8720)	6 years ago
Adrien Delorme	52e5b7051e	Update mock.go	6 years ago
Adrien Delorme	3c213e6eaf	continue and realise and unused undefaulted value triggers an error	6 years ago
Adrien Delorme	cebfb1c735	give correct error when variable is unset	6 years ago
Adrien Delorme	79867ca26e	add test for unset variable	6 years ago
Adrien Delorme	00c812cfe8	insert "github.com/zclconf/go-cty/cty/json" encoding beforce hcl decoding things to make sure tests are working similarly as real life version	6 years ago
Adrien Delorme	1ec68cac23	refactor prepare into MockConfig	6 years ago
Sylvia Moss	2981fd627d	Avoid calling CoreBuild.Prepare(...) for HCL2 templates (#8742)	6 years ago
Adrien Delorme	4b10c5a87c	try to reproduce #8730 in tests	6 years ago
Adrien Delorme	193dad46e6	Hcl2 input variables, local variables and functions (#8588) ... Mainly redefine or reused what Terraform did. * allow to used `variables`, `variable` and `local` blocks * import the following functions and their docs from Terraform: abs, abspath, basename, base64decode, base64encode, bcrypt, can, ceil, chomp, chunklist, cidrhost, cidrnetmask, cidrsubnet, cidrsubnets, coalesce, coalescelist, compact, concat, contains, convert, csvdecode, dirname, distinct, element, file, fileexists, fileset, flatten, floor, format, formatdate, formatlist, indent, index, join, jsondecode, jsonencode, keys, length, log, lookup, lower, max, md5, merge, min, parseint, pathexpand, pow, range, reverse, rsadecrypt, setintersection, setproduct, setunion, sha1, sha256, sha512, signum, slice, sort, split, strrev, substr, timestamp, timeadd, title, trim, trimprefix, trimspace, trimsuffix, try, upper, urlencode, uuidv4, uuidv5, values, yamldecode, yamlencode, zipmap.	6 years ago
Sylvia Moss	08b0bd1d2c	Fix HCL2 code generation for slices within another slice (#8669)	6 years ago
nywilken	d2a9e6b32e	Format code with `gofmt -s -w`	6 years ago
Adrien Delorme	2d1a67c6cb	hcl2: allow to optionnaly name provisioners and post-processors	6 years ago
Adrien Delorme	13ea97a1df	mapstructure-to-hcl2: make basic named types pointers ( optional )	6 years ago
Adrien Delorme	d8c3385814	hcl2template/mock.go: add fields with named types	6 years ago
Adrien Delorme	79d7b3e636	regroup duplicate error message	6 years ago
Adrien Delorme	0102f5b6fa	remove unecessary inexistant block panic + add test ... the hcl library will error for us	6 years ago
Adrien Delorme	219c80b1e6	better empty folder test	6 years ago
Adrien Delorme	aad90842b4	add test case and fix the breaking ones	6 years ago
Adrien Delorme	d8c33bc59e	HCL: deshadown warnings from Parser.Parse ... the func would return when `diags.HasErrors()` but this does not mean that diags is empty.	6 years ago
Adrien Delorme	5ef1893b00	fix crash when build.sources is set to an invalid name ... the `build` body doesn't have any labels and we were trying to display those. I also added a test.	6 years ago
Megan Marsh	5bacd37014	fix pps	6 years ago
Megan Marsh	dca2c03cdb	Merge pull request #7866 from hashicorp/sharing_info ... Add new struct to Provision() method signature, allowing us to share connection and credential info generated at build time with provisioners.	6 years ago
Megan Marsh	25711ed7d0	make HCL2 respect the new builder-returned generated vars list	6 years ago
Adrien Delorme	ee2d74ce9e	hcl2template/common_test.go: make testParse a helper (#8495) ... so that when an error happens we see the real calling function	6 years ago
Adrien Delorme	bc49234930	remove old untrue comment	6 years ago
Adrien Delorme	50fb1148b4	wip	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	4479f73995	uncomment duplicate check tests	7 years ago
Adrien Delorme	0e4fec03d7	make complete tests files link as windows can't handle synlinks	7 years ago
Adrien Delorme	21a0cbffba	fmt	7 years ago
Adrien Delorme	2b0e0d4eab	add hcl2template pkg ... Package hcl2template defines code to parse hcl2 template files correctly. In order to configure a packer builder,provisioner,communicator and post processor. Checkout the files in testdata/complete/ to see what a packer config could look like.	7 years ago