306 Commits (2cdc052d7c2920068d0ebca61e6c55698ec96192)

Author	SHA1	Message	Date
Megan Marsh	b05fd9303e	document that users must re-apply packer defualts for drive and device arguments	6 years ago
Megan Marsh	3e35630d8d	remove slashes to prevent windows test fails	6 years ago
Megan Marsh	8e632866b1	typo	6 years ago
Megan Marsh	b54b778572	major refactor of the step_run. Splits step into two major parts: ... - generating defaults - overriding defaults with user args The default generation has been shuffled around some, in order to make sure that any changes to a specific arg happen in one place to make it easier to reason about those args. Related args have been moved close to one another. The deviceArgs and driveArgs were overly complex after several layers of copy/paste modifications. Careful pruning reduced the layers of logic and repeated code, to help make it easier to reason about.	6 years ago
Lik	bdb1c47532	Pass QemuImgArgs to stepConvertDisk (#10001)	6 years ago
Megan Marsh	b7b43a41f3	review cleanup	6 years ago
Megan Marsh	1d218d9e65	add QemuImgArgs option to set specialized flags in qemu-img ... convert, resize, and create commands. Add tests. Refactor steps to not require config pulled from statebag.	6 years ago
Megan Marsh	1052733fca	Skip qemu-img convert if format of output file matches format of input file. ... This works around an osx bug in qemu-img convert in osx.	6 years ago
Megan Marsh	83ee4e7d13	miscellaneous qemu cleanup. Fix generator strings; generate code ... fix diskimage logic linting fix tests	6 years ago
Megan Marsh	3577c4a283	refactor multistep array construction in qemu builder to push majority of conditionals into their steps rather than the multistep constructor code.	6 years ago
Megan Marsh	9ac76be190	clean up step_run	6 years ago
Megan Marsh	5b714497e6	qemu: split config and config tests into their own files to match best practices from other builders	6 years ago
Megan Marsh	6c0c603fbf	stub out test	6 years ago
Megan Marsh	e00f6afff8	Merge pull request #9918 from hashicorp/fix_7408 ... skip compaction when backing file is used, to prevent conversion that…	6 years ago
Megan Marsh	e723609ef1	regenerate hcl config	6 years ago
Megan Marsh	9140985ab0	implement cd_files for qemu builder	6 years ago
Andreas Botzner	3739970b84	Adds ability to specify interfaces for http_directroy and VM for the Proxmox builder (#9874) ... Adds two config options to the Proxmox builder: ``` http_interface vm_interface ``` Both give the user the ability to specify an interface whos IP will be set as the `.HTTPIP` and VMIP respectively. This is useful when the VM and or the machine executing Packer has multiple interfaces. Until now Packer would accept the first non-loopback IP as the `.HTTPIP` and VMIP. I'm open to suggestions and any kind of feedback. * Added ability to define the NIC where the HTTPIP is taken from. * Added VM interface config option * fmt and documentation * Moved HTTPInterface into HTTPCommon * Build Fix * Documentation Fix	6 years ago
Megan Marsh	0a02bd5b2a	skip compaction when backing file is used, to prevent conversion that would make backing file pointless	6 years ago
Wilken Rivera	0719f906d4	Replace if/else with simple if (#9913)	6 years ago
Richard Turc	b4ff0ea4bc	[builder/qemu] Skip resize step when skip_resize_disk is enable #9860 (#9896) ... * [builder/qemu] Skip resize step when skip_resize_disk is enable #9860 * Update builder/qemu/builder_test.go Improve the code quality Co-authored-by: Wilken Rivera <dev@wilkenrivera.com> * Update files for unit tests Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Ronald van Zantvoort	7335695c84	qemu vnc: hardcoded lowerbound leaves negative ports ... ```hcl2 vnc_port_min = 5000 vnc_port_max = 5500 ``` Build returns faulty: ``` qemu.one: view the screen of the VM, connect via VNC to vnc://127.0.0.1:5138 (...) 2020/09/06 19:09:52 packer-builder-qemu plugin: Qemu stderr: qemu-system-x86_64: -vnc 127.0.0.1:-762,password: can't convert to a number: -762 ```	6 years ago
sylviamoss	fc2e94554a	add qemu hcl examples	6 years ago
Megan Marsh	a687d6fe12	ci/tech-debt: Fix vmware acceptance tests (#9636) ... * add kex algorithm option to ssh config * regenerate code * This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts: 1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed. 2) It modifies logic in reading and defaulting hardware config values, which was crashing. 3) It adds a new acceptance test with a preseed file to test loading from an http directory.	6 years ago
Roger Hu	28f8241a05	update generated files	6 years ago
Megan Marsh	673858a63c	Merge pull request #9513 from hashicorp/undocument_ssh_temp_key ... Undocument ssh options not used by all builders	6 years ago
Lyle Franklin	a4d1afb83a	Add 'cdrom_interface' option to QEMU builder (#9483) ... - This option allows the user to select the interface type for the CDROM drive, e.g. `virtio-scsi`, rather than the default `virtio` - Background: Installation of Ubuntu 20.04 on ARM64 fails as it can't mount the installation CDROM. While the default `virtio` CDROM fails, setting `cdrom_interface: virtio-scsi` with this PR succeeds. Some links: - ISO link: http://cdimage.ubuntu.com/ubuntu-legacy-server/releases/20.04/release/ubuntu-20.04-legacy-server-arm64.iso - https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1605407 - https://superuser.com/a/1376628/230508	6 years ago
Moss	8ea64c5b35	undocument ssh_keypair_name and ssh_agent_auth	6 years ago
Moss	41edd09d3c	undocument temporary_key_pair_name and ssh_private_key_file	6 years ago
Megan Marsh	cd5cf77998	only set up localhost port forwarding if skipnatmapping is false.	6 years ago
Megan Marsh	4f77bb0c4a	add new ssh_ciphers option	6 years ago
Megan Marsh	4178625afb	re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.	6 years ago
Joshua Foster	d35f342319	add the ability to configure the http bind address. defaults to 0.0.0.0.	6 years ago
Sylvia Moss	ce45a1990a	Refactor communicator config for Qemu and add SkipNatMapping option (#9307)	6 years ago
Megan Marsh	8a9833f5b1	Merge pull request #9287 from rgl/feature-qemu-add-timeout-wait-for-ip-address ... builder/qemu: timeout waiting for the guest to become available in the network bridge	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Adrien Delorme	0fa60c68fb	Drop the iso_checksum_type & iso_checksum_url fields (#8437) ... * Drop the iso_checksum_type & iso_checksum_url fields In favor of simply using iso_checksum that will know what to do. * fix after master merge * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * remove checksum lowercasing tests * Update builder_test.go * Update builder_test.go * better docs * Update builder_test.go * even better docs * Update config.go * Update builder_test.go * Update step_create_vmx_test.go * make generate * better docs * fix imports * up tests * Update _ISOConfig-required.html.md * Update builder_test.go * don't use sha1.Sum("none") as a caching path * Update builder_test.go * better docs * Update iso_config_test.go remove ISOChecksumType/ISOChecksumURL references * Update step_download_test.go * add iso_checksum_url and iso_checksum_type fixers + tests * add concrete examples of checksum values * add examples of checksumming from local file * update go-getter dep * up deps * use new go-getter version * up ESX5Driver.VerifyChecksum: use go-getter's checksumming * ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum * Update iso_config.go * get go-getter from v2 branch * Update driver_esx5.go add more comments * Update driver_esx5.go * show better error message when the checksum is invalid * Update builder_test.go put in a valid checksum to fix tests, checksum is md5("packer") * Update builder_test.go test invalid and valid checksum * more test updating * fix default md5 string to be a valid md5 * TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming * Update iso_config_test.go * Update iso_config_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update CHANGELOG.md * Update CHANGELOG.md * Update go.mod * Update go.mod * Update CHANGELOG.md	6 years ago
Rui Lopes	4839b9189d	builder/qemu: timeout waiting for the guest to become available in the network bridge	6 years ago
Megan Marsh	082d806b1f	fix httpip acquisition	6 years ago
Rui Lopes	06fad6cc4f	qemu: add support for using a network bridge	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Sylvia Moss	b0c7fe491c	Remove net_device prepare validation (#8979)	6 years ago
Megan Marsh	6008f911fd	Merge pull request #8847 from takaishi/support-keyboard-interactive ... communicator/ssh: support keyboard-interactive auth to connect bastion	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Wilken Rivera	7b705545d9	docs: Various doc clean-ups to fix code block formatting and syntax highlighting (#8868)	6 years ago
Wilken Rivera	66ad6f3483	builders: Fix gosimple S1007 linting issue (#8871) ... Results before change ``` ⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007 builder/alicloud/ecs/image_config.go:208:9: S1007: should use raw string post-processor/vsphere-template/step_mark_as_template.go:130:8: S1007: shape twice (gosimple) builder/azure/arm/config.go:58:27: S1007: should use raw string (`...`) builder/azure/arm/config.go:59:27: S1007: should use raw string (`...`) builder/qemu/driver.go:192:15: S1007: should use raw string (`...`) ``` Results after change ``` ⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007 ```	6 years ago
Wilken Rivera	e1a46ec293	Fix gosimple S1025 linting errors (#8838) ... Remove unneeded use of fmt.Sprintf for variables that are already strings.	6 years ago
Megan Marsh	dde74232f2	Clearly document all template-engine-enabled options (#8770)	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago