364 Commits (2bdfd53756611eafed685a4edced00aa1011de4e)

Author	SHA1	Message	Date
Paul Meyer	5ea90fea5b	Merge pull request #10210 from sumit-kalra/master ... [builder/azure-arm] Create keyvaults with SoftDelete enabled	6 years ago
Simon Gottschlag	65b7d3b604	Add Azure CLI authentication (#10157) ... Adds the ability to use an active `az login` session for authenticating the Azure builder	6 years ago
Sumit Kalra	2b69a5f496	azure-arm builder: Create keyvaults with SoftDelete enabled	6 years ago
Megan Marsh	72fd763207	fix crash	6 years ago
Adrien Delorme	f5e037e8b4	Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp	6 years ago
Wilken Rivera	a1d69bfe91	Fix liniting issues	6 years ago
Wilken Rivera	afd33679f5	builder/azure_arm: Fix build failures due to the deletion of attached managed disks ... Previously (prior to v1.6.2) the Azure ARM builder had two delete functions one that would run before any of the StepDelete* types, and one on deployment template cleanup. The refactored coded re-introduces the logic from the previously removed step in v1.6.1 as the main delete logic for the whole deployment template. Ensuring that all deployed items are deleted before trying to remove any managed disks. This change moves all the deletion logic into the step_deployment_template#Cleanup function to ensure that dependent steps are only called once the created deployment items (i.e StepDelateAdditionalDisks) have been deleted. Test results before change ``` compute.DisksClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="OperationNotAllowed" Message="Disk pkrdd02e9rzzu5k-1 is attached to VM /subscriptions/1f90521a-24f6-4758-ac3d-88d869fb0bf5/resourceGroups/packer-acceptance-test/providers/Microsoft.Compute/virtualMachines/pkrvm02e9rzzu5k." --- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (454.00s) FAIL FAIL github.com/hashicorp/packer/builder/azure/arm 454.008s ``` Test results after change ``` --- PASS: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (563.56s) ``` Closes #10070	6 years ago
Megan Marsh	70cb4097e1	review comments, add plugin type for a few missing builders	6 years ago
Wilken Rivera	a2ba700ac0	Remove deprecated object ids from configs	6 years ago
Adrien Delorme	522d122858	regen all code	6 years ago
Wilken Rivera	1621ab59d8	tests/azure/arm: Update test image name (#10133) ... I've run into a few cases where running the full test suite for the ARM builder would fail because of conflicting image names. This is a workaround for now the bigger fix is to have the acceptance clean up any created images. Results before change ``` the managed image named testBuilderAccManagedDiskWindows-1603151855 already exists in the resource group packer-acceptance-test, use the -force option to automatically delete it. --- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group (0.66s) ``` Results after change ``` PASS ok github.com/hashicorp/packer/builder/azure/arm 2431.115s ```	6 years ago
Adrien Delorme	54032d6c11	gen code and docs	6 years ago
Wilken Rivera	c7ba5c9a14	Fix line ending issues for test files (#10096)	6 years ago
Braunson	b2047bd938	Put the correct AzureTags type in StateBag (#10014) ... Azure expects the tags format to use a pointer to the string for the map value. The configuration from the builder is not a pointer so when storing in the state bag for reference in later execution we convert it when creating the StateBag. Fixes #10012 and #10013. * Use the MapToAzureTags helper and error check in resource group creation * Added test case for tag values not using a pointer * test/azure/arm: Add test to verify tags stored in state * test/azure/arm: Add azure_tags to existing acceptance test for Linux Test Before Fix ``` --- FAIL: TestBuilderAcc_ManagedDisk_Linux (1.81s) panic: interface conversion: interface {} is map[string]string, not map[string]*string [recovered] panic: interface conversion: interface {} is map[string]string, not map[string]*string FAIL github.com/hashicorp/packer/builder/azure/arm 1.822s ``` Test After Fix ``` 2020/09/29 17:23:03 ui: ==> test: Resource group has been deleted. --- PASS: TestBuilderAcc_ManagedDisk_Linux (517.41s) PASS ok github.com/hashicorp/packer/builder/azure/arm 517.426s ``` Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Adrien Delorme	654fade0a9	azure arm: make map[string]*string => map[string]string to simplify things (#9985) ... * azure arm: make map[string]*string => map[string]string to simplify things * go generate ./builder/azure/... * tests ! fix #9984	6 years ago
Sylvia Moss	ba74602d63	Allows publishing to a Shared Image Gallery with a different subscription id (#9875)	6 years ago
Wilken Rivera	55812fe8a5	Handle error of deferred deletion	6 years ago
Wilken Rivera	5700f74c8c	Handle lease not present error	6 years ago
Wilken Rivera	d91839b93e	Update deletion logic for OS disks ... * Add an ResourceNotFound error check * Add logic to break temporary disk lease before deleting it	6 years ago
Wilken Rivera	ba6d11d518	Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup	6 years ago
Wilken Rivera	aed97e1a8b	Ensure any active leases are brokend before deleting	6 years ago
Wilken Rivera	920da9d0a4	Fix up code to remove some additional steps	6 years ago
Wilken Rivera	7c28d5590c	Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup	6 years ago
Megan Marsh	4964c54f60	update docs to state resource id must be fully qualified	6 years ago
Megan Marsh	aede34079d	provide more helpful error message than the one returned by the client, without context	6 years ago
Megan Marsh	a687d6fe12	ci/tech-debt: Fix vmware acceptance tests (#9636) ... * add kex algorithm option to ssh config * regenerate code * This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts: 1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed. 2) It modifies logic in reading and defaulting hardware config values, which was crashing. 3) It adds a new acceptance test with a preseed file to test loading from an http directory.	6 years ago
Megan Marsh	8964367eb5	Merge pull request #9603 from paulmey/disable-password ... [azure-arm] Disable ssh password authentication unless password is explicitly specified	6 years ago
Paul Meyer	708ca1c126	Add some error checking	6 years ago
Paul Meyer	deca28c158	Disable password auth on ssh key Linux builds	6 years ago
Roger Hu	28f8241a05	update generated files	6 years ago
Megan Marsh	d4a7dd24d9	fix link in deprecation warning (#9544)	6 years ago
Moss	8ea64c5b35	undocument ssh_keypair_name and ssh_agent_auth	6 years ago
Moss	41edd09d3c	undocument temporary_key_pair_name and ssh_private_key_file	6 years ago
Wilken Rivera	8d209caf34	Fix spacing and line endings	6 years ago
Arsenii Petrovich	f3c33f9a27	remove spaces	6 years ago
Arsenii Petrovich	c2f352ee6e	Update JSONs to fix tests and make them work with the latest URL changes	6 years ago
Megan Marsh	4f77bb0c4a	add new ssh_ciphers option	6 years ago
Megan Marsh	4178625afb	re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.	6 years ago
Jeff Escalante	9a38fbe2c7	patch source for a couple code block changes	6 years ago
Feiyu Shi	1c1991c073	fix a bug	6 years ago
Feiyu Shi	f86f5b958a	Merge remote-tracking branch 'origin/master' into identity	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Feiyu Shi	fdb0b2ab03	Revert "validate if user assigned identity exists" ... This reverts commit 9bd19df040.	6 years ago
Feiyu Shi	3fdab998f8	check error	6 years ago
Feiyu Shi	9bd19df040	validate if user assigned identity exists	6 years ago
Feiyu Shi	3e3fdaa24e	make generate	6 years ago
Feiyu Shi	f7f033a7fd	add config validation test	6 years ago
Feiyu Shi	10b0a4548f	add identity resource id validation	6 years ago
Feiyu Shi	7c1a62dfed	set identity field in the template	6 years ago
Feiyu Shi	b5b2982772	add user_assigned_managed_identities to the config	6 years ago