Commit Graph

883 Commits (2bdfd53756611eafed685a4edced00aa1011de4e)

Author SHA1 Message Date
Lars Lehtonen e5e2bfa83f
builder/amazon/common: remove nil check on slice, len() on nil slices is zero
7 years ago
Megan Marsh 6191b9c8c6
Merge pull request #8288 from hashicorp/fix_8271
7 years ago
Megan Marsh d084cd1895 Update builder/amazon/common/ami_config.go
7 years ago
Megan Marsh e9f02e44cb add test to catch this case
7 years ago
Megan Marsh 7cf47fc463 add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build
7 years ago
Megan Marsh e2283445f2 need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly.
7 years ago
Megan Marsh 7928b5b045 fix transcription error from when we moved to generated docs
7 years ago
Megan Marsh b9245a402d add structure to its own struct to make generated code stop complaining
7 years ago
Megan Marsh 5614f307fb regerate code
7 years ago
Megan Marsh d15f43e4eb
Merge pull request #8232 from hashicorp/artifact-tree
7 years ago
Bernard Baltrusaitis ec1d70dc44 adding required changes
7 years ago
Bernard Baltrusaitis 65d1447b64 adding formatting
7 years ago
Bernard Baltrusaitis 6e2146324f Merge branch 'master' of github.com:b-b3rn4rd/packer
7 years ago
Bernard Baltrusaitis 8b83cca064 adding temporary instance profile document policy
7 years ago
Adrien Delorme 078ba7c8c3 commit old code generation tool
7 years ago
Adrien Delorme 221e72e9c3 builder.amazon.common: remove pointer (*) from []*string and map[*string]*string types
7 years ago
Megan Marsh 0e70e0e5a4 fix template imports
7 years ago
Megan Marsh 44f91c9afc Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"
7 years ago
Adrien Delorme d4600a7716 fix go imports
7 years ago
Megan Marsh 0026792d2f remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name
7 years ago
Megan Marsh e16fb19bfc don't abort on a single error if another availability zone was able to create the instance
7 years ago
Megan Marsh eccf0fb51d update docs
7 years ago
Megan Marsh e047b97bf7
Merge pull request #8162 from hashicorp/fix_8154
7 years ago
Megan Marsh ac6e7a4800 updates tests to validate that ssh_host value supplied in the template overrides all else
7 years ago
Adrien Delorme 941dc394f0 Update step_run_spot_instance.go
7 years ago
Adrien Delorme d049284120
Update builder/amazon/common/step_run_spot_instance.go
7 years ago
Adrien Delorme 07e97e26de
step_run_source_instance.go: make sure we use the right ShouldRetry error
7 years ago
Megan Marsh c722009159 we only need one describeInstances call, not 3, and it should be wrapped in a retry
7 years ago
Megan Marsh e47059aaca put retry around describeinstances call in amazon
7 years ago
Megan Marsh 31bb1e818f fix tests
7 years ago
Megan Marsh 0cbd3ff0f3 make sure amazon builders respect ssh_host option
7 years ago
Megan Marsh 72d393c95a update docs to show a use case for block device mappings
7 years ago
Adrien Delorme 4fb05e5bc4 fix test
7 years ago
Adrien Delorme 849de792da re-apply doc changes of master
7 years ago
Adrien Delorme 3fe9d52e3f Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
7 years ago
Adrien Delorme 4d4bd38afa
Merge pull request #8087 from hashicorp/fix_8048
7 years ago
Megan Marsh 9503802814 adding ctx makes the cancel channel redundant
7 years ago
Megan Marsh 4b497006b3 add retry wrapper to query so it handles rate limiting
7 years ago
Adrien Delorme de9bb26f62
Merge branch 'master' into fix_7959
7 years ago
Adrien Delorme 9f8e9893b3 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
7 years ago
Adrien Delorme 86cee5cbef
Merge pull request #8034 from cove/retry-describe-instances
7 years ago
cove 87e0a3b5e7 add prevalidating AMI name retries so the build doesn't fail when throttled
7 years ago
Adrien Delorme 9d0bc476d9 add ommited struct interpolation
7 years ago
Adrien Delorme 5517d41468 make sure all documentation fields are there
7 years ago
Adrien Delorme 2efc94521b use trilean initializers in test where missing
7 years ago
Megan Marsh 6a895db9be converte block device encryption to trilean
7 years ago
Megan Marsh 1d9bba6fe3 change AMIEncryptBootVolume to trilean
7 years ago
Megan Marsh 1a6adadb89 convert EnableAMIENASupport to trilean in code
7 years ago
Megan Marsh 3c3f7f26ce implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool.
7 years ago
Adrien Delorme 4cb7c30987 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
7 years ago
Megan Marsh 4aa33306cb make sure that fleetId exists before trying to stick it into error message
7 years ago
Megan Marsh 316a30b31d fix spot_tags
7 years ago
Megan Marsh 9f6d14c75a work around spot_tags related regression and bad fleet cleanup in spot instances
7 years ago
Megan Marsh b42701380c add test for nil case
7 years ago
DanHam 088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag
7 years ago
Christian Muehlhaeuser 216afbaa8b
Fixed various typos
7 years ago
Megan Marsh 54d2ad5028 refactored step_ami_region_copy to fix bugs and clarify assumptions; added more tests for that step.
7 years ago
Megan Marsh 39a4da4d07 add code to deduplicate the region list, and to make sure that the original region's kms key id is in the map.
7 years ago
Megan Marsh 6ad975f296 Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct"
7 years ago
Megan Marsh 42611e6004 fix build
7 years ago
Megan Marsh a60f7e395e add a test to make sure we don't error becaue of spot price auto product, yet
7 years ago
Megan Marsh c722afe707 stop calculating spot bids; amazon changed the way spot instances are priced to be stable rather than bid-based, so when user sets auto, we can just default to the ondemand price and know that they'll get the same price as everyone else bidding at that time.
7 years ago
Daniel Rodgers-Pryor 8a9753032c Allow EC2 fleet packer instances to run in parallel
7 years ago
Adrien Delorme 433c40d72d make block device example less specific
7 years ago
Adrien Delorme 9f4c8fb321 document ebs builder using partials
7 years ago
Adrien Delorme a476ab79d7 document chroot builder using partials
7 years ago
Adrien Delorme dcc22df609 aws: move the OmitFromArtifact field in ebssurrogat where it's being used
7 years ago
Adrien Delorme a86aae1c7e mode KmsKeyId to chroot block device, as it's only used there
7 years ago
Adrien Delorme 9989845ada add BuildEC2BlockDeviceMapping func to the BlockDevice type
7 years ago
Adrien Delorme c696878d2e aws block devices mapping: BlockDevices.Build -> BuildEC2BlockDeviceMappings()
7 years ago
Adrien Delorme ff2e0298ba simplify block devices utilisation by removing intermediary types
7 years ago
Adrien Delorme 78b29d1a74 up AMIBlockDevices docs
7 years ago
Megan Marsh 305592d8ed fix copy logic and tests
7 years ago
Megan Marsh 8cc82ca8d2 add broken test
7 years ago
Megan Marsh 0d55bc46ee add skip_save_build_region flag to fix naming conflicts when building for multiple regions
7 years ago
Adrien Delorme daa9f9d34e Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
7 years ago
Megan Marsh 1c3b234b55
Merge pull request #7737 from hashicorp/document_retry
7 years ago
Adrien Delorme 6e3dc1aa9a Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
7 years ago
Adrien Delorme 98206d59d7 aws: step_create_tags make the max waiting time 30s and not 30ns
7 years ago
Pratyush Singhal d92e82c43f refactor: replace the maxBackoff from 30 nanosecond to 30 seconds
7 years ago
Pratyush singhal d4b0cb68e3 feat: add retry for temp key-pair generation in amazon-ebs
7 years ago
Adrien Delorme 8e857d64f1 aws: rewrap struct comments for documentation generation
7 years ago
Adrien Delorme 4bf6a56d71 split communitacor.SSH & communitacor.WinRM to facilitate documentation
7 years ago
Adrien Delorme 4399684372 make fmt autogenerated docs
7 years ago
Adrien Delorme e09f3fbd02 amazon: update docs & links
7 years ago
Adrien Delorme e6cbb013ba add // go:generate struct-markdown to all previously edited files
7 years ago
Adrien Delorme f1917edd34 generate the comments for config struct of builders scraping doc website
7 years ago
Megan Marsh 3f036b33c5 test for length of ami tags before tagging
7 years ago
Megan Marsh 078d888dba
Merge pull request #7707 from CARFAX/master
7 years ago
Jason McIntosh abef9820c7 Fixed spacing on comment
7 years ago
Jason McIntosh 24a4e2f23e Updated comments
7 years ago
Jason McIntosh 24bc50ce1b Enable encrypted AMIs with custom KMS Keys
7 years ago
Megan Marsh 6786c0d641 update tests to reflect new behavior
7 years ago
Megan Marsh bda09bf7d5 the build ami is made with an intermediary name, which means that we can't skip copying even from the original build region when unencrypted
7 years ago
Megan Marsh 708165eaa8 refactoring step_run_spot_instance and swapping out the calls to create a spot instance with a call to create a spot fleet of one, so that we can be more flexible with the instance type when desired
7 years ago
Megan Marsh 1062295ecd add omit_from_artifact option for ebssurragote launch_block_devices
7 years ago
Megan Marsh 2c352cc681 add tests for step_ami_region_copy
7 years ago
Megan Marsh 8c1d0f9686 clean up temporary unencrypted AMI and associated snapshots
7 years ago
Megan Marsh c0e69a9da0 if encrypt_boot is explicitly set to false, don't copy. Also, make sure we don't cause a wait group block when we aren't performing a copy.
7 years ago
Megan Marsh 105d3f8853 delete unencrypted temporary snapshot when encrypt_boot is true. Also, fix nil map error in region copy
7 years ago
Megan Marsh 201c8c1332 make sure that you encrypt using the provided kms key id and not the default
7 years ago
Adrien Delorme d72040f4fa move retry code into the common/retry pkg and make retry context aware
7 years ago
Adrien Delorme a81abd297b Merge remote-tracking branch 'origin/master' into context_provisioner
7 years ago
Megan Marsh 3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770
7 years ago
Adrien Delorme c4f3dccc14 rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
7 years ago
Adrien Delorme a4bf94dd3c change Builder to be passed a context for cancellation
7 years ago
Adrien Delorme 9836dad0c9 introduce the clean_resource_name to clean image names and deprecate the old ones
7 years ago
Akshat Mahajan f07e4214cc Addresses issues #5384, #5494: Rename and change `temporary_security_group_source_cidr`
7 years ago
programmer04 596a9cc7ff Improve error message for AWS and Alibaba
7 years ago
Megan Marsh 3ed9fe6dee remove unused imports
7 years ago
Megan Marsh ca9a5daf29 fix proxy and tls
7 years ago
Adrien Delorme f535464097 up a test
7 years ago
Adrien Delorme f03cbd8a10 aws: allow to pass nil bool as encryption parameter
7 years ago
Adrien Delorme ce8532e94b aws: document ValidateRegion better
7 years ago
Adrien Delorme 6af621c37a aws: StepAMIRegionCopy call waitgroup.add only once
7 years ago
Michael F 01a0b0c766 kmsArnStartPattern - fix support for aws-us-gov
7 years ago
Megan Marsh 026e543b24 move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation
7 years ago
Megan Marsh 2a613dd6e9 fix up the github suggestion
7 years ago
Adrien Delorme 3ae5a912d4
Update builder/amazon/common/step_pre_validate.go
7 years ago
Megan Marsh 3704a053d0 move region validation and credential wait into step pre validate
7 years ago
Megan Marsh 8add176ab7 finish first pass at vault code; needs testing and cleanup of error messages
7 years ago
Megan Marsh 7a78b47e83 make vault engine stuff into a little struct for easier management
7 years ago
Megan Marsh 035c3506ba manually set proxyfromenvironment in default http client for ec2 sessions
7 years ago
Adrien Delorme 4a2773f8fa remove default max retries config of 8, it will now be used from env
7 years ago
Adrien Delorme 964b149df2 aws: remove now unused AccessConfig.metadataRegion
7 years ago
Adrien Delorme 335f442b51 aws: unwrap AccessConfig.region func
7 years ago
Adrien Delorme 54af9951a8 make guard clauses to clearly see success pass
7 years ago
Adrien Delorme 0864b4d07b name unclear import
7 years ago
Megan Marsh e0543246fa remove commented code
7 years ago
Megan Marsh 783ed32e7e fix region stuff
7 years ago
Megan Marsh ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
7 years ago
Tom Elliff 12bf7fc4d6 Check that the KMS key ID is valid
7 years ago
Megan Marsh 042e9ad14b Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.
7 years ago
Megan Marsh da6e350949 fix tests
8 years ago
Megan Marsh fbb3d526e3 move region validation to run so that we don't break validation when we don't have aws creds set
8 years ago
Mikhail Ushanov 536252683e builders: reuse private key file reading function
8 years ago
Megan Marsh 79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
8 years ago
Adrien Delorme 3f288fc6ca aws client: config.WithMaxRetries(8)
8 years ago
Mikhail Ushanov 4608b5d39d amazon: add option for skipping TLS verification
8 years ago
Adrien Delorme f4fbf45349 remove duplicate region check error
8 years ago
Adrien Delorme 16aa21dffe aws: better error handling of region guessing from metadata
8 years ago
Adrien Delorme ed793a8fb8 make ValidateRegion a member of *AccessConfig and make it variadic
8 years ago
Megan Marsh fe044d8ff7 fix tests
8 years ago
Megan Marsh 340009009d Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
8 years ago
Megan Marsh 0cd3f36d50 Revert "Merge pull request #6892 from hashicorp/fix_6890"
8 years ago
Megan Marsh 0924a316b7 fix template-set credentials
8 years ago
Megan Marsh 9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
8 years ago
Matt Dainty feb8067c7d Convert `ena_support` to a pointer
8 years ago
Megan Marsh 57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
8 years ago
Megan Marsh 2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
8 years ago
Megan Marsh e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
8 years ago
Mikhail Ushanov 00c96fc400 aws: use IpPermissions for authorizing temporary security group
8 years ago
Mikhail Ushanov b316be51cd aws: wait for temporary security group before authorizing
8 years ago
Megan Marsh b0cfecf314 remove unnecessary valid flag
8 years ago
Matt Dainty 9e0fae9db3 Add support to explicitly disable ENA support
8 years ago
Megan Marsh d4767845f0 fix tests
8 years ago
Megan Marsh 7c3f0aa3b2 make sure region validation catches authentication errors
8 years ago
Mikhail Ushanov ee133482b4 aws: add validation for device_name parameter
8 years ago
Megan Marsh 02bfac118f default wait time for amazon import to one hour.
8 years ago
Megan Marsh f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
8 years ago
Adrien Delorme f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
8 years ago
Megan Marsh d616f0ba71 abort if image import fails
8 years ago
Megan Marsh 79093da6ad skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock
8 years ago
Megan Marsh 93f1155a14 remove test-related special casing
8 years ago
Anshul Sharma ef3c10c403 Modify Validate Region for test cases
8 years ago
Anshul Sharma 98f13eaf29 Use DescribeRegions for aws region validation
8 years ago
Megan Marsh f4e6d06e68 reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides
8 years ago
Adrien Delorme 770f61e682 spot instance creation, only set blockDurationMinutes when > 0
8 years ago
Matt DeBoer 09797df958 use a UI wrapper to auto-decode error messages
8 years ago
Megan Marsh a0edaf6c46 Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
8 years ago
Adrien Delorme e02d0dacc4
Merge branch 'master' into aws-filters
8 years ago
Megan Marsh b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
8 years ago
Sargun Dhillon 902497d6ce Allow users to build hvm images from pv images to have ena_support
8 years ago
Megan Marsh 349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
8 years ago
Adrien Delorme 2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
8 years ago
RenaudS 26aab49aaf aws spot instances: add block_duration_minutes option (#6638)
8 years ago
Megan Marsh 4472ecccb0 fix waiters that weren't applying env defaults
8 years ago
Megan Marsh 2b9f937c23 increase max retries from 3 to 20
8 years ago
Adrien Delorme b0c09087a2 move SSHInterface/SSHIPVersion fields to communitator.Config struct
8 years ago
Adrien Delorme 0938b640cc use key pair name from config
8 years ago
Adrien Delorme ef4ca9c48e builder.amazon: use c.Comm for ssh
8 years ago
Adrien Delorme 9a9b82715b config.Comm.SSHKeyPair => SSHKeyPairName
8 years ago
Adrien Delorme 3a4bb26150 builder.aws: use key pair from comm struct
8 years ago
Adrien Delorme 293c485372 builder.aws: use SSHAgentAuth from Comm
8 years ago
Adrien Delorme ef08c441c9 builder.aws: use Comm field for StepKeyPair & StepGetPassword
8 years ago
Adrien Delorme 51d2aac9f6 SSHPrivateKey => SSHPrivateKeyFile
8 years ago
Megan Marsh b35acbd879 use statebag instead of SetSharedState for winRM password
8 years ago
Rickard von Essen 23f62f221e Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available
8 years ago
Megan Marsh fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
8 years ago
Adrien Delorme 6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls (#6622)
8 years ago
Rickard von Essen 533967cb66 builder/amazon: Add suppport for security_group_filter
8 years ago
Rickard von Essen 9840862757 builder/amazon: Add suppport for vpc_filter and subnet_filter
8 years ago
Megan Marsh ff6a039d5b replace scrubconfig with packer.LogSecretFilter.Set
8 years ago
Megan Marsh 00c6ec979f do 30 minutes not 25
8 years ago
Megan Marsh 00de0f4996 increase the timeout for waiting for an ami to become available
8 years ago
Megan Marsh 71cad4f2a9 fix tests
8 years ago
Megan Marsh 250da0ab49 fix security hole with ami filter
8 years ago
Anshul Sharma c1edcd3774
amazon-ebssurrogate clean up volumes
8 years ago
Matthew Hooker 814c1cf2b2
spellfix
8 years ago
James Nugent 9fffe4056e
Merge pull request #5452 from smaato/tag-spot-requests
8 years ago