458 Commits (26629efbf0c8100fd31ddff0d520f6ea5fdfbf9e)

Author	SHA1	Message	Date
Megan Marsh	918db58604	added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used	8 years ago
Adrien Delorme	41f6e0334d	refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc ... * still need to append the auth methods into an array for gracefullness	8 years ago
Ali Rizvi-Santiago	cf9bbe3ecf	Incorporated the hack demonstrated by @SwampDragons in order to deal with packer.rpc.Ui not exporting any information about what it's doing to anybody.	8 years ago
Ali Rizvi-Santiago	5726927cba	Moved the progress bar out of packer.Ui and unlinked it out of all the packer.Ui implementations. Split up the terminal-related functions into a separate terminal.go and calculate the progress bar width by traversing through packer.Ui to avoid the issue with github.com/ugorji/go/codec serializing private members (or unsafe pointers) of structs. Shuffled some arguments around in getConsoleScreenBufferInfo in common/terminal_windows.go so that the interface forces the user to correctly declare a _CONSOLE_SCREEN_BUFFER_INFO type.	8 years ago
Ali Rizvi-Santiago	0f10032b3d	Moved the progress bar from common to the packer.UI interface and refactored it so that the terminal width is calculated based on each interface which returns a custom progressbar specific to its ui.	8 years ago
Ali Rizvi-Santiago	fd2fef8738	Added support for the progress bar to automatically determine its width using the minimum length from a packer.UI and the terminal dimensions via kernel32.GetConsoleScreenBufferInfo or an ioctl (TIOCGWINSZ) to "/dev/tty".	8 years ago
Ali Rizvi-Santiago	16ecb3ad9a	Reverted removal of progress-bar that was done by commit 5d97b105a8 and added some missing arguments that were missed during the rebase. Modified the default progress bar's width to 80 as a result of the conversation on PR #5851.	8 years ago
Megan Marsh	ff6a039d5b	replace scrubconfig with packer.LogSecretFilter.Set ... filter winrm password from logs Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.	8 years ago
Adrien Delorme	a5587e30ec	log wether the file was transfered or is just being inplace referenced	8 years ago
Adrien Delorme	6b3844a64f	Revert "allow to use ISO images in-place v.s. copying them"	8 years ago
Adrien Delorme	c744e8b2bb	make download messages less redudant and more simple	8 years ago
Adrien Delorme	d7d4aed51c	be even more precise	8 years ago
Adrien Delorme	2b3ea29970	show more precise error download/copy/referencing messages	8 years ago
Adrien Delorme	fae3db4e58	test inplace linking	8 years ago
Adrien Delorme	17f2949e36	remove stuttering; ISOConfig.InplaceISO -> Inplace	8 years ago
Adrien Delorme	863222b1e2	Also use the terminology Inplace in DownloadConfig for clarity/consistency ... * swapped boolean checks * swapped in tests too	8 years ago
Adrien Delorme	82e480a285	allow to use ISO images inplace v.s. copying them	8 years ago
Ali Rizvi-Santiago	71e43d0b7f	Updated common/download.go to handle when a connection error happens (response is nil), and reformatted the error that's returned when an HTTP error occurs.	8 years ago
Megan Marsh	5ef8b55559	need log import	8 years ago
Megan Marsh	a2f5fbadf6	don't fail if you can't find abs or relative path.	8 years ago
DanHam	da21c25791	Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts ... grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \ xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'	8 years ago
DanHam	674bad0ab4	Break very long lines for readability	8 years ago
DanHam	d2390f464d	Actually implement the function for the driver	8 years ago
DanHam	c2437ba592	Remove the option to place the VHD files in a separate directory ... The export process now exports the VM directly from the build directory into the output directory. There are no intermediate steps or copying of files involved. This means that there is no longer any benefit in having a separate directory to house the VHD files - see #5206 for the reasoning behind the introduction of this feature. If a user wishes to house the build files on a separate disk from the output directory (perhaps for performance reasons or due to disk space limitations) they can still do so through the use of `temp_path`.	8 years ago
DanHam	c6b9d9ce90	Add checks/error reporting to compaction process ... * Report compaction results * Failure to find any disks under the supplied path is treated as a 'soft' error and a warning message will be printed in place of the compaction result. Any other failure will cause the build to fail.	8 years ago
DanHam	534fc4a473	Ensure the export directory structure matches that of previous versions ... Commit 3fc2defb6 altered the directory structure associated with an exported VM. The changes mean that the export process now stores the exported machine files and folders under a folder with name 'vm_name' in the output directory. This commit restores the previous behaviour whereby the exported machine files and folders were stored directly in the output directory. This allows us to keep the efficiency improvements introduced with 3fc2defb6 while maintaining backward compatibility. By default the Export-VM command creates three folders in the specified export directory - 'Virtual Hard Disks', 'Virtual Machines' and 'Snapshots'. When a machine with no associated snapshots is exported the 'Snapshots' directory is empty. Prior to 3fc2defb6 the Snapshots folder was not copied/incorporated into the output directory at all. This was a bug. This commit preserves the legacy behaviour by not including an empty Snapshots directory in the export. However, if there *are* Snapshots associated with the VM, they are now moved into the output directory along with the usual directories containing disks and VM metadata. This prevents warnings/errors on import due to missing snapshots.	8 years ago
DanHam	dc46848f89	Remove now redundant function to copy exported VM files	8 years ago
DanHam	3fc2defb6d	Refactor the export step for Hyper-V ISO and VMCX builders ... * Fixes a bug that caused the build to error if users did not explicitly set `skip_compaction:true` when setting `skip_export: true`. See #6392. * Improves the efficiency of the compaction and export process by reordering the compaction and export steps. * Further improves the efficiency of the compacting step through compacting the vmd* file directly rather than creating and then operating on a copy. * The changes mean the export process now stores the exported machine files and folders under a folder with name 'vm_name' in the output directory. Previously the exported machine files and folders were stored directly in the output directory.	8 years ago
Mathieu Tarral	edcc0b3853	shell-local: expose PACKER_HTTP_ADDR env var	8 years ago
Megan Marsh	0df33cd032	fix relative pathing versus iso checksum dir to work even if user has provided a relative path for the iso_url which is relative to the directory where Packer is run.	8 years ago
Megan Marsh	d0f0da6626	allow absolute paths to isos in checksum files	8 years ago
M. Marsh	e5a63a674e	Merge pull request #6422 from DanHam/fix-gh-vmsecureboot ... Hyper-V: Use Get-Command over Get-Help to check for SecureBootTemplate parameter	8 years ago
M. Marsh	baaca808e8	Merge pull request #6412 from hashicorp/fix_config_validation_bug_windows_shell_local ... found a config validation bug where packer crashes instead of throwin…	8 years ago
DanHam	297f6b85ec	Use Get-Command over Get-Help to check for SecureBootTemplate parameter	8 years ago
Simon Hulme	475e79a251	Fixed SecureBootTemplate not being passed through to PS cmdlet ... Added check for SecureBootTemplate parameter for Server 2012 and below Corrected enableSecureBootString usage	8 years ago
Megan Marsh	4a7953f93a	found a config validation bug where packer crashes instead of throwing a validation error if a windows-style path is provided to a provisioner on linux	8 years ago
Jordan Borean	efa9021974	Check if hyper-v addresses is an array before slicing it	8 years ago
Giovanni Tirloni	28095cf027	Do not return error on initial HEAD request	8 years ago
Giovanni Tirloni	b7ea0b44fc	HTTPDownloader - Fix invalid error handling	8 years ago
M. Marsh	a012f70e71	Merge pull request #6251 from hashicorp/do_winrm_shell_local ... access automatically generated winrm password from shell-local	8 years ago
Megan Marsh	3afca6905b	remove duplicate assignmnet	8 years ago
Matthew Hooker	6a769f08d8	regenerate boot command code	8 years ago
Matthew Hooker	788418cff2	Add unit test to show that we handle tars safely	8 years ago
Megan Marsh	846f94c964	implement template variable for accessing WinRM password in either environemnt variables or directly in execute_command or inline commands.	8 years ago
M. Marsh	62e1323577	Merge pull request #5956 from hashicorp/dedupe_shell_local ... Deduplicate the code for the shell-local post-processor and shell-local provisioner	8 years ago
Megan Marsh	d1e31c0f23	use if/else to clarify code	8 years ago
Megan Marsh	969201a2d4	handle minor shell-local PR suggestions and corrections	8 years ago
Megan Marsh	1fdf763d0f	fancier logging	8 years ago
M. Marsh	edb5c1f50d	Merge pull request #6243 from camjjack/hyper-v-gui ... Using vmconnect to display gui for hyper-v	8 years ago
WaaZaa666	b747877222	Fixing #6267, multiple hyper-v disks	8 years ago
Unknown	29c4b4436d	Changes requested in PR #6243 ... - Logging error if vmconnect.exe fails. - Using StepRun struct rather than StateBag for command Cancel function - Better handling in Disconnect when headless is true or vmconnect failed in Start	8 years ago
Unknown	fc734b6bd9	Using vmconnect to display gui for hyper-v ... vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.	8 years ago
M. Marsh	5871b8242b	Merge pull request #6101 from adarobin/azurecompatible ... Add use_fixed_vhd_format Hyper-V ISO option	8 years ago
Stefan Henseler	6f00596053	Adds config option to specify hyper-v secure boot template	8 years ago
DanHam	d9d8b93c14	Remove tmp file created by common/ test. Avoid possible race condition.	8 years ago
M. Marsh	7c46e3d89c	Merge pull request #6207 from gtirloni/issue-6203 ... [WIP] Handle HTTP download errors	8 years ago
Matthew Hooker	5e6e12cacd	Use fmt to convert whatever's in error to a string. ... This way we don't crash if someone sticks something else in the error key in the state bag (which a quick glance at the code tells me we're already doing. Perhaps in the future we can add an error attribute to the state bag but for now this will have to suffice.	8 years ago
Matthew Hooker	0a1842140b	Display build error when on-error=ask|abort	8 years ago
Megan Marsh	1bea658e16	fix command and inline calls on windows	8 years ago
Megan Marsh	fabd1a6517	windows cmd env vars	8 years ago
Megan Marsh	9651432378	preserver BC for people using 'command' option	8 years ago
Megan Marsh	dd183f22d9	update docs and add warnings around WSL limitations	8 years ago
Megan Marsh	51bcc7aa13	add new feature for telling shell-local whether to use linux pathing on windows; update docs with some examples.	8 years ago
Megan Marsh	e983a94a88	fix default windows bash call for shell-local provisioner and move chmod command from the execute_command array into the portion of code where we actually generate inline scripts, sparing users the need to think about this modification which Packer should really handle on its own ... make bash call work on windows	8 years ago
Megan Marsh	5da4377f21	first pass at docs update	8 years ago
Megan Marsh	854d6fb141	add tests making sure post-processor has backwards compatability	8 years ago
Megan Marsh	f799003b66	tighten up shell-local config validation	8 years ago
Megan Marsh	479d36734d	consolidate shell-local defaulting of InlineShebang and ExecuteCommand to the config validation	8 years ago
Megan Marsh	d304234725	fix tests	8 years ago
Megan Marsh	67739270bb	pull temp file writing into its own function for easier testing	8 years ago
Megan Marsh	6dc4b1cbdc	move all of the run commands for shell-local provisioner and postprocessor into common library too	8 years ago
Megan Marsh	c7c66bedcb	set inline to an empty array, rather than nil	8 years ago
Megan Marsh	926327beba	deduplicate all validation and interpolation of the shell-local config, sharing options between shell-local provisioner and post-processor. Maintain backwards compatibility with shell-local provisioner.	8 years ago
Megan Marsh	616b41e58f	deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module	8 years ago
M. Marsh	bf6dc932d5	Merge pull request #6219 from jborean93/hyper-v-ip ... Hyper-V: Add support retrieving IP for Server 2008 R2	8 years ago
DanHam	7e478f650e	Remove tmp files created by common/ tests	8 years ago
Jordan Borean	14e41fad7e	Hyper-V: Add support retrieving IP for Server 2008	8 years ago
Giovanni Tirloni	413d13c411	Handle HTTP download errors	8 years ago
Adam Robinson	3aebd5f462	Add use_fixed_vhd_format Hyper-V ISO option	8 years ago
Matthew Hooker	a3bf2c786a	Use expression sequence generator in tests.	8 years ago
M. Marsh	69c7e2d51d	Merge pull request #6144 from hashicorp/winrm_password_fix ... use build name to ensure that winrm password and other shared state i…	8 years ago
Matthew Hooker	e4bd30e53d	fix bug with empty boot command.	8 years ago
Matthew Hooker	b5a97e468f	fix test	8 years ago
Matthew Hooker	7e9af8247a	fix 2 byte scancodes for pc-xt VMs.	8 years ago
Matthew Hooker	675eae1e92	flush scancodes when we wait	8 years ago
Matthew Hooker	374d8f089f	better log message	8 years ago
Matthew Hooker	31d04f1945	remove outdated comment	8 years ago
Matthew Hooker	df6224d04e	fix vnc config	8 years ago
Matthew Hooker	aa69bdf74e	Perform validation of boot command.	8 years ago
Matthew Hooker	7d43324359	add menu key. ... Replaces #5989	8 years ago
Matthew Hooker	e9e27941cc	sort keycode lists	8 years ago
Matthew Hooker	c6299972b9	s/boot_command/bootcommand/	8 years ago
Matthew Hooker	7990966a09	fix boot command config struct name	8 years ago
Matthew Hooker	408eba88ad	flatten boot command config and implement for vmware	8 years ago
Matthew Hooker	9a8acbbcab	negative wait WIP	8 years ago
Matthew Hooker	add7e8acb9	Stop sending boot commands when context canceled.	8 years ago
Matthew Hooker	94129b7fe3	we're using PC-XT (set1) not PC-AT	8 years ago
Matthew Hooker	a46a7afa20	Remove old tests.	8 years ago
Matthew Hooker	e2e7bc65fd	Make special keys case insensitive. ... add tests	8 years ago
Matthew Hooker	cba4d3235f	cleanup	8 years ago
Matthew Hooker	bdb1eee7d8	Implement new parser for HyperV boot command	8 years ago
Matthew Hooker	f9ad264f4d	Comments	8 years ago
Matthew Hooker	81d127768c	Add key press interval to virtualbox.	8 years ago
Matthew Hooker	59376294ef	Maximize scancode throughput. ... Let's cache the scancodes and flush them at the end. Also make sure to send only as many as the driver can send correctly. It's important here to chunk the scancodes correctly, so that we don't accidentally split them over successive calls to the driver	8 years ago
Matthew Hooker	9b7704c714	Implement new parser for Parallels boot command	8 years ago
Matthew Hooker	99d61920d0	Abstract vbox driver into PC-AT driver.	8 years ago
Matthew Hooker	e4af71858f	Implement new parser for Virtualbox boot command ... Remove boot wait for virtualbox run step	8 years ago
Matthew Hooker	1c0af28662	Some cleanup and comments.	8 years ago
Matthew Hooker	673245afcf	Replace boot command parser with PEG parser.	8 years ago
M. Marsh	f5c031baf9	Merge pull request #5941 from synax/hyper-v-disk-block-size ... Adds Support to configure hyper-v disk block size	8 years ago
Stefan Henseler	b8bf421dc2	Fixes missing diskblocksize parameter for gen1 vms	8 years ago
Megan Marsh	3afb243f11	use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.	8 years ago
Seth Vargo	b17b333e29	Add a common package for specifying useragent and adopt that everywhere ... There were 5 different formats for the Packer useragent string. This fixes that and unifies it into a helper package. I did not touch oracle's user-agent, because it looked kinda special.	8 years ago
Hannu Piki	3ffaf551c0	Fixing Hyper-V ISO builder CopyExportedVirtualMachine PowerShell ... Script wasn't able to handle path that Packer used to create VM in the first place: "==> hyperv-iso: Copying to output dir... ==> hyperv-iso: Error exporting vm: PowerShell error: Move-Item : An object at the specified path C:\Users\HANNU~1.PIK does not exist. ==> hyperv-iso: At C:\Users\hannu.piki\AppData\Local\Temp\ps520830935.ps1:13 char:1 ==> hyperv-iso: + Move-Item -Path "$srcPath/$vhdDirName" -Destination $dstPath -Verbose ==> hyperv-iso: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ==> hyperv-iso: + CategoryInfo : InvalidArgument: (:) [Move-Item], PSArgumentException ==> hyperv-iso: + FullyQualifiedErrorId : Argument,Microsoft.PowerShell.Commands.MoveItemCommand" Used path was: C:\Users\HANNU~1.PIK\AppData\Local\Temp\packerhv616791918\export253729206\2016min Real path was: C:\Users\hannu.piki\AppData\Local\Temp\packerhv616791918\export253729206\2016min	8 years ago
Stefan Henseler	03f0b4aa11	Fixes minor typo	8 years ago
Stefan Henseler	d31e35075e	Removes obsolete code	8 years ago
Megan Marsh	d689e6b4d3	allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.	8 years ago
Josh Soref	5178dd36e8	spelling: regular	8 years ago
Stefan Henseler	a6b0bd2927	Merge branch 'master' into hyper-v-disk-block-size	8 years ago
Stefan Henseler	103186af86	Adds Support to configure hyper-v disk block size	8 years ago
Anthony Allen	f3c361de6b	Fully qualify hyper-v powershell commands	8 years ago
SwampDragons	7d5d62d748	Merge pull request #2906 from arizvisa/GH-2377 ... Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme	8 years ago
Ali Rizvi-Santiago	9eb2f37429	Ack! Forgot to include the test-fixtures/SomeDir/myfile.txt file...	8 years ago
Ali Rizvi-Santiago	d4b00b722a	Removed an extra '/' from the TestFileExistsLocally test in common/config_test.go	8 years ago
Ali Rizvi-Santiago	efc97dbda2	Fixed TestFileExistsLocally tests in common/config_test.go so that they're actually being run. Added a non-existent-protocol:// test.	8 years ago
Ali Rizvi-Santiago	c366a1e160	Inverted the logic of FileExistsLocally as suggested by @SwampDragons as remote URLs are assumed to exist locally.	8 years ago
Ali Rizvi-Santiago	c98a074f0d	Renamed common/config.go's SupportedURL to SupportedProtocol as suggested by @SwampDragons.	8 years ago
Ben Phegan	3c88e787df	Merge branch 'master' into hyperv_mac_address	8 years ago
Matthew Hooker	8cd403425e	test fixes WIP	8 years ago
Matthew Hooker	5d48d658b4	Wire context through misc steps ... Some steps actually need to pass the context around, so let's create a ctx variable and pass it.	8 years ago
Matthew Hooker	7a189a83a1	fix imports ... `find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`	8 years ago
Matthew Hooker	a831d522be	change run signatures ... Run now takes a context as well as a statebag. We'll assign the context to the blank identifier to prevent namespace collisions. We'll let the step authors opt-in to using the context. `find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`	8 years ago
Matthew Hooker	366dc3da0a	move multistep imports to helper. ... gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"	8 years ago
Matthew Hooker	ebe995c0ff	run goimports	8 years ago
Ali Rizvi-Santiago	0e0b467da7	Forgot to check some errors during the adding of files to the floppy disk. This gives users some better information in case packer is unable to add a file...like if there's not enough disk space available.	8 years ago
Ali Rizvi-Santiago	97fc9c02a5	Grr...missed the case that actually mattered on linux.	8 years ago
Ali Rizvi-Santiago	f9572cb244	Fixed a bug on linux related to forgetting to check the platform for the forward-slash prefix.	8 years ago
Ali Rizvi-Santiago	41f4dc3f3d	umm...gofmt -w on common/config{,_test}.go from linux instead of windows(?)	8 years ago
Ali Rizvi-Santiago	7cd5d576d9	Updated common/config.go's FileExistsLocally implementation to use the LocalDownloader interface for determining the real file path.	8 years ago
Ali Rizvi-Santiago	8a102a42a0	gofmt -w on common/config{,_test}.go	8 years ago
Ali Rizvi-Santiago	15079a99dc	Fixed common/config_test.go tests for DownloadableURL to avoid writing to disk on the windows platform. Also added tests for relative paths/uris. ... common/config_test.go: Replaced instances of os.Mkdir and os.Create with tests that use the existing "common/test-fixtures" mechanism. Removed the runtime.GOOS test for the "FileExistsLocally" test, as the functionality should work regardless of the platform. Added some more comprehensive tests for the relative uri/pathing. Replaced the Windows Object Manager name test as the Object Manager's naming scheme is different from a UNC path. Modified the FilePaths tests to support the policy of windows absolute paths being prefixed with the `/` introduced with PR #5761.	8 years ago
Ali Rizvi-Santiago	95f60f6153	Modified common/config.go to accommodate some of the new DownloadableURL policies made by the PR #5761 merge. ... common/config.go: Added the ability for DownloadableURL to promote UNC paths to the SMB uri. Modified DownloadableURL to include the "./" prefix when a relative path is passed to it. Fix-up the DownloadableURL argument if on windows and incorrectly prefixed with "/".	8 years ago
Ali Rizvi-Santiago	50e9cd2ca7	Initial fixes of common/config.go after rebase before refactoring of test-cases so that they don't require root to run.	8 years ago
Ali Rizvi-Santiago	c17f827e1d	Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols.	8 years ago
Ali Rizvi-Santiago	3cf448f6ec	Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path.	8 years ago
Ali Rizvi-Santiago	4a1fb0d262	Grrr...gofmt -w common/*.go	8 years ago
Ali Rizvi-Santiago	5d97b105a8	Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist.	8 years ago
Ali Rizvi-Santiago	5a3e98b529	Updated the testcases in common/download_test.go to pass a non-nil progress-bar due to the removal of a pointer type in commit ed2e341b7d7f49a063dd5018701b4ae548b8ec14 from yesterday.	8 years ago
Ali Rizvi-Santiago	ab4490b967	Consolidated progress bar's appearance into the GetDefaultProgressBar() function. Updated dependency for cheggaaa's progress-bar from the gopkg.in location to the better maintained one on github.com.	8 years ago
Ali Rizvi-Santiago	8c6efe336c	Added second argument for custom-formatted progress-bar to NewDownloadClient in common/download_test.go. This second parameter was added as a result of commit f0bd9018f3e318caafb1fe7d46e04c470e07c092 which lets you customize the progress-bar format.	8 years ago