278 Commits (23552bfbd72f05bb17f40b8d02bbad10cdbb4592)

Author	SHA1	Message	Date
Adrien Delorme	f5e037e8b4	Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp	6 years ago
Adrien Delorme	b4f68767a3	make default key type RSA instead of DSA	6 years ago
Megan Marsh	70cb4097e1	review comments, add plugin type for a few missing builders	6 years ago
Megan Marsh	c0ce8a9414	rework fixer deprecation code so we know what plugins they relate to	6 years ago
Adrien Delorme	4aea2efd0f	HCL2: fully name SSHTemporaryKeyPair fields so that they don't conflict and can be generated	6 years ago
Adrien Delorme	d1e0214bec	avoid panic debugging ssh key	6 years ago
Adrien Delorme	b24911661f	add sshkey package and ssh-keygen comand (#10101) ... * add sshkey.Generate function that returns an sshkey.Pair to be used with openssh. * add cmd/ssh-keygen/main.go for testing purposes * add a test calling ssh.ParsePrivateKey & ssh.ParseAuthorizedKey (which is very similar to what openssh would do to read a keypair) The wrapping of the keys should be handled by crypto/x509.MarshalPKCS8PrivateKey & x/crypto/ssh.NewPublicKey which does not work for ed25519 and dsa. x509.MarshalPKCS8PrivateKey marshals ed25519 keys but the keys did not work with openssh. x509.MarshalPKCS8PrivateKey does not handle dsa keys. So I had to 'wrap' those manually by reading the code of the openssh package. Note that ssh.NewPublicKey works with any keytype. I should probably do a PR to ssh to have a NewPrivateKey & Marshalling funcs	6 years ago
Adrien Delorme	54032d6c11	gen code and docs	6 years ago
Adrien Delorme	f4f731b83c	Refactor google compute's temporary ssh keygen genertion to use the sshkey package	6 years ago
Adrien Delorme	5b7037c069	add more comments	6 years ago
Adrien Delorme	fe8d287036	some linting	6 years ago
Adrien Delorme	c5d6e72720	comment PairFromED25519	6 years ago
Adrien Delorme	766e7872a0	add a comment for DSA default bits setting	6 years ago
Adrien Delorme	77adeb1191	create PairFromED25519 func to create valid ed25519 keypairs	6 years ago
Adrien Delorme	3712cd8e2c	bump default RSA bits to 4096	6 years ago
Adrien Delorme	9b68099ad5	remove specific EC code	6 years ago
Adrien Delorme	48199c5aa8	add basic test to see if generated files are parseable	6 years ago
Adrien Delorme	ca23dab943	set correct type for PEM block	6 years ago
Adrien Delorme	750102901c	add cmd/ssh-keygen/main.go to try this on real servers	6 years ago
Adrien Delorme	0cf7af4247	add sshkey.Generate function	6 years ago
Ricardo Rosales	809f38be3a	[azure-chroot] Updating parameter `exlude_from_latest` to `exclude_from_latest` (#10034)	6 years ago
Marco Molteni	4d7e42220b	scaleway: add pre validate step (check image and snapshot names) (#9840) ... * Implement Stringer inteface for multistep.StepAction * scaleway: add pre validate step (check image and snapshot names) Before, it was possible to create multiple images with the same name, leading to a confusing and wasteful situation (same for snapshots). Now, we perform the same kind of checks done by the AWS EC2 builder, and refuse to proceed if there is an existing image with the same name (same for snapshots). As usual, invoking `packer build -force` will bypass the checks. Closes #9839.	6 years ago
Megan Marsh	94a9beaac6	fix up documentation for virtualbox key pair ssh options	6 years ago
Megan Marsh	5120ad9d9a	add test file	6 years ago
Megan Marsh	20d62654ae	move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder	6 years ago
Megan Marsh	2dcf950441	change pause to run connect again afterwards	6 years ago
Adrien Delorme	44616d3bff	refactor initialization out from packer configs + tests (#9627) ... The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost. This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too. fix #9478	6 years ago
Megan Marsh	a687d6fe12	ci/tech-debt: Fix vmware acceptance tests (#9636) ... * add kex algorithm option to ssh config * regenerate code * This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts: 1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed. 2) It modifies logic in reading and defaulting hardware config values, which was crashing. 3) It adds a new acceptance test with a preseed file to test loading from an http directory.	6 years ago
Adrien Delorme	125178d943	core: Decode: when in HCL2 decoding mode; reset the whole struct before preparing it. (#9622) ... * core: Decode when in HCL2 decoding mode; reset the whole struct before preparing it. * HCL2: add path variables + docs & tests Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Adrien Delorme	fd6be7f279	better/simpler `pause_before_connecting` example	6 years ago
Megan Marsh	530f5e3f63	more additions to partials	6 years ago
Roger Hu	31a7a1d637	adding basic support for OpenSSH CertificateFile support ... small fix	6 years ago
Sylvia Moss	9c1409dbba	Add content_library_destination to import VM template to a Content Library (#9551)	6 years ago
Moss	8ea64c5b35	undocument ssh_keypair_name and ssh_agent_auth	6 years ago
Moss	41edd09d3c	undocument temporary_key_pair_name and ssh_private_key_file	6 years ago
Megan Marsh	cacdb0ca02	add tests	6 years ago
Megan Marsh	4f77bb0c4a	add new ssh_ciphers option	6 years ago
Megan Marsh	a07563c64f	fix up typos in comments and regenerate docs. ... Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Megan Marsh	4178625afb	re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.	6 years ago
Wilken Rivera	f672f5bd9b	command/validate: Add support for HCL2 configuration files ... * Update validate command to use FixConfig for checking against known fixers * Update validation command flag docs * Add ConfigFixer method to PackerHandler Interface * Implement ConfigFixer interface in PackerConfig * Remove all stdout messaging (i.e calls to c.Ui.Say) in the validate command. The command will only display hcl.Diagnotic messaging when there is an error or warning. HCL2 Configs ``` ⇶ packer validate docker_centos_shell_provisioner.pkr.hcl ``` JSON Configs ``` ⇶ packer validate vmware-iso_ubuntu_minimal/vmware-iso_ubuntu_minimal.json Error: Failed to prepare build: "vmware-iso" 1 error occurred: * Deprecated configuration key: 'iso_checksum_type'. Please call `packer fix` against your template to update your template to be compatable with the current version of Packer. Visit https://www.packer.io/docs/commands/fix/ for more detail. Warning: Fixable configuration found. You may need to run `packer fix` to get your build to run correctly. See debug log for more information. map[string]interface{}{ "builders": []interface{}{ map[string]interface{}{ ... // 3 identical entries "guest_os_type": string("ubuntu-64"), "http_directory": string("http"), - "iso_checksum": string("946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), + "iso_checksum": string("sha256:946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), - "iso_checksum_type": string("sha256"), "iso_url": string("http://old-releases.ubuntu.com/releases/14.04.1/ubuntu-14.04.1-server-amd64.iso"), "shutdown_command": string("echo 'vagrant' | sudo -S shutdown -P now"), ... // 4 identical entries }, }, } ```	6 years ago
Sylvia Moss	ce45a1990a	Refactor communicator config for Qemu and add SkipNatMapping option (#9307)	6 years ago
Megan Marsh	4698f90e65	update deprecated options	6 years ago
Megan Marsh	a94e147865	fix go fmt	6 years ago
Megan Marsh	b28059c0a5	add generator to create a list of all the deprecated options that the fixers fix ... fix location of deprecated_options code	6 years ago
Megan Marsh	15b14d4879	add deprecation check to config helper	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Megan Marsh	217dcbb97f	golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago