772 Commits (13ea97a1dfebf0980d45bbdc1a2148ae341b9840)

Author	SHA1	Message	Date
Adrien Delorme	f1e6f8eac1	removed unused config puts	6 years ago
Adrien Delorme	a67948f155	fix config pointers	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	84063d2132	implement ID and Type values in the provisioner template info sharing	6 years ago
Stephen Tawn	c66219084e	Fix error message when ovftool is missing	6 years ago
Lars Lehtonen	5f02150e05	builder/vmware/common: defer close after testing for errors	6 years ago
Lars Lehtonen	9924d16fc3	builder/vmware/common: remove unused testHWConfig()	6 years ago
Lars Lehtonen	6eefe55e23	builder/vmware/iso: remove unused testState()	6 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	6 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	6 years ago
Adrien Delorme	21a0cbffba	fmt	6 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	6 years ago
Adrien Delorme	766e5c77ef	builder.vmware.vmx: remove duplicate RemoteType field.	6 years ago
Adrien Delorme	00e3f97f5b	builder.vmware.iso: remove duplicate Format field	6 years ago
Lars Lehtonen	2b795053b4	builder/vmware: fix dropped test errors	7 years ago
Megan Marsh	c24693372d	Merge pull request #8132 from scienty/support_floppy_vmx_esxi ... Support floppy_files for vmx on esxi	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Prakash Sidaraddi	67be007f45	Support floppy_files for vmx on esxi	7 years ago
allinwait	171c2a9a07	add the floppy label option	7 years ago
Adrien Delorme	ba9ffcbf73	re-indent HWConfig struct comments	7 years ago
Adrien Delorme	b3cdf2ac8f	remove docs typo	7 years ago
Adrien Delorme	5517d41468	make sure all documentation fields are there ... * add missing `temporary_key_pair_name` field for alicloud * add missing description to `vpc_filter` for aws * add missing ssh communicator fields for aws * add links for aws * update vmware-vmx docs * manually describe AMI Configuration section for ebsvolume * display missing required ami_name field for aws * add missing fields for docker * add missing fields for openstack	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Vladislav Rassokhin	991cf22504	Prevent endless reading of closed file in vmware plugin	7 years ago
Adrien Delorme	4a61dc3670	vmware: document using partials	7 years ago
Adrien Delorme	c11ef90cb6	use interpolate.NewContext() instead of testConfigTemplate(t) ... because it's what's happenning there	7 years ago
Adrien Delorme	926c8bbaa6	refactor ShutdownConfig into a single struct	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
aaronk1	4ffa1779f1	Correct typo in var name	7 years ago
Megan Marsh	f7c1b5e940	add 30 minute timeout for destroying a VM	7 years ago
Adrien Delorme	56c7593725	fix panic in StepConfigureVNC ... When the driver is the esx5 driver s.l won't be set at all. Meaning this will crash. In the esx5 driver we try to dial possible ports to see if it works so it doesn't make sense to use packer's `net.ListenRangeConfig`. It could make sense to have a net.DialRangeConfig but this sounds a bit too specific and not broad enough to do. fix #7505	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Adrien Delorme	ac92916b01	StepConfigureVNC: close listener only once	7 years ago
Adrien Delorme	a3838ecfad	error on negative ports	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	f828b72c10	step configure vnc: allow to use ESX5Driver again	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	b5d78d47f5	vmware StepConfigureVNC: use common/net pkg to find open port	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	eb98840f18	Merge pull request #7357 from e-mow/issue-7140 ... Issue 7140	7 years ago
Eric Mowry	cef3d0eb24	Ran make fmt per Megan's request.	7 years ago
Eric Mowry	109ba2c54c	After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.	7 years ago
Megan Marsh	0371e2a1b4	Merge pull request #7074 from hashicorp/fix_3329 ... vmware-iso (esxi) Add check that "format" is not being set when remote_type is empty.	7 years ago