403 Commits (030da4b6b9a0efd62447dbd2ae177dbe3f0ffcc5)

Author	SHA1	Message	Date
Adrien Delorme	c11ef90cb6	use interpolate.NewContext() instead of testConfigTemplate(t) ... because it's what's happenning there	7 years ago
Adrien Delorme	926c8bbaa6	refactor ShutdownConfig into a single struct	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	4399684372	make fmt autogenerated docs	7 years ago
Adrien Delorme	e6cbb013ba	add // go:generate struct-markdown to all previously edited files	7 years ago
Adrien Delorme	f1917edd34	generate the comments for config struct of builders scraping doc website	7 years ago
Megan Marsh	f7c1b5e940	add 30 minute timeout for destroying a VM	7 years ago
Adrien Delorme	56c7593725	fix panic in StepConfigureVNC ... When the driver is the esx5 driver s.l won't be set at all. Meaning this will crash. In the esx5 driver we try to dial possible ports to see if it works so it doesn't make sense to use packer's `net.ListenRangeConfig`. It could make sense to have a net.DialRangeConfig but this sounds a bit too specific and not broad enough to do. fix #7505	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	ac92916b01	StepConfigureVNC: close listener only once	7 years ago
Adrien Delorme	a3838ecfad	error on negative ports	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	f828b72c10	step configure vnc: allow to use ESX5Driver again	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	b5d78d47f5	vmware StepConfigureVNC: use common/net pkg to find open port	7 years ago
Eric Mowry	cef3d0eb24	Ran make fmt per Megan's request.	7 years ago
Eric Mowry	109ba2c54c	After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.	7 years ago
Eric Mowry	e74a81e27b	Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process.	7 years ago
Eric Mowry	1127096beb	Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted.	7 years ago
Megan Marsh	5cc442872e	Merge pull request #7314 from hashicorp/fix_7234 ... add noSSLVerify to ovftool args	7 years ago
Megan Marsh	bbc52f9a7d	add noSSLVerify to ovftool args	7 years ago
Megan Marsh	bd3339f1f9	also strip \r to work around windows file ending strangeness	7 years ago
Megan Marsh	6ea64bc378	Merge pull request #7191 from arizvisa/GH-7190 ... Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.	7 years ago
Megan Marsh	ce8f5c31df	escape query as suggested in issue #7200	7 years ago
Ali Rizvi-Santiago	9d2f98394e	Revert "Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`." ... This reverts commit 0c37a3c68f and avoids bikeshedding from other committers.	7 years ago
Ali Rizvi-Santiago	0c37a3c68f	Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`.	7 years ago
Ali Rizvi-Santiago	062c62eed8	Added support for specifying the number of cores as `cores` to vmware-common.	7 years ago
DanHam	0821653256	Fix 'nil' dir in VMware artifact when building locally	7 years ago
Ali Rizvi-Santiago	96bdf17d2e	Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.	7 years ago
Ali Rizvi-Santiago	fa4998e1ec	Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.	7 years ago
Ali Rizvi-Santiago	3512c3c5ea	Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.	7 years ago
Megan Marsh	11ef407b4d	Merge pull request #7016 from rickard-von-essen/vmware-tech-prev ... vmware: Correctly parse version for VMware Fusion Tech Preview	8 years ago
Megan Marsh	ec75913412	fix crash that occurs when dir is nil	8 years ago
Ali Rizvi-Santiago	f8c23c1808	Updated things related to the vmware-iso builder to include @azr's suggestions.	8 years ago
Ali Rizvi-Santiago	61ee3a44f5	Modified the cpus and memory options for the vmware builders to only apply them if they were specified.	8 years ago
Ali Rizvi-Santiago	fb7ce9f2b5	Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).	8 years ago
Ali Rizvi-Santiago	cd45248eaa	Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.	8 years ago
Rickard von Essen	4ea3d1567a	vmware: Correctly parse version for VMware Fusion Tech Preview ... Closes #5317	8 years ago
Megan Marsh	dca02c7b07	Merge pull request #6962 from hashicorp/fix_6940 ... escape vSphere username when putting it into the query	8 years ago
Megan Marsh	89184ae384	rework if/else to simplify main code body.	8 years ago
Megan Marsh	536e0501ac	Validate username/password for ovftool during prepare. ... Add template option skip_validate_credentials allowing users to skip this validation if they don't want it. Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file	8 years ago
Megan Marsh	49b40e0789	Merge pull request #6984 from hashicorp/add_display_name_vmware ... add new display_name template option	8 years ago
Adrien Delorme	f1fa28847f	remove debug line. ... Co-Authored-By: SwampDragons <megan@hashicorp.com>	8 years ago
Megan Marsh	e5c4a4a6fb	create export directories for vmx and ovf file types, too.	8 years ago
Megan Marsh	68c9e34bfe	add new display_name template option	8 years ago
Megan Marsh	790d5661c5	escape username	8 years ago
Megan Marsh	96d628eef1	fix silliness with pointers	8 years ago
Megan Marsh	5c2ca450bd	fix tests	8 years ago
Megan Marsh	5815b376b4	remove unnecessary checks; we always default format to ovf if it is unset. ... fix exportoutputdir	8 years ago
Megan Marsh	c3144c2d0a	add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.	8 years ago
Megan Marsh	c3d6d45696	modify test so that it accesses CommConfig the same way we really do within the driver	8 years ago
Megan Marsh	f18bb19f96	remove redundant config; CommConfig was already a part of the SSSHConfig struct	8 years ago
Megan Marsh	fa12113eaf	remove unused NewLocalArtifact ... consolidate artifacts entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder	8 years ago
Megan Marsh	2ae235a28a	fix tests	8 years ago
Megan Marsh	290f4a7c4c	cleanup to make it actually build after that monstrous rebase	8 years ago
Alexander Laamanen	3193f50f17	Support export with the vmx builder.	8 years ago
Alexander Laamanen	a68a639a1a	Move step_export to common.	8 years ago
Alexander Laamanen	63054fb808	Fix the test.	8 years ago
Stuart Miller	da5f322484	Add quotes around all filenames to prevent issues with spaces	8 years ago
Alexander Laamanen	f42f5a8ad3	Remove some extra logging.	8 years ago
Alexander Laamanen	e7e6a80587	No need to make upload public.	8 years ago
Alexander Laamanen	c940f7e754	Conditional reload.	8 years ago
Alexander Laamanen	17845beadc	Fix the CommHost tests	8 years ago
Alexander Laamanen	5e74bcfb88	Fix tests, move remote_ default values to driver_config.	8 years ago
Alexander Laamanen	4d9cb19012	Refactor artifacts and output_dir implementations.	8 years ago
Alexander Laamanen	2d00dc6756	Add VMName to the vmx mods.	8 years ago
Alexander Laamanen	7b5943160b	Re-enable the CommHost() call. Use common's driver factory.	8 years ago
Alexander Laamanen	ba22090bc9	Move step_register and step_uload_vmx from iso to common.	8 years ago
Alexander Laamanen	b5298464c5	Move the remote_driver from iso to common.	8 years ago
Alexander Laamanen	91c7089455	Implement the first version of the remote Clone().	8 years ago
Alexander Laamanen	46cfb5a30c	Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver()	8 years ago
Adrien Delorme	51d2aac9f6	SSHPrivateKey => SSHPrivateKeyFile	8 years ago
Megan Marsh	bf191d1ef6	Merge pull request #6204 from arizvisa/GH-6197 ... Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.	8 years ago
Megan Marsh	340363a649	Merge pull request #6613 from hashicorp/merge_ssh_config_funcs ... Merge ssh config funcs from builders	8 years ago
Megan Marsh	31d4f8af45	use a time.Duration instead of a hardcoded ms	8 years ago
Megan Marsh	918db58604	added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used	8 years ago
Adrien Delorme	41f6e0334d	refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc ... * still need to append the auth methods into an array for gracefullness	8 years ago
DanHam	a39c5887fb	Test we halt if a bad path is set in vmx_path	8 years ago
DanHam	21117e5d38	Test we fail if displayName is not stored in the statebag as 'display_name'	8 years ago
DanHam	88c43ec98d	Test we fail if the displayName key is not found in the VMX	8 years ago
DanHam	d68d26a6e5	Fix tests: We now need to set `displayName` key/val pair in the test VMX	8 years ago
DanHam	3eab3cc99b	ESXi builds require we store the value of displayName in the statebag ... The value of displayName is needed by later steps: * When determining the IP address of the build VM * When exporting the VM using ovftool By default Packer will configure the VMX so `displayName` is equal to the value defined for `vm_name` in the build template. However, it is possible (and sometimes desirable) to set a custom value for `displayName`. Users can set a custom `displayName` through use of the `vmx_data` option in their template.	8 years ago
M. Marsh	406f4eeb93	Merge pull request #6394 from conradjones/master ... Add support to vmware-vmx for linked clones	8 years ago
Conrad Jones	d9b6924986	Add cloneType to fusion driver	8 years ago
Bob Brumfield	04ff0761e6	Notify that we are skipping file, but retain error message	8 years ago
Bob Brumfield	591bfe3dfa	Continue searching for leases even if one of the files cannot be read.	8 years ago
Conrad Jones	d05a601d00	Add support to vmware-vmx builder for linked clones.	8 years ago
DanHam	73eb9a629e	Revert "Fix test - reporting compaction results requires a tmp file" ... This reverts commit f342975ff3.	8 years ago
DanHam	2939cd75ae	Revert "Report the result of the disk compaction step" ... Unfortunately this broke the ability to build on remote (ESXi) hosts. This reverts commit 08f9d619a9.	8 years ago
DanHam	25dd27a164	Remove tmp directories created by builder/vmware/common tests	8 years ago
DanHam	c828015bc3	Follow variable varName <-> statebag var_name convention	8 years ago
DanHam	f342975ff3	Fix test - reporting compaction results requires a tmp file	8 years ago
DanHam	08f9d619a9	Report the result of the disk compaction step	8 years ago
DanHam	10d93dffa4	Fix tests for vmware/common	8 years ago
DanHam	c48a7889f9	Simplify handling of disks by collating requirements and unifying ops	8 years ago
Ali Rizvi-Santiago	5d8b476a7f	Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code.	8 years ago
Matthew Hooker	c6299972b9	s/boot_command/bootcommand/	8 years ago
Matthew Hooker	408eba88ad	flatten boot command config and implement for vmware	8 years ago
Matthew Hooker	cba4d3235f	cleanup	8 years ago
Matthew Hooker	bf0a320125	Implement new parser for qemu boot command	8 years ago
Matthew Hooker	1c0af28662	Some cleanup and comments.	8 years ago
Matthew Hooker	4e2f14196a	Rely on context to cancel typing boot command.	8 years ago
Matthew Hooker	673245afcf	Replace boot command parser with PEG parser.	8 years ago
Ali Rizvi-Santiago	2c2904c095	Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases..	8 years ago
Ali Rizvi-Santiago	7e9699675f	Modified device matching logs to look more consistent.	8 years ago
Ali Rizvi-Santiago	6e176f97a0	Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network.	8 years ago
Ali Rizvi-Santiago	646523c5f4	Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers.	8 years ago
Megan Marsh	ef4f3f143b	Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices ... Handle multiple devices per VMware network type	8 years ago
Josh Soref	61030c0d85	spelling: output	8 years ago
Josh Soref	d987fcefc3	spelling: multiples	8 years ago
Andreas Sommer	ff92fb883d	Handle multiple devices per VMware network type ... Fixes #5979	8 years ago
Megan Marsh	ac2e02b938	remove loglines that should not have made it onto master	8 years ago
SwampDragons	9e8e376d6c	Merge pull request #5932 from hashicorp/add_configurable_snapshot_timeout ... add configurable snapshot timeout to oracle-classic builder	8 years ago
Megan Marsh	597ddc2192	add configurable snapshot timeout to oracle-classic builder	8 years ago
Ali Rizvi-Santiago	27ed479b0a	Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux. ... It was reported that on WS14 on Linux, that the path may be different than stated in the documentation. This modifies `workstationDhcpConfPath` and `workstationDhcpLeasesPath` functions to walk through every permutation while attempting to find the correct file. This reinforces the fix for issue #5882.	8 years ago
Ali Rizvi-Santiago	d6e5342ece	Fixed a type-o in the VMWare builder when locating the dhcp configuration file on Linux. ... Closes issue #5882.	8 years ago
Ali Rizvi-Santiago	fa2dddd26d	Fixed some things mucked up during rebase.	8 years ago
Ali Rizvi-Santiago	74946071d2	Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch (#2968) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885. ... arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify. arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew. icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)	8 years ago
Ali Rizvi-Santiago	594ed950c7	Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them.	8 years ago
Ali Rizvi-Santiago	737e951685	Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons.	8 years ago
Ali Rizvi-Santiago	b2fec18b1e	Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite.	8 years ago
Ali Rizvi-Santiago	069d00f70b	Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still.	8 years ago
Ali Rizvi-Santiago	8cc0776f3a	Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'.	8 years ago
Ali Rizvi-Santiago	029c357d8c	Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md.	8 years ago
Ali Rizvi-Santiago	258804106b	Added missing GetVmwareDriver() method to VMware Builder's DriverMock.	8 years ago
Ali Rizvi-Santiago	75fbfa0763	Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface. ... This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.	8 years ago
Ali Rizvi-Santiago	884af69da1	go fmt on builder/vmware/*	8 years ago
Ali Rizvi-Santiago	0d6cf7fac4	Added support for auto-detection to the serial and parallel port types. ... Included the yield option to all the serial port types. Added the ability for the network type to fallback to a custom network if the specified network name is not found in netmap.conf. Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver. Updated the documentation for the VMware builder.	8 years ago
Ali Rizvi-Santiago	b52e2d3f45	Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type.	8 years ago
Ali Rizvi-Santiago	9b95ce0bc6	Completely forgot to support the unix paths in each of the drivers for the VMware builder. Fixed.	8 years ago
Ali Rizvi-Santiago	4225b3568e	Fixed bad ORs and a bad fmtstring.	8 years ago
Ali Rizvi-Santiago	75d3ea7cee	Added support for sound, serial ports, parallel ports, usb, and specifying a default network to the vmware builder. ... builder/vmware/{iso,vmx}: Added the specific configuration options that get parsed. Normalize paths when pulling them from the json template so that they'll work on Windows too. Added some improved error checking when parsing these options. Stash the vm's network connection type so that other steps can figure out addressing information Modified the esx5 driver to support the new addressing logic. Modified the template in step_create_vmx to include the new options. builder/vmware/common: Implemented a parser for vmware's configuration files to the vmware builder. Modified the driver's interface to include support for resolving both guest/host hw and ip addresses Implemented a base structure with some methods that implement these features. Rewrote all ip and mac address dependent code to utilize these new methods. Removed host_ip and guest_ip due to their logic being moved directly into a base-structure used by each driver. The code was explicitly checking runtime.GOOS instead of portably using net.Interfaces() anyways. Updated driver_mock to support the new addressing methods	8 years ago
SwampDragons	8ae8f31a52	Merge pull request #5681 from mcandre/super-key ... add super key (vmware builder)	8 years ago
Matthew Hooker	8bdd3b45c7	use helper functions for reading vmx files	8 years ago
Matthew Hooker	76b2ce8604	log which vmware driver we decide on	8 years ago
Matthew Hooker	07421b4433	test vmware workstation version checking	8 years ago
Matthew Hooker	8cd403425e	test fixes WIP	8 years ago
Matthew Hooker	7a189a83a1	fix imports ... `find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`	8 years ago
Matthew Hooker	a831d522be	change run signatures ... Run now takes a context as well as a statebag. We'll assign the context to the blank identifier to prevent namespace collisions. We'll let the step authors opt-in to using the context. `find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`	8 years ago
Matthew Hooker	366dc3da0a	move multistep imports to helper. ... gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"	8 years ago
Matthew Hooker	ebe995c0ff	run goimports	8 years ago
Andrew Pennebaker	d069dc5b7c	handle holding a-z keys, such as for boot options (vmware builder)	8 years ago
Andrew Pennebaker	4acc98a729	add super key (vmware builder)	8 years ago
Matthew Hooker	4d117bf117	Make vm log output less confusing	9 years ago
Matthew Hooker	07b013945f	more consistent flag name	9 years ago
Matthew Hooker	106408f6be	add new disable_vnc option	9 years ago
nictrix	6a238a3ef3	add option to skip vnc phase and update docs	9 years ago
Michael Kuzmin	9876a28ea7	vmware: publish vm_name as artifact ID	9 years ago
Matthew Hooker	bf830e393d	Merge pull request #4810 from bryonr/fix_vmware_shutdown_cleanup_osx ... Help ensure VMX builder properly removes mounted CDs on OS X	9 years ago