134 Commits (poc/packer-init)

Author	SHA1	Message	Date
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Wilken Rivera	1eee0bca5f	Merge pull request #9011 from hashicorp/powershell-acceptance-test ... provisioner/powershell: Add basic Powershell provisioner acceptance tests	6 years ago
Lars Lehtonen	78bb742aa5	provisioner/shell: fix dropped test error	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Moss	185deeeb38	Fix provisioner acc-test builder and provisioner store	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Adrien Delorme	b94937c05c	Update provisioner_test.go (#8900)	6 years ago
Adrien Delorme	569c802630	Update provisioner_test.go ... fix TestProvisioner_RemoteFileDefaultsToScriptnnnn	6 years ago
Adrien Delorme	f1c0a9cdbd	see what's wrong with that weird test	6 years ago
Moss	112d4daa3d	Fix linter	6 years ago
Moss	5a8c628880	Add acc test validation to avoid running with unit tests	6 years ago
Moss	3f49b7c66e	Fix linter	6 years ago
Moss	0cc1092222	Fix format	6 years ago
Moss	2ca6804827	Move shell prov acc test to the same folder	6 years ago
Moss	6c06a2a048	Fix format	6 years ago
Moss	a3740bb9be	Interpolate shell inline config	6 years ago
Wilken Rivera	e1a46ec293	Fix gosimple S1025 linting errors (#8838) ... Remove unneeded use of fmt.Sprintf for variables that are already strings.	6 years ago
nywilken	b80882f3b8	provisioner/shell: Fix envVarFile clean up issue ... This change ensures the deletion of the external envVarFile (use_env_var_file = true) occurs after all script files have been executed and deleted. Build results before change ``` > packer build build.pkr.hcl [~0] docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp476880774:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh ==> docker: /bin/sh: 1: .: Can't open /tmp/varfile_2555.sh ==> docker: Provisioning step had errors: Running the cleanup provisioner, if present... ==> docker: Killing the container: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b Build 'docker' errored: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Some builds didn't complete successfully and had errors: --> docker: Script exited with non-zero exit status: 2.Allowed exit codes are: [0] ==> Builds finished but no artifacts were created. ``` Build results after change ``` > packer build build.pkr.hcl docker: output will be in this color. ==> docker: Creating a temporary directory for sharing data... ==> docker: Pulling Docker image: ubuntu:bionic docker: bionic: Pulling from library/ubuntu docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110 docker: Status: Image is up to date for ubuntu:bionic docker: docker.io/library/ubuntu:bionic ==> docker: Starting docker container... docker: Run command: docker run -v /home/wilken/.packer.d/tmp819845000:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic docker: Container ID: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 ==> docker: Using docker communicator to connect: 172.17.0.2 ==> docker: Provisioning with shell script: sample.sh docker: Sample Script docker: wilken is NotForSale! ==> docker: Provisioning with shell script: foobar.sh docker: FooBar Script docker: wilken is NotForSale! ==> docker: Committing the container docker: Image ID: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ==> docker: Killing the container: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5 Build 'docker' finished. ==> Builds finished. The artifacts of successful builds are: --> docker: Imported Docker image: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3 ```	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	39fd462b56	change all provision func signatures to use map[string]interface{}	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	f4c3501af5	pass struct of generated data into provision() call	6 years ago
Megan Marsh	7d4353864f	use shell struct in shell-local provisioner and post-processor.	6 years ago
nywilken	3522e13b1e	provisioner/shell: Add `env_var_format` support to shell provisioner ... * Move setting of default EnvVarFormat to the Prepare function * Add generated hcl2 structure for the updated Shell provisioner config * Move `EnvVarFormat` field to shared common shell type * Add description for the `env_var_format` parameter * Update `env_var_format` when used with `use_env_var_file`	6 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	6 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	6 years ago
Lars Lehtonen	9c19cfdc6f	provisioner/shell: fix dropped error	6 years ago
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c7ce4d598e	change Provisioner to be passed a context for cancellation	7 years ago
Adrien Delorme	72e5ae9ddc	use ValidExitCode in provisioners windows-shell, powershell and shell	7 years ago
Adrien Delorme	30a65c858a	regroup shell provisioner params into a common struct	7 years ago
Adrien Delorme	b7222d1f56	Add tmp package that offers Dir & File funcs ... this regroups the calls of tmp func calls into one package. the tmp pkg allows to store tmp files under a common directory for easier managment Squashed commit of the following: commit 74b674c015 Merge: fc94b5714 66001525d Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 02:02:38 2018 -0400 Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs commit fc94b57142 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit 5a562359f4 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 9d5a4a0935 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit fbae4c2e05 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 3590fae8bd Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit d5c5306a97 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 0a72297da8 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 20f68228b6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit c73ebe3d83 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit 63549b8bd7 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit 9761010749 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit 95159afbc0 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 66001525d7 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit e9b6adefea Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 852113ed07 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit 54add38d1d Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 6b5b8f6d4e Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit c22092c601 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 7a73045091 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 0f2933adb6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit d74839ede0 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit eb65416619 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit acaa2b31ed Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit e573fde668 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 39a9874afc Merge: 8a413cfe8 3315812c2 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 18:19:26 2018 -0400 Merge branch 'master' of https://github.com/hashicorp/packer into prestine commit 8a413cfe83 Merge: e07491de5 4e14710a6 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Oct 1 20:18:10 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit e07491de59 Merge: 42610a35d a1fa35dff Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Aug 21 13:26:19 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 42610a35d5 Merge: 5298142da 0d63cf7bc Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue Jun 19 22:45:05 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 5298142da6 Merge: 7bb110bc7 9d9736552 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Jun 11 15:10:09 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 7bb110bc74 Merge: a61c869ca 6189d66e7 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Wed May 9 23:41:22 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit a61c869ca7 Merge: 098101dd9 4be5f072c Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri May 4 10:13:04 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 098101dd99 Merge: fefaf0fa6 554b2b4a5 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue May 1 20:52:30 2018 -0400 Merge branch 'EOL-handling' into prestine Co-Authored-By: Matthew Patton <pattonme@yahoo.com>	7 years ago
Megan Marsh	e69391f28b	save users some bash scripting by exposing IP and port separately as well as together	7 years ago
Adrien Delorme	56fd98552e	removed space	7 years ago
Mark Meyer	31afd1c2f8	Add PauseAfter option to shell provisioner ... Closes #6540	7 years ago
Megan Marsh	266a48a73a	minor fixes for shell provisioner docs and logging	8 years ago
Megan Marsh	ab13c73277	make varfile name unique and make sure to remove it from guest system if cleanup is true.	8 years ago
Megan Marsh	2c9a205f11	update shell provisioner tests	8 years ago
Megan Marsh	cce13e3877	shell provisioner: add option to source env vars from a file	8 years ago
Megan Marsh	fbbcbd772b	remove file stat	8 years ago
Matthew Hooker	732a532d0e	pass file info during shell file upload	8 years ago
Matthew Hooker	ecad3348b3	rephrase log message.	8 years ago
Ohad Basan	33b85b0130	Add suggestion for "expected_disconnect" option if disconnection occurs	8 years ago
Matthew Hooker	75111e49e9	remove convoluted pointer logic	8 years ago
Megan Marsh	401c718a59	set default for ExpectDisconnect to false	9 years ago
Matthew Hooker	56979a1974	Revert "Universally provide POSIX semantics for the `shell` provisioner." ... This reverts commit 1ba7f9cc20.	9 years ago