336 Commits (plugin_load_spec_docs)

Author	SHA1	Message	Date
Lucas Bajolet	61c810e720	command: rework HCP-related error messages ... The HCP error messages were sometimes a bit terse in terms of the information it bubbles up to the user. This made them useful for people who already knew what to look for, but newcomers would almost certainly be lost because of the lack of information in those. To improve on this situation, we reword most of those error messages in this commit.	4 years ago
Lucas Bajolet	c0e7e7bd3c	hcl2: report error on build without sources ... When a template describes a build block without a source reference, the build should be considered invalid as we won't have a CoreBuild produced as a result of the need to have both. In current versions of Packer, this will produce an error message hinting that nothing will happen because of the lack of either build or source block. This commit takes the defined block, and points out to it as missing a source block as being the reason why nothing is happening, making it clearer what is required for an HCL2 build to be processed.	4 years ago
Lucas Bajolet	61c56e161c	hcl2: add example for undefined variable set warn ... When a variable is set in a pkrvars file, but isn't defined, an error message is output, but does not deliver an example of what is expected by Packer in order to complete a build. To remedy that, we improve the error message by giving an example of variable block to include in the build template.	4 years ago
Eng Zer Jun	f5ec0f1c57	test: use `T.Setenv` to set env vars in tests ... This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	4 years ago
Lucas Bajolet	a298617ecb	command/build: warn and exit when nothing to build ... When a `packer build' is run on a config that does not define anything to be built, the process would run normally, and only state that no artifacts were produced after builds were run successfully. This is misleading as we reach the end of the command without having a proper warning that nothing was even attempted to be built. This commit adds a warning when that happens, and leaves immediately after.	4 years ago
Lucas Bajolet	7cd095062a	parser: extract HCP logic out of the HCL parser ... Before this commit, some HCP-related logic was embedded in the parser, making all of it common to all commands. This complexifies the logic as some parts rely on the template being in a HCP-valid environment, and the datasources need to be evaluated in order for some operations to be executed. To simplify this and avoid those pitfalls, we move this logic to its own set of functions that will be performed after the parsing is done, on any valid HCL2 or JSON template.	4 years ago
Sylvia Moss	5c3d5c1295	Send channel id to HCP Packer (#11861)	4 years ago
Lucas Bajolet	6ab16561b5	hcl2: fix crash on malformed overrides (#11881) ... When an override block is either not an object, or if one of its contents are not an object, Packer would crash trying to forcefully cast the cty.Value to a cty.Collection. To avoid this behaviour, we add extra checks that return hcl.Diagnostics when they fail.	4 years ago
Lucas Bajolet	6794c6053a	hcl2template: only iterate on known HCP datasource (#11883) ... When we try to validate a build that contains references to hcp_packer_image, the data is not fetched, and the value is therefore unknown. However, during the decoding phase for the build blocks, we attempt to fetch the ancestry information for the current build, from the information previously fetched from HCP. Since we're validating, there's no way this is set, and attempting to cast without checking causes Packer to crash on the conversion. To avoid this, we only attempt this conversion if the value is known. Closes #11870	4 years ago
Wilken Rivera	846e4e6443	Associate Packer build to HCP Packer parent iteration (#11832) ... * Add support for data source lookup * Update failing test * Fix typo for HCP_PACKER_BUILD_FINGERPRINT env in test * Add test Fingerprint where needed; failing tests were not showing because they are properly set for acctest * Update to use BuildContext	4 years ago
Adrien Delorme	e03ad29ca0	Sanitize var code (#11566) ... * evaluateLocalVariables: modify code for readability and some (not benchmarked) perfs * Make default input variable type the DynamicPseudoType This should be the default, and avoids a panic. This type can represent situations where a type is not yet known. Its meaning is undefined in cty. * do not take Empty types from default value * Update types.variables.go Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
Wilken Rivera	2ad15617cc	core/hcl2: Fix issue preventing builds from pausing between provisioners when the `--debug` argument has been passed (#11537) ... * Update HCL2 PackerConfig to call SetDebug mode for CoreBuild when --debug flag is passed ``` ~> packer build --debug /tmp/source.pkr.hcl Debug mode enabled. Builds will not be parallelized. null.example: output will be in this color. ==> null.example: Pausing after run of step 'StepConnect'. Press enter to continue. ==> null.example: Pausing before the next provisioner . Press enter to continue. ==> null.example: Running local shell script: /var/folders/vz/rv7bk6v15211jxg8q801f7kw0000gq/T/packer-shell4149319610 null.example: hi ==> null.example: Pausing before the next provisioner . Press enter to continue. ==> null.example: Running local shell script: /var/folders/vz/rv7bk6v15211jxg8q801f7kw0000gq/T/packer-shell3210691290 null.example: hi 2 ==> null.example: Pausing after run of step 'StepProvision'. Press enter to continue. ==> null.example: Pausing before cleanup of step 'StepProvision'. Press enter to continue. ==> null.example: Pausing before cleanup of step 'StepConnect'. Press enter to continue. Build 'null.example' finished after 8 seconds 284 milliseconds. ==> Wait completed after 8 seconds 284 milliseconds ==> Builds finished. The artifacts of successful builds are: --> null.example: Did not export anything. This is the null builder ``` * Add call to SetOnError, and SetForce	4 years ago
Adrien Delorme	5d17d7fe65	prevent duplicate local block creation (#11534) ... * prevent duplicate local block creation * remove duplicate locals block bug * local variables: first get block, then decode it + simplify retry loop * Update types.packer_config.go * revert go get of hcl lib	4 years ago
teddylear	1d01ad3651	feat: print all locals errors when there is a circular error (#11527)	4 years ago
Wilken Rivera	760169b34e	Move to using ectx to preload build names (#11432) ... * Add basic post-processor test Closes #11411	5 years ago
Wilken Rivera	4a0fbd911a	Add support for variable interpolation to hcp_packer_registry and build blocks. (#11421) ... * Add variable interpolation support to hcp_packer_registry block * Add tests for variable interpolation in hcp_packer_registry block * Add variable interpolation support to the build block (#11425) * Add simple test to build command	5 years ago
Wilken Rivera	06b35c39de	hcp packer registry build labels (#11401) ... * Add basic support for build_labels argument * Update support for build_labels configuration argument * Update complete test-fixture with a build_labels configuration * Add test for deprecated labels argument * Add deprecation for hcp_packer_registry.labels When using the now deprecated labels argument of the new bucket_labels a Warning will be presented to the user. ``` ~> HCP_PACKER_BUILD_FINGERPRINT=356786543567865456789656789 packer build source.pkr.hcl Warning: the argument hcp_packer_registry.labels has been deprecated and will be removed in a future release; please use hcp_packer_registry.bucket_labels ``` When trying to use both bucket_labels and labels together an error is presented to the user. ``` ~> HCP_PACKER_BUILD_FINGERPRINT=ss6786543567865456789656789 packer build source.pkr.hcl Error: hcp_packer_registry.labels and hcp_packer_registry.bucket_labels are mutely exclusive; please use the recommended argument hcp_packer_registry.bucket_labels on source.pkr.hcl line 17: (source code not available) ``` * Update documentation for build_labels * Apply suggestions from code review Co-authored-by: Adrien Delorme <azr@users.noreply.github.com> * Update hcl2template/types.build.hcp_packer_registry.go Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	5 years ago
Adrien Delorme	710d109c55	HCL2: fix a crash when an HCL2 component is nil after a misconfiguration (#11382) ... * add test for crash * fix * show more precise error message when parse of a provisioner fails * Revert "fix" This reverts commit fc88e89fbb. * add better severity	5 years ago
Megan Marsh	e3719dd8a4	Merge pull request #11319 from hashicorp/add_iteration_id ... Add iteration	5 years ago
Megan Marsh	b763b79d9f	implement contextual variable packer.iteration_id	5 years ago
Megan Marsh	e7ba4d390d	Merge pull request #11318 from hashicorp/fix_source_accessor ... fix source accessor to allow use in source block	5 years ago
Megan Marsh	76c1059680	add tests, and simplify code	5 years ago
Adrien Delorme	254e020b08	Allow to use build variables in a post processor (#11323) ... * hcl: add test to verify that build.name can be used in a pp * allow to use build vars in post processors	5 years ago
Adrien Delorme	3135714465	rename all things 'inexist[e|a]nt' to 'nonexistent' & fix tests (#11325) ... + a typo	5 years ago
Kerim Satirli	bc6f1e36e6	Fixes typos in docs (#11322) ... * fixes typos in base docs * fixes typos in example code * fixes typos in website docs * fixes link to Terraform provider * fixes typo in function name	5 years ago
Megan Marsh	961d72bb37	add iteration_id to evaluation context.	5 years ago
Megan Marsh	cdde5cbbe2	fix source accessor to allow use in source block	5 years ago
Wilken Rivera	b10df3abb7	Update HCP Packer registry image extraction, validation, publishing logic for registry capable plugins (#11221) ... * Update handling of registry artifacts This change uses the github.com/hashicorp/packer-plgin-sdk/packer/registryimage for querying Artifact State for HCP Registry Image metadata. To handle the conversion of the RPC response, mapstructure was introduced to conversion state data into an registryimage.Image before publishing to a image bucket. * Update to use registry image from packersdk * Rename internal registry service pkg * Update vendored plugins to latest version * The latest release of Amazon, GoogleCompute, and Azure have support for publishing images to the HCP Packer registry.	5 years ago
Megan Marsh	6c7aadf08f	return diags earlier	5 years ago
Megan Marsh	295bac0c5f	remove unnecessary complexity	5 years ago
Megan Marsh	20a83dff4f	remove unneeded check.	5 years ago
Megan Marsh	48de1fc7da	allow datasources to use other datasources ... create a null data source for testing. We can choose to document if we want to, but it's a convenience for us add a test to catch cyclic datasource dependency, update tests to include out of order data sources, and update the code to clean up the returned diagnostics generated from the recursive evaluation PR review comments	5 years ago
Megan Marsh	2d16da10e7	Merge pull request #11219 from hashicorp/rename_slug_to_bucket ... make user-facing name for slug be bucket_name	5 years ago
Adrien Delorme	eb8e302941	hcl2_upgrade: special case: vsphere fix (#11216) ... * fix typo * hcl2_upgrade: special case linux_options and network_interface to block instead of maps * Update hcl2_upgrade_test.go * Update hcl2_upgrade_test.go remove unused code * hcl2_upgrade: support strftime too (#11220) * hcl2_upgrade strftime function * create legacy_strftime.mdx	5 years ago
Megan Marsh	4c22169c90	more test fix	5 years ago
Megan Marsh	2dd8c0dd26	fix tests	5 years ago
Megan Marsh	da301ab844	make user-facing name for slug be bucket_name	5 years ago
Wilken Rivera	e8b5b4b516	Fix {{packer_version}} interpolation regression (#11200) ... * Add Packer version to main context at variable interpolation Test Results Before Change ``` === RUN TestCoreBuild_packerVersion testing.go:30: err: template: root:1:2: executing "root" at <packer_version>: error calling packer_version: packer_version not available --- FAIL: TestCoreBuild_packerVersion (0.00s) ``` Test Results After Change ``` === RUN TestCoreBuild_packerVersion --- PASS: TestCoreBuild_packerVersion (0.00s) ``` * Add packer_core_version to interpolation context for HCL configs Test Results Before Change ``` === RUN TestParse_build/provisioner_with_packer_version_interpolation common_test.go:109: Parser.getBuilds() unexpected diagnostics. testdata/build/provisioner_packer_version_interpolation.pkr.hcl:8,5-24: Failed preparing provisioner-block "shell" ""; render 'slice_string': template: root:1:2: executing "root" at <packer_version>: error calling packer_version: packer_version not available in: {{packer_version}} --- FAIL: TestParse_build (0.01s) ``` Test Results After Change ``` --- PASS: TestParse_build (0.02s) --- PASS: TestParse_build/provisioner_with_packer_version_interpolation (0.00s) ```	5 years ago
Wilken Rivera	a534c743cf	HCP Packer registry enabled Packer client (#11154) ... * Add working registry pkg * Add custom error for handling the loading of PAR environment variables * Working Publish to Build, with proper error handling for bucket names * Update hcp-sdk-go to use branch instead of mod replace directive * Update Packer build status configuration * Add support for HCP_PACKER_BUILD_FINGERPRINT env * Add support for publishing one or more PARtifacts from a single build * add git shas to this branch * Add ability to set provider name if available * Add working RegistryBuilder type * Add RegistryPostProcessor as wrapper post-processor * When in PAR mode a empty RegistryPostProcessor is added to the end of the post-processor list to publish all final image data. * Add support for updating a build from PAR that is not in a DONE state * Fix a small issue with creation the initial builds for an empty iteration. * Add PAR URL to post-processor display * Implement hcp_packer_registry block (#11168) * Update vendored Amazon plugin to v1.0.1-dev * Fix panic when running a Packer registry build in a clean directory * Remove the publishing of post-processor metadata from the registry post-processor. * Remove metadata add from registry_builder * Update registry builder to skip a build that was found to be DONE Co-authored-by: Megan Marsh <megan@hashicorp.com> Co-authored-by: Sylvia Moss <moss@hashicorp.com>	5 years ago
Adrien Delorme	9d0193ac14	add possibility to use variables everywhere in post-processor blocks (#11094) ... feature + tests. Including in: * name * only * except * keep_input_artifact Example file: ```hcl source "null" "example1" { communicator = "none" } source "null" "example2" { communicator = "none" } locals { except = "null.example1" } variable "only" { default = "null.example1" } build { sources = ["source.null.example1", "source.null.example2"] post-processor "shell-local" { except = [local.except] inline = ["echo first post-processor"] } post-processor "shell-local" { only = [var.only] inline = ["echo second post-processor"] } } ``` Ouput: ```shell-session $ packer build foo.pkr.hcl null.example1: output will be in this color. null.example2: output will be in this color. ==> null.example1: Running post-processor: (type shell-local) ==> null.example2: Running post-processor: (type shell-local) ==> null.example2 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell201696062 ==> null.example1 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell494781572 null.example1 (shell-local): second post-processor Build 'null.example1' finished after 61 milliseconds 432 microseconds. null.example2 (shell-local): first post-processor Build 'null.example2' finished after 111 milliseconds 678 microseconds. ==> Wait completed after 111 milliseconds 714 microseconds ``` close #4895	5 years ago
Yoan Blanc	36a7b28b5f	fix: print unchanged formatted file when using stdin (#11047) ... Signed-off-by: Yoan Blanc <yoan@dosimple.ch>	5 years ago
Adrien Delorme	4be9dfd183	Say so when an only or an except option did not match anything (#11050) ... * Say so when an only or an except option did not match anything	5 years ago
Sergio Conde Gómez	f6f2469d4d	fix: HCL "index" function now actually returns the index of the element (#11008)	5 years ago
Adrien Delorme	bf939b7474	Update types.build.provisioners.go ... if pause_before is invalid, that's an error	5 years ago
Adrien Delorme	87ba7258b3	Use packer-sdc in packer + remove mapstructure-to-hcl2 & struct-markdown (#10913) ... * start using `go:generate packer-sdc struct-markdown` * Update Makefile remove @go install ./cmd/struct-markdown * run go generate for struct-markdown * use //go:generate packer-sdc mapstructure-to-hcl2 * run go generate for mapstructure-to-hcl2 * remove struct-markdown and mapstructure-to-hcl2 * vendor vendors	5 years ago
Adrien Delorme	03d79a2c39	HCL2 variables: split validation from getting value (#10843) ... * HCL2 variables: split validation from getting value, to only This way we do this only once and log this only once. The errors were being ignored anyways. * Update types.variables_test.go	5 years ago
Adrien Delorme	77a29fc2f8	Allow to have `dynamic` blocks in a `build` block + tests (#10825) ... This : * allows to have a `build.dynamic` block * add tests * makes sure to show a correct message when a source was not found * display only name of source (instead of a weird map printout) * use a "Did you mean %q" feature where possible Because dynamic blocks need all variables to be evaluated and available, I moved parsing of everything that is not a variable to "after" variables are extrapolated. Meaning that dynamic block get expanded in the `init` phase and then only we start interpreting HCL2 content. After #10819 fix #10657	5 years ago
Adrien Delorme	0e3fcb589b	Implicit required_plugin blocks (#10732) ... * used components that don't have a required_plugin block will make Packer 'implicitly' require those. These components are manually selected and commented for now. * add tests * docs	5 years ago
Wilken Rivera	5e17dbeff2	Fix up regex in test	5 years ago
Adrien Delorme	ff01e6715a	HCL2: add templatefile function (#10776) ... * tests * docs	5 years ago
Megan Marsh	a6f907c688	tests	5 years ago
Megan Marsh	f12c89bd84	add legacy_isotime function to hcl funcs	5 years ago
Megan Marsh	60c961c021	Merge pull request #10457 from teddylear/feature/recursivefmt-2 ... Adding recursive flag to formatter to format subdirectories	5 years ago
Adrien Delorme	f32b67c3bb	Simplify error message when config file can't be "stat'd" (#10763) ... * remove confusing message when a stat error happens while trying to list HCL2 files * leave early if our first GetHCL2Files has errors	5 years ago
Adrien Delorme	160d932cce	remove weir "Cannot tell wether " + path + " is a directory" error	5 years ago
Adrien Delorme	e0fe579837	un-remove tests	5 years ago
Adrien Delorme	8ee8420408	simplify return	5 years ago
Adrien Delorme	25ee6a19a6	flatten if a little	5 years ago
Adrien Delorme	a6321ac137	remove debug line	5 years ago
Adrien Delorme	832c0f2b2a	actually run fmt tests and then remove debug statements	5 years ago
teddylear	22d373c279	Adding more debug logic	5 years ago
Adrien Delorme	7d30a5d79d	remove duplicate tests	5 years ago
Adrien Delorme	4e22147909	Merge remote-tracking branch 'origin/master' into pr/teddylear/10457	5 years ago
Adrien Delorme	8208f425c8	addrs: remove Plugin.ForDisplay func, the String one does the job ... to make things less confusing	5 years ago
Adrien Delorme	429262030f	fix paths for windows !	5 years ago
Adrien Delorme	4487152d1e	cosmetic commit	5 years ago
Adrien Delorme	72e4dc4cb5	update docs to remove 'magic' required_plugin block usages	5 years ago
Adrien Delorme	7809242f41	quote template example	5 years ago
Adrien Delorme	4cb94a67b0	Update types.variables.go	5 years ago
Adrien Delorme	029729225d	tests and fixes	5 years ago
Adrien Delorme	aeecfcd422	show version constrain error in case it's handy	5 years ago
Adrien Delorme	9f545c28fe	required_plugins: prevent using `plugin = "version"`, and show an example	5 years ago
Adrien Delorme	fe12d53e77	addr: remove support for defaulting plugin namespace and host	5 years ago
teddylear	0637601eda	Fixing recursive formatting tests to work on all platforms	5 years ago
Sylvia Moss	774c5903f6	Add error-cleanup-provisioner to HCL2 (#10604)	5 years ago
teddylear	d85286e228	Merging in master	5 years ago
Sylvia Moss	1e889078fd	add regex and regexall functions (#10601)	5 years ago
Adrien Delorme	ffbb110167	Test running plugins with fake and fresh plugins (#10595) ... * show error as to why plugin discovery failed * allow to run more manual tests after a plugin installation * test that a freshly installed external plugin can run	5 years ago
teddylear	d3754e3021	Updating recursive formatter tests to be cleaner and table driven	5 years ago
teddylear	40a97e29db	Clean up recursive format tests to be more accurate	5 years ago
teddylear	93df53a275	Refactor recursive formatting test cases to be table driven	5 years ago
teddylear	261abe0cae	Setting recursive fmt to false, updatting recursive fmt test to validate ... formatted files	5 years ago
teddylear	ab4b3a8465	Adding recursive flag to formatter to format subdirectories	5 years ago
Megan Marsh	ca123721a6	plugin loading failure should be considered an error so build will not try to run	5 years ago
Sylvia Moss	ef4afafde9	Fix force flag for hcl2 provisioners and post-processors (#10571)	5 years ago
Sylvia Moss	3ddb17ad86	Don't allow data sources to be used inside data sources (#10559)	5 years ago
Wilken Rivera	8ccd164f25	Update diagnostic detail to display list of PostProcessors (#10564)	5 years ago
Adrien Delorme	ed091163be	HCL2 Parse packer.required_plugins block + packer init (#10304) ... This adds the new `required_plugins` block to be nested under the packer block. Example: ```hcl packer { required_plugins { aws = { version = ">= 2.7.0" source = "azr/aws" } azure = ">= 2.7.0" } } ``` For example on darwin_amd64 Packer will install those under : * "${PACKER_HOME_DIR}/plugin/github.com/azr/amazon/packer-plugin-amazon_2.7.0_x5.0_darwin_amd64" * "${PACKER_HOME_DIR}/plugin/github.com/hashicorp/azure/packer-plugin-azure_2.7.0_x5.0_darwin_amd64_x5" + docs + tests	5 years ago
Megan Marsh	a5a1344948	Merge pull request #10516 from hashicorp/fix_uint8_hcl ... fix uint8	5 years ago
Megan Marsh	90fb09e52a	linting	5 years ago
Megan Marsh	21df997061	Handle case where list is empty ... Co-authored-by: Sylvia Moss <moss@hashicorp.com>	5 years ago
Megan Marsh	fbbda0f9d9	Sensitive locals (#10509) ... * Allow locals to be delcared as individual blocks, and give them the Sensitive flag * add docs for new local block * linting * add tests * modified parsing to use schema, check for dupes properly * update comment fix wording a liiitle * add tests for duplicate variables definition in two different files * remove unnecessary slice initialisation * fix crash by returning when decode error is hit * parseLocalVariables: only treat a local vars if its not nil also return in case of error return locals in case of error too * fix duplicate_locals test for windows Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>	5 years ago
Megan Marsh	e3b14d888b	create util function in hcl2 template that will load config values into hcl values without panicing if it finds something it cannot handle	5 years ago
Megan Marsh	c8d5d56f61	fix	5 years ago
Megan Marsh	a8c8d247bb	fix uint8	5 years ago
Sylvia Moss	d1ada744e1	Aws Secrets Manager data sources (#10505)	5 years ago
Megan Marsh	93008045cd	Merge pull request #10500 from hashicorp/format_stdin ... enable Packer fmt to read from stdin	5 years ago
Megan Marsh	2b0996daa6	dont print filename if its reading from stdin	5 years ago
Sylvia Moss	291121dd55	(2) Implement datasources (#10440)	5 years ago
Megan Marsh	40df74e95a	linting	5 years ago