180 Commits (dev_version_changes)

Author	SHA1	Message	Date
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Megan Marsh	73c349d09c	Merge pull request #8908 from hashicorp/fix_4795 ... provisioner/powershell: Add cleanup step to remove any temporarily created scripts	6 years ago
Lars Lehtonen	49f28c9439	provisioner/powershell: fix dropped error ... provisioner/powershell: improve error message	6 years ago
Wilken Rivera	4a46d6ff7b	docs/provisioner/powershell: Add documentation for `skip_clean` option	6 years ago
Wilken Rivera	fe721d8e11	test/provisioner/powershell: Add acceptance test for powershell provisioner cleanup ... Passing Tests ``` --- PASS: TestAccPowershellProvisioner_basic (282.02s) --- PASS: TestAccPowershellProvisioner_basic/testing_amazon-ebs_builder_against_powershell_provisioner (282.01s) PASS ok github.com/hashicorp/packer/provisioner/powershell 282.046s ``` Failing tests on master ``` 2020/04/08 09:59:34 Uploading file to 'c:/Windows/Temp/script.bat' 2020/04/08 09:59:36 [INFO] starting remote command: set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat" 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: C:\Users\Administrator>dir C:\Windows\Temp\packer-*.ps1 2020/04/08 09:59:36 ui: amazon-ebs: Volume in drive C has no label. 2020/04/08 09:59:36 [INFO] command 'set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat"' exited with code: 0 2020/04/08 09:59:36 ui: amazon-ebs: Volume Serial Number is 46CA-4083 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: Directory of C:\Windows\Temp 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 102 packer-acc-test-script-test.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 76 packer-acc-test-vars.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 2 File(s) 178 bytes 2020/04/08 09:59:36 ui: amazon-ebs: 0 Dir(s) 9,735,806,976 bytes free 2020/04/08 09:59:36 ui: ==> amazon-ebs: Provisioning step had errors: Running the cleanup provisioner, if present... 2020/04/08 09:59:36 ui: ==> amazon-ebs: Terminating the source AWS instance... 2020/04/08 10:00:09 ui: ==> amazon-ebs: Cleaning up any extra volumes... 2020/04/08 10:00:09 ui: ==> amazon-ebs: No volumes to clean up, skipping 2020/04/08 10:00:09 ui: ==> amazon-ebs: Deleting temporary security group... 2020/04/08 10:00:10 ui: ==> amazon-ebs: Deleting temporary keypair... 2020/04/08 10:00:11 ui error: Build 'amazon-ebs' errored: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] 2020/04/08 10:00:11 machine readable: error-count []string{"1"} 2020/04/08 10:00:11 ui error: ==> Some builds didn't complete successfully and had errors: 2020/04/08 10:00:11 machine readable: amazon-ebs,error []string{"Script exited with non-zero exit status: 0.Allowed exit codes are: [1]"} 2020/04/08 10:00:11 ui error: --> amazon-ebs: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] ``` test: Fix windows-shell command	6 years ago
Wilken Rivera	11db6014fa	provisioner/powershell: Update remote clean up logic ... * Add retry logic so that the provisioner will retry if it fails to upload/execute because of some restart provisioner step * Add a testConfigWithSkipClean for testing that the provisioner executes the correct commands * Add a test case for toggling the "skip_clean" config option	6 years ago
Wilken Rivera	f6a61e2511	provisioner/powershell: Add post clean up step to remove temp script files	6 years ago
Wilken Rivera	1eee0bca5f	Merge pull request #9011 from hashicorp/powershell-acceptance-test ... provisioner/powershell: Add basic Powershell provisioner acceptance tests	6 years ago
Megan Marsh	bdcc95f989	fix execution policy parser to not interfere with legit integers, and add tests (#8997)	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Moss	185deeeb38	Fix provisioner acc-test builder and provisioner store	6 years ago
Wilken Rivera	b183c5498f	provisioner/powershell: Add basic Powershell provisioner acceptance tests ... * Modifies the amazon-ebs builder with a windows build configuration ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/powershell/... -run=TestPowershellProvisioner_Inline --- PASS: TestPowershellProvisioner_Inline (256.50s) --- PASS: TestPowershellProvisioner_Inline/testing_amazon-ebs_builder_against_powershell_provisioner (256.50s) PASS ok github.com/hashicorp/packer/provisioner/powershell 256.525s ```	6 years ago
Megan Marsh	9eda2031d2	Remove redundant placeholder (#8503)	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	3389d843f0	update all provisioners that used the winrmpassword tooling to use the new generateddata option	6 years ago
Megan Marsh	39fd462b56	change all provision func signatures to use map[string]interface{}	6 years ago
Megan Marsh	0ca7c9f397	fix tests	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
Megan Marsh	f4c3501af5	pass struct of generated data into provision() call	6 years ago
Megan Marsh	7d4353864f	use shell struct in shell-local provisioner and post-processor.	6 years ago
nywilken	3522e13b1e	provisioner/shell: Add `env_var_format` support to shell provisioner ... * Move setting of default EnvVarFormat to the Prepare function * Add generated hcl2 structure for the updated Shell provisioner config * Move `EnvVarFormat` field to shared common shell type * Add description for the `env_var_format` parameter * Update `env_var_format` when used with `use_env_var_file`	6 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	6 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	6 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Megan Marsh	0f704fb5b2	These cancel functions have been obsolete since merge of c7ce4d598e	7 years ago
Megan Marsh	de7106c36b	Merge pull request #7696 from hashicorp/go_generate_from_makefile ... run `go generate ./...` from makefile & CI test that it generates no diff	7 years ago
Megan Marsh	4bf75ac0f3	fix null file descriptor error	7 years ago
Adrien Delorme	abd6eda6c9	generate execution policy from makefile ... * make generate now generates on `./...` instead of `.`	7 years ago
Adrien Delorme	478f80af83	remove unused func	7 years ago
Adrien Delorme	7005958155	execution policy: make everything more idiomatic ... * make possible execution policy values lowercase * prefix execution policies possibilities	7 years ago
Adrien Delorme	e62aba3788	allow to set ExecutionPolicy to none for powershell provisioner ... this has the effect to not wrap the command, which will allow to know the exit status of a command in docker	7 years ago
Adrien Delorme	e96409954a	add execution policy type and use it to default the powershell cmd	7 years ago
Paul Meyer	814665fddd	Check error returned from retry.Config.Run()	7 years ago
Paul Meyer	ec14ab4875	Add unit test to find issue #7655	7 years ago
Adrien Delorme	d72040f4fa	move retry code into the common/retry pkg and make retry context aware	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	c7ce4d598e	change Provisioner to be passed a context for cancellation	7 years ago
Adrien Delorme	a77ce59e36	Update provisioner_test.go ... remove unecessary test	7 years ago
Adrien Delorme	72e5ae9ddc	use ValidExitCode in provisioners windows-shell, powershell and shell	7 years ago
Adrien Delorme	30a65c858a	regroup shell provisioner params into a common struct	7 years ago
Adrien Delorme	9f7b4ffc17	Merge branch 'master' into pr/6950	7 years ago
Megan Marsh	70c6fcb824	Merge pull request #7078 from aspectcapital/issue-5478 ... Elevated support for puppet-* & chef-client provisioners	7 years ago
Adrien Delorme	b7222d1f56	Add tmp package that offers Dir & File funcs ... this regroups the calls of tmp func calls into one package. the tmp pkg allows to store tmp files under a common directory for easier managment Squashed commit of the following: commit 74b674c015 Merge: fc94b5714 66001525d Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 02:02:38 2018 -0400 Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs commit fc94b57142 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit 5a562359f4 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 9d5a4a0935 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit fbae4c2e05 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 3590fae8bd Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit d5c5306a97 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 0a72297da8 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 20f68228b6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit c73ebe3d83 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit 63549b8bd7 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit 9761010749 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit 95159afbc0 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 66001525d7 Author: Matthew Patton <mpatton@enquizit.com> Date: Fri Nov 2 01:42:38 2018 -0400 update tests to honor configured temporary directory commit e9b6adefea Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 18:52:38 2018 -0400 sync straggler to refactor. implement tests at packer/configfile instead of buried in docker. commit 852113ed07 Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 15:39:46 2018 -0400 insert URL to GoLang API for os.TempDir() commit 54add38d1d Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:41:29 2018 -0400 revise documentation to match code commit 6b5b8f6d4e Author: Matthew Patton <mpatton@enquizit.com> Date: Thu Nov 1 07:21:59 2018 -0400 refacter config_file. replace all hard-coded os.TempDir with wrapper commit c22092c601 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 20:11:36 2018 -0400 close massive file overwrite hole with TempDir commit 7a73045091 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 01:06:00 2018 -0400 adjust var declaration scope commit 0f2933adb6 Author: Matthew Patton <mpatton@enquizit.com> Date: Wed Oct 31 00:54:35 2018 -0400 use mktemp() equivalent to create temporary directory commit d74839ede0 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 20:40:58 2018 -0400 remove extraneous variable declaration, fix FOR loop commit eb65416619 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:30:44 2018 -0400 match styistic convension with rest of docs commit acaa2b31ed Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 19:08:39 2018 -0400 revert dangling config file change commit e573fde668 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri Dec 29 23:53:43 2017 -0500 replace invalid TMPDIR variable wth PACKER_TMP_DIR. update ConfigTmpDir() to try common temporary paths first and only write to configDir() as a last resort. commit 39a9874afc Merge: 8a413cfe8 3315812c2 Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Oct 30 18:19:26 2018 -0400 Merge branch 'master' of https://github.com/hashicorp/packer into prestine commit 8a413cfe83 Merge: e07491de5 4e14710a6 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Oct 1 20:18:10 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit e07491de59 Merge: 42610a35d a1fa35dff Author: Matthew Patton <mpatton@enquizit.com> Date: Tue Aug 21 13:26:19 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 42610a35d5 Merge: 5298142da 0d63cf7bc Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue Jun 19 22:45:05 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 5298142da6 Merge: 7bb110bc7 9d9736552 Author: Matthew Patton <mpatton@enquizit.com> Date: Mon Jun 11 15:10:09 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 7bb110bc74 Merge: a61c869ca 6189d66e7 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Wed May 9 23:41:22 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit a61c869ca7 Merge: 098101dd9 4be5f072c Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Fri May 4 10:13:04 2018 -0400 Merge remote-tracking branch 'upstream/master' into prestine commit 098101dd99 Merge: fefaf0fa6 554b2b4a5 Author: Matthew Patton <matthew.patton@itgfirm.com> Date: Tue May 1 20:52:30 2018 -0400 Merge branch 'EOL-handling' into prestine Co-Authored-By: Matthew Patton <pattonme@yahoo.com>	7 years ago
Matt Dainty	19bd28cd72	Fix/add tests	7 years ago
Matt Dainty	2e4b00f59d	Refactor powershell provisioner ... Use the common elevated code instead.	7 years ago
Megan Marsh	e69391f28b	save users some bash scripting by exposing IP and port separately as well as together	7 years ago
Matt Dainty	412119c27e	Fix powershell provisioner tests	7 years ago
Matt Dainty	3b519acebc	Allow Powershell provisioner to use service accounts ... Fixes #6104	7 years ago
Megan Marsh	1d1729a5ff	fix powershell tests to use new command	8 years ago
Megan Marsh	a81d18cdab	explicitly use set-variable to work around a bug some users saw where the command invocation would vail	8 years ago
Megan Marsh	a0edaf6c46	Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice ... Revert "use statebag instead of SetSharedState for winRM password" This reverts commit b35acbd879.	8 years ago
Megan Marsh	b35acbd879	use statebag instead of SetSharedState for winRM password	8 years ago
Megan Marsh	ff6a039d5b	replace scrubconfig with packer.LogSecretFilter.Set ... filter winrm password from logs Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.	8 years ago
DanHam	485d565e32	Ensure comments are easily readable in a standard terminal	8 years ago
DanHam	e0bcba4913	Make the upload of env vars retryable in case of restarts	8 years ago
DanHam	b738f41efa	Remove tmp files created by provisioner/powershell tests	8 years ago
DanHam	b9ab2c8048	Remove script containing PowerShell inline commands from local tmp when done	8 years ago
DanHam	ccf687dac6	Fix tests	8 years ago
DanHam	5419375413	Change to CMD % style path is no longer required	8 years ago
DanHam	5b652316d9	Dollar's in env vars used in paths may cause problems for ssh ... * Dollars are interpreted by *nix shells so paths using env vars such as ${env:SYSTEMROOT} will cause issues	8 years ago
DanHam	4e7feea184	Allow users to specify the location that the env vars file is uploaded to ... Previously the location the file was uploaded to was set internally and used ${env:SYSTEMROOT}/Temp as the destination folder. By default, in order to inject the required environment variables, the file is 'dot sourced' by the 'execute_command' using the {{ .Vars }} variable. Unfortunately the inclusion of the dollar in the path caused issues for users connecting over ssh as the (typically bash) shell running the execute command would try and interpret the dollar sign. The change allows users to specify the location the file is uploaded to, thereby allowing the user to specify a custom 'execute_command' that escapes any dollar signs that could be present in the path. If not set the upload path now defaults to using C:/Windows/Temp as the upload folder.	8 years ago
Megan Marsh	3afb243f11	use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.	8 years ago
DanHam	ef4817d644	Fix vertical spacing	8 years ago
DanHam	34db6c4ab1	Remove temp debugging output	8 years ago
Megan Marsh	4e321b2dfa	don't need to use a receiver with this function	8 years ago
Megan Marsh	ce1ab1f021	fix winrm password	8 years ago
Megan Marsh	559719020c	use {{.WinRMPassword}} instead of some other weirdness	8 years ago
Megan Marsh	d689e6b4d3	allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.	8 years ago
Josh Soref	24b4c36fc9	spelling: function	8 years ago
Josh Soref	04d6bfc696	spelling: environment	8 years ago
Megan Marsh	f3a538db46	fix tests	8 years ago
Megan Marsh	3faf73b5f3	change backslashes to forward slashes in powershell provisioner; was breaking with cygwin	8 years ago
DanHam	2d830d5d43	Auto escape chars special to PowerShell in user supplied data	8 years ago
DanHam	aaf7102b9a	Tests for escape of chars special to PowerShell in user supplied data	8 years ago
DanHam	a7b118ed94	Fix tests post changes. Add test for upload func.	8 years ago
DanHam	478589abec	Extend upload and subsequent 'dot sourcing' of env vars to std PS command ... * Wrap funcs to flatten and upload env vars with new func prepareEnvVars. While the wrapped funcs could be combined, keeping them separate simplifies testing. * Configure/refactor std and elevated PS to use new funcs to prepare, upload and dot source env vars. * Dot sourcing the env vars in this way avoids the need to embed them directly in the command string. This avoids the need to escape the env vars to ensure the command string is correctly parsed. * Characters within the env vars that are special to PS (such as $'s and backticks) will still need to be escaped to allow them to be correctly interpreted by PS. * The std and elevated PS commands now inject env vars into the remote env via the same mechanism. This ensures consistent behaviour across the two command types. Fixes #5471	8 years ago
Megan Marsh	addedbb680	Revert "Merge pull request #5515 from DanHam/dot-source-env-vars" ... revert so we can use a branch that's had more recent work done This reverts commit e56849c605, reversing changes made to 6d14eb6ea4.	8 years ago
Megan Marsh	79fe900378	Revert "Merge pull request #5376 from DanHam/ps-escapes" ... Revert so that we can merge a different branch that's had more recent work instead This reverts commit ba518637d4, reversing changes made to e56849c605.	8 years ago
DanHam	7443adf2fd	Simpler escape of chars special to PowerShell in user supplied data	8 years ago
DanHam	68e13c90b1	Revert "Escape chars special to PowerShell in user supplied data" ... This reverts commit 53aefe744bcd74ee6ac866f764eafe9e7f507d80.	8 years ago
DanHam	b67c64fd66	Tests for escape of chars special to PowerShell in user supplied data	8 years ago
DanHam	f3c326bb3c	Escape chars special to PowerShell in user supplied data	8 years ago
DanHam	4b89fc1c00	Fix tests post changes. Add test for upload func.	8 years ago
DanHam	5949bc91c4	Extend upload and subsequent 'dot sourcing' of env vars to std PS command ... * Wrap funcs to flatten and upload env vars with new func prepareEnvVars. While the wrapped funcs could be combined, keeping them separate simplifies testing. * Configure/refactor std and elevated PS to use new funcs to prepare, upload and dot source env vars. * Dot sourcing the env vars in this way avoids the need to embed them directly in the command string. This avoids the need to escape the env vars to ensure the command string is correctly parsed. * Characters within the env vars that are special to PS (such as $'s and backticks) will still need to be escaped to allow them to be correctly interpreted by PS. * The std and elevated PS commands now inject env vars into the remote env via the same mechanism. This ensures consistent behaviour across the two command types. Fixes #5471	8 years ago
DanHam	fa5fd602aa	Fix tests post changes	9 years ago
DanHam	8214a12a2a	Move append of portion of command used to send elevated PS output to file	9 years ago
DanHam	2a060adbf8	Don't use -EncodedCommand with PS as progress stream always leaks to stderr ... * Setting $ProgressPreference to SilentlyContinue makes no difference when -EncodedCommand is used - any output to the progress stream still appears on stderr. * Delete file containing encode/decode functions since we no longer need them. * Fixes leak of output on progress streams for both normal and elevated commands. * Since we no longer base64 encode, ensure any characters special to XML are correctly escaped in the elevated command. This ensures correct parsing once the command is wrapped within the elevatedTemplates XML based Task Scheduler definition. Fixes #4322	9 years ago
DanHam	5374c6e367	Use system context env var to set path for elevated PS env vars file	9 years ago
Matthew Hooker	af1187d5e1	simplify a bit	9 years ago
Megan Marsh	b05c673a14	Update powershell provisioner test with new default	9 years ago
Megan Marsh	cbe1d7d854	simplify file upload for elevated powershell wrapper	9 years ago
Megan Marsh	92e70757bb	Move env vars into a file that we dot-source instead of trying to write them all to the command line	9 years ago
Megan Marsh	d458628529	exclude elevated_executed_command from config interpolation so it can be used correctly later	9 years ago
Megan Marsh	c6889ad009	clarify logging by changing 'shell' to 'powershell' inside of the powershell provisioner	9 years ago
Megan Marsh	b2923b4da6	check stdout to make sure echo command actually goes through before counting computer as fully restarted	9 years ago
Megan Marsh	89b058604d	update tests for pull 5272	9 years ago
Megan Marsh	5214851463	make every script name unique	9 years ago
Luke Farnell	d9a5b69403	clean up ineffectual assignments	9 years ago