23 Commits (dev_version_changes)

Author	SHA1	Message	Date
Lucas Bajolet	b522edca36	hcl2_upgrade: add required_plugins in out template ... When a legacy JSON template references built-in plugins, we add them to the resulting template as a `required_plugins' block in HCL2.	3 years ago
Wilken Rivera	095959ed6d	Fix crash when variables block is undefined ... This change fixes a crash that occurs when trying to add undeclared variables into an empty variables map. The variables block when defined will always be non-nil but in the case where variables are declared and initialized from a legacy JSON variables file the map must be initialized first.	3 years ago
Wilken Rivera	dbeeab448a	cmd/hcl2_upgrade: Generate variable block for all referenced user input variables (#12136) ... Currently the HCL2 upgrade command generates a valid variable block for all variables within the JSON variables property. However JSON templates in Packer support variable interpolation for input variables defined within a variable definition file without it being declared within the variables property. When upgrading a JSON template to HCL2 the user variable reference gets converted to var.<var_name>. The upgraded template ultimately fails on validation or build execution with undefined variable errors, with this change the upgrade command will now create a variable block for all input variables referenced within the build template to ensure all required variables been defined.	4 years ago
Lucas Bajolet	68ddb2f89d	hcl2_upgrade: add share_image_gallery workaround (#12087) ... In azure templates, the shared_image_gallery was mistakenly considered an attribute while this is supposed to be a block. This is due to a heuristic we use for deciding whether a JSON object is to be translated to an attribute or a block that fell short as the shared_image_gallery does not contain complex types. This cannot be fixed trivially for the general case, so we add this entity to the list of workarounds until we can implement something more robust.	4 years ago
Lucas Bajolet	3c249c0d42	hcl2_upgrade: replace passthroughs by pre-visit ... In previous versions of hcl2_upgrade, we referenced a list of passthrough statements from the original JSON template to be replaced by their equivalent Go-template in HCL2. This works but requires us to explicitely accept every possible templated variable in order to not ever encounter <no value> in our generated HCL2 templates. This is suboptimal, hence this commit changes approach by pre-visting the AST from the original Go Template, escaping every sequence that is not covered by the list of functions we can migrate. Pipes are also excluded from this function.	4 years ago
Zach Shilton	879fd9035c	fix: update redirected and broken links (#12060) ... * website: fix broken links on /docs/templates * fix: redirected install-plugins link * fix: debugging link * fix: secrets manager link in docs * fix: secrets manager link in source * fix: amazon ami plugin link in docs * fix: amazon ami plugin link in source * fix: extending plugins link * fix: plugins/builders/amazon links * fix: various builders links * fix: various amazon builder links * fix: redirected terminology link * fix: custom-provisioners link * fix: docker-push redirected plugin link * fix: googlecompute plugin links * fix: hyperv iso plugin links * website: update link to hcl upgrade guide Co-authored-by: Wilken Rivera <wilken@hashicorp.com> Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
Adrien Delorme	eb8e302941	hcl2_upgrade: special case: vsphere fix (#11216) ... * fix typo * hcl2_upgrade: special case linux_options and network_interface to block instead of maps * Update hcl2_upgrade_test.go * Update hcl2_upgrade_test.go remove unused code * hcl2_upgrade: support strftime too (#11220) * hcl2_upgrade strftime function * create legacy_strftime.mdx	5 years ago
Sylvia Moss	927093e5c0	improve regex to fix escaping on split function (#11083)	5 years ago
Adrien Delorme	98990fc34e	hcl2_upgrade: allow to hcl2_upgrade with unknown builders, just log errors (#11049)	5 years ago
Adrien Delorme	a9bec7945e	remove .mdx extensions in links (#10823) ... Some of them were added in #10800 some where already there	5 years ago
Sylvia Moss	505cbd2591	Vendor amazon plugin (#10800) ... * remove amazon from core * vendor amazon plugin * remove website content * Add amazon to docs-remote-plugins * update amazon reference links in the documentation * update amazon docs version to latest Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	5 years ago
Megan Marsh	0993c976fa	hcl2_upgrade escaped quotes fix (#10794) ... * clean up extra quoting that can cause text template failures. when everyone else abandons you, regex will always be there. * LINTING	5 years ago
Megan Marsh	4242cf3151	fix tests	5 years ago
Sylvia Moss	610dde7f02	check for nil config map (#10730)	5 years ago
sylviamoss	5ccbd27b72	Improve upgrade error and transform all variables with template eng to locals	5 years ago
sylviamoss	a1a5cf0113	upgrade variables with other variables	5 years ago
sylviamoss	2016d6baec	Fix panic on upgrading variables json file	5 years ago
Sylvia Moss	37d05c85ff	upgrade pause_before (#10654)	5 years ago
Sylvia Moss	e0557f84e9	Add access config to generated amazon ami data source (#10634)	5 years ago
sylviamoss	76e3d57cae	add with-annotation flag to hcl2_upgrade	5 years ago
Sylvia Moss	774c5903f6	Add error-cleanup-provisioner to HCL2 (#10604)	5 years ago
Sylvia Moss	d28e6fe009	write timestamp local only when necessary (#10602)	5 years ago
Sylvia Moss	f5006d0842	fix empty locals and source name with blank space (#10593)	5 years ago