From e94ed9a6835cab7a009b41e73218df3b161131a1 Mon Sep 17 00:00:00 2001 From: Chris Cunningham Date: Thu, 6 Feb 2020 17:38:57 +0100 Subject: [PATCH 1/2] update the note about Windows symlinks GH-7534 and GH-7545 disabled the use of symlinks for copying local ISOs, per: https://github.com/hashicorp/packer/blob/master/common/step_download.go#L106 Update the documentation to match, as without reading the source it is implied that this should work. --- common/iso_config.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/common/iso_config.go b/common/iso_config.go index 0edd86bd8..67769dfb3 100644 --- a/common/iso_config.go +++ b/common/iso_config.go @@ -29,11 +29,9 @@ import ( // * Amazon S3 // // -// \~> On windows - when referencing a local iso - if packer is running -// without symlinking rights, the iso will be copied to the cache folder. Read -// [Symlinks in Windows 10 -// !](https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/) -// for more info. +// \~> On Windows, using a symlink to refer to local files is currently +// unsupported. Packer will always copy a local iso into the Packer cache +// directory. // // Examples: // go-getter can guess the checksum type based on `iso_checksum` len. From bfa8b17039c33416a52092a7db9b7e8a67382db0 Mon Sep 17 00:00:00 2001 From: Megan Marsh Date: Thu, 6 Feb 2020 17:02:01 -0800 Subject: [PATCH 2/2] regenerate docs --- website/source/partials/common/_ISOConfig.html.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/website/source/partials/common/_ISOConfig.html.md b/website/source/partials/common/_ISOConfig.html.md index ab0097107..ef395403e 100644 --- a/website/source/partials/common/_ISOConfig.html.md +++ b/website/source/partials/common/_ISOConfig.html.md @@ -12,11 +12,9 @@ go-getter supports the following protocols: * HTTP * Amazon S3 -\~> On windows - when referencing a local iso - if packer is running -without symlinking rights, the iso will be copied to the cache folder. Read -[Symlinks in Windows 10 -!](https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/) -for more info. +\~> On Windows, using a symlink to refer to local files is currently +unsupported. Packer will always copy a local iso into the Packer cache +directory. Examples: go-getter can guess the checksum type based on `iso_checksum` len.