From fdeadfe3f698e8bf6d5733b878409db3cbd4bf3f Mon Sep 17 00:00:00 2001 From: Matthew Hooker Date: Fri, 10 Feb 2017 00:49:47 -0800 Subject: [PATCH] builder/vmware: correctly default export format to ovf --- builder/vmware/iso/builder.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/builder/vmware/iso/builder.go b/builder/vmware/iso/builder.go index 60c0fc462..39f221b42 100644 --- a/builder/vmware/iso/builder.go +++ b/builder/vmware/iso/builder.go @@ -212,11 +212,13 @@ func (b *Builder) Prepare(raws ...interface{}) ([]string, error) { } } - if b.config.Format != "" { - if !(b.config.Format == "ova" || b.config.Format == "ovf" || b.config.Format == "vmx") { - errs = packer.MultiErrorAppend(errs, - fmt.Errorf("format must be one of ova, ovf, or vmx")) - } + if b.config.Format == "" { + b.config.Format = "ovf" + } + + if !(b.config.Format == "ova" || b.config.Format == "ovf" || b.config.Format == "vmx") { + errs = packer.MultiErrorAppend(errs, + fmt.Errorf("format must be one of ova, ovf, or vmx")) } // Warnings @@ -256,7 +258,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe exportOutputPath := b.config.OutputDir - if b.config.RemoteType != "" && b.config.Format != "" { + if b.config.RemoteType != "" { b.config.OutputDir = b.config.VMName } dir.SetOutputDir(b.config.OutputDir)