From efd69aea2a4ae83e344f886a8478e2f30de71cae Mon Sep 17 00:00:00 2001 From: Adrien Delorme Date: Wed, 2 Sep 2020 17:19:56 +0200 Subject: [PATCH] console: allow to use console when there are untyped vars (#9864) * the var will simply be "unknown" * add a test --- command/console.go | 6 +----- command/console_test.go | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/command/console.go b/command/console.go index ea43771b2..38bc1c726 100644 --- a/command/console.go +++ b/command/console.go @@ -60,11 +60,7 @@ func (c *ConsoleCommand) RunContext(ctx context.Context, cla *ConsoleArgs) int { return ret } - diags := packerStarter.Initialize() - ret = writeDiags(c.Ui, nil, diags) - if ret != 0 { - return ret - } + _ = packerStarter.Initialize() // Determine if stdin is a pipe. If so, we evaluate directly. if c.StdinPiped() { diff --git a/command/console_test.go b/command/console_test.go index 3988c648e..bfc5fd65c 100644 --- a/command/console_test.go +++ b/command/console_test.go @@ -35,6 +35,7 @@ func Test_console(t *testing.T) { {"var.list_of_string[0]", []string{"console", `-var=list_of_string=["first"]`, filepath.Join(testFixture("hcl", "variables", "list_of_string"))}, nil, "first\n"}, {"var.untyped[2]", []string{"console", filepath.Join(testFixture("hcl", "variables", "untyped_var"))}, nil, "strings\n"}, {"var.untyped", []string{"console", `-var=untyped=just_a_string`, filepath.Join(testFixture("hcl", "variables", "untyped_var"))}, nil, "just_a_string\n"}, + {"var.untyped", []string{"console", filepath.Join(testFixture("hcl", "variables", "untyped_var", "var.pkr.hcl"))}, nil, "\n"}, {"var.untyped", []string{"console", filepath.Join(testFixture("hcl", "variables", "untyped_var", "var.pkr.hcl"))}, []string{"PKR_VAR_untyped=just_a_string"}, "just_a_string\n"}, }