Report metadata only when the build completes (#12922)

* Report metadata only when the build completes

* Lint lord

internal/hcp/registry/hcl.go

@@ -71,11 +71,6 @@ func (h *HCLRegistry) StartBuild(ctx context.Context, build sdkpacker.Build) err
 		name = cb.Type
 	}
 
-	metadata := cb.GetMetadata()
-	err := h.bucket.Version.AddMetadataToBuild(ctx, name, metadata)
-	if err != nil {
-		return err
-	}
 	return h.bucket.startBuild(ctx, name)
 }
 

internal/hcp/registry/json.go

@@ -84,12 +84,6 @@ func (h *JSONRegistry) PopulateVersion(ctx context.Context) error {
 // StartBuild is invoked when one build for the configuration is starting to be processed
 func (h *JSONRegistry) StartBuild(ctx context.Context, build sdkpacker.Build) error {
 	name := build.Name()
-
-	metadata := build.(*packer.CoreBuild).GetMetadata()
-	err := h.bucket.Version.AddMetadataToBuild(ctx, name, metadata)
-	if err != nil {
-		return err
-	}
 	return h.bucket.startBuild(ctx, name)
 }
 

internal/hcp/registry/types.bucket.go

@@ -213,7 +213,7 @@ func (bucket *Bucket) UpdateBuildStatus(
 		nil,
 		status,
 		nil,
-		&buildToUpdate.Metadata,
+		nil,
 	)
 	if err != nil {
 		return err