From ea3c73a480a59ff1885fe86dfa98b504da604fb5 Mon Sep 17 00:00:00 2001 From: Wilken Rivera Date: Thu, 3 Mar 2022 17:30:27 -0500 Subject: [PATCH] Set default file extension for binary installations on Windows (#11625) This change sets the default file extension for binary installations on Windows. Results before change ``` $ packer plugins install github.com/hashicorp/amazon 9 errors occurred: * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_freebsd_arm64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_darwin_amd64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_freebsd_amd64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_linux_amd64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_darwin_arm64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_windows_arm64.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_windows_386.zip: wrong system, expected windows_amd64 * ignoring invalid remote binary packer-plugin-amazon_v1.0.8_x5.0_linux_arm.zip: wrong system, expected windows_amd64 * could not find a packer-plugin-amazon_v1.0.8_x5.0_windows_amd64.zip file in zipfile exit status 1 ``` Results after change ``` $ packer plugins install github.com/hashicorp/amazon Installed plugin github.com/hashicorp/amazon v1.0.8 in "C:/Users/Packer/AppData/Roaming/packer.d/plugins/github.com/hashicorp/amazon/packer-plugin-amazon_v1.0.8_x5.0_windows_amd64.exe" ``` --- command/plugins_install.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/command/plugins_install.go b/command/plugins_install.go index 2e14fcca2..f9fd02447 100644 --- a/command/plugins_install.go +++ b/command/plugins_install.go @@ -86,6 +86,10 @@ func (c *PluginsInstallCommand) RunContext(buildCtx context.Context, args []stri pluginRequirement.VersionConstraints = constraints } + if runtime.GOOS == "windows" && opts.Ext == "" { + opts.BinaryInstallationOptions.Ext = ".exe" + } + getters := []plugingetter.Getter{ &github.Getter{ // In the past some terraform plugins downloads were blocked from a