From cbe7e9113a230d2450cd13ef3dcffc031d085ae3 Mon Sep 17 00:00:00 2001
From: Matthew Hooker <mwhooker@gmail.com>
Date: Tue, 13 Dec 2016 16:32:15 -0800
Subject: [PATCH] return early if no set visibility

---
 .../openstack/step_update_image_visibility.go | 44 ++++++++++---------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/builder/openstack/step_update_image_visibility.go b/builder/openstack/step_update_image_visibility.go
index fbfdf1431..96bd9d59c 100644
--- a/builder/openstack/step_update_image_visibility.go
+++ b/builder/openstack/step_update_image_visibility.go
@@ -15,29 +15,31 @@ func (s *stepUpdateImageVisibility) Run(state multistep.StateBag) multistep.Step
 	ui := state.Get("ui").(packer.Ui)
 	config := state.Get("config").(Config)
 
-	if config.ImageVisibility != "" {
-		imageClient, err := config.imageV2Client()
-		if err != nil {
-			err = fmt.Errorf("Error initializing image service client: %s", err)
-			state.Put("error", err)
-			return multistep.ActionHalt
-		}
-		ui.Say(fmt.Sprintf("Updating image visibility to %s", config.ImageVisibility))
-		r := imageservice.Update(
-			imageClient,
-			imageId,
-			imageservice.UpdateOpts{
-				imageservice.UpdateVisibility{
-					Visibility: config.ImageVisibility,
-				},
+	if config.ImageVisibility == "" {
+		return multistep.ActionContinue
+	}
+	imageClient, err := config.imageV2Client()
+	if err != nil {
+		err = fmt.Errorf("Error initializing image service client: %s", err)
+		state.Put("error", err)
+		return multistep.ActionHalt
+	}
+
+	ui.Say(fmt.Sprintf("Updating image visibility to %s", config.ImageVisibility))
+	r := imageservice.Update(
+		imageClient,
+		imageId,
+		imageservice.UpdateOpts{
+			imageservice.UpdateVisibility{
+				Visibility: config.ImageVisibility,
 			},
-		)
-		if _, err = r.Extract(); err != nil {
-			err = fmt.Errorf("Error updating image visibility: %s", err)
-			state.Put("error", err)
-			return multistep.ActionHalt
-		}
+		},
+	)
 
+	if _, err = r.Extract(); err != nil {
+		err = fmt.Errorf("Error updating image visibility: %s", err)
+		state.Put("error", err)
+		return multistep.ActionHalt
 	}
 
 	return multistep.ActionContinue