From c8a60c77d10817b1a4180db482ff63018ca17cb9 Mon Sep 17 00:00:00 2001 From: Joel Lopes Date: Thu, 21 Feb 2019 18:12:57 -0800 Subject: [PATCH] Add comments --- builder/azure/arm/builder.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/builder/azure/arm/builder.go b/builder/azure/arm/builder.go index f6f3a1f33..c591893f0 100644 --- a/builder/azure/arm/builder.go +++ b/builder/azure/arm/builder.go @@ -59,6 +59,9 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe b.ctxCancel = cancel defer cancel() + // User's intent to use MSI is indicated with empty subscription id, tenant, client id, client cert, client secret and jwt. + // FillParameters function will set subscription and tenant id here. Therefore getServicePrincipalTokens won't select right auth type. + // If we run this after getServicePrincipalTokens call then getServicePrincipalTokens won't have tenant id. if !b.config.useMSI() { if err := newConfigRetriever().FillParameters(b.config); err != nil { return nil, err @@ -76,6 +79,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe return nil, err } + // We need subscription id and tenant id for arm operations. Users hasn't specified one so we try to detect them here. if b.config.useMSI() { if err := newConfigRetriever().FillParameters(b.config); err != nil { return nil, err