From c7d7e2cf0f34683b41f6aa4956bc55577d992621 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Tue, 19 Nov 2013 21:31:54 -0800 Subject: [PATCH] packer: don't change background color in UI --- CHANGELOG.md | 3 +++ packer/ui.go | 2 +- packer/ui_test.go | 6 +++--- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5863fbe0..f9ac6e548 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,9 @@ ## 0.4.1 (unreleased) +BUG FIXES: +* core: Don't change background color on CLI anymore, making things look + a tad nicer in some terminals. ## 0.4.0 (November 19, 2013) diff --git a/packer/ui.go b/packer/ui.go index 8ede82703..e0a4685ce 100644 --- a/packer/ui.go +++ b/packer/ui.go @@ -106,7 +106,7 @@ func (u *ColoredUi) colorize(message string, color UiColor, bold bool) string { attr = 1 } - return fmt.Sprintf("\033[%d;%d;40m%s\033[0m", attr, color, message) + return fmt.Sprintf("\033[%d;%dm%s\033[0m", attr, color, message) } func (u *ColoredUi) supportsColors() bool { diff --git a/packer/ui_test.go b/packer/ui_test.go index c8168a19e..c411eb0e5 100644 --- a/packer/ui_test.go +++ b/packer/ui_test.go @@ -19,19 +19,19 @@ func TestColoredUi(t *testing.T) { ui.Say("foo") result := readWriter(bufferUi) - if result != "\033[1;33;40mfoo\033[0m\n" { + if result != "\033[1;33mfoo\033[0m\n" { t.Fatalf("invalid output: %s", result) } ui.Message("foo") result = readWriter(bufferUi) - if result != "\033[0;33;40mfoo\033[0m\n" { + if result != "\033[0;33mfoo\033[0m\n" { t.Fatalf("invalid output: %s", result) } ui.Error("foo") result = readWriter(bufferUi) - if result != "\033[1;31;40mfoo\033[0m\n" { + if result != "\033[1;31mfoo\033[0m\n" { t.Fatalf("invalid output: %s", result) } }