From 5a0dc48f0fddd7fbe80a31d5bbe90a1f6d242291 Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Tue, 5 Nov 2019 11:40:42 -0800 Subject: [PATCH] builder/file: defer close after testing for errors --- builder/file/builder.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/file/builder.go b/builder/file/builder.go index f4e95c194..0defa6049 100644 --- a/builder/file/builder.go +++ b/builder/file/builder.go @@ -39,17 +39,17 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack if b.config.Source != "" { source, err := os.Open(b.config.Source) - defer source.Close() if err != nil { return nil, err } + defer source.Close() // Create will truncate an existing file target, err := os.Create(b.config.Target) - defer target.Close() if err != nil { return nil, err } + defer target.Close() ui.Say(fmt.Sprintf("Copying %s to %s", source.Name(), target.Name())) bytes, err := io.Copy(target, source)