diff --git a/builder/azure/arm/artifact.go b/builder/azure/arm/artifact.go index d90a178f2..f9bb25d81 100644 --- a/builder/azure/arm/artifact.go +++ b/builder/azure/arm/artifact.go @@ -40,7 +40,7 @@ type Artifact struct { AdditionalDisks *[]AdditionalDiskArtifact } -func NewManagedImageArtifact(osType, resourceGroup, name, location, id, osDiskSnapshotName, osDiskSnapshotPrefix string) (*Artifact, error) { +func NewManagedImageArtifact(osType, resourceGroup, name, location, id, osDiskSnapshotName, dataDiskSnapshotPrefix string) (*Artifact, error) { return &Artifact{ ManagedImageResourceGroupName: resourceGroup, ManagedImageName: name, @@ -48,7 +48,7 @@ func NewManagedImageArtifact(osType, resourceGroup, name, location, id, osDiskSn ManagedImageId: id, OSType: osType, ManagedImageOSDiskSnapshotName: osDiskSnapshotName, - ManagedImageDataDiskSnapshotPrefix: osDiskSnapshotPrefix, + ManagedImageDataDiskSnapshotPrefix: dataDiskSnapshotPrefix, }, nil } diff --git a/builder/azure/arm/artifact_test.go b/builder/azure/arm/artifact_test.go index 340212bcd..11b8c3b2a 100644 --- a/builder/azure/arm/artifact_test.go +++ b/builder/azure/arm/artifact_test.go @@ -42,14 +42,67 @@ func TestArtifactIdVHD(t *testing.T) { } func TestArtifactIDManagedImage(t *testing.T) { - artifact, err := NewManagedImageArtifact("Linux", "fakeResourceGroup", "fakeName", "fakeLocation", "fakeID", "fakeOSDiskSnapshotName", "fakeOSDiskSnapshotPrefix") + artifact, err := NewManagedImageArtifact("Linux", "fakeResourceGroup", "fakeName", "fakeLocation", "fakeID", "fakeOsDiskSnapshotName", "fakeDataDiskSnapshotPrefix") if err != nil { t.Fatalf("err=%s", err) } - expected := "fakeID" + expected := `Azure.ResourceManagement.VMImage: - result := artifact.Id() +OSType: Linux +ManagedImageResourceGroupName: fakeResourceGroup +ManagedImageName: fakeName +ManagedImageId: fakeID +ManagedImageLocation: fakeLocation +ManagedImageOSDiskSnapshotName: fakeOsDiskSnapshotName +ManagedImageDataDiskSnapshotPrefix: fakeDataDiskSnapshotPrefix +` + + result := artifact.String() + if result != expected { + t.Fatalf("bad: %s", result) + } +} + +func TestArtifactIDManagedImageWithoutOSDiskSnapshotName(t *testing.T) { + artifact, err := NewManagedImageArtifact("Linux", "fakeResourceGroup", "fakeName", "fakeLocation", "fakeID", "", "fakeDataDiskSnapshotPrefix") + if err != nil { + t.Fatalf("err=%s", err) + } + + expected := `Azure.ResourceManagement.VMImage: + +OSType: Linux +ManagedImageResourceGroupName: fakeResourceGroup +ManagedImageName: fakeName +ManagedImageId: fakeID +ManagedImageLocation: fakeLocation +ManagedImageDataDiskSnapshotPrefix: fakeDataDiskSnapshotPrefix +` + + result := artifact.String() + if result != expected { + t.Fatalf("bad: %s", result) + } +} + +func TestArtifactIDManagedImageWithoutDataDiskSnapshotPrefix(t *testing.T) { + artifact, err := NewManagedImageArtifact("Linux", "fakeResourceGroup", "fakeName", "fakeLocation", "fakeID", "fakeOsDiskSnapshotName", "") + if err != nil { + t.Fatalf("err=%s", err) + } + + expected := `Azure.ResourceManagement.VMImage: + +OSType: Linux +ManagedImageResourceGroupName: fakeResourceGroup +ManagedImageName: fakeName +ManagedImageId: fakeID +ManagedImageLocation: fakeLocation +ManagedImageOSDiskSnapshotName: fakeOsDiskSnapshotName +` + + result := artifact.String() if result != expected { t.Fatalf("bad: %s", result) }