From b5ed1784c2520976e511e40480d5514d7a15e61a Mon Sep 17 00:00:00 2001 From: Devashish Date: Fri, 30 May 2025 09:28:26 -0400 Subject: [PATCH] Update PR template for PCI (#13387) --- .github/PULL_REQUEST_TEMPLATE.md | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 243d89310..cd88455f6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,19 +1,31 @@ -**DELETE THIS TEMPLATE BEFORE SUBMITTING** +**DELETE THIS PART BEFORE SUBMITTING** In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a PR, and understand the lifecycle -of a Packer PR: - -https://github.com/hashicorp/packer/blob/master/.github/CONTRIBUTING.md#opening-an-pull-request - -Describe the change you are making here! +of a Packer Plugin PR: +- https://github.com/hashicorp/$REPO_NAME/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request Please include tests. Check out these examples: - https://github.com/hashicorp/packer/blob/master/builder/parallels/common/ssh_config_test.go#L34 - https://github.com/hashicorp/packer/blob/master/post-processor/compress/post-processor_test.go#L153-L182 -If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged: +---- + +### Description +What code changed, and why? +### Resolved Issues +If your PR resolves any open issue(s), please indicate them like this so they +will be closed when your PR is merged: Closes #xxx Closes #xxx + + +### Rollback Plan +If a change needs to be reverted, we will roll out an update to the code within +7 days. + +### Changes to Security Controls +Are there any changes to security controls (access controls, encryption, logging) +in this pull request? If so, explain.