From ab9621ab7d83a56eea02e11134edf8a941ed294d Mon Sep 17 00:00:00 2001 From: Chris Bednarski Date: Tue, 14 Jun 2016 14:34:01 -0700 Subject: [PATCH] Added aws shutdown_behavior to the changelog --- CHANGELOG.md | 1 + builder/amazon/common/run_config.go | 41 +++++++++++++++-------------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75affa64f..a8ee70bd3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ IMPROVEMENTS: * builder/amazon: Added `disable_stop_instance` option to prevent automatic shutdown when the build is complete [GH-3352] * builder/amazon: Added `skip_region_validation` option to allow newer or custom AWS regions [GH-3598] + * builder/amazon: Added `shutdown_behavior` option to support `stop` or `terminate` at the end of the build [GH-3556] * builder/azure: Now pre-validates `capture_container_name` and `capture_name_prefix` [GH-3537] * builder/azure: Support for custom images [GH-3575] diff --git a/builder/amazon/common/run_config.go b/builder/amazon/common/run_config.go index 055202c46..729ebce13 100644 --- a/builder/amazon/common/run_config.go +++ b/builder/amazon/common/run_config.go @@ -4,35 +4,37 @@ import ( "errors" "fmt" "os" - "time" "regexp" + "time" "github.com/mitchellh/packer/common/uuid" "github.com/mitchellh/packer/helper/communicator" "github.com/mitchellh/packer/template/interpolate" ) +var reShutdownBehavior = regexp.MustCompile("^(stop|terminate)$") + // RunConfig contains configuration for running an instance from a source // AMI and details on how to access that launched image. type RunConfig struct { - AssociatePublicIpAddress bool `mapstructure:"associate_public_ip_address"` - AvailabilityZone string `mapstructure:"availability_zone"` - EbsOptimized bool `mapstructure:"ebs_optimized"` - IamInstanceProfile string `mapstructure:"iam_instance_profile"` - InstanceType string `mapstructure:"instance_type"` - RunTags map[string]string `mapstructure:"run_tags"` - SourceAmi string `mapstructure:"source_ami"` - SpotPrice string `mapstructure:"spot_price"` - SpotPriceAutoProduct string `mapstructure:"spot_price_auto_product"` - DisableStopInstance bool `mapstructure:"disable_stop_instance"` - SecurityGroupId string `mapstructure:"security_group_id"` - SecurityGroupIds []string `mapstructure:"security_group_ids"` - SubnetId string `mapstructure:"subnet_id"` - TemporaryKeyPairName string `mapstructure:"temporary_key_pair_name"` - UserData string `mapstructure:"user_data"` - UserDataFile string `mapstructure:"user_data_file"` - WindowsPasswordTimeout time.Duration `mapstructure:"windows_password_timeout"` - VpcId string `mapstructure:"vpc_id"` + AssociatePublicIpAddress bool `mapstructure:"associate_public_ip_address"` + AvailabilityZone string `mapstructure:"availability_zone"` + EbsOptimized bool `mapstructure:"ebs_optimized"` + IamInstanceProfile string `mapstructure:"iam_instance_profile"` + InstanceType string `mapstructure:"instance_type"` + RunTags map[string]string `mapstructure:"run_tags"` + SourceAmi string `mapstructure:"source_ami"` + SpotPrice string `mapstructure:"spot_price"` + SpotPriceAutoProduct string `mapstructure:"spot_price_auto_product"` + DisableStopInstance bool `mapstructure:"disable_stop_instance"` + SecurityGroupId string `mapstructure:"security_group_id"` + SecurityGroupIds []string `mapstructure:"security_group_ids"` + SubnetId string `mapstructure:"subnet_id"` + TemporaryKeyPairName string `mapstructure:"temporary_key_pair_name"` + UserData string `mapstructure:"user_data"` + UserDataFile string `mapstructure:"user_data_file"` + WindowsPasswordTimeout time.Duration `mapstructure:"windows_password_timeout"` + VpcId string `mapstructure:"vpc_id"` InstanceInitiatedShutdownBehavior string `mapstructure:"shutdown_behaviour"` // Communicator settings @@ -86,7 +88,6 @@ func (c *RunConfig) Prepare(ctx *interpolate.Context) []error { } } - var reShutdownBehavior = regexp.MustCompile("(stop|terminate)") if c.InstanceInitiatedShutdownBehavior == "" { c.InstanceInitiatedShutdownBehavior = "stop" } else if !reShutdownBehavior.MatchString(c.InstanceInitiatedShutdownBehavior) {