Merge pull request #10577 from hashicorp/fix_build_run_diags

plugin loading failure should be considered an error so build will no…

hcl2template/types.build.post-processor.go

@@ -59,9 +59,10 @@ func (cfg *PackerConfig) startPostProcessor(source SourceUseBlock, pp *PostProce
 	postProcessor, err := cfg.parser.PluginConfig.PostProcessors.Start(pp.PType)
 	if err != nil {
 		diags = append(diags, &hcl.Diagnostic{
-			Summary: fmt.Sprintf("Failed loading %s", pp.PType),
-			Subject: pp.DefRange.Ptr(),
-			Detail:  err.Error(),
+			Severity: hcl.DiagError,
+			Summary:  fmt.Sprintf("Failed loading %s", pp.PType),
+			Subject:  pp.DefRange.Ptr(),
+			Detail:   err.Error(),
 		})
 		return nil, diags
 	}

hcl2template/types.build.provisioners.go

@@ -146,9 +146,10 @@ func (cfg *PackerConfig) startProvisioner(source SourceUseBlock, pb *Provisioner
 	provisioner, err := cfg.parser.PluginConfig.Provisioners.Start(pb.PType)
 	if err != nil {
 		diags = append(diags, &hcl.Diagnostic{
-			Summary: fmt.Sprintf("failed loading %s", pb.PType),
-			Subject: pb.HCL2Ref.LabelsRanges[0].Ptr(),
-			Detail:  err.Error(),
+			Severity: hcl.DiagError,
+			Summary:  fmt.Sprintf("failed loading %s", pb.PType),
+			Subject:  pb.HCL2Ref.LabelsRanges[0].Ptr(),
+			Detail:   err.Error(),
 		})
 		return nil, diags
 	}

hcl2template/types.source.go

@@ -101,8 +101,9 @@ func (cfg *PackerConfig) startBuilder(source SourceUseBlock, ectx *hcl.EvalConte
 	builder, err := cfg.parser.PluginConfig.Builders.Start(source.Type)
 	if err != nil {
 		diags = append(diags, &hcl.Diagnostic{
-			Summary: "Failed to load " + sourceLabel + " type",
-			Detail:  err.Error(),
+			Severity: hcl.DiagError,
+			Summary:  "Failed to load " + sourceLabel + " type",
+			Detail:   err.Error(),
 		})
 		return builder, diags, nil
 	}