From a13a2511f986bddd4bdefc04e3a7555bf6faf831 Mon Sep 17 00:00:00 2001 From: Hariharan Jayaraman Date: Mon, 21 May 2018 22:20:36 -0700 Subject: [PATCH] Added additional error message if we failed to parse token --- builder/azure/arm/builder.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/builder/azure/arm/builder.go b/builder/azure/arm/builder.go index bb67e5622..23d3d2181 100644 --- a/builder/azure/arm/builder.go +++ b/builder/azure/arm/builder.go @@ -92,7 +92,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe return nil, err } if b.config.ObjectID == "" { - b.config.ObjectID = getObjectIdFromToken(spnCloud) + b.config.ObjectID = getObjectIdFromToken(ui, spnCloud) } else { ui.Message("You have provided Object_ID which is no longer needed, azure packer builder determines this dynamically from the authentication token") } @@ -423,7 +423,7 @@ func (b *Builder) getServicePrincipalTokens(say func(string)) (*adal.ServicePrin return servicePrincipalToken, servicePrincipalTokenVault, nil } -func getObjectIdFromToken(token *adal.ServicePrincipalToken) string { +func getObjectIdFromToken(ui packer.Ui, token *adal.ServicePrincipalToken) string { claims := jwt.MapClaims{} var p jwt.Parser @@ -432,6 +432,7 @@ func getObjectIdFromToken(token *adal.ServicePrincipalToken) string { _, _, err = p.ParseUnverified(token.OAuthToken(), claims) if err != nil { + ui.Error(fmt.Sprintf("Failed to parse the token,Error: %s", err.Error())) return "" } return claims["oid"].(string)